Files
CV_Site_Nuxt/.gitea/workflows/pr-checker.yml
T
Noel Sabia 5f1d64db90
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 35s
PR Check / Typecheck (pull_request) Successful in 37s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Failing after 9s
PR Check / AI code review (opencode) (pull_request) Failing after 11s
ci: bind opencode API key explicitly via opencode.json
The headless CI container has no stored credentials, so auth depends
entirely on the injected key. Generate an opencode.json at runtime
that binds OPENCODE_API_KEY to the opencode-go provider explicitly,
removing any dependence on env-var-to-provider mapping behavior.
2026-10-18 17:08:46 +02:00

327 lines
14 KiB
YAML

name: PR Check
on:
pull_request:
types: [opened, synchronize, reopened]
concurrency:
group: pr-check-${{ github.event.pull_request.number }}
cancel-in-progress: true
env:
# The Gitea repo root IS the Nuxt app (CV_Website/CV_Site_Nuxt), so all
# app commands run from the workspace root. If you ever move the app into
# a subdirectory, change this to the subdirectory path.
APP_DIR: .
jobs:
# ---------------------------------------------------------------- lint ----
lint:
name: ESLint
runs-on: ubuntu-latest
container: node:22-bookworm
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
with:
# match the pnpm major version used locally (v11.x) - older pnpm
# rejects our config-only pnpm-workspace.yaml ("packages field
# missing or empty")
version: 11
- name: Install dependencies
working-directory: ${{ env.APP_DIR }}
run: pnpm install --frozen-lockfile
- name: Run ESLint
working-directory: ${{ env.APP_DIR }}
run: pnpm lint
# ------------------------------------------------------------ typecheck ---
typecheck:
name: Typecheck
runs-on: ubuntu-latest
container: node:22-bookworm
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
with:
# match the pnpm major version used locally (v11.x) - older pnpm
# rejects our config-only pnpm-workspace.yaml ("packages field
# missing or empty")
version: 11
- name: Install dependencies
working-directory: ${{ env.APP_DIR }}
run: pnpm install --frozen-lockfile
- name: Typecheck (vue-tsc)
working-directory: ${{ env.APP_DIR }}
run: pnpm typecheck
# -------------------------------------------------------------- secrets ---
secrets:
name: Secret scan (gitleaks)
runs-on: ubuntu-latest
# plain node image: the gitleaks container image has no node, which
# breaks node-based actions like actions/checkout
container: node:22-bookworm
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0 # gitleaks scans the full history
- name: Install gitleaks
run: |
echo "Runner arch: $(uname -m)"
case "$(uname -m)" in
x86_64) GITLEAKS_ARCH=x64 ;;
aarch64) GITLEAKS_ARCH=arm64 ;;
*) echo "unsupported arch: $(uname -m)" && exit 1 ;;
esac
curl -fsSL -o /tmp/gitleaks.tar.gz \
"https://github.com/gitleaks/gitleaks/releases/download/v8.28.0/gitleaks_8.28.0_linux_${GITLEAKS_ARCH}.tar.gz"
tar -xzf /tmp/gitleaks.tar.gz -C /usr/local/bin gitleaks
gitleaks version
- name: Scan for leaked secrets
run: gitleaks detect --source . --redact --verbose
# Already-committed secrets that you've accepted? Add a .gitleaksignore
# file listing their fingerprints instead of disabling the check.
# ----------------------------------------------------------- dependency ---
audit:
name: Dependency audit
runs-on: ubuntu-latest
container: node:22-bookworm
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
with:
# match the pnpm major version used locally (v11.x) - older pnpm
# rejects our config-only pnpm-workspace.yaml ("packages field
# missing or empty")
version: 11
- name: Audit dependencies for known vulnerabilities
working-directory: ${{ env.APP_DIR }}
run: pnpm audit --prod --audit-level moderate
# blocks the PR on vulnerabilities - flip to true only if a CVE fix
# is genuinely blocked, never to make red pipelines "go away"
# ------------------------------------------------------- dockerfile lint --
dockerfile-lint:
name: Dockerfile lint (droast)
runs-on: ubuntu-latest
container:
image: immanuwell/droast:1.7.0
# skips until the repo contains a Dockerfile
if: ${{ hashFiles('**/Dockerfile', '**/Dockerfile.*', '**/Containerfile') != '' }}
steps:
- uses: actions/checkout@v4
- name: Lint Dockerfile(s)
run: |
# --no-roast = technical output for CI; --min-severity warning so
# info-level findings don't block the PR
droast --no-roast --min-severity warning .
# ------------------------------------------------------- snyk security ----
# DISABLED: Snyk free plan only includes ~100 test credits/month, which the
# pipeline would burn through quickly (2 tests per PR push).
# To re-enable, delete the "if: false" line below. Consider also running
# this job only on PRs marked "ready for review" or on a weekly schedule
# instead of on every push.
snyk:
name: Security scan (Snyk)
runs-on: ubuntu-latest
if: false
# snyk/snyk:node is amd64-only ("no matching manifest for linux/arm64"),
# so install the CLI via npm in the multi-arch node image instead
container: node:22-bookworm
steps:
- uses: actions/checkout@v4
- name: Install Snyk CLI
run: npm install -g snyk@1 && snyk --version
- name: Snyk dependency scan
env:
SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
working-directory: ${{ env.APP_DIR }}
run: |
# --all-projects: required because pnpm-workspace.yaml exists -
# without it Snyk errors with SNYK-CLI-0000
# --strict-out-of-sync: fails if the lockfile doesn't match package.json
snyk test \
--all-projects \
--severity-threshold=high \
--strict-out-of-sync=true
- name: Snyk Code scan (SAST)
env:
SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
working-directory: ${{ env.APP_DIR }}
run: |
# static analysis of our own source code (XSS, injection, ...)
# Dockerfile/base image checks are covered by the droast job
snyk code test \
--severity-threshold=high
# -------------------------------------------------------- ai code review --
review:
name: AI code review (opencode)
runs-on: ubuntu-latest
container: node:22-bookworm
# Draft PRs don't get a (paid) review yet
if: ${{ !github.event.pull_request.draft }}
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Install opencode CLI
run: curl -fsSL https://opencode.ai/install | bash
env:
# pin the version for reproducible CI, e.g. v1.0.0
OPENCODE_VERSION: latest
- name: Get PR diff
run: |
# lockfile changes bloat the diff (175KB here) and are pointless to
# review - pnpm audit already covers dependencies. Excluding the
# lockfile also keeps the diff small enough to hand to the model.
# The diff goes to a file IN the workspace so the agent can read it
# with its file tools (passing 190KB as a CLI argument fails with
# "Argument list too long", MAX_ARG_STRLEN is 128KiB).
git diff --merge-base "origin/${{ github.base_ref }}" \
-- . ':(exclude)pnpm-lock.yaml' > .pr-review-diff.patch
wc -c .pr-review-diff.patch
- name: Run opencode review
env:
OPENCODE_API_KEY: ${{ secrets.OPENCODE_API_KEY }}
run: |
# opencode-go/deepseek-v4-pro#max: flagship reasoning model at
# maximum thinking budget - included in the opencode-go $10 plan
# (variants: high, max). NOTE the provider prefix must be
# "opencode-go", NOT "opencode" (Zen is a different, pay-per-call
# provider and fails with 'Insufficient account funds').
#
# Belt and suspenders on auth: OPENCODE_API_KEY is exported for
# env-based pickup, AND an opencode.json is generated that binds
# the key to the opencode-go provider explicitly - so headless CI
# never depends on env-var mapping behavior.
printf '{
"$schema": "https://opencode.ai/config.json",
"provider": {
"opencode-go": {
"options": { "apiKey": "%s" }
}
}
}' "$OPENCODE_API_KEY" > opencode.json
# --print-logs: surface auth/provider errors in the CI log instead
# of failing with an opaque exit code
opencode run \
--print-logs \
--model opencode-go/deepseek-v4-pro#max \
"You are a principal engineer performing a rigorous code review on a
pull request. You have tool access: read repo files for context when
the diff alone is ambiguous, but review ONLY code changed in this PR.
The full PR diff is in the file .pr-review-diff.patch in the repo
root. Read it first with your file tools.
## Project context
- Stack: Nuxt 4 (Vue 3, TypeScript) SSR web app in the repo root.
Backend/API services are being added in Golang.
- Deployment target: a personal production CV website.
- Already covered by other CI jobs, do NOT repeat their findings:
ESLint (style), vue-tsc (types), gitleaks (secrets in git history),
pnpm audit (dependency CVEs), droast (Dockerfile lint).
- Your job is everything those tools CANNOT see: logic, security,
architecture, correctness.
## Nuxt / Vue / TypeScript focus
- SSR pitfalls: window/document/localStorage access without
<ClientOnly> or process.client guards; hydration mismatch risks
(Date.now(), Math.random(), locale formatting in render path).
- useAsyncData/useFetch: missing or colliding keys, duplicate
requests between server and client, wrong caching/refresh setup.
- Reactivity bugs: destructuring reactive objects losing reactivity,
missing await on async setup, watch on getters vs refs.
- Security: v-html with unsanitized data, user input flowing into
meta/URLs, open redirects, missing validation in /server/api and
Nitro route handlers, auth checks on both page and API level.
- Config hygiene: server-only runtime config (no NUXT_PUBLIC_
prefix) leaking secrets into the client bundle.
## Golang focus (when Go code is in the diff)
- Errors: unchecked errors, errors discarded, wrapping with %w,
sentinel vs typed errors, panic in library code.
- Concurrency: goroutine leaks (missing context cancellation),
data races (shared state without mutex/channel), WaitGroup
misuse, defer in loops.
- Resources: unclosed response bodies/files/rows, missing
timeouts on http.Client, unbounded buffering.
- Correctness: slice aliasing surprises, copy vs reference
semantics, nil map writes, integer truncation.
## Cross-cutting
- API contract mismatches between Nuxt frontend and Go backends
(field names, nullability, status codes, date formats).
- Missing authorization checks on new endpoints or pages.
- Secrets/credentials ending up in logs or client-visible output.
- Performance on the critical render path (heavy components,
unoptimized images, blocking Nitro middleware).
## Output format (strict)
Review the diff in .pr-review-diff.patch. For every finding:
[BLOCKER] file:line - what and why + concrete fix suggestion
[WARN] file:line - what and why + concrete fix suggestion
[NIT] file:line - optional improvement
BLOCKER = must fix before merge (security, data loss, broken
behavior). WARN = should fix soon. NIT = optional.
If a finding cannot be localized to a file, prefix [BLOCKER-GENERAL].
No compliments, no summaries of what the diff does, no style nits.
Keep it under 400 words unless there are more than 10 findings.
If the diff contains no reviewable code (docs/config only), say so
in one line.
End your response with a final verdict line, exactly one of:
VERDICT: APPROVE (no BLOCKER findings)
VERDICT: REQUEST_CHANGES (at least one BLOCKER)" \
> /tmp/review.md 2>&1
EXIT_CODE=$?
cat /tmp/review.md
if [ $EXIT_CODE -ne 0 ]; then
echo "::error::opencode review failed (exit ${EXIT_CODE}) - NOT posting this output as a review comment"
exit $EXIT_CODE
fi
- name: Post review as PR comment
continue-on-error: true # token missing/expired must not fail the build
env:
GITEA_TOKEN: ${{ secrets.PR_GITEA_TOKEN }}
PR_NUMBER: ${{ github.event.pull_request.number }}
REPO: ${{ github.repository }}
# Gitea sets GITHUB_API_URL, e.g. https://gitea.example.com/api/v1
run: |
# jq is not in the node image - use node for JSON encoding
BODY=$(node -e 'process.stdout.write(JSON.stringify(require("fs").readFileSync("/tmp/review.md","utf8")))')
HTTP_CODE=$(curl -s -o /tmp/comment-response.json -w "%{http_code}" \
-X POST \
-H "Authorization: token ${GITEA_TOKEN}" \
-H "Content-Type: application/json" \
-d "{\"body\": ${BODY}}" \
"${GITHUB_API_URL}/repos/${REPO}/issues/${PR_NUMBER}/comments")
echo "POST status: ${HTTP_CODE}"
cat /tmp/comment-response.json
case "$HTTP_CODE" in
200|201) echo "Review comment posted." ;;
*) echo "::error::Failed to post review comment (HTTP ${HTTP_CODE}) - check PR_GITEA_TOKEN scope and expiry" ;;
esac