From 636a65dd05049c37a8b232843a96c65c1f995d08 Mon Sep 17 00:00:00 2001 From: Noel Sabia Date: Fri, 30 Oct 2026 21:28:05 +0100 Subject: [PATCH] docs(pr-agent): record the first successful review The key is wired into the live server .env; glm-5.3-flash returned OK and /review on PR #28 posted a PR Reviewer Guide. --- OKF_Nuxt/decisions/pr-agent.md | 17 +++++++++-------- OKF_Nuxt/log.md | 3 ++- deploy/pr-agent/README.md | 11 ++++------- 3 files changed, 15 insertions(+), 16 deletions(-) diff --git a/OKF_Nuxt/decisions/pr-agent.md b/OKF_Nuxt/decisions/pr-agent.md index f49cb70..18b0567 100644 --- a/OKF_Nuxt/decisions/pr-agent.md +++ b/OKF_Nuxt/decisions/pr-agent.md @@ -89,21 +89,22 @@ provider rejects the request before it reaches the model. `server0`. The repository contains the compose file and an example env file, never the token or webhook secret. +# Evidence + +* 2026-10-30: a direct `glm-5.3-flash` call through the handler returned + `OK`, and `/review` on PR #28 posted a PR Reviewer Guide through the Gitea + comment API. The key is set only in the server-side `.env`. + # Not verified -* The OpenCode Go API key was not present when this was committed, so no - model call has completed. A dummy-key call now reaches the provider's - authentication check instead of failing on the missing session header, - so the remaining blocker is the credential. The first PR after the key is - set is the real verification. -* Whether `glm-5.3-flash` handles PR-Agent's structured review output well - enough. `glm-5.3` is configured as the fallback. +* Whether the model finds the same class of issues as the opencode prompt on + larger diffs. The first review found none; `glm-5.3` remains the fallback. * Whether two gunicorn workers and the 1 GB memory limit hold under concurrent reviews. The host has roughly 2.5 GB available with Gitea and its runner idle. * Whether the default review prompt is specific enough for this repository. A `.pr_agent.toml` with project instructions is deliberately absent until - the first real review shows what it misses. + a real review shows what it misses. # Revisit when diff --git a/OKF_Nuxt/log.md b/OKF_Nuxt/log.md index f71053c..1662e6b 100644 --- a/OKF_Nuxt/log.md +++ b/OKF_Nuxt/log.md @@ -5,7 +5,8 @@ * **Fix**: `pnpm-lock.yaml` - merging `main` left the lockfile at `@nuxt/icon` 2.6.0 while `package.json` asked for 2.6.2, so `pnpm install --frozen-lockfile` aborted in CI. The lockfile now resolves 2.6.2. * **Fix**: `pnpm-workspace.yaml` - `seroval` 1.6.9 was the two moderate audit findings (GHSA-f86p-h4j2-7qgj, GHSA-9wx9-5pv9-3349). The patched 1.6.11 is forced through `overrides`; the blocking audit now reports only two low-severity advisories and passes the moderate gate. * **Fix**: PR-Agent model routing - OpenCode Go rejects requests without `x-opencode-session`; `LITELLM__EXTRA_HEADERS` now supplies it, and the fallback keeps the `openai/` prefix. Auto commands are `/describe` and `/review`; `/improve` is on demand. A dummy-key call reaches the provider's auth check instead of failing on the missing header. -* **State**: the OpenCode Go API key is still unset, so no real review has run. The next step is the credential, then a `/review` comment on PR #28. +* **Evidence**: the key was wired into the live `.env`; a direct `glm-5.3-flash` call returned `OK`, and `/review` on PR #28 posted a PR Reviewer Guide (no findings). The failed-review comment was removed. +* **State**: the key is set only in the server-side `.env`; the first `/review` posted on PR #28 with no findings. ## 2026-10-30 (PR-Agent replaces the opencode review job) diff --git a/deploy/pr-agent/README.md b/deploy/pr-agent/README.md index 18f107c..59ac864 100644 --- a/deploy/pr-agent/README.md +++ b/deploy/pr-agent/README.md @@ -77,13 +77,10 @@ capped by PR-Agent's default `config.max_model_tokens` of 32000. OpenCode Go requires an `x-opencode-session` header; PR-Agent sends the stable id `pr-agent` through `LITELLM__EXTRA_HEADERS`. -The transfer file used during installation was empty, so set the key as -root and redeploy: - -```sh -sudoedit /opt/pr-agent/.env # set OPENAI__KEY=… -sudo /usr/local/sbin/pr-agent-deploy -``` +The API key lives only in the server's `.env`, never in the repo. Set +`OPENAI__KEY` in the live `/home/noel/self-hosted/pr-agent/.env` until the +`/opt` migration has run; afterwards use `/opt/pr-agent/.env` and the deploy +helper. ## First check