docs(okf): record CI/CD, AI review, release and secrets decisions
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 36s
PR Check / Typecheck (pull_request) Successful in 38s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 5s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / AI code review (opencode) (pull_request) Failing after 13s
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 36s
PR Check / Typecheck (pull_request) Successful in 38s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 5s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / AI code review (opencode) (pull_request) Failing after 13s
Four new decision documents covering the pipeline work: layering, AI review setup (provider prefix, v2 CLI, env-only auth, verdict gate), release engineering (release-please manifest mode), and the Snyk pause with the token scope policy. Index grouped, log extended, open questions updated.
This commit is contained in:
1 parent
c70f5d7963
commit
7bf649cba6
8 files changed
+302
-2
No files matched your search
@@ -0,0 +1,51 @@
|
||||
---
|
||||
type: Decision
|
||||
title: Snyk paused, quotas and secrets policy
|
||||
description: The Snyk job stays in the workflow but is disabled via `if: false` - the free plan quota was the binding constraint - and every Gitea token secret must carry the write:issue scope.
|
||||
tags: [decision, security, ci, snyk]
|
||||
status: draft
|
||||
generated: { by: opencode-go/glm-5.3-flash, at: 2026-10-18T16:05:00Z }
|
||||
verified: { by: human:noel, at: not yet }
|
||||
sources:
|
||||
- id: pr-checker
|
||||
resource: .gitea/workflows/pr-checker.yml
|
||||
title: PR Check workflow, snyk job
|
||||
---
|
||||
|
||||
# Decision
|
||||
|
||||
1. The Snyk job remains in `pr-checker.yml` with `if: false` — skipped,
|
||||
not deleted. All the arm64/npm-CLI engineering is preserved for the
|
||||
day it is re-enabled.
|
||||
2. When re-enabled, it should not run on every push; a schedule or a
|
||||
ready-for-review gate fits the quota better.
|
||||
3. Gitea API tokens used by workflow secrets must have `issue`
|
||||
read+write **and** `repository` read+write, and must not be
|
||||
public-only. One well-scoped token serves both the AI review comment
|
||||
posting and release-please.
|
||||
|
||||
# Why
|
||||
|
||||
* The Snyk free plan grants a small monthly test budget; the pipeline
|
||||
would burn two tests per PR push. The job failed on its first runs for
|
||||
two independent reasons (an amd64-only container image, then the
|
||||
workspace-detection error) before the quota question even arose — the
|
||||
pause is about quota, the fixes are about portability.
|
||||
* The `write:issue` scope was discovered the hard way: posting a PR
|
||||
comment goes through Gitea's issues API, and a token with only
|
||||
`write:repository` fails with HTTP 403 naming the missing scope. The
|
||||
error text is the diagnostic — the comment-posting step now prints
|
||||
status code and response body on failure instead of `curl -sf`
|
||||
silence.
|
||||
|
||||
# Not verified
|
||||
|
||||
* Whether the current `RELEASE_PLEASE_TOKEN_CV_SITE_NUXT` value carries
|
||||
the correct scopes — its failure signature suggested it did not.
|
||||
|
||||
# Revisit when
|
||||
|
||||
* The quota constraint changes (paid tier, or a schedule-based scan
|
||||
makes the budget predictable).
|
||||
* Gitea adds fine-grained token scopes that separate "comment on PR"
|
||||
from "write issues".
|
||||
Reference in new issue
Block a user