fix(ci): validate the release tag and query pending PRs by label
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m8s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 8s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s

Both PR-Agent findings were confirmed. A tag at the merge commit now counts only when it is exactly v<manifest version>; foreign CI or annotation tags are logged and ignored. Pending release PRs are fetched through the autorelease: pending label filter instead of paging every closed PR, so a concurrent close cannot shift a page and hide one.

Also fail loudly on a merged PR without merge_commit_sha or a manifest without a version, instead of producing vundefined.

Rebased on main after the separate audit fix (e0c69c1); the dependency overrides and lockfile changes from the earlier local commit were dropped. Verified on the rebased tree: lint, typecheck, build, the exact audit command, actionlint and a live dry run.
This commit is contained in:
Noel Sabia committed 2026-10-31 20:05:40 +01:00
1 parent 1860e88156
commit 7ffc6d73b6
5 files changed
+297

No files matched your search

+15
View File
@@ -49,6 +49,21 @@ jobs:
echo "created label: ${name}"
done
# The label fix above is not retroactive. PR #22 was merged with
# `autorelease: pending` but its head branch had already been deleted,
# so the action reports `Bad branch name: refs/pull/22/head`, creates no
# tag and leaves the label behind. Every later run then aborts with
# "There are untagged, merged release PRs outstanding" and never opens a
# new release PR - green, no tags. This step reconciles that state before
# the action runs: mark a pending PR tagged when its tag already exists,
# or recreate the tag when the head branch is gone and release-please
# therefore cannot. See scripts/reconcile-release-please.mjs and
# OKF_Nuxt/decisions/release-engineering.md.
- name: Reconcile stale release-please state
env:
GITEA_TOKEN: ${{ secrets.PR_GITEA_TOKEN }}
run: node scripts/reconcile-release-please.mjs
- uses: joaquinjsb/gitea-release-please-action@v4
with:
# One well-scoped token for all workflow API work (see