fix(ci): check out the repo before the release-please reconcile step
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Canceled after 54s
PR Check / Secret scan (gitleaks) (pull_request) Canceled after 0s
PR Check / Dependency audit (pull_request) Canceled after 0s
PR Check / Dockerfile lint (droast) (pull_request) Canceled after 0s

The release-please job never had a checkout because the action clones into its own temp directory. The new reconcile step runs a file from the workspace, so the first post-merge run failed with MODULE_NOT_FOUND for scripts/reconcile-release-please.mjs. Add actions/checkout@v4 before the label/reconcile steps; the action still uses its own temp clone for the release branch.
This commit is contained in:
Noel Sabia committed 2026-10-31 20:15:09 +01:00
1 parent 06e1d24977
commit 90ef58a8cb
2 files changed
+10

No files matched your search

+6
View File
@@ -17,6 +17,12 @@ jobs:
release-please: release-please:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
# The reconcile step below runs a file from this repository. The
# release-please action clones into its own temp directory and does not
# check the workspace out, so without this step the job fails with
# "Cannot find module .../scripts/reconcile-release-please.mjs".
- uses: actions/checkout@v4
# release-please marks its release PR with `autorelease: pending` and # release-please marks its release PR with `autorelease: pending` and
# later finds the merged PR by that label. Gitea's label API resolves # later finds the merged PR by that label. Gitea's label API resolves
# names and *silently ignores unknown ones* (GetLabelIDsInRepoByNames # names and *silently ignores unknown ones* (GetLabelIDsInRepoByNames
+4
View File
@@ -1,5 +1,9 @@
# Update Log # Update Log
## 2026-10-31 (release-please reconcile step needs a checkout)
* **Fix**: [release-please.yml](../.gitea/workflows/release-please.yml) - added `actions/checkout@v4` before the reconcile step. The job had no checkout because the release-please action clones the repository into its own temp directory; the new step runs `scripts/reconcile-release-please.mjs` from the workspace, so the first post-merge run failed with `Cannot find module '/workspace/CV_Website/CV_Site_Nuxt/scripts/reconcile-release-please.mjs'` (task 571). The checkout supplies the file; the action still uses its own temp clone for the release branch.
## 2026-10-31 (PR #33 second review: release tag validated, pending PRs queried by label) ## 2026-10-31 (PR #33 second review: release tag validated, pending PRs queried by label)
* **Fix**: [reconcile-release-please.mjs](../scripts/reconcile-release-please.mjs) - both PR-Agent findings were confirmed. A tag at the merge commit now counts only when it is exactly `v<manifest version>`; a foreign CI/annotation tag is logged and ignored. Pending release PRs are fetched through the `autorelease: pending` label filter instead of paging every closed PR, so a concurrent close cannot shift a page and hide one. * **Fix**: [reconcile-release-please.mjs](../scripts/reconcile-release-please.mjs) - both PR-Agent findings were confirmed. A tag at the merge commit now counts only when it is exactly `v<manifest version>`; a foreign CI/annotation tag is logged and ignored. Pending release PRs are fetched through the `autorelease: pending` label filter instead of paging every closed PR, so a concurrent close cannot shift a page and hide one.