diff --git a/.gitea/workflows/pr-checker.yml b/.gitea/workflows/pr-checker.yml index 8e6817c..0387e39 100644 --- a/.gitea/workflows/pr-checker.yml +++ b/.gitea/workflows/pr-checker.yml @@ -198,22 +198,74 @@ jobs: env: OPENCODE_API_KEY: ${{ secrets.OPENCODE_API_KEY }} run: | - # deepseek-v4-pro: DeepSeek's flagship reasoning model - much - # cheaper than claude-sonnet while still thorough for reviews. + # deepseek-v4-pro#max: flagship reasoning model at maximum thinking + # budget. Requires funds on the opencode account. + # Cheaper fallbacks: opencode/deepseek-v4.1-flash, or remove "#max". opencode run \ - --model opencode/deepseek-v4.1-flash \ - "You are a strict but pragmatic code reviewer for a pull request. - Review ONLY the diff provided in /tmp/pr.diff. Fetch surrounding files - if you need context from the repo. + --model opencode/deepseek-v4-pro#max \ + "You are a principal engineer performing a rigorous code review on a + pull request. You have tool access: read repo files for context when + the diff alone is ambiguous, but review ONLY code changed in this PR. - Look for: security issues (XSS, injection, auth bypass), leaked - secrets, obvious bugs, breaking changes, performance problems in - Vue/Nuxt code, and missing error handling. Ignore pure style nits - - ESLint already covers those. + ## Project context + - Stack: Nuxt 4 (Vue 3, TypeScript) SSR web app in the repo root. + Backend/API services are being added in Golang. + - Deployment target: a personal production CV website. + - Already covered by other CI jobs, do NOT repeat their findings: + ESLint (style), vue-tsc (types), gitleaks (secrets in git history), + pnpm audit (dependency CVEs), droast (Dockerfile lint). + - Your job is everything those tools CANNOT see: logic, security, + architecture, correctness. + + ## Nuxt / Vue / TypeScript focus + - SSR pitfalls: window/document/localStorage access without + or process.client guards; hydration mismatch risks + (Date.now(), Math.random(), locale formatting in render path). + - useAsyncData/useFetch: missing or colliding keys, duplicate + requests between server and client, wrong caching/refresh setup. + - Reactivity bugs: destructuring reactive objects losing reactivity, + missing await on async setup, watch on getters vs refs. + - Security: v-html with unsanitized data, user input flowing into + meta/URLs, open redirects, missing validation in /server/api and + Nitro route handlers, auth checks on both page and API level. + - Config hygiene: server-only runtime config (no NUXT_PUBLIC_ + prefix) leaking secrets into the client bundle. + + ## Golang focus (when Go code is in the diff) + - Errors: unchecked errors, errors discarded, wrapping with %w, + sentinel vs typed errors, panic in library code. + - Concurrency: goroutine leaks (missing context cancellation), + data races (shared state without mutex/channel), WaitGroup + misuse, defer in loops. + - Resources: unclosed response bodies/files/rows, missing + timeouts on http.Client, unbounded buffering. + - Correctness: slice aliasing surprises, copy vs reference + semantics, nil map writes, integer truncation. + + ## Cross-cutting + - API contract mismatches between Nuxt frontend and Go backends + (field names, nullability, status codes, date formats). + - Missing authorization checks on new endpoints or pages. + - Secrets/credentials ending up in logs or client-visible output. + - Performance on the critical render path (heavy components, + unoptimized images, blocking Nitro middleware). + + ## Output format (strict) + Review the diff at the end of this message. For every finding: + [BLOCKER] file:line - what and why + concrete fix suggestion + [WARN] file:line - what and why + concrete fix suggestion + [NIT] file:line - optional improvement + BLOCKER = must fix before merge (security, data loss, broken + behavior). WARN = should fix soon. NIT = optional. + If a finding cannot be localized to a file, prefix [BLOCKER-GENERAL]. + No compliments, no summaries of what the diff does, no style nits. + Keep it under 400 words unless there are more than 10 findings. + If the diff contains no reviewable code (docs/config only), say so + in one line. End your response with a final verdict line, exactly one of: - VERDICT: APPROVE - VERDICT: REQUEST_CHANGES" \ + VERDICT: APPROVE (no BLOCKER findings) + VERDICT: REQUEST_CHANGES (at least one BLOCKER)" \ "$(cat /tmp/pr.diff)" \ 2>&1 | tee /tmp/review.md