From 9be62982a4a2494351006463ae71bd99f4e49fe4 Mon Sep 17 00:00:00 2001 From: Noel Sabia Date: Tue, 20 Oct 2026 20:46:43 +0200 Subject: [PATCH] fix(ci): gate the ai review to pull_request events, restore route announcer --- .gitea/workflows/pr-checker.yml | 7 +++++-- OKF_Nuxt/log.md | 3 +++ app/app.vue | 1 + 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/.gitea/workflows/pr-checker.yml b/.gitea/workflows/pr-checker.yml index 4f48075..99ff822 100644 --- a/.gitea/workflows/pr-checker.yml +++ b/.gitea/workflows/pr-checker.yml @@ -224,8 +224,11 @@ jobs: name: AI code review (opencode) runs-on: ubuntu-latest container: node:22-bookworm - # Draft PRs don't get a (paid) review yet - if: ${{ !github.event.pull_request.draft }} + # Draft PRs don't get a (paid) review yet. The event_name check is + # load-bearing: manual (workflow_dispatch) triggers - which exist to + # run the paused snyk job - must NOT launch a paid review, which on + # a dispatch event has no PR to post to. + if: ${{ github.event_name == 'pull_request' && !github.event.pull_request.draft }} steps: - uses: actions/checkout@v4 with: diff --git a/OKF_Nuxt/log.md b/OKF_Nuxt/log.md index 4af79ea..fe30d4a 100644 --- a/OKF_Nuxt/log.md +++ b/OKF_Nuxt/log.md @@ -1,5 +1,8 @@ # Update Log +## 2026-10-20 (first flash review validated, two findings applied) +* **Update**: PR #14 review (flash model, `VERDICT: APPROVE`) was fact-checked finding by finding. Applied: `` restored in `app.vue` (this PR's diff had dropped it with the NuxtWelcome swap), and the review job now requires `github.event_name == 'pull_request'` (manual dispatch - the new snyk trigger - would otherwise launch a paid review with no PR to post to). Rejected with evidence: the reviewer's `postcss-selector-parser` 6.1.5 override suggestion - the 6.1.5 backport exists on npm, but the blocking audit still flags it (`<7.1.6` covers 6.x), verified empirically; 7.1.6 stays. Deferred as design decisions: mobile nav, aria-current via NuxtLink, sprite-to-SVG, font fallback stacks, `borderRadius.full` token, the fall-endpoint budget in the API contract. + ## 2026-10-20 (snyk pause made actionlint-clean) * **Update**: pr-checker.yml - the paused snyk job's `if: false` (flagged by actionlint as a constant condition once this PR touched the workflow file) became `if: github.event_name == 'workflow_dispatch'` plus a `workflow_dispatch:` trigger. Same pause semantics ([snyk paused](decisions/snyk-paused-and-secrets-policy.md)) - pushes/PRs burn no credits; the job is now runnable manually instead of dead code. diff --git a/app/app.vue b/app/app.vue index f8eacfa..62cd98b 100644 --- a/app/app.vue +++ b/app/app.vue @@ -1,4 +1,5 @@