diff --git a/.gitea/workflows/pr-checker.yml b/.gitea/workflows/pr-checker.yml index 062d693..553a9ca 100644 --- a/.gitea/workflows/pr-checker.yml +++ b/.gitea/workflows/pr-checker.yml @@ -126,17 +126,18 @@ jobs: - name: Install droast run: | case "$(uname -m)" in - x86_64) DROAST_ASSET=droast-linux-x86_64 ;; - aarch64) DROAST_ASSET=droast-linux-arm64 ;; + x86_64) DROAST_ASSET=droast-linux-x86_64; DROAST_SHA=cadb963a040ba2e68641af764f794e5d4fb3371bb9b92255fa5027060b08ea6e ;; + aarch64) DROAST_ASSET=droast-linux-arm64; DROAST_SHA=0800e80d11f668615fc87750f58809b56bedca83ec6d8a539daa56f42da64bc3 ;; *) echo "unsupported arch: $(uname -m)" && exit 1 ;; esac curl -fsSL -o /usr/local/bin/droast \ "https://github.com/immanuwell/dockerfile-roast/releases/download/1.7.0/${DROAST_ASSET}" - # verify against the publisher's checksum file of the same pinned - # release (upstream sha256sums.txt matches our own verification) - curl -fsSL -o /tmp/droast-sha256sums.txt \ - "https://github.com/immanuwell/dockerfile-roast/releases/download/1.7.0/sha256sums.txt" - echo "$(grep "${DROAST_ASSET}\$" /tmp/droast-sha256sums.txt)" | (cd /usr/local/bin && sha256sum -c -) + # verify against the pinned hash checked into this workflow + # (fetching the checksum from the same release as the binary + # would be trust-on-first-use and prove nothing) + echo "${DROAST_SHA} /usr/local/bin/droast" | sha256sum -c - + chmod +x /usr/local/bin/droast + droast --version - name: Discover Dockerfiles id: discover @@ -144,10 +145,12 @@ jobs: # evaluation returned empty and silently skipped the job even when # Dockerfiles existed run: | + # Discovery: -print -quit instead of `| head -n 1` - head can + # SIGPIPE find (exit 141) when multiple Dockerfiles match found="$(find . \ -path ./.git -prune -o -path ./node_modules -prune -o \ -type f \( -iname 'Dockerfile*' -o -iname '*dockerfile' -o -iname 'Containerfile*' \) \ - -print | head -n 1)" + -print -quit)" if [ -n "$found" ]; then echo "found=true" >> "$GITHUB_OUTPUT" echo "Dockerfile found: $found" @@ -258,13 +261,19 @@ jobs: # means no headless permission prompts can hang or kill the run, # and the reviewer physically cannot modify the repo. mkdir -p "$HOME/.config/opencode" + # OpenCode v2 permission schema: ordered array of + # {action, resource, effect}; "bash" was renamed "shell" in v2. + # websearch is a distinct action from webfetch - deny both, plus + # external directories. printf '{ "$schema": "https://opencode.ai/config.json", - "permission": { - "edit": "deny", - "bash": "deny", - "webfetch": "deny" - } + "permission": [ + { "action": "edit", "resource": "*", "effect": "deny" }, + { "action": "shell", "resource": "*", "effect": "deny" }, + { "action": "webfetch", "resource": "*", "effect": "deny" }, + { "action": "websearch", "resource": "*", "effect": "deny" }, + { "action": "external_directory", "resource": "*", "effect": "deny" } + ] }' > "$HOME/.config/opencode/opencode.json" # --print-logs: surface auth/provider errors in the CI log instead # of failing with an opaque exit code @@ -341,9 +350,17 @@ jobs: > /tmp/review.md 2>&1 || EXIT_CODE=$? # always show the output - never swallow the error text cat /tmp/review.md - if [ "$EXIT_CODE" -ne 0 ]; then - echo "::error::opencode review failed (exit ${EXIT_CODE}) - NOT posting this output as a review comment" - exit "$EXIT_CODE" + # The posting gate is the OUTPUT CONTRACT, not the exit code: + # a completed review always ends with a VERDICT line - error + # dumps never do. opencode can exit 1 on benign tool denials + # even after a full review, so a present verdict means post; + # anything else means the review did not complete. + if grep -qE '^VERDICT: (APPROVE|REQUEST_CHANGES)' /tmp/review.md; then + [ "$EXIT_CODE" -ne 0 ] && echo "::warning::opencode exited ${EXIT_CODE} but produced a valid verdict - posting review" + echo "Review completed with verdict." + else + echo "::error::opencode produced no valid review (exit ${EXIT_CODE:-1}) - NOT posting this output as a review comment" + exit "${EXIT_CODE:-1}" fi - name: Post review as PR comment