From 90ef58a8cb8917d547947ae0046a56b8be882114 Mon Sep 17 00:00:00 2001 From: Noel Sabia Date: Sat, 31 Oct 2026 20:15:09 +0100 Subject: [PATCH] fix(ci): check out the repo before the release-please reconcile step The release-please job never had a checkout because the action clones into its own temp directory. The new reconcile step runs a file from the workspace, so the first post-merge run failed with MODULE_NOT_FOUND for scripts/reconcile-release-please.mjs. Add actions/checkout@v4 before the label/reconcile steps; the action still uses its own temp clone for the release branch. --- .gitea/workflows/release-please.yml | 6 ++++++ OKF_Nuxt/log.md | 4 ++++ 2 files changed, 10 insertions(+) diff --git a/.gitea/workflows/release-please.yml b/.gitea/workflows/release-please.yml index 7056282..ec8927b 100644 --- a/.gitea/workflows/release-please.yml +++ b/.gitea/workflows/release-please.yml @@ -17,6 +17,12 @@ jobs: release-please: runs-on: ubuntu-latest steps: + # The reconcile step below runs a file from this repository. The + # release-please action clones into its own temp directory and does not + # check the workspace out, so without this step the job fails with + # "Cannot find module .../scripts/reconcile-release-please.mjs". + - uses: actions/checkout@v4 + # release-please marks its release PR with `autorelease: pending` and # later finds the merged PR by that label. Gitea's label API resolves # names and *silently ignores unknown ones* (GetLabelIDsInRepoByNames diff --git a/OKF_Nuxt/log.md b/OKF_Nuxt/log.md index ee12d04..37eb1d3 100644 --- a/OKF_Nuxt/log.md +++ b/OKF_Nuxt/log.md @@ -1,5 +1,9 @@ # Update Log +## 2026-10-31 (release-please reconcile step needs a checkout) + +* **Fix**: [release-please.yml](../.gitea/workflows/release-please.yml) - added `actions/checkout@v4` before the reconcile step. The job had no checkout because the release-please action clones the repository into its own temp directory; the new step runs `scripts/reconcile-release-please.mjs` from the workspace, so the first post-merge run failed with `Cannot find module '/workspace/CV_Website/CV_Site_Nuxt/scripts/reconcile-release-please.mjs'` (task 571). The checkout supplies the file; the action still uses its own temp clone for the release branch. + ## 2026-10-31 (PR #33 second review: release tag validated, pending PRs queried by label) * **Fix**: [reconcile-release-please.mjs](../scripts/reconcile-release-please.mjs) - both PR-Agent findings were confirmed. A tag at the merge commit now counts only when it is exactly `v`; a foreign CI/annotation tag is logged and ignored. Pending release PRs are fetched through the `autorelease: pending` label filter instead of paging every closed PR, so a concurrent close cannot shift a page and hide one.