From ad4e8d7bd9e394d6c9f1b157f6cc71b28e62dcaa Mon Sep 17 00:00:00 2001 From: Noel Sabia Date: Fri, 23 Oct 2026 21:50:17 +0200 Subject: [PATCH] fix(ci): tell the reviewer the lockfile is excluded on purpose The diff filter drops pnpm-lock.yaml to keep the patch small; the model read that as an uncommitted lockfile and raised a BLOCKER on PR #16. Say so in the prompt instead of widening the diff. --- .gitea/workflows/pr-checker.yml | 5 +++++ OKF_Nuxt/log.md | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/.gitea/workflows/pr-checker.yml b/.gitea/workflows/pr-checker.yml index 79daeea..a45ac14 100644 --- a/.gitea/workflows/pr-checker.yml +++ b/.gitea/workflows/pr-checker.yml @@ -341,6 +341,11 @@ jobs: The full PR diff is in the file .pr-review-diff.patch in the repo root. Read it first with your file tools. + pnpm-lock.yaml is deliberately excluded from that patch to keep it + small, not forgotten. It is committed in the PR, pnpm audit covers + the dependencies, and CI runs `pnpm install --frozen-lockfile`. + Do not report a missing lockfile or a frozen-install drift. + ## Project context - Stack: Nuxt 4 (Vue 3, TypeScript) SSR web app in the repo root. Backend/API services are being added in Golang. diff --git a/OKF_Nuxt/log.md b/OKF_Nuxt/log.md index 3d8bb87..9b19663 100644 --- a/OKF_Nuxt/log.md +++ b/OKF_Nuxt/log.md @@ -1,5 +1,10 @@ # Update Log +## 2026-10-23 (PR #16 review checked, three findings applied) +* **Update**: [pr-checker.yml](../.gitea/workflows/pr-checker.yml) - the review prompt now states that `pnpm-lock.yaml` is excluded from `.pr-review-diff.patch` on purpose. The reviewer read the exclusion as an uncommitted lockfile and raised a false BLOCKER; the lockfile is in the PR and matches `package.json`. +* **Fix**: `scripts/generate-favicon.mjs` - `BACKGROUND = null` now writes alpha 0 instead of opaque black, matching the transparency the comment promises. The committed icons are unchanged (regenerated byte-identical). +* **Update**: deleted `public/_robots.txt` - unreferenced leftover from the rename; `@nuxtjs/seo` writes `robots.txt` itself. + ## 2026-10-23 (Nuxt SEO configured, static OG card) * **Decision**: Recorded [SEO stack and site metadata](decisions/seo-and-metadata.md) - `@nuxtjs/seo` 6.0.1 registered; `site` and `schemaOrg.identity` (Person) read `site.config.mjs`; canonical, sitemap, robots and social tags need no per-page setup. `ogImage: false` and `skewProtection: false` because the card is a committed PNG and the site deploys as static files. * **Update**: `public/og-image.png` (1200x630) and `og-image.alt.txt` generated from the pixel avatar and the site metadata by `pnpm og-image` (`scripts/generate-og-image.mjs`; needs `woff2_decompress` + `rsvg-convert`, output committed). SEO Utils emits `og:image`, `twitter:image` and their dimensions/alt automatically.