fix(deps): unblock the dependency audit
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m7s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 8s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m7s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 8s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
Bump nuxt to 4.6.3 and override node-forge 1.4.1 and glob 14.0.2. minimatch stays a reviewed ignore: its patch drops makeRe, which eslint-plugin-import-x imports. Verified locally: lint, typecheck, build, and the exact audit command.
This commit is contained in:
1 parent
c00db55f98
commit
e0c69c1b77
5 files changed
+532
-499
No files matched your search
@@ -31,23 +31,32 @@ patched 7.1.6 was already in the tree via `postcss-nesting` and proved
|
||||
API-compatible through a full build. The override is removed when
|
||||
`tailwindcss` ships `>= 7.1.6` itself or the site moves to Tailwind v4.
|
||||
|
||||
Currently ignored (both verified against the advisory database and the npm
|
||||
registries on 2026-10-18 - the newest published versions are the vulnerable
|
||||
ones):
|
||||
Currently ignored (verified against the advisory database and the npm
|
||||
registries on 2026-10-31):
|
||||
|
||||
* `GHSA-86w9-cpqp-85rv` - node-forge <= 1.4.0, high. Path:
|
||||
`nuxt > @nuxt/nitro-server > nitropack > listhen > node-forge` - listhen
|
||||
generates dev certificates; build/dev-time only, not in the server bundle.
|
||||
* `GHSA-vfj7-8cjw-p6xm` - braces <= 3.0.3, high. Path:
|
||||
`nitropack > globby > micromatch > braces` - globbing during build, no
|
||||
attacker-controlled patterns at runtime.
|
||||
* `GHSA-g3hv-75wg-m249` - minimatch < 11.0.1, moderate. The patch
|
||||
(11.0.1) dropped the `makeRe` export that `eslint-plugin-import-x`
|
||||
imports, so forcing it breaks `pnpm lint` with "does not provide an
|
||||
export named 'makeRe'"; it also breaks ESLint's config loader. All
|
||||
affected paths are build/lint-time (Nitro, i18n, ESLint via
|
||||
vite-plugin-checker), never in the running server.
|
||||
|
||||
The 2026-10-31 round also upgraded `nuxt` 4.6.2 -> 4.6.3 (fixes the Nuxt
|
||||
dot-segment, dev-server and appSecret advisories) and added overrides for
|
||||
`node-forge: 1.4.1` (the old node-forge ignore, `GHSA-86w9-cpqp-85rv`,
|
||||
is gone - a patch now exists) and `glob: 14.0.2` for
|
||||
`GHSA-3g3m-2fjr-6pw4` (scoped to `>=9.0.0 <=14.0.1` so
|
||||
tailwind-config-viewer keeps glob 7).
|
||||
|
||||
# Why
|
||||
|
||||
A red job that can never go green trains everyone to ignore red - the same
|
||||
silent-failure outcome "nothing fails silently" exists to prevent. The
|
||||
ignore list is the opposite of silence: the audit still names what it
|
||||
skipped ("2 ignored: 2 high") and the decision lives in a reviewable file.
|
||||
skipped ("1 ignored: 1 high") and the decision lives in a reviewable file.
|
||||
|
||||
# The pnpm 11 lesson
|
||||
|
||||
|
||||
@@ -30,6 +30,13 @@
|
||||
* **Creation**: `deploy/pr-agent/` (later removed; the service now lives in the Gitea compose stack) - compose service, example environment and operator README. The real `.env` lived only at `/home/noel/self-hosted/pr-agent/.env` (mode 600) on `server0`.
|
||||
* **State**: the container is running and the webhook signature path is verified. Gitea gained `[webhook] ALLOWED_HOST_LIST = private:3000` (one restart, healthy) and the repository has a signed webhook. The OpenCode Go API key was still missing at commit time, so no model call or real review has run yet.
|
||||
|
||||
## 2026-10-31 (audit green again: nuxt 4.6.3 and dependency overrides)
|
||||
|
||||
* **Fix**: `pnpm audit --prod --audit-level moderate` failed on every branch (#30, #31, #33 and this PR) - new advisories plus a Nuxt patch release. `nuxt` 4.6.2 -> **4.6.3** clears GHSA-9v7c-q64q-vv33 (dot-segment middleware bypass), GHSA-3xf4-9g3c-4h4w and GHSA-x287-wcfc-q46c (dev-server file read/runtime config).
|
||||
* **Fix**: [pnpm-workspace.yaml](../pnpm-workspace.yaml) - overrides for `node-forge: 1.4.1` (the old GHSA-86w9-cpqp-85rv ignore is removed - a patch exists now) and `glob@>=9.0.0 <=14.0.1: 14.0.2` (GHSA-3g3m-2fjr-6pw4; glob 7 is kept for tailwind-config-viewer).
|
||||
* **Decision**: minimatch GHSA-g3hv-75wg-m249 stays a reviewed ignore. Its patch (11.0.1) dropped `makeRe`, which `eslint-plugin-import-x` imports - forcing it makes `pnpm lint` fail with "does not provide an export named 'makeRe'" (measured). All affected paths are build/lint-time. See [Vulnerability audit policy](decisions/vulnerability-audit-policy.md).
|
||||
* **Verified locally**: `pnpm lint`, `pnpm typecheck`, `pnpm build` and the exact audit command all pass on the merged tree.
|
||||
|
||||
## 2026-10-27 (release-please still never tagged: the deleted head branch)
|
||||
|
||||
* **Fix**: [release-please-config.json](../release-please-config.json) gained `"changelog-host": "https://git.noelsabia.dev"` - the changelog compare links were generated against `github.com/CV_Website/CV_Site_Nuxt`, a host this repository does not live on. Root cause of the missing tags: **Gitea rewrites `head.ref` to `refs/pull/<n>/head` when the merged PR's branch is deleted**, and release-please parses that field as the release branch, so `BranchName.parse` fails and the release is dropped - silently, exit code 0. Evidence: run 143 (task 475) logs `✖ Bad branch name: refs/pull/22/head` right after `Found pull request #22`, then `Expected 1 releases, only found 0`; #22 did carry `autorelease: pending`. The repository deleted every merged branch (`default_delete_branch_after_merge: true`); it is `false` now. Four versions (1.1.0-1.4.0) were consumed by the manifest with no tag ever created, so the release baseline has to be restored by hand. See [Release engineering](decisions/release-engineering.md).
|
||||
|
||||
Reference in new issue
Block a user