Merge remote-tracking branch 'origin/main' into fix/arm64-base-digest
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m6s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 4s
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m6s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 4s
# Conflicts: # OKF_Nuxt/log.md
This commit is contained in:
commit
e3e0b8d28c
8 files changed
+1030
-1098
No files matched your search
@@ -175,10 +175,38 @@ component is empty. `include-component-in-tag: false` makes
|
||||
`package-name` - here `CV_Site_Frontend`. The two never match, so the
|
||||
release is dropped before the tag is created.
|
||||
|
||||
The fix is to remove `package-name` from the package config. The strategy
|
||||
component is then empty as well, the comparison matches, and the tag is
|
||||
created. Nothing else changes: the changelog headings are already
|
||||
version-only (`## [1.5.0]`), not component-prefixed.
|
||||
Removing `package-name` is not enough. Run 183 (after #36 merged) shows
|
||||
the node strategy falling back to the `package.json` name:
|
||||
|
||||
```
|
||||
⚠ PR component: undefined does not match configured component: nuxt-app
|
||||
```
|
||||
|
||||
`BaseStrategy.getDefaultPackageName()` is overridden by the node strategy
|
||||
to read `package.json` `name`, so an absent `package-name` resolves to
|
||||
`nuxt-app`.
|
||||
|
||||
The working setting is `"package-name": ""` (an empty string, not an
|
||||
omitted key). An empty string is not nullish, so `getBranchComponent()`
|
||||
returns empty and matches the legacy default branch
|
||||
`release-please--branches--main`. This was verified by running the
|
||||
action's bundled release-please 16.15.6 locally against the live Gitea
|
||||
API, with writes intercepted: the release phase produced
|
||||
|
||||
```
|
||||
POST /repos/CV_Website/CV_Site_Nuxt/releases
|
||||
{"name":"v1.5.0","tag_name":"v1.5.0",...,"target_commitish":"a80c9ebf..."}
|
||||
```
|
||||
|
||||
then swapped #35 to `autorelease: tagged`. That is release-please creating
|
||||
the tag itself, not a manual `git tag`.
|
||||
|
||||
The action's official default mode (`release-type: node`, no manifest
|
||||
config) was tested the same way and still fails for #35 with
|
||||
`configured component: nuxt-app`. It cannot retroactively accept the
|
||||
already-merged legacy PR; it would only help a release PR created after
|
||||
the switch. The empty `package-name` is therefore the compatibility
|
||||
setting that lets release-please finish v1.5.0.
|
||||
|
||||
# Recovering the versions that never got a tag
|
||||
|
||||
@@ -204,9 +232,10 @@ whole history.
|
||||
|
||||
# Not verified
|
||||
|
||||
* That the release phase now tags #35 after the component fix. The previous
|
||||
run (181) kept the branch but dropped the release on the component
|
||||
mismatch, so the next run is the proof.
|
||||
* That the live run tags #35. The exact release-phase request was verified
|
||||
locally with writes intercepted (`POST /releases` with `tag_name:
|
||||
v1.5.0` at `a80c9eb`); the run after merging the empty `package-name` is
|
||||
the final proof.
|
||||
* That the reconcile step's tag-creation fallback works with a live
|
||||
token. Only the tag-already-exists path was exercised, in dry-run,
|
||||
against the live PR #22. The fallback is written from the same Gitea
|
||||
|
||||
Reference in new issue
Block a user