fix: unblock the release PR - real production image, reviewed audit ignores
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Canceled after 28s
PR Check / Typecheck (pull_request) Canceled after 0s
PR Check / Secret scan (gitleaks) (pull_request) Canceled after 0s
PR Check / Dependency audit (pull_request) Canceled after 0s
PR Check / Dockerfile lint (droast) (pull_request) Canceled after 0s
PR Check / AI code review (opencode) (pull_request) Canceled after 0s

The release PR (chore: release main) failed two checks, both verified
locally before pushing:

- droast: the empty production Dockerfile failed DF071 (no
  instructions). The new Dockerfile is a runnable Node server (SSR):
  multi-stage, manifests-first layers, digest-pinned node:26-slim (same
  digest as the dev container), non-root uid 1000, node-fetch
  HEALTHCHECK. Measured: docker build succeeds in-image, container
  serves HTTP 200 and reports healthy; droast reports 0 errors.
- audit: two high advisories with NO patched release anywhere
  (node-forge <=1.4.0 and braces <=3.0.3 are the newest npm versions;
  both build-time-only paths under nitropack). Recorded as
  auditConfig.ignoreGhsas in pnpm-workspace.yaml with the reason and
  removal condition - the audit output still names what it skipped.
  pnpm 11 ignores the pnpm field in package.json (caught locally via
  the WARN before pushing); settings live in pnpm-workspace.yaml.

OKF_Nuxt: recorded the production-image and audit-policy decisions,
updated log, indexes and open questions.
This commit is contained in:
Noel Sabia committed 2026-10-18 21:14:12 +02:00
1 parent 0e5ddda59d
commit f32ad07648
8 files changed
+201 -2

No files matched your search

+5
View File
@@ -1,5 +1,10 @@
# Update Log
## 2026-10-18 (evening — release PR unblocked)
* **Decision**: Recorded the [production image shape](decisions/production-image.md) - multi-stage, digest-pinned `node:26-slim`, non-root, healthchecked runnable Node server. Built and served locally: HTTP 200, uid 1000, healthcheck healthy. This decides the question that had kept `Dockerfile` empty (and failing the droast job with `DF071`).
* **Decision**: Recorded the [vulnerability audit policy](decisions/vulnerability-audit-policy.md) - blocking audit with two reviewed ignores (`node-forge`, `braces`: no patched release exists; both build-time-only paths under nitropack). Learned en route: pnpm 11 ignores the `pnpm` field in `package.json` - settings live in `pnpm-workspace.yaml`.
* **Update**: Added both decisions to the [decisions index](decisions/index.md).
## 2026-10-18 (later — CI/CD and releases)
* **Creation**: Recorded the [PR pipeline layering](decisions/pr-pipeline-layering.md) — three layers (pre-commit, Gitea Actions, AI review), the cost rule that assigns checks to layers, and the failure modes the pipeline was designed against.
* **Creation**: Recorded the [AI review setup](decisions/ai-review-setup.md): the `opencode-go` provider prefix (the wrong one failed every run with "Insufficient account funds"), the v2 installer (v1 cannot resolve model variants), env-only auth after the prompt-injection finding, the read-only permission set, and the verdict line as the posting gate.