fix: unblock the release PR - real production image, reviewed audit ignores
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Canceled after 28s
PR Check / Typecheck (pull_request) Canceled after 0s
PR Check / Secret scan (gitleaks) (pull_request) Canceled after 0s
PR Check / Dependency audit (pull_request) Canceled after 0s
PR Check / Dockerfile lint (droast) (pull_request) Canceled after 0s
PR Check / AI code review (opencode) (pull_request) Canceled after 0s

The release PR (chore: release main) failed two checks, both verified
locally before pushing:

- droast: the empty production Dockerfile failed DF071 (no
  instructions). The new Dockerfile is a runnable Node server (SSR):
  multi-stage, manifests-first layers, digest-pinned node:26-slim (same
  digest as the dev container), non-root uid 1000, node-fetch
  HEALTHCHECK. Measured: docker build succeeds in-image, container
  serves HTTP 200 and reports healthy; droast reports 0 errors.
- audit: two high advisories with NO patched release anywhere
  (node-forge <=1.4.0 and braces <=3.0.3 are the newest npm versions;
  both build-time-only paths under nitropack). Recorded as
  auditConfig.ignoreGhsas in pnpm-workspace.yaml with the reason and
  removal condition - the audit output still names what it skipped.
  pnpm 11 ignores the pnpm field in package.json (caught locally via
  the WARN before pushing); settings live in pnpm-workspace.yaml.

OKF_Nuxt: recorded the production-image and audit-policy decisions,
updated log, indexes and open questions.
This commit is contained in:
Noel Sabia committed 2026-10-18 21:14:12 +02:00
1 parent 0e5ddda59d
commit f32ad07648
8 files changed
+201 -2

No files matched your search

+4 -2
View File
@@ -9,14 +9,16 @@ generated: { by: opencode-go/glm-5.3-flash, at: 2026-10-18T12:41:52Z }
| Question | Needed by | Default if nobody decides |
|---|---|---|
| Shape of the production image: a runnable Node server, or static `.output/public/` files for the gateway to embed | the next Dockerfile step | None. The empty `Dockerfile` stays empty — and until it holds real instructions, the droast job will fail on it. |
| ~~Shape of the production image~~ - **decided**: runnable Node server, see [production image](decisions/production-image.md) | done | — |
| How the compose service mounts the source: the whole repository plus a volume for `node_modules`, or only the directories that get edited | finishing `Local_Development/docker-compose.yml` | None. The compose file is not yet valid. |
| Which pnpm version the production image pins | writing the production image | The same as dev, 11.26.0. |
| Which pnpm version the production image pins | ~~writing the production image~~ **decided**: 11.26.0, same as dev ([production image](decisions/production-image.md)) | done |
| How the gateway serves the site now that the production image is an SSR Node server (proxy to the server, instead of embedding static files) | updating the sibling `OKF_CV_Website` decision `static-nuxt-in-gateway` | Proxy to the server. |
| Whether these decisions stay in this bundle or fold into the sibling `OKF_CV_Website` bundle, which already describes the frontend at design level | after the production image exists | None. |
| When and how often Snyk runs once re-enabled: weekly schedule, ready-for-review gate, or per-push | re-enabling the snyk job | Stay disabled. |
| Whether the AI review job should gate merges (required status check on the verdict) or stay advisory | branch protection setup | Advisory. The review comment is information; blocking merges on an AI verdict is a policy choice, not a technical one. |
| How the opencode CLI version in CI gets upgraded: manually bump the pinned 2.0.32, or automate when a new major appears | first review failure after an opencode release | Manual bump. Pinning exists so upgrades are decisions. |
| Whether the Go plan's per-model usage windows ($3 per 5 hours for DeepSeek V4 Pro) survive real review frequency, or the review model must move to `deepseek-v4.1-flash` ($80 window) | first quota-limited review | Switch to flash. |
| Removing the two reviewed audit ignores when `node-forge` or `braces` ship patched releases | next dependency update round | Watch for new releases. |
# The mount trade-off, in detail