diff --git a/OKF_Nuxt/decisions/release-engineering.md b/OKF_Nuxt/decisions/release-engineering.md index d568003..00c8b36 100644 --- a/OKF_Nuxt/decisions/release-engineering.md +++ b/OKF_Nuxt/decisions/release-engineering.md @@ -152,6 +152,34 @@ Two details keep the reconciliation from suppressing a real release: `v`. A CI or annotation tag on the same commit is logged and ignored, and the release tag is still created. +# The release phase drops the PR on a component mismatch (2026-10-31) + +With the branch kept and the label reconciled, PR #35 was still not +tagged. Run 181 (task 578, immediately after #35 merged) shows why: + +``` +❯ Found pull request #35: 'chore: release main' +... +⚠ PR component: undefined does not match configured component: CV_Site_Frontend +... +⚠ There are untagged, merged release PRs outstanding - aborting +``` + +`buildRelease()` compares the component parsed from the merged PR with the +strategy's component when the release body contains one component and that +component is empty. `include-component-in-tag: false` makes +`getComponent()` return an empty string, so the release PR is +`chore: release main` with an empty component and the branch is +`release-please--branches--main` (parsed component: undefined). But +`getBranchComponent()` ignores `include-component-in-tag` and returns +`package-name` - here `CV_Site_Frontend`. The two never match, so the +release is dropped before the tag is created. + +The fix is to remove `package-name` from the package config. The strategy +component is then empty as well, the comparison matches, and the tag is +created. Nothing else changes: the changelog headings are already +version-only (`## [1.5.0]`), not component-prefixed. + # Recovering the versions that never got a tag The label alone cannot recover them — #20, #21 and #22 all lost their head @@ -176,8 +204,9 @@ whole history. # Not verified -* That the release phase tags correctly once the head branch survives a - merge. The next release cycle proves it. +* That the release phase now tags #35 after the component fix. The previous + run (181) kept the branch but dropped the release on the component + mismatch, so the next run is the proof. * That the reconcile step's tag-creation fallback works with a live token. Only the tag-already-exists path was exercised, in dry-run, against the live PR #22. The fallback is written from the same Gitea diff --git a/OKF_Nuxt/log.md b/OKF_Nuxt/log.md index 37eb1d3..9fdd15c 100644 --- a/OKF_Nuxt/log.md +++ b/OKF_Nuxt/log.md @@ -1,5 +1,11 @@ # Update Log +## 2026-10-31 (release-please component mismatch: no v1.5.0 tag) + +* **Fix**: [release-please-config.json](../release-please-config.json) - removed `package-name: CV_Site_Frontend`. With `include-component-in-tag: false` the strategy component and the release PR body component are empty, but `getBranchComponent()` still returned `package-name`; the release phase logged `PR component: undefined does not match configured component: CV_Site_Frontend` and returned before creating the tag. The component now matches, so the next run should tag #35. +* **Evidence**: run 181 (task 578, immediately after #35 merged) - the reconcile step correctly left #35 for the action because its branch survived, then the action found #35, hit the component mismatch and aborted with "There are untagged, merged release PRs outstanding". The earlier label/branch fixes were correct; this was the remaining check. +* **Expected result**: the run after this merge creates `v1.5.0` at the #35 merge commit (`a80c9eb`), marks #35 `autorelease: tagged`, and stops opening duplicate release PRs. + ## 2026-10-31 (release-please reconcile step needs a checkout) * **Fix**: [release-please.yml](../.gitea/workflows/release-please.yml) - added `actions/checkout@v4` before the reconcile step. The job had no checkout because the release-please action clones the repository into its own temp directory; the new step runs `scripts/reconcile-release-please.mjs` from the workspace, so the first post-merge run failed with `Cannot find module '/workspace/CV_Website/CV_Site_Nuxt/scripts/reconcile-release-please.mjs'` (task 571). The checkout supplies the file; the action still uses its own temp clone for the release branch. diff --git a/release-please-config.json b/release-please-config.json index 8132984..9e6f1e0 100644 --- a/release-please-config.json +++ b/release-please-config.json @@ -6,7 +6,6 @@ "changelog-host": "https://git.noelsabia.dev", "packages": { ".": { - "package-name": "CV_Site_Frontend", "changelog-path": "CHANGELOG.md", "extra-files": [], "versioning": "default"