Commit Graph
5 Commits
Author SHA1 Message Date
Noel Sabia e23f8d2618 fix(ci): remove the release-please component mismatch
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m59s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
PR #35 merged with its branch kept, but the release phase logged 'PR component: undefined does not match configured component: CV_Site_Frontend' and returned before creating the tag. With include-component-in-tag false the strategy component and release body component are empty, while getBranchComponent still returns package-name. Remove package-name so both sides are empty; the changelog headings are already version-only.

Evidence: run 181 (task 578) after #35 merged. The next run should create v1.5.0 at a80c9eb and mark #35 autorelease: tagged.
2026-10-31 20:34:49 +01:00
Noel Sabia 7ffc6d73b6 fix(ci): validate the release tag and query pending PRs by label
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m8s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 8s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
Both PR-Agent findings were confirmed. A tag at the merge commit now counts only when it is exactly v<manifest version>; foreign CI or annotation tags are logged and ignored. Pending release PRs are fetched through the autorelease: pending label filter instead of paging every closed PR, so a concurrent close cannot shift a page and hide one.

Also fail loudly on a merged PR without merge_commit_sha or a manifest without a version, instead of producing vundefined.

Rebased on main after the separate audit fix (e0c69c1); the dependency overrides and lockfile changes from the earlier local commit were dropped. Verified on the rebased tree: lint, typecheck, build, the exact audit command, actionlint and a live dry run.
2026-10-31 20:05:40 +01:00
Noel Sabia a2259df877 fix(ci): point changelog compare links at our Gitea
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m10s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 6s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / AI code review (opencode) (pull_request) Successful in 22s
The generated CHANGELOG linked every release to
github.com/CV_Website/CV_Site_Nuxt, a host this repository does not live
on. release-please takes the compare host from the configuration, so it
is set now.

The decision record also gains the real reason no tag was ever created:
Gitea rewrites a merged PR's head.ref to refs/pull/<n>/head once the head
branch is deleted, and the Gitea build parses that field as the release
branch. BranchName.parse then fails and the release is dropped with a
logged error while the run still exits 0. The repository deleted every
merged branch; that default is off now, and the versions the manifest
already consumed have to be tagged by hand.
2026-10-27 12:20:28 +01:00
Noel Sabia 0a3c90cc74 fix(ci): create the release-please labels before the action runs
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m11s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 4s
PR Check / AI code review (opencode) (pull_request) Successful in 38s
release-please finds merged release PRs by the 'autorelease: pending'
label. Gitea resolves label names with GetLabelIDsInRepoByNames, a SQL IN
filter that silently drops unknown names, so on a repository without the
labels the PR is created unlabeled and every run finds zero merged release
PRs: no tag, no release, and the next release PR instead - with a green
run each time. That is what happened to #20 and #21.

The workflow now ensures both labels exist (idempotent: list, create the
missing ones) and gained workflow_dispatch so a missed release can be
replayed.
2026-10-24 20:21:50 +02:00
Noel Sabia 7bf649cba6 docs(okf): record CI/CD, AI review, release and secrets decisions
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 36s
PR Check / Typecheck (pull_request) Successful in 38s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 5s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / AI code review (opencode) (pull_request) Failing after 13s
Four new decision documents covering the pipeline work: layering,
AI review setup (provider prefix, v2 CLI, env-only auth, verdict
gate), release engineering (release-please manifest mode), and the
Snyk pause with the token scope policy. Index grouped, log extended,
open questions updated.
2026-10-18 18:19:59 +02:00