Compare commits

..
Author SHA1 Message Date
Noel Sabia a2259df877 fix(ci): point changelog compare links at our Gitea
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m10s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 6s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / AI code review (opencode) (pull_request) Successful in 22s
The generated CHANGELOG linked every release to
github.com/CV_Website/CV_Site_Nuxt, a host this repository does not live
on. release-please takes the compare host from the configuration, so it
is set now.

The decision record also gains the real reason no tag was ever created:
Gitea rewrites a merged PR's head.ref to refs/pull/<n>/head once the head
branch is deleted, and the Gitea build parses that field as the release
branch. BranchName.parse then fails and the release is dropped with a
logged error while the run still exits 0. The repository deleted every
merged branch; that default is off now, and the versions the manifest
already consumed have to be tagged by hand.
2026-10-27 12:20:28 +01:00
Noel 0c937e6f80 Merge pull request 'chore: release main' (#22) from release-please--branches--main into main
release-please / release-please (push) Successful in 7s
Publish image / Build and push image (push) Canceled after 0s
Reviewed-on: #22
2026-10-27 11:12:15 +00:00
Gitea Actions [Bot] e8ce629e1b chore: release main
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m10s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
PR Check / AI code review (opencode) (pull_request) Successful in 19s
2026-10-27 11:07:55 +00:00
Noel f9ddbb7e1a Merge pull request 'fix(ci): create the release-please labels before the action runs' (#23) from fix/release_please into main
release-please / release-please (push) Successful in 9s
Reviewed-on: #23
2026-10-27 11:07:45 +00:00
Noel Sabia 0a3c90cc74 fix(ci): create the release-please labels before the action runs
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m11s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 4s
PR Check / AI code review (opencode) (pull_request) Successful in 38s
release-please finds merged release PRs by the 'autorelease: pending'
label. Gitea resolves label names with GetLabelIDsInRepoByNames, a SQL IN
filter that silently drops unknown names, so on a repository without the
labels the PR is created unlabeled and every run finds zero merged release
PRs: no tag, no release, and the next release PR instead - with a green
run each time. That is what happened to #20 and #21.

The workflow now ensures both labels exist (idempotent: list, create the
missing ones) and gained workflow_dispatch so a missed release can be
replayed.
2026-10-24 20:21:50 +02:00
5 changed files with 123 additions and 3 deletions

No files matched your search

+36
View File
@@ -2,6 +2,10 @@ on:
push: push:
branches: branches:
- main - main
# Manual trigger so a missed release can be replayed without waiting for
# the next push. The job is idempotent: it tags only merged release PRs
# that carry the pending label.
workflow_dispatch:
permissions: permissions:
contents: write contents: write
@@ -13,6 +17,38 @@ jobs:
release-please: release-please:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
# release-please marks its release PR with `autorelease: pending` and
# later finds the merged PR by that label. Gitea's label API resolves
# names and *silently ignores unknown ones* (GetLabelIDsInRepoByNames
# filters by name in SQL), so on a repository without these labels the
# PR is created unlabeled, the release phase finds no merged release PR
# and creates no tag - while the run still reports success. That is the
# bug this step prevents: make the labels exist first, every run.
- name: Ensure release-please labels exist
env:
GITEA_TOKEN: ${{ secrets.PR_GITEA_TOKEN }}
run: |
set -eu
existing="$(curl -sS -H "Authorization: token ${GITEA_TOKEN}" \
"${GITHUB_API_URL}/repos/${GITHUB_REPOSITORY}/labels?limit=50")"
for name in "autorelease: pending" "autorelease: tagged"; do
if printf '%s' "$existing" | grep -qF "\"name\":\"${name}\""; then
echo "label exists: ${name}"
continue
fi
code="$(curl -sS -o /tmp/label.json -w '%{http_code}' -X POST \
-H "Authorization: token ${GITEA_TOKEN}" \
-H 'Content-Type: application/json' \
-d "{\"name\":\"${name}\",\"color\":\"ededed\",\"description\":\"release-please state\"}" \
"${GITHUB_API_URL}/repos/${GITHUB_REPOSITORY}/labels")"
if [ "$code" != "201" ]; then
echo "::error::could not create label '${name}' (HTTP ${code})"
cat /tmp/label.json
exit 1
fi
echo "created label: ${name}"
done
- uses: joaquinjsb/gitea-release-please-action@v4 - uses: joaquinjsb/gitea-release-please-action@v4
with: with:
# One well-scoped token for all workflow API work (see # One well-scoped token for all workflow API work (see
+2 -1
View File
@@ -1,6 +1,6 @@
# Changelog # Changelog
## [1.4.0](https://github.com/CV_Website/CV_Site_Nuxt/compare/v1.3.0...v1.4.0) (2026-10-24) ## [1.4.0](https://github.com/CV_Website/CV_Site_Nuxt/compare/v1.3.0...v1.4.0) (2026-10-27)
### Features ### Features
@@ -25,6 +25,7 @@
* **ci:** address AI review findings (credentials, supply chain) ([85f488a](https://github.com/CV_Website/CV_Site_Nuxt/commit/85f488a94dd8796ea5f11c292edddd32e21398cd)) * **ci:** address AI review findings (credentials, supply chain) ([85f488a](https://github.com/CV_Website/CV_Site_Nuxt/commit/85f488a94dd8796ea5f11c292edddd32e21398cd))
* **ci:** apply review findings round two ([a3e6aef](https://github.com/CV_Website/CV_Site_Nuxt/commit/a3e6aef901086f5f8b416e2aa7d29596517f9550)) * **ci:** apply review findings round two ([a3e6aef](https://github.com/CV_Website/CV_Site_Nuxt/commit/a3e6aef901086f5f8b416e2aa7d29596517f9550))
* **ci:** close the fail-open gate, enforce read-only sandbox ([3e68e63](https://github.com/CV_Website/CV_Site_Nuxt/commit/3e68e630dff92a7abd791b7a8808eb682f37a060)) * **ci:** close the fail-open gate, enforce read-only sandbox ([3e68e63](https://github.com/CV_Website/CV_Site_Nuxt/commit/3e68e630dff92a7abd791b7a8808eb682f37a060))
* **ci:** create the release-please labels before the action runs ([0a3c90c](https://github.com/CV_Website/CV_Site_Nuxt/commit/0a3c90cc7489b7657a9a142fb2b6248ae0738a63))
* **ci:** deny write tools, never swallow review errors ([f8d1287](https://github.com/CV_Website/CV_Site_Nuxt/commit/f8d128705faa9493202cf724ae0a451d4dc6d1e5)) * **ci:** deny write tools, never swallow review errors ([f8d1287](https://github.com/CV_Website/CV_Site_Nuxt/commit/f8d128705faa9493202cf724ae0a451d4dc6d1e5))
* **ci:** gate the ai review to pull_request events, restore route announcer ([9be6298](https://github.com/CV_Website/CV_Site_Nuxt/commit/9be62982a4a2494351006463ae71bd99f4e49fe4)) * **ci:** gate the ai review to pull_request events, restore route announcer ([9be6298](https://github.com/CV_Website/CV_Site_Nuxt/commit/9be62982a4a2494351006463ae71bd99f4e49fe4))
* **ci:** give release-please git credentials for the release-branch push ([a27bbbb](https://github.com/CV_Website/CV_Site_Nuxt/commit/a27bbbb2abf0fa8ddedd20c05bba2128e88faa3a)) * **ci:** give release-please git credentials for the release-branch push ([a27bbbb](https://github.com/CV_Website/CV_Site_Nuxt/commit/a27bbbb2abf0fa8ddedd20c05bba2128e88faa3a))
+76 -2
View File
@@ -48,10 +48,81 @@ feeds this machine is enforced locally by the commitizen pre-commit hook.
3. Merge the release PR → version bumped, changelog written, tag 3. Merge the release PR → version bumped, changelog written, tag
`vX.Y.Z` created. `vX.Y.Z` created.
# The label is load-bearing (2026-10-24)
Steps 2 and 3 are connected by a label, not by the merge alone:
* release-please creates the release PR with `autorelease: pending`;
* on the next run it lists merged PRs and keeps only those carrying that
label; those are the releases it tags.
Gitea resolves label **names** in `POST /issues/{index}/labels` with
`GetLabelIDsInRepoByNames`, which is a SQL `IN` filter: names that do not
exist are dropped **without an error**. A repository with no labels
therefore accepts the call, returns 200, and attaches nothing.
That is exactly what happened here: PRs #20 and #21 were merged as release
PRs with no label at all, so every run found zero merged release PRs,
created zero tags, and opened the next release PR instead — while reporting
success. Three release PRs, no tags.
The workflow now creates both labels (`autorelease: pending`,
`autorelease: tagged`) before the action runs. Idempotent: it reads the
label list and creates only what is missing.
# The head branch must survive the merge (2026-10-27)
The label fix was necessary but not sufficient. PR #22 carried
`autorelease: pending` when it was merged, and the run after it still
created no tag. From its log (task 475):
```
❯ Found pull request #22: 'chore: release main'
✖ Bad branch name: refs/pull/22/head
⚠ Expected 1 releases, only found 0
```
Gitea rewrites a merged PR's `head.ref` to `refs/pull/<n>/head` once the
head branch is deleted; the branch name survives only in `head.label`.
The Gitea build of release-please reads `head.ref`
(`BranchName.parse(mergedPullRequest.headBranchName)`, bundled at
`dist/index.js:15288`) and abandons the release when it is not a release
branch. GitHub keeps the branch name there, which is why the plugin's
assumption holds on GitHub and not here.
The repository deleted the head branch of every merged PR
(`default_delete_branch_after_merge: true`). It is `false` now, and a
release PR must be merged with its branch kept. The mechanism was
confirmed by comparison, not inference: while `fix/release_please` still
existed, PR #23 reported `head.ref = fix/release_please`; every PR whose
branch was gone reported `refs/pull/<n>/head`.
# Recovering the versions that never got a tag
The label alone cannot recover them — #20, #21 and #22 all lost their head
branch, so release-please skips them for the reason above. Creating those
tags is a one-time manual step:
| Version | Merge commit |
|---|---|
| `v1.1.0` | `67cf232` (#12) |
| `v1.2.0` | `4e8aa28` (#20) |
| `v1.3.0` | `08eb042` (#21) |
| `v1.4.0` | `0c937e6` (#22) |
`v1.0.0` is the bootstrap changelog entry from the configuration commit
`c89747e` (2026-10-18); no release PR produced it.
The manifest moved to 1.4.0 without any tag existing, so until a tag is
present release-please has no baseline: it reported "No latest release
found for path: ., component: , but a previous version (1.4.0) was
specified in the manifest" and would compute the next release from the
whole history.
# Not verified # Not verified
* The first release PR end to end — needs at least one `feat:`/`fix:` * That the release phase tags correctly once the head branch survives a
commit on `main` after the workflow merge. merge. The next release cycle proves it.
* That `RELEASE_PLEASE_TOKEN_CV_SITE_NUXT` carries the `write:issue` * That `RELEASE_PLEASE_TOKEN_CV_SITE_NUXT` carries the `write:issue`
scope the same way `PR_GITEA_TOKEN` needed it; the previous failure scope the same way `PR_GITEA_TOKEN` needed it; the previous failure
was an immediate API rejection consistent with a scope problem. was an immediate API rejection consistent with a scope problem.
@@ -62,3 +133,6 @@ feeds this machine is enforced locally by the commitizen pre-commit hook.
`include-component-in-tag` and `separate-pull-requests` matter). `include-component-in-tag` and `separate-pull-requests` matter).
* A release must trigger a deploy — the workflow gains a step after * A release must trigger a deploy — the workflow gains a step after
`release_created` is set. `release_created` is set.
* The label step breaks: if Gitea ever starts rejecting unknown label
names, the `Ensure release-please labels exist` step will fail loudly
instead of silently, which is the point.
+8
View File
@@ -1,5 +1,13 @@
# Update Log # Update Log
## 2026-10-27 (release-please still never tagged: the deleted head branch)
* **Fix**: [release-please-config.json](../release-please-config.json) gained `"changelog-host": "https://git.noelsabia.dev"` - the changelog compare links were generated against `github.com/CV_Website/CV_Site_Nuxt`, a host this repository does not live on. Root cause of the missing tags: **Gitea rewrites `head.ref` to `refs/pull/<n>/head` when the merged PR's branch is deleted**, and release-please parses that field as the release branch, so `BranchName.parse` fails and the release is dropped - silently, exit code 0. Evidence: run 143 (task 475) logs `✖ Bad branch name: refs/pull/22/head` right after `Found pull request #22`, then `Expected 1 releases, only found 0`; #22 did carry `autorelease: pending`. The repository deleted every merged branch (`default_delete_branch_after_merge: true`); it is `false` now. Four versions (1.1.0-1.4.0) were consumed by the manifest with no tag ever created, so the release baseline has to be restored by hand. See [Release engineering](decisions/release-engineering.md).
## 2026-10-24 (release-please never tagged: the missing labels)
* **Fix**: [release-please.yml](../.gitea/workflows/release-please.yml) - the workflow now creates `autorelease: pending` and `autorelease: tagged` before the action runs, and gained `workflow_dispatch` so a missed release can be replayed. Root cause: release-please finds merged release PRs **by label**, and Gitea resolves label names with `GetLabelIDsInRepoByNames`, a SQL `IN` filter that silently drops unknown names. The repository had no labels at all, so PRs #20 and #21 were merged unlabeled, every run found zero merged release PRs, created zero tags and opened the next release PR instead - reporting success each time. Evidence: run 137 green, 0 tags, 0 releases, `labels: []` on #20/#21/#22, and the repo's label list empty. See [Release engineering](decisions/release-engineering.md).
## 2026-10-24 (release publishes an image) ## 2026-10-24 (release publishes an image)
* **Creation**: [publish-image.yml](../.gitea/workflows/publish-image.yml) - a `vX.Y.Z` tag push builds `Dockerfile` on the arm64 runner and pushes `registry.noelsabia.dev/cv_website/nuxt` as the version and `sha-<12>`, plus `latest` when that tag is the newest release. Main pushes deliberately do not build: the registry holds releases, not commits. The job uses the runner's own Docker daemon (client only in the `node:22-bookworm` container), so the act_runner needs `container.docker_host: automount`; the first step fails with that cause if it is missing. That socket is root-equivalent, so it may only sit on a label PR jobs cannot use - recorded under the trust boundary in [Publishing images to the own registry](decisions/registry-publishing.md). Repo secrets: `REGISTRY_USERNAME`, `REGISTRY_PASSWORD`. * **Creation**: [publish-image.yml](../.gitea/workflows/publish-image.yml) - a `vX.Y.Z` tag push builds `Dockerfile` on the arm64 runner and pushes `registry.noelsabia.dev/cv_website/nuxt` as the version and `sha-<12>`, plus `latest` when that tag is the newest release. Main pushes deliberately do not build: the registry holds releases, not commits. The job uses the runner's own Docker daemon (client only in the `node:22-bookworm` container), so the act_runner needs `container.docker_host: automount`; the first step fails with that cause if it is missing. That socket is root-equivalent, so it may only sit on a label PR jobs cannot use - recorded under the trust boundary in [Publishing images to the own registry](decisions/registry-publishing.md). Repo secrets: `REGISTRY_USERNAME`, `REGISTRY_PASSWORD`.
+1
View File
@@ -3,6 +3,7 @@
"release-type": "node", "release-type": "node",
"include-component-in-tag": false, "include-component-in-tag": false,
"separate-pull-requests": false, "separate-pull-requests": false,
"changelog-host": "https://git.noelsabia.dev",
"packages": { "packages": {
".": { ".": {
"package-name": "CV_Site_Frontend", "package-name": "CV_Site_Frontend",