Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
81bfae7489 |
No files matched your search
@@ -27,7 +27,7 @@ jobs:
|
|||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
container: node:22-bookworm
|
container: node:22-bookworm
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v7
|
- uses: actions/checkout@v4
|
||||||
|
|
||||||
- uses: pnpm/action-setup@v4
|
- uses: pnpm/action-setup@v4
|
||||||
with:
|
with:
|
||||||
@@ -55,7 +55,7 @@ jobs:
|
|||||||
# A cache outage must not turn into a red PR: install still works
|
# A cache outage must not turn into a red PR: install still works
|
||||||
# without the store, just slower.
|
# without the store, just slower.
|
||||||
continue-on-error: true
|
continue-on-error: true
|
||||||
uses: actions/cache@v6.1.0
|
uses: actions/cache@v4.1.0
|
||||||
with:
|
with:
|
||||||
path: ${{ steps.pnpm.outputs.store }}
|
path: ${{ steps.pnpm.outputs.store }}
|
||||||
key: pnpm-store-${{ runner.os }}-${{ steps.pnpm.outputs.layout }}-${{ steps.pnpm.outputs.lockfile }}
|
key: pnpm-store-${{ runner.os }}-${{ steps.pnpm.outputs.layout }}-${{ steps.pnpm.outputs.lockfile }}
|
||||||
@@ -82,7 +82,7 @@ jobs:
|
|||||||
# breaks node-based actions like actions/checkout
|
# breaks node-based actions like actions/checkout
|
||||||
container: node:22-bookworm
|
container: node:22-bookworm
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v7
|
- uses: actions/checkout@v4
|
||||||
with:
|
with:
|
||||||
fetch-depth: 0 # gitleaks scans the full history
|
fetch-depth: 0 # gitleaks scans the full history
|
||||||
|
|
||||||
@@ -110,7 +110,7 @@ jobs:
|
|||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
container: node:22-bookworm
|
container: node:22-bookworm
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v7
|
- uses: actions/checkout@v4
|
||||||
|
|
||||||
- uses: pnpm/action-setup@v4
|
- uses: pnpm/action-setup@v4
|
||||||
with:
|
with:
|
||||||
@@ -135,7 +135,7 @@ jobs:
|
|||||||
# binary in the multi-arch node image instead
|
# binary in the multi-arch node image instead
|
||||||
container: node:22-bookworm
|
container: node:22-bookworm
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v7
|
- uses: actions/checkout@v4
|
||||||
|
|
||||||
- name: Install droast
|
- name: Install droast
|
||||||
run: |
|
run: |
|
||||||
@@ -202,7 +202,7 @@ jobs:
|
|||||||
# so install the CLI via npm in the multi-arch node image instead
|
# so install the CLI via npm in the multi-arch node image instead
|
||||||
container: node:22-bookworm
|
container: node:22-bookworm
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v7
|
- uses: actions/checkout@v4
|
||||||
|
|
||||||
- name: Install Snyk CLI
|
- name: Install Snyk CLI
|
||||||
run: npm install -g snyk@1 && snyk --version
|
run: npm install -g snyk@1 && snyk --version
|
||||||
|
|||||||
@@ -59,7 +59,7 @@ jobs:
|
|||||||
# the CLI - see OKF_Nuxt/decisions/registry-publishing.md.
|
# the CLI - see OKF_Nuxt/decisions/registry-publishing.md.
|
||||||
container: node:22-bookworm
|
container: node:22-bookworm
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v7
|
- uses: actions/checkout@v4
|
||||||
|
|
||||||
- name: Install Docker CLI
|
- name: Install Docker CLI
|
||||||
# Debian's docker.io, not a curl-piped binary from GitHub: apt is a
|
# Debian's docker.io, not a curl-piped binary from GitHub: apt is a
|
||||||
|
|||||||
@@ -17,12 +17,6 @@ jobs:
|
|||||||
release-please:
|
release-please:
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
steps:
|
steps:
|
||||||
# The reconcile step below runs a file from this repository. The
|
|
||||||
# release-please action clones into its own temp directory and does not
|
|
||||||
# check the workspace out, so without this step the job fails with
|
|
||||||
# "Cannot find module .../scripts/reconcile-release-please.mjs".
|
|
||||||
- uses: actions/checkout@v7
|
|
||||||
|
|
||||||
# release-please marks its release PR with `autorelease: pending` and
|
# release-please marks its release PR with `autorelease: pending` and
|
||||||
# later finds the merged PR by that label. Gitea's label API resolves
|
# later finds the merged PR by that label. Gitea's label API resolves
|
||||||
# names and *silently ignores unknown ones* (GetLabelIDsInRepoByNames
|
# names and *silently ignores unknown ones* (GetLabelIDsInRepoByNames
|
||||||
@@ -55,21 +49,6 @@ jobs:
|
|||||||
echo "created label: ${name}"
|
echo "created label: ${name}"
|
||||||
done
|
done
|
||||||
|
|
||||||
# The label fix above is not retroactive. PR #22 was merged with
|
|
||||||
# `autorelease: pending` but its head branch had already been deleted,
|
|
||||||
# so the action reports `Bad branch name: refs/pull/22/head`, creates no
|
|
||||||
# tag and leaves the label behind. Every later run then aborts with
|
|
||||||
# "There are untagged, merged release PRs outstanding" and never opens a
|
|
||||||
# new release PR - green, no tags. This step reconciles that state before
|
|
||||||
# the action runs: mark a pending PR tagged when its tag already exists,
|
|
||||||
# or recreate the tag when the head branch is gone and release-please
|
|
||||||
# therefore cannot. See scripts/reconcile-release-please.mjs and
|
|
||||||
# OKF_Nuxt/decisions/release-engineering.md.
|
|
||||||
- name: Reconcile stale release-please state
|
|
||||||
env:
|
|
||||||
GITEA_TOKEN: ${{ secrets.PR_GITEA_TOKEN }}
|
|
||||||
run: node scripts/reconcile-release-please.mjs
|
|
||||||
|
|
||||||
- uses: joaquinjsb/gitea-release-please-action@v4
|
- uses: joaquinjsb/gitea-release-please-action@v4
|
||||||
with:
|
with:
|
||||||
# One well-scoped token for all workflow API work (see
|
# One well-scoped token for all workflow API work (see
|
||||||
|
|||||||
@@ -28,7 +28,7 @@ jobs:
|
|||||||
timeout-minutes: 30
|
timeout-minutes: 30
|
||||||
# Pinned and multi-arch (the runner is arm64). The image installs the
|
# Pinned and multi-arch (the runner is arm64). The image installs the
|
||||||
# Node-based toolchain it needs on demand.
|
# Node-based toolchain it needs on demand.
|
||||||
container: renovate/renovate:44.225.1
|
container: renovate/renovate:44.198.2
|
||||||
steps:
|
steps:
|
||||||
- name: Run Renovate
|
- name: Run Renovate
|
||||||
env:
|
env:
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
{
|
{
|
||||||
".": "1.5.2"
|
".": "1.4.0"
|
||||||
}
|
}
|
||||||
@@ -1,38 +1,5 @@
|
|||||||
# Changelog
|
# Changelog
|
||||||
|
|
||||||
## [1.5.2](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/compare/v1.5.1...v1.5.2) (2026-10-31)
|
|
||||||
|
|
||||||
|
|
||||||
### Bug Fixes
|
|
||||||
|
|
||||||
* **docker:** pin the multi-platform base image index digest ([7981575](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/7981575f862eb2c4d298327e21f7a006fec66591))
|
|
||||||
|
|
||||||
## [1.5.1](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/compare/v1.5.0...v1.5.1) (2026-10-31)
|
|
||||||
|
|
||||||
|
|
||||||
### Bug Fixes
|
|
||||||
|
|
||||||
* **ci:** remove the release-please component mismatch ([e23f8d2](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/e23f8d26185443093f6aff949a22a9e785662c2f))
|
|
||||||
* **ci:** use an empty package-name so release-please tags v1.5.0 ([c8250c9](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/c8250c9ca3f9a7d820d891733f225692f18fa3b3))
|
|
||||||
* updated pnpm lockfile ([42b07e9](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/42b07e9ab938a4eadbcf0b3785fbb86e87f605a1))
|
|
||||||
|
|
||||||
## [1.5.0](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/compare/v1.4.0...v1.5.0) (2026-10-31)
|
|
||||||
|
|
||||||
|
|
||||||
### Features
|
|
||||||
|
|
||||||
* **ci:** replace opencode review with PR-Agent ([c626cc9](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/c626cc9c1dc7db94e645d33eab3c7c7b9a860438))
|
|
||||||
|
|
||||||
|
|
||||||
### Bug Fixes
|
|
||||||
|
|
||||||
* **ci:** check out the repo before the release-please reconcile step ([90ef58a](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/90ef58a8cb8917d547947ae0046a56b8be882114))
|
|
||||||
* **ci:** point changelog compare links at our Gitea ([a2259df](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/a2259df877615c34311a41c1a218ff4bea169d72))
|
|
||||||
* **ci:** repair PR-Agent model routing ([a43134a](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/a43134ad83bece7670543e557f40407892dbf48e))
|
|
||||||
* **ci:** validate the release tag and query pending PRs by label ([7ffc6d7](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/7ffc6d73b607d697a6086a6fe17d077ffc50d5c2))
|
|
||||||
* **deps:** sync lockfile and pin patched seroval ([3eac732](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/3eac73255ff5f5b34233576fc8cbcfa97a50d3dc))
|
|
||||||
* **deps:** unblock the dependency audit ([e0c69c1](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/e0c69c1b7727a65b240e5bcab91dad98cd80fdec))
|
|
||||||
|
|
||||||
## [1.4.0](https://github.com/CV_Website/CV_Site_Nuxt/compare/v1.3.0...v1.4.0) (2026-10-27)
|
## [1.4.0](https://github.com/CV_Website/CV_Site_Nuxt/compare/v1.3.0...v1.4.0) (2026-10-27)
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
+4
-7
@@ -12,14 +12,11 @@
|
|||||||
# edits invalidate almost nothing.
|
# edits invalidate almost nothing.
|
||||||
#
|
#
|
||||||
# Base image is digest-pinned to the same node:26-slim digest as the dev
|
# Base image is digest-pinned to the same node:26-slim digest as the dev
|
||||||
# container (OKF_Nuxt/decisions/dev-container-shape.md). The digest is the
|
# container (OKF_Nuxt/decisions/dev-container-shape.md) - verified for the
|
||||||
# multi-platform OCI INDEX, not a platform manifest: the previous pin was
|
# runner's arm64 and this workstation's x86_64.
|
||||||
# the linux/amd64 manifest digest, so `--platform linux/arm64` on the arm64
|
|
||||||
# runner failed instantly with "no matching manifest for linux/arm64".
|
|
||||||
# Index digest verified 2026-10-31 to contain linux/amd64 and linux/arm64/v8.
|
|
||||||
# syntax: no BuildKit-only features used, so the default frontend suffices.
|
# syntax: no BuildKit-only features used, so the default frontend suffices.
|
||||||
|
|
||||||
FROM node:26-slim@sha256:5adad64f9a1fca2d51972caa65983634c8a774eb300d72b20f7f2a0f60368072 AS build
|
FROM node:26-slim@sha256:18f03e4b532a63baf09809fe8349c2171807f1818cb6c5230fb12aecd5beda65 AS build
|
||||||
|
|
||||||
# pnpm pinned to the same version as CI (pr-checker.yml pins major 11) and
|
# pnpm pinned to the same version as CI (pr-checker.yml pins major 11) and
|
||||||
# the local toolchain (11.26.0). Installed via npm from the node image - no
|
# the local toolchain (11.26.0). Installed via npm from the node image - no
|
||||||
@@ -41,7 +38,7 @@ COPY . .
|
|||||||
RUN pnpm build
|
RUN pnpm build
|
||||||
|
|
||||||
|
|
||||||
FROM node:26-slim@sha256:5adad64f9a1fca2d51972caa65983634c8a774eb300d72b20f7f2a0f60368072
|
FROM node:26-slim@sha256:18f03e4b532a63baf09809fe8349c2171807f1818cb6c5230fb12aecd5beda65
|
||||||
|
|
||||||
# pnpm is NOT installed in the runtime image: nothing here runs pnpm.
|
# pnpm is NOT installed in the runtime image: nothing here runs pnpm.
|
||||||
ENV NODE_ENV=production \
|
ENV NODE_ENV=production \
|
||||||
|
|||||||
+1
-1
@@ -1,4 +1,4 @@
|
|||||||
FROM node:26-slim@sha256:5adad64f9a1fca2d51972caa65983634c8a774eb300d72b20f7f2a0f60368072
|
FROM node:26-slim@sha256:18f03e4b532a63baf09809fe8349c2171807f1818cb6c5230fb12aecd5beda65
|
||||||
|
|
||||||
# Node no longer bundles pnpm (corepack and pnpm are both absent from this
|
# Node no longer bundles pnpm (corepack and pnpm are both absent from this
|
||||||
# image), so install it. First instruction, so later changes reuse the layer.
|
# image), so install it. First instruction, so later changes reuse the layer.
|
||||||
|
|||||||
@@ -34,17 +34,6 @@ the gateway must now **proxy to this server** instead of embedding
|
|||||||
`.output/public/`. That sibling decision needs updating; the compose wiring
|
`.output/public/`. That sibling decision needs updating; the compose wiring
|
||||||
is still open.
|
is still open.
|
||||||
|
|
||||||
# The arm64 digest lesson (2026-10-31)
|
|
||||||
|
|
||||||
The first real release (`v1.5.0`, `v1.5.1`) failed at `Build image` after one
|
|
||||||
second: the pinned `sha256:18f03e4b...` was the **linux/amd64 platform
|
|
||||||
manifest**, not the multi-platform index, so `docker build --platform
|
|
||||||
linux/arm64` on the arm64 runner found no arm64 entry. The base is now
|
|
||||||
pinned to the OCI **index** digest (`sha256:e4db4c91...`, contains
|
|
||||||
linux/amd64 and linux/arm64/v8). Rule: a digest pin for a multi-arch image
|
|
||||||
must be the index digest; `docker buildx imagetools inspect` prints both,
|
|
||||||
and the platform manifests carry a `Platform:` line.
|
|
||||||
|
|
||||||
# Why `--ignore-scripts`
|
# Why `--ignore-scripts`
|
||||||
|
|
||||||
The `postinstall` script (`nuxt prepare`) runs before the source is copied
|
The `postinstall` script (`nuxt prepare`) runs before the source is copied
|
||||||
|
|||||||
@@ -16,9 +16,6 @@ sources:
|
|||||||
- id: workflow
|
- id: workflow
|
||||||
resource: .gitea/workflows/release-please.yml
|
resource: .gitea/workflows/release-please.yml
|
||||||
title: release-please workflow
|
title: release-please workflow
|
||||||
- id: reconcile
|
|
||||||
resource: scripts/reconcile-release-please.mjs
|
|
||||||
title: release-please state reconciliation
|
|
||||||
---
|
---
|
||||||
|
|
||||||
# Decision
|
# Decision
|
||||||
@@ -100,114 +97,6 @@ confirmed by comparison, not inference: while `fix/release_please` still
|
|||||||
existed, PR #23 reported `head.ref = fix/release_please`; every PR whose
|
existed, PR #23 reported `head.ref = fix/release_please`; every PR whose
|
||||||
branch was gone reported `refs/pull/<n>/head`.
|
branch was gone reported `refs/pull/<n>/head`.
|
||||||
|
|
||||||
# A pending label outlives the branch and blocks every later release (2026-10-31)
|
|
||||||
|
|
||||||
Flipping `default_delete_branch_after_merge` to `false` only protects
|
|
||||||
branches deleted *after* the change. PR #22's branch was already gone, so
|
|
||||||
its `head.ref` stayed `refs/pull/22/head` and its `autorelease: pending`
|
|
||||||
label stayed attached. Run 143 (task 475, 2026-10-27, the run immediately
|
|
||||||
after #22 merged) shows the full deadlock:
|
|
||||||
|
|
||||||
```
|
|
||||||
❯ Found pull request #22: 'chore: release main'
|
|
||||||
✖ Bad branch name: refs/pull/22/head
|
|
||||||
...
|
|
||||||
✔ Building candidate release pull request for path: .
|
|
||||||
❯ Found pull request #22: 'chore: release main'
|
|
||||||
⚠ There are untagged, merged release PRs outstanding - aborting
|
|
||||||
::set-output:: prs_created=false
|
|
||||||
::set-output:: releases_created=false
|
|
||||||
```
|
|
||||||
|
|
||||||
The first block fails the tagging phase. The second finds the same
|
|
||||||
still-pending PR and aborts the propose phase, so no new release PR is
|
|
||||||
even opened. Every later run (145, 148, 151, 153, 162, 164, 167) has the
|
|
||||||
same shape. The hand-created `v1.4.0` tag restores the baseline (`found:
|
|
||||||
v1.4.0`) but does not clear the label, so it does not break the
|
|
||||||
deadlock. This is the current reason the pipeline is still healthy-looking
|
|
||||||
and tagless.
|
|
||||||
|
|
||||||
The workflow now reconciles that state before the action runs
|
|
||||||
(`scripts/reconcile-release-please.mjs`):
|
|
||||||
|
|
||||||
* merged + `autorelease: pending` + a tag already at the merge commit ->
|
|
||||||
replace the label with `autorelease: tagged`;
|
|
||||||
* merged + `autorelease: pending` + head branch gone + no tag -> create
|
|
||||||
the tag from the version recorded in the manifest at the merge commit
|
|
||||||
(the exact tag release-please would have made), then swap the label;
|
|
||||||
* merged + `autorelease: pending` + head branch still present -> leave
|
|
||||||
it; release-please tags it in the same run.
|
|
||||||
|
|
||||||
The step is idempotent and runs on every push to `main` and every manual
|
|
||||||
dispatch, so a deleted branch cannot silently poison the release pipeline
|
|
||||||
again. #20 and #21 are not labelled pending, so they do not block; their
|
|
||||||
tags remain the one-time manual recovery in the table below.
|
|
||||||
|
|
||||||
Two details keep the reconciliation from suppressing a real release:
|
|
||||||
|
|
||||||
* pending PRs are fetched through the `autorelease: pending` label filter,
|
|
||||||
not by paging every closed PR, so concurrent PR closes cannot shift a
|
|
||||||
page and hide one;
|
|
||||||
* a tag at the merge commit counts only when its name is exactly
|
|
||||||
`v<manifest version>`. A CI or annotation tag on the same commit is
|
|
||||||
logged and ignored, and the release tag is still created.
|
|
||||||
|
|
||||||
# The release phase drops the PR on a component mismatch (2026-10-31)
|
|
||||||
|
|
||||||
With the branch kept and the label reconciled, PR #35 was still not
|
|
||||||
tagged. Run 181 (task 578, immediately after #35 merged) shows why:
|
|
||||||
|
|
||||||
```
|
|
||||||
❯ Found pull request #35: 'chore: release main'
|
|
||||||
...
|
|
||||||
⚠ PR component: undefined does not match configured component: CV_Site_Frontend
|
|
||||||
...
|
|
||||||
⚠ There are untagged, merged release PRs outstanding - aborting
|
|
||||||
```
|
|
||||||
|
|
||||||
`buildRelease()` compares the component parsed from the merged PR with the
|
|
||||||
strategy's component when the release body contains one component and that
|
|
||||||
component is empty. `include-component-in-tag: false` makes
|
|
||||||
`getComponent()` return an empty string, so the release PR is
|
|
||||||
`chore: release main` with an empty component and the branch is
|
|
||||||
`release-please--branches--main` (parsed component: undefined). But
|
|
||||||
`getBranchComponent()` ignores `include-component-in-tag` and returns
|
|
||||||
`package-name` - here `CV_Site_Frontend`. The two never match, so the
|
|
||||||
release is dropped before the tag is created.
|
|
||||||
|
|
||||||
Removing `package-name` is not enough. Run 183 (after #36 merged) shows
|
|
||||||
the node strategy falling back to the `package.json` name:
|
|
||||||
|
|
||||||
```
|
|
||||||
⚠ PR component: undefined does not match configured component: nuxt-app
|
|
||||||
```
|
|
||||||
|
|
||||||
`BaseStrategy.getDefaultPackageName()` is overridden by the node strategy
|
|
||||||
to read `package.json` `name`, so an absent `package-name` resolves to
|
|
||||||
`nuxt-app`.
|
|
||||||
|
|
||||||
The working setting is `"package-name": ""` (an empty string, not an
|
|
||||||
omitted key). An empty string is not nullish, so `getBranchComponent()`
|
|
||||||
returns empty and matches the legacy default branch
|
|
||||||
`release-please--branches--main`. This was verified by running the
|
|
||||||
action's bundled release-please 16.15.6 locally against the live Gitea
|
|
||||||
API, with writes intercepted: the release phase produced
|
|
||||||
|
|
||||||
```
|
|
||||||
POST /repos/CV_Website/CV_Site_Nuxt/releases
|
|
||||||
{"name":"v1.5.0","tag_name":"v1.5.0",...,"target_commitish":"a80c9ebf..."}
|
|
||||||
```
|
|
||||||
|
|
||||||
then swapped #35 to `autorelease: tagged`. That is release-please creating
|
|
||||||
the tag itself, not a manual `git tag`.
|
|
||||||
|
|
||||||
The action's official default mode (`release-type: node`, no manifest
|
|
||||||
config) was tested the same way and still fails for #35 with
|
|
||||||
`configured component: nuxt-app`. It cannot retroactively accept the
|
|
||||||
already-merged legacy PR; it would only help a release PR created after
|
|
||||||
the switch. The empty `package-name` is therefore the compatibility
|
|
||||||
setting that lets release-please finish v1.5.0.
|
|
||||||
|
|
||||||
# Recovering the versions that never got a tag
|
# Recovering the versions that never got a tag
|
||||||
|
|
||||||
The label alone cannot recover them — #20, #21 and #22 all lost their head
|
The label alone cannot recover them — #20, #21 and #22 all lost their head
|
||||||
@@ -232,15 +121,8 @@ whole history.
|
|||||||
|
|
||||||
# Not verified
|
# Not verified
|
||||||
|
|
||||||
* That the live run tags #35. The exact release-phase request was verified
|
* That the release phase tags correctly once the head branch survives a
|
||||||
locally with writes intercepted (`POST /releases` with `tag_name:
|
merge. The next release cycle proves it.
|
||||||
v1.5.0` at `a80c9eb`); the run after merging the empty `package-name` is
|
|
||||||
the final proof.
|
|
||||||
* That the reconcile step's tag-creation fallback works with a live
|
|
||||||
token. Only the tag-already-exists path was exercised, in dry-run,
|
|
||||||
against the live PR #22. The fallback is written from the same Gitea
|
|
||||||
API shapes (`POST /tags`, `PUT /issues/{index}/labels`) the rest of the
|
|
||||||
workflow uses.
|
|
||||||
* That `RELEASE_PLEASE_TOKEN_CV_SITE_NUXT` carries the `write:issue`
|
* That `RELEASE_PLEASE_TOKEN_CV_SITE_NUXT` carries the `write:issue`
|
||||||
scope the same way `PR_GITEA_TOKEN` needed it; the previous failure
|
scope the same way `PR_GITEA_TOKEN` needed it; the previous failure
|
||||||
was an immediate API rejection consistent with a scope problem.
|
was an immediate API rejection consistent with a scope problem.
|
||||||
|
|||||||
@@ -1,34 +1,5 @@
|
|||||||
# Update Log
|
# Update Log
|
||||||
|
|
||||||
## 2026-10-31 (first release builds failed: pinned the amd64 manifest)
|
|
||||||
|
|
||||||
* **Fix**: [Dockerfile](../Dockerfile) and [Dockerfile.dev](../Dockerfile.dev) - the base digest `sha256:18f03e4b...` was the **linux/amd64 platform manifest**, so `docker build --platform linux/arm64` on the arm64 runner failed at `Build image` one second after the step started (run 157, v1.5.1; run 153, v1.5.0). Both now pin the multi-platform OCI **index** digest `sha256:e4db4c91...`, verified with `docker buildx imagetools inspect` to contain linux/amd64 and linux/arm64/v8. See [Production image shape](decisions/production-image.md).
|
|
||||||
* **Detail**: checkout, Docker CLI install, `Check daemon access`, registry login, the immutability guard and version resolution all passed - the runner and registry setup were correct; only the base image pin was wrong.
|
|
||||||
|
|
||||||
## 2026-10-31 (release-please tag: empty package-name is the verified fix)
|
|
||||||
|
|
||||||
* **Correction**: removing `package-name` in #36 was not enough. Run 183 shows the node strategy falling back to `package.json` `name`, so the release phase still failed with `PR component: undefined does not match configured component: nuxt-app`.
|
|
||||||
* **Fix**: [release-please-config.json](../release-please-config.json) sets `"package-name": ""`. An empty string is not nullish, so `getBranchComponent()` stays empty and matches the legacy `release-please--branches--main` branch. This is the only setting that lets release-please accept the already-merged #35.
|
|
||||||
* **Evidence**: the action's bundled release-please 16.15.6 was run locally against the live Gitea API with writes intercepted. It produced `POST /repos/CV_Website/CV_Site_Nuxt/releases` with `{"name":"v1.5.0","tag_name":"v1.5.0","target_commitish":"a80c9ebf..."}`, then swapped #35 to `autorelease: tagged`. The official default `release-type: node` mode was tested the same way and still fails for #35 with `configured component: nuxt-app`, so it cannot retroactively tag the legacy PR.
|
|
||||||
* **Expected result**: the run after this merge creates `v1.5.0` at `a80c9eb` through the release-please action itself. No manual `git tag`.
|
|
||||||
|
|
||||||
## 2026-10-31 (release-please component mismatch: no v1.5.0 tag)
|
|
||||||
|
|
||||||
* **Fix**: [release-please-config.json](../release-please-config.json) - removed `package-name: CV_Site_Frontend`. With `include-component-in-tag: false` the strategy component and the release PR body component are empty, but `getBranchComponent()` still returned `package-name`; the release phase logged `PR component: undefined does not match configured component: CV_Site_Frontend` and returned before creating the tag. The component now matches, so the next run should tag #35.
|
|
||||||
* **Evidence**: run 181 (task 578, immediately after #35 merged) - the reconcile step correctly left #35 for the action because its branch survived, then the action found #35, hit the component mismatch and aborted with "There are untagged, merged release PRs outstanding". The earlier label/branch fixes were correct; this was the remaining check.
|
|
||||||
* **Expected result**: the run after this merge creates `v1.5.0` at the #35 merge commit (`a80c9eb`), marks #35 `autorelease: tagged`, and stops opening duplicate release PRs.
|
|
||||||
|
|
||||||
## 2026-10-31 (release-please reconcile step needs a checkout)
|
|
||||||
|
|
||||||
* **Fix**: [release-please.yml](../.gitea/workflows/release-please.yml) - added `actions/checkout@v4` before the reconcile step. The job had no checkout because the release-please action clones the repository into its own temp directory; the new step runs `scripts/reconcile-release-please.mjs` from the workspace, so the first post-merge run failed with `Cannot find module '/workspace/CV_Website/CV_Site_Nuxt/scripts/reconcile-release-please.mjs'` (task 571). The checkout supplies the file; the action still uses its own temp clone for the release branch.
|
|
||||||
|
|
||||||
## 2026-10-31 (PR #33 second review: release tag validated, pending PRs queried by label)
|
|
||||||
|
|
||||||
* **Fix**: [reconcile-release-please.mjs](../scripts/reconcile-release-please.mjs) - both PR-Agent findings were confirmed. A tag at the merge commit now counts only when it is exactly `v<manifest version>`; a foreign CI/annotation tag is logged and ignored. Pending release PRs are fetched through the `autorelease: pending` label filter instead of paging every closed PR, so a concurrent close cannot shift a page and hide one.
|
|
||||||
* **Guard**: a merged PR without `merge_commit_sha`, or a manifest without a version, now fails loudly instead of producing `vundefined`.
|
|
||||||
* **Verified locally**: dry-run against the live repo still matches #22 to `v1.4.0`; `pnpm lint`, `pnpm typecheck`, `pnpm build` and `pnpm audit --prod --audit-level moderate` pass on the rebased tree.
|
|
||||||
* **Known issue**: PR-Agent's `/describe` posts `Failed to update PR description`; the bot token has `write:issue` but not the PR-edit scope. Recorded with the fix in [PR-Agent operations](pr-agent.md).
|
|
||||||
|
|
||||||
## 2026-10-31 (registry host corrected: Gitea's built-in registry on git.noelsabia.dev)
|
## 2026-10-31 (registry host corrected: Gitea's built-in registry on git.noelsabia.dev)
|
||||||
|
|
||||||
* **Correction**: `registry.noelsabia.dev` is gone from the documentation and the workflow. Gitea's built-in container registry is served on the Gitea hostname itself, so the image is **`git.noelsabia.dev/cv_website/nuxt:<tag>`** ([docs.gitea.com/usage/packages/container](https://docs.gitea.com/usage/packages/container/)). `registry.noelsabia.dev` was a separate hostname set up before that was known; the server-side setup is being reverted. No separate registry, no extra hostname, no extra certificate - Gitea already provides this by default.
|
* **Correction**: `registry.noelsabia.dev` is gone from the documentation and the workflow. Gitea's built-in container registry is served on the Gitea hostname itself, so the image is **`git.noelsabia.dev/cv_website/nuxt:<tag>`** ([docs.gitea.com/usage/packages/container](https://docs.gitea.com/usage/packages/container/)). `registry.noelsabia.dev` was a separate hostname set up before that was known; the server-side setup is being reverted. No separate registry, no extra hostname, no extra certificate - Gitea already provides this by default.
|
||||||
|
|||||||
@@ -52,16 +52,6 @@ access is a separate change.
|
|||||||
it, Gitea's default egress policy refuses deliveries to the Docker
|
it, Gitea's default egress policy refuses deliveries to the Docker
|
||||||
network.
|
network.
|
||||||
|
|
||||||
# Known issue: "Failed to update PR description"
|
|
||||||
|
|
||||||
On PR #33 (2026-10-31) `/describe` posted `Failed to update PR description`
|
|
||||||
before the reviewer guide. Comments work because the bot token has
|
|
||||||
`write:issue`; editing the PR body is a repository-route write and needs
|
|
||||||
`write:repository` as well. Add that scope to the `pr-agent` token and
|
|
||||||
restart the service, or remove `/describe` from `GITEA__PR_COMMANDS` if the
|
|
||||||
description update is not wanted. The review comment is still posted; this
|
|
||||||
affects only the description sync.
|
|
||||||
|
|
||||||
# Commands
|
# Commands
|
||||||
|
|
||||||
| Trigger | What runs |
|
| Trigger | What runs |
|
||||||
|
|||||||
+1
-1
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "nuxt-app",
|
"name": "nuxt-app",
|
||||||
"version": "1.5.2",
|
"version": "1.4.0",
|
||||||
"type": "module",
|
"type": "module",
|
||||||
"private": true,
|
"private": true,
|
||||||
"engines": {
|
"engines": {
|
||||||
|
|||||||
Generated
+1283
-1268
File diff suppressed because it is too large.
Load diff
+4
-9
@@ -26,23 +26,23 @@ overrides:
|
|||||||
# already in the tree via postcss-nesting and is API-compatible. Remove
|
# already in the tree via postcss-nesting and is API-compatible. Remove
|
||||||
# the override when tailwindcss ships >= 7.1.6 itself (or the site moves
|
# the override when tailwindcss ships >= 7.1.6 itself (or the site moves
|
||||||
# to Tailwind v4).
|
# to Tailwind v4).
|
||||||
postcss-selector-parser: 7.2.0
|
postcss-selector-parser: 7.1.6
|
||||||
# GHSA-f86p-h4j2-7qgj and GHSA-9wx9-5pv9-3349 (moderate, 2026-10-30):
|
# GHSA-f86p-h4j2-7qgj and GHSA-9wx9-5pv9-3349 (moderate, 2026-10-30):
|
||||||
# seroval < 1.6.11 allows code/script injection through serialized output.
|
# seroval < 1.6.11 allows code/script injection through serialized output.
|
||||||
# Nuxt's vite-builder still resolves 1.6.9; the patched 1.6.11 is the
|
# Nuxt's vite-builder still resolves 1.6.9; the patched 1.6.11 is the
|
||||||
# smallest version that clears both advisories. Remove this when Nuxt ships
|
# smallest version that clears both advisories. Remove this when Nuxt ships
|
||||||
# a vite-builder that resolves >= 1.6.11 itself.
|
# a vite-builder that resolves >= 1.6.11 itself.
|
||||||
seroval: 1.8.0
|
seroval: 1.6.11
|
||||||
# GHSA-g3hv-75wg-m249 (moderate, 2026-10-31): minimatch < 11.0.1 has a
|
# GHSA-g3hv-75wg-m249 (moderate, 2026-10-31): minimatch < 11.0.1 has a
|
||||||
# globparts amplification DoS. Deliberately NOT overridden - see the
|
# globparts amplification DoS. Deliberately NOT overridden - see the
|
||||||
# auditConfig ignore note above.
|
# auditConfig ignore note above.
|
||||||
# GHSA-3g3m-2fjr-6pw4 (moderate, 2026-10-31): glob 9.0.0-14.0.1 bypasses
|
# GHSA-3g3m-2fjr-6pw4 (moderate, 2026-10-31): glob 9.0.0-14.0.1 bypasses
|
||||||
# AbortSignal cancellation. Patched in 14.0.2; the range keeps glob 7 for
|
# AbortSignal cancellation. Patched in 14.0.2; the range keeps glob 7 for
|
||||||
# tailwind-config-viewer.
|
# tailwind-config-viewer.
|
||||||
"glob@>=9.0.0 <=14.0.1": 14.0.4
|
"glob@>=9.0.0 <=14.0.1": 14.0.2
|
||||||
# node-forge 1.4.1 shipped (2026-10-31) and clears every node-forge
|
# node-forge 1.4.1 shipped (2026-10-31) and clears every node-forge
|
||||||
# advisory that was previously ignored - no ignore needed anymore.
|
# advisory that was previously ignored - no ignore needed anymore.
|
||||||
node-forge: 1.4.3
|
node-forge: 1.4.1
|
||||||
minimumReleaseAgeExclude:
|
minimumReleaseAgeExclude:
|
||||||
- '@rollup/rollup-darwin-x64@4.64.8'
|
- '@rollup/rollup-darwin-x64@4.64.8'
|
||||||
- '@rollup/rollup-freebsd-arm64@4.64.8'
|
- '@rollup/rollup-freebsd-arm64@4.64.8'
|
||||||
@@ -56,8 +56,3 @@ minimumReleaseAgeExclude:
|
|||||||
- '@rollup/rollup-openharmony-arm64@4.64.8'
|
- '@rollup/rollup-openharmony-arm64@4.64.8'
|
||||||
- '@rollup/rollup-win32-ia32-msvc@4.64.8'
|
- '@rollup/rollup-win32-ia32-msvc@4.64.8'
|
||||||
- '@nuxt/icon@2.6.0'
|
- '@nuxt/icon@2.6.0'
|
||||||
permissions:
|
|
||||||
'@nuxtjs/seo':
|
|
||||||
skills:
|
|
||||||
dirs:
|
|
||||||
- .agents/skills
|
|
||||||
@@ -6,7 +6,7 @@
|
|||||||
"changelog-host": "https://git.noelsabia.dev",
|
"changelog-host": "https://git.noelsabia.dev",
|
||||||
"packages": {
|
"packages": {
|
||||||
".": {
|
".": {
|
||||||
"package-name": "",
|
"package-name": "CV_Site_Frontend",
|
||||||
"changelog-path": "CHANGELOG.md",
|
"changelog-path": "CHANGELOG.md",
|
||||||
"extra-files": [],
|
"extra-files": [],
|
||||||
"versioning": "default"
|
"versioning": "default"
|
||||||
|
|||||||
@@ -1,205 +0,0 @@
|
|||||||
// Repairs the release-please state that its Gitea fork cannot recover from.
|
|
||||||
//
|
|
||||||
// Why this exists (evidence in OKF_Nuxt/decisions/release-engineering.md):
|
|
||||||
//
|
|
||||||
// Gitea rewrites a merged PR's `head.ref` to `refs/pull/<n>/head` when the
|
|
||||||
// head branch is deleted. The fork parses that field as the release branch,
|
|
||||||
// logs `Bad branch name`, creates no tag - and still exits successfully.
|
|
||||||
// The merged PR keeps `autorelease: pending`, so every later run aborts with
|
|
||||||
// `There are untagged, merged release PRs outstanding` and opens no new
|
|
||||||
// release PR. That is a permanent deadlock, not a transient failure.
|
|
||||||
//
|
|
||||||
// This script runs before the action and reconciles the state:
|
|
||||||
//
|
|
||||||
// * a merged pending PR whose merge commit already has the expected
|
|
||||||
// `v<manifest version>` tag -> swap `autorelease: pending` for
|
|
||||||
// `autorelease: tagged` (the release exists, only the label is stale);
|
|
||||||
// * a merged pending PR whose head branch is gone and has no expected tag
|
|
||||||
// -> create the tag from the version recorded in the manifest at that
|
|
||||||
// merge commit. This is exactly the tag release-please would have made if
|
|
||||||
// the branch had survived; without it the PR blocks every future release;
|
|
||||||
// * a merged pending PR whose head branch still exists -> leave it alone,
|
|
||||||
// release-please tags it in the same run.
|
|
||||||
//
|
|
||||||
// Pending PRs are looked up by the label itself, not by paging through every
|
|
||||||
// closed PR: the set is tiny (normally zero or one) and cannot race with PRs
|
|
||||||
// closing while the pages are being read.
|
|
||||||
//
|
|
||||||
// Run locally against the public API with:
|
|
||||||
// DRY_RUN=1 node scripts/reconcile-release-please.mjs
|
|
||||||
// Reads work unauthenticated for a public repository; writes are skipped.
|
|
||||||
|
|
||||||
const API_URL = process.env.GITHUB_API_URL
|
|
||||||
const REPOSITORY = process.env.GITHUB_REPOSITORY
|
|
||||||
const TOKEN = process.env.GITEA_TOKEN
|
|
||||||
const DRY_RUN = process.env.DRY_RUN === '1' || process.argv.includes('--dry-run')
|
|
||||||
|
|
||||||
const PENDING = 'autorelease: pending'
|
|
||||||
const TAGGED = 'autorelease: tagged'
|
|
||||||
const MANIFEST = '.release-please-manifest.json'
|
|
||||||
|
|
||||||
if (!API_URL || !REPOSITORY) {
|
|
||||||
console.error('::error::GITHUB_API_URL and GITHUB_REPOSITORY must be set')
|
|
||||||
process.exit(1)
|
|
||||||
}
|
|
||||||
if (!TOKEN && !DRY_RUN) {
|
|
||||||
console.error('::error::GITEA_TOKEN is required (or set DRY_RUN=1)')
|
|
||||||
process.exit(1)
|
|
||||||
}
|
|
||||||
|
|
||||||
const repoUrl = `${API_URL}/repos/${REPOSITORY}`
|
|
||||||
|
|
||||||
const api = async (path, init = {}) => {
|
|
||||||
const response = await fetch(`${repoUrl}${path}`, {
|
|
||||||
...init,
|
|
||||||
headers: {
|
|
||||||
Accept: 'application/json',
|
|
||||||
...(TOKEN ? { Authorization: `token ${TOKEN}` } : {}),
|
|
||||||
...(init.headers ?? {}),
|
|
||||||
},
|
|
||||||
})
|
|
||||||
const body = await response.text()
|
|
||||||
if (!response.ok) {
|
|
||||||
throw new Error(`${init.method ?? 'GET'} ${path} -> HTTP ${response.status}: ${body.slice(0, 300)}`)
|
|
||||||
}
|
|
||||||
return body ? JSON.parse(body) : null
|
|
||||||
}
|
|
||||||
|
|
||||||
// Gitea caps page size at 50. The label-filtered issue list is normally one
|
|
||||||
// page; loop anyway so a backlog of stale pending PRs is still reconciled.
|
|
||||||
const listAll = async (path, params = {}) => {
|
|
||||||
const items = []
|
|
||||||
for (let page = 1; ; page++) {
|
|
||||||
const query = new URLSearchParams({ ...params, limit: '50', page: String(page) })
|
|
||||||
const batch = await api(`${path}?${query}`)
|
|
||||||
items.push(...batch)
|
|
||||||
if (batch.length < 50) return items
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
const replaceLabels = async (number, labels) => {
|
|
||||||
if (DRY_RUN) {
|
|
||||||
console.log(`[dry-run] #${number}: labels -> ${labels.join(', ')}`)
|
|
||||||
return
|
|
||||||
}
|
|
||||||
await api(`/issues/${number}/labels`, {
|
|
||||||
method: 'PUT',
|
|
||||||
headers: { 'Content-Type': 'application/json' },
|
|
||||||
body: JSON.stringify({ labels }),
|
|
||||||
})
|
|
||||||
}
|
|
||||||
|
|
||||||
const createTag = async (name, sha) => {
|
|
||||||
if (DRY_RUN) {
|
|
||||||
console.log(`[dry-run] create tag ${name} at ${sha}`)
|
|
||||||
return
|
|
||||||
}
|
|
||||||
await api('/tags', {
|
|
||||||
method: 'POST',
|
|
||||||
headers: { 'Content-Type': 'application/json' },
|
|
||||||
body: JSON.stringify({ tag_name: name, target: sha, message: `Release ${name}` }),
|
|
||||||
})
|
|
||||||
}
|
|
||||||
|
|
||||||
const versionAt = async (sha) => {
|
|
||||||
const file = await api(`/contents/${MANIFEST}?ref=${sha}`)
|
|
||||||
if (!file?.content) throw new Error(`no manifest content at ${sha}`)
|
|
||||||
const manifest = JSON.parse(Buffer.from(file.content, 'base64').toString('utf8'))
|
|
||||||
// Single-package repository: the root path is ".". Keep a fallback so a
|
|
||||||
// future second package cannot silently produce `vundefined`.
|
|
||||||
const version = manifest['.'] ?? Object.values(manifest)[0]
|
|
||||||
if (!version) throw new Error(`manifest at ${sha} has no version`)
|
|
||||||
return version
|
|
||||||
}
|
|
||||||
|
|
||||||
const run = async () => {
|
|
||||||
// One tag can point at the merge commit for a non-release reason (CI
|
|
||||||
// tooling, a manual annotation). Only the `v<manifest version>` tag proves
|
|
||||||
// the release exists; every other tag at that commit is ignored.
|
|
||||||
const tags = await listAll('/tags')
|
|
||||||
const tagsAtSha = new Map()
|
|
||||||
const tagSha = new Map()
|
|
||||||
for (const tag of tags) {
|
|
||||||
const sha = tag.commit?.sha
|
|
||||||
if (!sha) continue
|
|
||||||
if (!tagsAtSha.has(sha)) tagsAtSha.set(sha, [])
|
|
||||||
tagsAtSha.get(sha).push(tag.name)
|
|
||||||
tagSha.set(tag.name, sha)
|
|
||||||
}
|
|
||||||
|
|
||||||
const pendingIssues = await listAll('/issues', {
|
|
||||||
state: 'closed',
|
|
||||||
type: 'pulls',
|
|
||||||
labels: PENDING,
|
|
||||||
})
|
|
||||||
if (pendingIssues.length === 0) {
|
|
||||||
console.log('No merged release PR is pending - nothing to reconcile.')
|
|
||||||
return
|
|
||||||
}
|
|
||||||
|
|
||||||
const failures = []
|
|
||||||
const versionCache = new Map()
|
|
||||||
|
|
||||||
for (const issue of pendingIssues) {
|
|
||||||
const pull = await api(`/pulls/${issue.number}`)
|
|
||||||
if (!pull.merged_at) continue
|
|
||||||
|
|
||||||
const mergeSha = pull.merge_commit_sha
|
|
||||||
if (!mergeSha) {
|
|
||||||
failures.push(`#${pull.number}: merged PR has no merge_commit_sha`)
|
|
||||||
continue
|
|
||||||
}
|
|
||||||
const headRef = pull.head?.ref ?? ''
|
|
||||||
const branchGone = headRef.startsWith('refs/pull/') || headRef === ''
|
|
||||||
const labels = (pull.labels ?? []).map(label => label.name)
|
|
||||||
if (!versionCache.has(mergeSha)) versionCache.set(mergeSha, await versionAt(mergeSha))
|
|
||||||
const expectedTag = `v${versionCache.get(mergeSha)}`
|
|
||||||
const tagsHere = tagsAtSha.get(mergeSha) ?? []
|
|
||||||
|
|
||||||
if (tagsHere.includes(expectedTag)) {
|
|
||||||
console.log(`#${pull.number}: ${expectedTag} already points at merge commit ${mergeSha} - marking as tagged`)
|
|
||||||
const next = labels.filter(name => name !== PENDING)
|
|
||||||
if (!next.includes(TAGGED)) next.push(TAGGED)
|
|
||||||
await replaceLabels(pull.number, next)
|
|
||||||
continue
|
|
||||||
}
|
|
||||||
|
|
||||||
if (tagsHere.length > 0) {
|
|
||||||
console.log(`#${pull.number}: ignoring non-release tag(s) at merge commit: ${tagsHere.join(', ')}`)
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!branchGone) {
|
|
||||||
console.log(`#${pull.number}: head branch ${headRef} still exists - leaving it for release-please to tag`)
|
|
||||||
continue
|
|
||||||
}
|
|
||||||
|
|
||||||
// The branch is gone and the expected tag is missing, so release-please
|
|
||||||
// will never get past `Bad branch name` for this PR. Recreate the tag it
|
|
||||||
// should have made, using the version the merged release PR wrote into the
|
|
||||||
// manifest.
|
|
||||||
try {
|
|
||||||
if (tagSha.has(expectedTag)) {
|
|
||||||
throw new Error(`${expectedTag} already exists at ${tagSha.get(expectedTag)}, not at merge commit ${mergeSha}; refusing to move a release tag`)
|
|
||||||
}
|
|
||||||
console.log(`#${pull.number}: head branch is gone (${headRef}) - creating ${expectedTag} at ${mergeSha}`)
|
|
||||||
await createTag(expectedTag, mergeSha)
|
|
||||||
const next = labels.filter(name => name !== PENDING)
|
|
||||||
if (!next.includes(TAGGED)) next.push(TAGGED)
|
|
||||||
await replaceLabels(pull.number, next)
|
|
||||||
}
|
|
||||||
catch (error) {
|
|
||||||
failures.push(`#${pull.number}: ${error.message}`)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
if (failures.length > 0) {
|
|
||||||
for (const failure of failures) console.error(`::error::${failure}`)
|
|
||||||
console.error('::error::release-please state is unrecoverable automatically; repair the PR/tag by hand before the next release')
|
|
||||||
process.exit(1)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
run().catch((error) => {
|
|
||||||
console.error(`::error::${error.message}`)
|
|
||||||
process.exit(1)
|
|
||||||
})
|
|
||||||
Reference in new issue
Block a user