Compare commits

..
Author SHA1 Message Date
Noel Sabia 81bfae7489 ci(publish): add a manual build-only rehearsal trigger
workflow_dispatch with version/push/latest inputs: push defaults to
false, so the runner, socket and registry login can be verified without
creating a tag or a package version. latest is never moved unless asked.
2026-10-31 20:40:10 +01:00
Noel Sabia e0c69c1b77 fix(deps): unblock the dependency audit
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m7s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 8s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
Bump nuxt to 4.6.3 and override node-forge 1.4.1 and glob 14.0.2.
minimatch stays a reviewed ignore: its patch drops makeRe, which
eslint-plugin-import-x imports.

Verified locally: lint, typecheck, build, and the exact audit command.
2026-10-31 19:57:38 +01:00
Noel Sabia c00db55f98 Merge remote-tracking branch 'origin/main' into feat/docs_registrys
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m6s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Failing after 8s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
# Conflicts:
#	OKF_Nuxt/log.md
2026-10-31 19:51:00 +01:00
Noel Sabia 700b1030fc docs: use Gitea's own registry on git.noelsabia.dev
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Failing after 1m17s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 7s
PR Check / Dependency audit (pull_request) Failing after 10s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
PR Check / AI code review (opencode) (pull_request) Failing after 14s
The registry endpoint is the Gitea hostname itself, not a separate
registry.noelsabia.dev host. Point IMAGE, docker login and the v2
manifests check at git.noelsabia.dev and record the correction.
2026-10-31 19:05:57 +01:00
Noel Sabia 5f7027bd86 docs: record that the registry is Gitea's built-in container registry
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Failing after 22s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Failing after 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
PR Check / AI code review (opencode) (pull_request) Failing after 13s
Verified by logging in to registry.noelsabia.dev and pushing by hand.
The registry is Gitea's own, not a separately deployed component, so
there is nothing to stand up or reinvent.
2026-10-31 18:56:56 +01:00
12 changed files with 651 additions and 761 deletions

No files matched your search

+56 -8
View File
@@ -9,6 +9,24 @@ on:
push: push:
tags: tags:
- 'v*' - 'v*'
# Manual rehearsal from the Gitea UI (Actions -> Publish image -> Run
# workflow). `push` defaults to false: the job builds and smoke-tests, then
# stops without publishing, so the runner can be verified without creating
# a tag or a package version. Set `push` to true (and `latest` only for a
# real release) to publish.
workflow_dispatch:
inputs:
version:
description: 'Version to build, e.g. v0.0.1 (vMAJOR.MINOR.PATCH)'
required: true
push:
description: 'Push the image to the registry'
required: false
default: 'false'
latest:
description: 'Also move :latest (real releases only)'
required: false
default: 'false'
# The runner has capacity 1, so releases already serialize. This keeps a # The runner has capacity 1, so releases already serialize. This keeps a
# manual re-run from racing a fresh release on the same tags. # manual re-run from racing a fresh release on the same tags.
@@ -18,8 +36,8 @@ concurrency:
env: env:
# Registry host + repository path. The path segment is the Gitea # Registry host + repository path. The path segment is the Gitea
# organisation, so k3s pulls registry.noelsabia.dev/cv_website/nuxt:<tag>. # organisation, so k3s pulls git.noelsabia.dev/cv_website/nuxt:<tag>.
IMAGE: registry.noelsabia.dev/cv_website/nuxt IMAGE: git.noelsabia.dev/cv_website/nuxt
APP_DIR: . APP_DIR: .
jobs: jobs:
@@ -72,10 +90,19 @@ jobs:
- name: Resolve version and tags - name: Resolve version and tags
id: version id: version
env:
# Inputs go through env, not direct interpolation: a value pasted
# into a `run:` block is shell code before any check can run.
INPUT_VERSION: ${{ github.event.inputs.version }}
INPUT_LATEST: ${{ github.event.inputs.latest }}
run: | run: |
# GITHUB_REF_NAME is the tag on a tag push. The git fallback keeps # On a tag push GITHUB_REF_NAME is the tag; on workflow_dispatch it
# this working if a runner version does not set it. # is the BRANCH, so the manual version input must win. The git
version="${GITHUB_REF_NAME:-$(git describe --tags --exact-match HEAD)}" # fallback keeps tag pushes working if a runner omits the variable.
version="$INPUT_VERSION"
if [ -z "$version" ]; then
version="${GITHUB_REF_NAME:-$(git describe --tags --exact-match HEAD)}"
fi
# Strict semver, not a `v[0-9]*` prefix match: that would accept # Strict semver, not a `v[0-9]*` prefix match: that would accept
# `v1`, `v1-anything` and prereleases, all valid registry tags. # `v1`, `v1-anything` and prereleases, all valid registry tags.
if ! printf '%s' "$version" | grep -qE '^v[0-9]+\.[0-9]+\.[0-9]+$'; then if ! printf '%s' "$version" | grep -qE '^v[0-9]+\.[0-9]+\.[0-9]+$'; then
@@ -91,7 +118,13 @@ jobs:
# A tag comparison needs the other tags, which a depth-1 tag # A tag comparison needs the other tags, which a depth-1 tag
# checkout does not have. If the fetch fails, skip `latest` and # checkout does not have. If the fetch fails, skip `latest` and
# say so - a wrong tag is worse than a missing one. # say so - a wrong tag is worse than a missing one.
if git fetch --tags --force --quiet origin 2>/dev/null; then #
# A manual run moves `latest` only when the `latest` input says so;
# a rehearsal must never repoint the production tag.
if [ "$INPUT_LATEST" = "true" ]; then
latest=true
echo "manual run requested :latest"
elif git fetch --tags --force --quiet origin 2>/dev/null; then
newest="$(git tag -l | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$' | sort -V | tail -n 1)" newest="$(git tag -l | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$' | sort -V | tail -n 1)"
if [ "$version" = "$newest" ]; then if [ "$version" = "$newest" ]; then
latest=true latest=true
@@ -125,9 +158,12 @@ jobs:
[ -n "$REGISTRY_USERNAME" ] || { echo "::error::secret REGISTRY_USERNAME is empty"; exit 1; } [ -n "$REGISTRY_USERNAME" ] || { echo "::error::secret REGISTRY_USERNAME is empty"; exit 1; }
[ -n "$REGISTRY_PASSWORD" ] || { echo "::error::secret REGISTRY_PASSWORD is empty"; exit 1; } [ -n "$REGISTRY_PASSWORD" ] || { echo "::error::secret REGISTRY_PASSWORD is empty"; exit 1; }
printf '%s' "$REGISTRY_PASSWORD" \ printf '%s' "$REGISTRY_PASSWORD" \
| docker login registry.noelsabia.dev -u "$REGISTRY_USERNAME" --password-stdin | docker login git.noelsabia.dev -u "$REGISTRY_USERNAME" --password-stdin
- name: Refuse to overwrite a published version - name: Refuse to overwrite a published version
# Build-only rehearsals publish nothing, so an existing tag is not a
# conflict there; the guard only protects actual pushes.
if: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.push == 'true' }}
env: env:
REGISTRY_USERNAME: ${{ secrets.REGISTRY_USERNAME }} REGISTRY_USERNAME: ${{ secrets.REGISTRY_USERNAME }}
REGISTRY_PASSWORD: ${{ secrets.REGISTRY_PASSWORD }} REGISTRY_PASSWORD: ${{ secrets.REGISTRY_PASSWORD }}
@@ -143,7 +179,7 @@ jobs:
# Debian 20.10 client fails that command on OCI indexes with # Debian 20.10 client fails that command on OCI indexes with
# "unsupported manifest media type and no default available", # "unsupported manifest media type and no default available",
# for existing and missing tags alike. # for existing and missing tags alike.
url="https://registry.noelsabia.dev/v2/cv_website/nuxt/manifests/${VERSION}" url="https://git.noelsabia.dev/v2/cv_website/nuxt/manifests/${VERSION}"
code=$(curl -s -o /dev/null -w '%{http_code}' \ code=$(curl -s -o /dev/null -w '%{http_code}' \
-u "${REGISTRY_USERNAME}:${REGISTRY_PASSWORD}" \ -u "${REGISTRY_USERNAME}:${REGISTRY_PASSWORD}" \
-H 'Accept: application/vnd.docker.distribution.manifest.v2+json' \ -H 'Accept: application/vnd.docker.distribution.manifest.v2+json' \
@@ -213,6 +249,8 @@ jobs:
run: docker tag "${IMAGE}:${VERSION}" "${IMAGE}:latest" run: docker tag "${IMAGE}:${VERSION}" "${IMAGE}:latest"
- name: Push image - name: Push image
# Manual run with `push` left at false: build and smoke test only.
if: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.push == 'true' }}
env: env:
VERSION: ${{ steps.version.outputs.version }} VERSION: ${{ steps.version.outputs.version }}
SHA: ${{ steps.version.outputs.sha }} SHA: ${{ steps.version.outputs.sha }}
@@ -228,3 +266,13 @@ jobs:
else else
echo "Pushed ${IMAGE}:${VERSION}, :sha-${SHA} (:latest untouched)" echo "Pushed ${IMAGE}:${VERSION}, :sha-${SHA} (:latest untouched)"
fi fi
- name: Rehearsal summary
if: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.push != 'true' }}
env:
VERSION: ${{ steps.version.outputs.version }}
SHA: ${{ steps.version.outputs.sha }}
run: |
echo "Build-only rehearsal for ${VERSION} (${SHA}) - the image passed the smoke test and was NOT pushed."
echo "Re-run with push=true to publish it."
-15
View File
@@ -49,21 +49,6 @@ jobs:
echo "created label: ${name}" echo "created label: ${name}"
done done
# The label fix above is not retroactive. PR #22 was merged with
# `autorelease: pending` but its head branch had already been deleted,
# so the action reports `Bad branch name: refs/pull/22/head`, creates no
# tag and leaves the label behind. Every later run then aborts with
# "There are untagged, merged release PRs outstanding" and never opens a
# new release PR - green, no tags. This step reconciles that state before
# the action runs: mark a pending PR tagged when its tag already exists,
# or recreate the tag when the head branch is gone and release-please
# therefore cannot. See scripts/reconcile-release-please.mjs and
# OKF_Nuxt/decisions/release-engineering.md.
- name: Reconcile stale release-please state
env:
GITEA_TOKEN: ${{ secrets.PR_GITEA_TOKEN }}
run: node scripts/reconcile-release-please.mjs
- uses: joaquinjsb/gitea-release-please-action@v4 - uses: joaquinjsb/gitea-release-please-action@v4
with: with:
# One well-scoped token for all workflow API work (see # One well-scoped token for all workflow API work (see
+1 -1
View File
@@ -6,7 +6,7 @@
* [Vulnerability audit policy](vulnerability-audit-policy.md) - Blocking audit, reviewed ignore-list for unfixable advisories, and the pnpm-11 settings home. * [Vulnerability audit policy](vulnerability-audit-policy.md) - Blocking audit, reviewed ignore-list for unfixable advisories, and the pnpm-11 settings home.
* [Release engineering](release-engineering.md) - release-please in manifest mode, conventional commits as input, message format enforced at commit time. * [Release engineering](release-engineering.md) - release-please in manifest mode, conventional commits as input, message format enforced at commit time.
* [Snyk paused and secrets policy](snyk-paused-and-secrets-policy.md) - Why the job is skipped rather than deleted, and the token scopes every workflow secret needs. * [Snyk paused and secrets policy](snyk-paused-and-secrets-policy.md) - Why the job is skipped rather than deleted, and the token scopes every workflow secret needs.
* [Publishing images to the own registry](registry-publishing.md) - A release tag builds and pushes to registry.noelsabia.dev; main pushes do not build. * [Publishing images to the own registry](registry-publishing.md) - A release tag builds and pushes to git.noelsabia.dev; main pushes do not build.
* [Dev container shape](dev-container-shape.md) - The source is bind-mounted into a container that already holds the dependencies, and the dev server runs as the image's `node` user. * [Dev container shape](dev-container-shape.md) - The source is bind-mounted into a container that already holds the dependencies, and the dev server runs as the image's `node` user.
* [Build layer order](build-layer-order.md) - Why the manifests are copied before the source, and what invalidates what. * [Build layer order](build-layer-order.md) - Why the manifests are copied before the source, and what invalidates what.
* [Build context filter](build-context-filter.md) - What `.dockerignore` may exclude, and the one thing it must never exclude. * [Build context filter](build-context-filter.md) - What `.dockerignore` may exclude, and the one thing it must never exclude.
+49 -7
View File
@@ -1,7 +1,7 @@
--- ---
type: Decision type: Decision
title: Publishing images to the own registry title: Publishing images to the own registry
description: A release tag builds the production image and pushes it to registry.noelsabia.dev, because that is the only way Kubernetes can pull it. description: A release tag builds the production image and pushes it to git.noelsabia.dev, because that is the only way Kubernetes can pull it.
tags: [decision, ci, docker, registry, gitea-actions] tags: [decision, ci, docker, registry, gitea-actions]
status: draft status: draft
generated: { by: opencode-go/deepseek-v4.1-flash, at: 2026-10-24T00:00:00Z } generated: { by: opencode-go/deepseek-v4.1-flash, at: 2026-10-24T00:00:00Z }
@@ -20,13 +20,36 @@ sources:
# Decision # Decision
**The registry is Gitea's own, served on the Gitea host.** Gitea ships a
built-in container registry per owner/organisation
([docs.gitea.com - container](https://docs.gitea.com/usage/packages/container/)).
The endpoint is the Gitea hostname itself - `git.noelsabia.dev` - and the
`/cv_website/` path segment is the Gitea organisation; images live under
the package of the repository that pushed them:
```
docker login git.noelsabia.dev
git.noelsabia.dev/cv_website/nuxt:<tag>
```
There is nothing to stand up and nothing to reinvent: no separate
Registry/Harbor deployment, no extra hostname, no extra certificate.
TLS and auth are the ones Gitea already serves. The publishing workflow
exists only to automate pushes to this built-in registry.
**Corrected 2026-10-31:** `registry.noelsabia.dev` was a separate
hostname set up before this was known. It is not needed and is being
removed on the server side; this repository now uses
`git.noelsabia.dev` everywhere. Any leftover `registry.noelsabia.dev`
reference is a bug.
`.gitea/workflows/publish-image.yml` builds `Dockerfile` and pushes the `.gitea/workflows/publish-image.yml` builds `Dockerfile` and pushes the
result to the own registry: result to the own registry:
``` ```
registry.noelsabia.dev/cv_website/nuxt:v1.2.3 git.noelsabia.dev/cv_website/nuxt:v1.2.3
registry.noelsabia.dev/cv_website/nuxt:sha-<12-char-sha> git.noelsabia.dev/cv_website/nuxt:sha-<12-char-sha>
registry.noelsabia.dev/cv_website/nuxt:latest # newest release only git.noelsabia.dev/cv_website/nuxt:latest # newest release only
``` ```
**Trigger is the release tag, not the main push.** release-please creates **Trigger is the release tag, not the main push.** release-please creates
@@ -103,7 +126,7 @@ run.
| Gitea secret | Use | | Gitea secret | Use |
|---|---| |---|---|
| `REGISTRY_USERNAME` | basic-auth user for `docker login registry.noelsabia.dev` | | `REGISTRY_USERNAME` | basic-auth user for `docker login git.noelsabia.dev` |
| `REGISTRY_PASSWORD` | basic-auth password (or token) for the same login | | `REGISTRY_PASSWORD` | basic-auth password (or token) for the same login |
Both are repo secrets. The login uses `--password-stdin` so the value never Both are repo secrets. The login uses `--password-stdin` so the value never
@@ -117,7 +140,26 @@ appears in the process list or the log.
forever; without the socket it fails at `Check daemon access`. forever; without the socket it fails at `Check daemon access`.
3. `pr-checker.yml` still runs on a label whose runner has no socket. 3. `pr-checker.yml` still runs on a label whose runner has no socket.
4. Namespace `cv` has an `imagePullSecret` for the same credentials. 4. Namespace `cv` has an `imagePullSecret` for the same credentials.
5. `registry.noelsabia.dev` answers over HTTPS. 5. `git.noelsabia.dev` answers over HTTPS.
# Manual rehearsal (workflow_dispatch)
The workflow can be started from the Gitea UI (Actions → Publish image →
Run workflow) without creating a tag:
| Input | Use |
|---|---|
| `version` | required, `vMAJOR.MINOR.PATCH` |
| `push` | `false` (default) builds and smoke-tests only; `true` publishes |
| `latest` | `false` unless this is a real release |
A build-only run publishes nothing, so it creates no package version and
the immutability guard is skipped. This is the way to prove the runner,
socket and registry login before the first release - a rehearsal must never
move `latest`, which is why that input is explicit.
Gitea only offers the Run-workflow button for workflows present on the
default branch, so this trigger is available once the change is on `main`.
# Guards in the workflow # Guards in the workflow
@@ -153,7 +195,7 @@ appears in the process list or the log.
* That the smoke test passes on arm64. The same script was run against an * That the smoke test passes on arm64. The same script was run against an
x86_64 build of the merged tree and answered 2xx; the arm64 run is the x86_64 build of the merged tree and answered 2xx; the arm64 run is the
first release. first release.
* That `registry.noelsabia.dev` is reachable over HTTPS from the runner. * That `git.noelsabia.dev` is reachable over HTTPS from the runner.
A plain-HTTP endpoint fails `docker login` with `server gave HTTP A plain-HTTP endpoint fails `docker login` with `server gave HTTP
response to HTTPS client` and needs `insecure-registries` on the daemon response to HTTPS client` and needs `insecure-registries` on the daemon
plus `registries.yaml` on k3s. plus `registries.yaml` on k3s.
-51
View File
@@ -16,9 +16,6 @@ sources:
- id: workflow - id: workflow
resource: .gitea/workflows/release-please.yml resource: .gitea/workflows/release-please.yml
title: release-please workflow title: release-please workflow
- id: reconcile
resource: scripts/reconcile-release-please.mjs
title: release-please state reconciliation
--- ---
# Decision # Decision
@@ -100,49 +97,6 @@ confirmed by comparison, not inference: while `fix/release_please` still
existed, PR #23 reported `head.ref = fix/release_please`; every PR whose existed, PR #23 reported `head.ref = fix/release_please`; every PR whose
branch was gone reported `refs/pull/<n>/head`. branch was gone reported `refs/pull/<n>/head`.
# A pending label outlives the branch and blocks every later release (2026-10-31)
Flipping `default_delete_branch_after_merge` to `false` only protects
branches deleted *after* the change. PR #22's branch was already gone, so
its `head.ref` stayed `refs/pull/22/head` and its `autorelease: pending`
label stayed attached. Run 143 (task 475, 2026-10-27, the run immediately
after #22 merged) shows the full deadlock:
```
❯ Found pull request #22: 'chore: release main'
✖ Bad branch name: refs/pull/22/head
...
✔ Building candidate release pull request for path: .
❯ Found pull request #22: 'chore: release main'
⚠ There are untagged, merged release PRs outstanding - aborting
::set-output:: prs_created=false
::set-output:: releases_created=false
```
The first block fails the tagging phase. The second finds the same
still-pending PR and aborts the propose phase, so no new release PR is
even opened. Every later run (145, 148, 151, 153, 162, 164, 167) has the
same shape. The hand-created `v1.4.0` tag restores the baseline (`found:
v1.4.0`) but does not clear the label, so it does not break the
deadlock. This is the current reason the pipeline is still healthy-looking
and tagless.
The workflow now reconciles that state before the action runs
(`scripts/reconcile-release-please.mjs`):
* merged + `autorelease: pending` + a tag already at the merge commit ->
replace the label with `autorelease: tagged`;
* merged + `autorelease: pending` + head branch gone + no tag -> create
the tag from the version recorded in the manifest at the merge commit
(the exact tag release-please would have made), then swap the label;
* merged + `autorelease: pending` + head branch still present -> leave
it; release-please tags it in the same run.
The step is idempotent and runs on every push to `main` and every manual
dispatch, so a deleted branch cannot silently poison the release pipeline
again. #20 and #21 are not labelled pending, so they do not block; their
tags remain the one-time manual recovery in the table below.
# Recovering the versions that never got a tag # Recovering the versions that never got a tag
The label alone cannot recover them — #20, #21 and #22 all lost their head The label alone cannot recover them — #20, #21 and #22 all lost their head
@@ -169,11 +123,6 @@ whole history.
* That the release phase tags correctly once the head branch survives a * That the release phase tags correctly once the head branch survives a
merge. The next release cycle proves it. merge. The next release cycle proves it.
* That the reconcile step's tag-creation fallback works with a live
token. Only the tag-already-exists path was exercised, in dry-run,
against the live PR #22. The fallback is written from the same Gitea
API shapes (`POST /tags`, `PUT /issues/{index}/labels`) the rest of the
workflow uses.
* That `RELEASE_PLEASE_TOKEN_CV_SITE_NUXT` carries the `write:issue` * That `RELEASE_PLEASE_TOKEN_CV_SITE_NUXT` carries the `write:issue`
scope the same way `PR_GITEA_TOKEN` needed it; the previous failure scope the same way `PR_GITEA_TOKEN` needed it; the previous failure
was an immediate API rejection consistent with a scope problem. was an immediate API rejection consistent with a scope problem.
@@ -31,23 +31,32 @@ patched 7.1.6 was already in the tree via `postcss-nesting` and proved
API-compatible through a full build. The override is removed when API-compatible through a full build. The override is removed when
`tailwindcss` ships `>= 7.1.6` itself or the site moves to Tailwind v4. `tailwindcss` ships `>= 7.1.6` itself or the site moves to Tailwind v4.
Currently ignored (both verified against the advisory database and the npm Currently ignored (verified against the advisory database and the npm
registries on 2026-10-18 - the newest published versions are the vulnerable registries on 2026-10-31):
ones):
* `GHSA-86w9-cpqp-85rv` - node-forge <= 1.4.0, high. Path:
`nuxt > @nuxt/nitro-server > nitropack > listhen > node-forge` - listhen
generates dev certificates; build/dev-time only, not in the server bundle.
* `GHSA-vfj7-8cjw-p6xm` - braces <= 3.0.3, high. Path: * `GHSA-vfj7-8cjw-p6xm` - braces <= 3.0.3, high. Path:
`nitropack > globby > micromatch > braces` - globbing during build, no `nitropack > globby > micromatch > braces` - globbing during build, no
attacker-controlled patterns at runtime. attacker-controlled patterns at runtime.
* `GHSA-g3hv-75wg-m249` - minimatch < 11.0.1, moderate. The patch
(11.0.1) dropped the `makeRe` export that `eslint-plugin-import-x`
imports, so forcing it breaks `pnpm lint` with "does not provide an
export named 'makeRe'"; it also breaks ESLint's config loader. All
affected paths are build/lint-time (Nitro, i18n, ESLint via
vite-plugin-checker), never in the running server.
The 2026-10-31 round also upgraded `nuxt` 4.6.2 -> 4.6.3 (fixes the Nuxt
dot-segment, dev-server and appSecret advisories) and added overrides for
`node-forge: 1.4.1` (the old node-forge ignore, `GHSA-86w9-cpqp-85rv`,
is gone - a patch now exists) and `glob: 14.0.2` for
`GHSA-3g3m-2fjr-6pw4` (scoped to `>=9.0.0 <=14.0.1` so
tailwind-config-viewer keeps glob 7).
# Why # Why
A red job that can never go green trains everyone to ignore red - the same A red job that can never go green trains everyone to ignore red - the same
silent-failure outcome "nothing fails silently" exists to prevent. The silent-failure outcome "nothing fails silently" exists to prevent. The
ignore list is the opposite of silence: the audit still names what it ignore list is the opposite of silence: the audit still names what it
skipped ("2 ignored: 2 high") and the decision lives in a reviewable file. skipped ("1 ignored: 1 high") and the decision lives in a reviewable file.
# The pnpm 11 lesson # The pnpm 11 lesson
+1 -1
View File
@@ -25,7 +25,7 @@ config files — the configs say what, these documents say why.
* [Vulnerability audit policy](decisions/vulnerability-audit-policy.md) - Blocking audit; reviewed ignore-list for unfixable advisories in pnpm-workspace.yaml. * [Vulnerability audit policy](decisions/vulnerability-audit-policy.md) - Blocking audit; reviewed ignore-list for unfixable advisories in pnpm-workspace.yaml.
* [Release engineering](decisions/release-engineering.md) - release-please in manifest mode; conventional commits enforced at commit time. * [Release engineering](decisions/release-engineering.md) - release-please in manifest mode; conventional commits enforced at commit time.
* [Snyk paused and secrets policy](decisions/snyk-paused-and-secrets-policy.md) - Quota-paused job kept in place; `write:issue` scope required on every workflow token. * [Snyk paused and secrets policy](decisions/snyk-paused-and-secrets-policy.md) - Quota-paused job kept in place; `write:issue` scope required on every workflow token.
* [Publishing images to the own registry](decisions/registry-publishing.md) - A release tag builds the image and pushes it to registry.noelsabia.dev; the runner socket it needs is root-equivalent and belongs on a separate label. * [Publishing images to the own registry](decisions/registry-publishing.md) - A release tag builds the image and pushes it to git.noelsabia.dev; the runner socket it needs is root-equivalent and belongs on a separate label.
## Docker and development environment ## Docker and development environment
+19 -3
View File
@@ -1,8 +1,13 @@
# Update Log # Update Log
## 2026-10-31 (release-please still never tagged: the stale pending label) ## 2026-10-31 (registry host corrected: Gitea's built-in registry on git.noelsabia.dev)
* **Fix**: [release-please.yml](../.gitea/workflows/release-please.yml) now runs [scripts/reconcile-release-please.mjs](../scripts/reconcile-release-please.mjs) before the action. The branch-deletion fix from 2026-10-27 only protects branches deleted after the setting changed; PR #22's branch was already gone, so its `autorelease: pending` label was never cleared. The action therefore finds #22 on every run, logs `Bad branch name: refs/pull/22/head`, creates no tag, and then aborts the propose phase with `There are untagged, merged release PRs outstanding` - `prs_created=false`, `releases_created=false`, exit code 0. Evidence: run 143 (task 475, immediately after #22 merged) and every run through 167 has that exact shape; the hand-created `v1.4.0` tag makes the baseline work (`found: v1.4.0`) but does not clear the label. The reconcile script marks a pending PR tagged when its tag already exists, and recreates the tag from the manifest at the merge commit when the head branch is gone and the tag is missing. A dry run against the live API correctly matches #22 to `v1.4.0` and proposes `autorelease: tagged`. See [Release engineering](decisions/release-engineering.md). * **Correction**: `registry.noelsabia.dev` is gone from the documentation and the workflow. Gitea's built-in container registry is served on the Gitea hostname itself, so the image is **`git.noelsabia.dev/cv_website/nuxt:<tag>`** ([docs.gitea.com/usage/packages/container](https://docs.gitea.com/usage/packages/container/)). `registry.noelsabia.dev` was a separate hostname set up before that was known; the server-side setup is being reverted. No separate registry, no extra hostname, no extra certificate - Gitea already provides this by default.
* **Update**: [publish-image.yml](../.gitea/workflows/publish-image.yml) - `IMAGE`, `docker login` and the v2 `manifests/<version>` immutability check all point at `git.noelsabia.dev`. [Publishing images to the own registry](decisions/registry-publishing.md) records the corrected host and the reason.
## 2026-10-31 (registry confirmed: Gitea's built-in container registry)
* **Confirmation**: Logged in and pushed by hand - push access works. The registry is **Gitea's built-in container registry** ([docs.gitea.com/usage/packages/container](https://docs.gitea.com/usage/packages/container/)), not a separately deployed component: it is served on the Gitea host, and the `/cv_website/` path segment is the organisation namespace. This is the default - no Registry/Harbor to stand up, nothing to reinvent. Host corrected in the entry above; see [Publishing images to the own registry](decisions/registry-publishing.md).
## 2026-10-30 (PR-Agent moved into the Gitea compose stack) ## 2026-10-30 (PR-Agent moved into the Gitea compose stack)
@@ -25,6 +30,17 @@
* **Creation**: `deploy/pr-agent/` (later removed; the service now lives in the Gitea compose stack) - compose service, example environment and operator README. The real `.env` lived only at `/home/noel/self-hosted/pr-agent/.env` (mode 600) on `server0`. * **Creation**: `deploy/pr-agent/` (later removed; the service now lives in the Gitea compose stack) - compose service, example environment and operator README. The real `.env` lived only at `/home/noel/self-hosted/pr-agent/.env` (mode 600) on `server0`.
* **State**: the container is running and the webhook signature path is verified. Gitea gained `[webhook] ALLOWED_HOST_LIST = private:3000` (one restart, healthy) and the repository has a signed webhook. The OpenCode Go API key was still missing at commit time, so no model call or real review has run yet. * **State**: the container is running and the webhook signature path is verified. Gitea gained `[webhook] ALLOWED_HOST_LIST = private:3000` (one restart, healthy) and the repository has a signed webhook. The OpenCode Go API key was still missing at commit time, so no model call or real review has run yet.
## 2026-10-31 (manual publish rehearsal without a tag)
* **Creation**: [publish-image.yml](../.gitea/workflows/publish-image.yml) gained `workflow_dispatch` with `version`, `push` and `latest` inputs. Default is **build + smoke test only** (`push=false`): no tag, no package version, immutability guard skipped, `latest` never moved unless explicitly requested. Use it to verify the `publish` runner (socket + `automount`) before the first release. Manual runs do not replace the tag path - a published image still always maps to a release tag.
## 2026-10-31 (audit green again: nuxt 4.6.3 and dependency overrides)
* **Fix**: `pnpm audit --prod --audit-level moderate` failed on every branch (#30, #31, #33 and this PR) - new advisories plus a Nuxt patch release. `nuxt` 4.6.2 -> **4.6.3** clears GHSA-9v7c-q64q-vv33 (dot-segment middleware bypass), GHSA-3xf4-9g3c-4h4w and GHSA-x287-wcfc-q46c (dev-server file read/runtime config).
* **Fix**: [pnpm-workspace.yaml](../pnpm-workspace.yaml) - overrides for `node-forge: 1.4.1` (the old GHSA-86w9-cpqp-85rv ignore is removed - a patch exists now) and `glob@>=9.0.0 <=14.0.1: 14.0.2` (GHSA-3g3m-2fjr-6pw4; glob 7 is kept for tailwind-config-viewer).
* **Decision**: minimatch GHSA-g3hv-75wg-m249 stays a reviewed ignore. Its patch (11.0.1) dropped `makeRe`, which `eslint-plugin-import-x` imports - forcing it makes `pnpm lint` fail with "does not provide an export named 'makeRe'" (measured). All affected paths are build/lint-time. See [Vulnerability audit policy](decisions/vulnerability-audit-policy.md).
* **Verified locally**: `pnpm lint`, `pnpm typecheck`, `pnpm build` and the exact audit command all pass on the merged tree.
## 2026-10-27 (release-please still never tagged: the deleted head branch) ## 2026-10-27 (release-please still never tagged: the deleted head branch)
* **Fix**: [release-please-config.json](../release-please-config.json) gained `"changelog-host": "https://git.noelsabia.dev"` - the changelog compare links were generated against `github.com/CV_Website/CV_Site_Nuxt`, a host this repository does not live on. Root cause of the missing tags: **Gitea rewrites `head.ref` to `refs/pull/<n>/head` when the merged PR's branch is deleted**, and release-please parses that field as the release branch, so `BranchName.parse` fails and the release is dropped - silently, exit code 0. Evidence: run 143 (task 475) logs `✖ Bad branch name: refs/pull/22/head` right after `Found pull request #22`, then `Expected 1 releases, only found 0`; #22 did carry `autorelease: pending`. The repository deleted every merged branch (`default_delete_branch_after_merge: true`); it is `false` now. Four versions (1.1.0-1.4.0) were consumed by the manifest with no tag ever created, so the release baseline has to be restored by hand. See [Release engineering](decisions/release-engineering.md). * **Fix**: [release-please-config.json](../release-please-config.json) gained `"changelog-host": "https://git.noelsabia.dev"` - the changelog compare links were generated against `github.com/CV_Website/CV_Site_Nuxt`, a host this repository does not live on. Root cause of the missing tags: **Gitea rewrites `head.ref` to `refs/pull/<n>/head` when the merged PR's branch is deleted**, and release-please parses that field as the release branch, so `BranchName.parse` fails and the release is dropped - silently, exit code 0. Evidence: run 143 (task 475) logs `✖ Bad branch name: refs/pull/22/head` right after `Found pull request #22`, then `Expected 1 releases, only found 0`; #22 did carry `autorelease: pending`. The repository deleted every merged branch (`default_delete_branch_after_merge: true`); it is `false` now. Four versions (1.1.0-1.4.0) were consumed by the manifest with no tag ever created, so the release baseline has to be restored by hand. See [Release engineering](decisions/release-engineering.md).
@@ -35,7 +51,7 @@
## 2026-10-24 (release publishes an image) ## 2026-10-24 (release publishes an image)
* **Creation**: [publish-image.yml](../.gitea/workflows/publish-image.yml) - a `vX.Y.Z` tag push builds `Dockerfile` on the arm64 runner and pushes `registry.noelsabia.dev/cv_website/nuxt` as the version and `sha-<12>`, plus `latest` when that tag is the newest release. Main pushes deliberately do not build: the registry holds releases, not commits. The job uses the runner's own Docker daemon (client only in the `node:22-bookworm` container), so the act_runner needs `container.docker_host: automount`; the first step fails with that cause if it is missing. That socket is root-equivalent, so it may only sit on a label PR jobs cannot use - recorded under the trust boundary in [Publishing images to the own registry](decisions/registry-publishing.md). Repo secrets: `REGISTRY_USERNAME`, `REGISTRY_PASSWORD`. * **Creation**: [publish-image.yml](../.gitea/workflows/publish-image.yml) - a `vX.Y.Z` tag push builds `Dockerfile` on the arm64 runner and pushes `git.noelsabia.dev/cv_website/nuxt` as the version and `sha-<12>`, plus `latest` when that tag is the newest release. Main pushes deliberately do not build: the registry holds releases, not commits. The job uses the runner's own Docker daemon (client only in the `node:22-bookworm` container), so the act_runner needs `container.docker_host: automount`; the first step fails with that cause if it is missing. That socket is root-equivalent, so it may only sit on a label PR jobs cannot use - recorded under the trust boundary in [Publishing images to the own registry](decisions/registry-publishing.md). Repo secrets: `REGISTRY_USERNAME`, `REGISTRY_PASSWORD`.
* **Review follow-up** (PR #19, 1 BLOCKER + 4 WARN + 2 NIT): applied the strict `vMAJOR.MINOR.PATCH` check, the newest-release rule for `latest`, a smoke test that starts the image and requires 2xx on `/`, and `timeout-minutes: 20`. Rejected with evidence: the `.dockerignore` leak (`.env*`, `*.pem`, `.git` are excluded) and the Docker-client/daemon API mismatch (20.10.24 client against a 29.9.2 daemon built successfully over the socket). * **Review follow-up** (PR #19, 1 BLOCKER + 4 WARN + 2 NIT): applied the strict `vMAJOR.MINOR.PATCH` check, the newest-release rule for `latest`, a smoke test that starts the image and requires 2xx on `/`, and `timeout-minutes: 20`. Rejected with evidence: the `.dockerignore` leak (`.env*`, `*.pem`, `.git` are excluded) and the Docker-client/daemon API mismatch (20.10.24 client against a 29.9.2 daemon built successfully over the socket).
* **Second review follow-up** (PR #19): the job now runs on the dedicated `publish` label instead of `ubuntu-latest`, so the host socket it needs can never be shared with PR jobs - the earlier version required a runner configuration its own trust boundary forbade. Added the immutability guard (registry v2 `manifests/<version>`: `200` aborts, `404` continues) after measuring that `docker manifest inspect` fails on OCI indexes with the pinned 20.10 client; the smoke test now also requires a rendered body (10 kB floor) rather than a bare 2xx. `.github/actionlint.yaml` declares the custom label, and the hook passes it with `-config-file` because this repo keeps workflows in `.gitea/`. * **Second review follow-up** (PR #19): the job now runs on the dedicated `publish` label instead of `ubuntu-latest`, so the host socket it needs can never be shared with PR jobs - the earlier version required a runner configuration its own trust boundary forbade. Added the immutability guard (registry v2 `manifests/<version>`: `200` aborts, `404` continues) after measuring that `docker manifest inspect` fails on OCI indexes with the pinned 20.10 client; the smoke test now also requires a rendered body (10 kB floor) rather than a bare 2xx. `.github/actionlint.yaml` declares the custom label, and the hook passes it with `-config-file` because this repo keeps workflows in `.gitea/`.
+1 -1
View File
@@ -24,7 +24,7 @@
"@nuxtjs/i18n": "10.6.0", "@nuxtjs/i18n": "10.6.0",
"@nuxtjs/seo": "6.0.1", "@nuxtjs/seo": "6.0.1",
"@nuxtjs/tailwindcss": "6.14.0", "@nuxtjs/tailwindcss": "6.14.0",
"nuxt": "^4.6.2", "nuxt": "^4.6.3",
"vue": "^3.5.43", "vue": "^3.5.43",
"vue-router": "^5.4.0" "vue-router": "^5.4.0"
}, },
+485 -484
View File
File diff suppressed because it is too large. Load diff
+23 -7
View File
@@ -2,15 +2,21 @@ allowBuilds:
esbuild: true esbuild: true
unrs-resolver: true unrs-resolver: true
auditConfig: auditConfig:
# Reviewed ignores for advisories with NO patched release (verified against # Reviewed ignores for advisories with NO patched release, or whose patch
# the advisory database and npm registries on 2026-10-18: node-forge 1.4.0 # is incompatible with a consumer in this tree. braces is unfixable
# and braces 3.0.3 are the newest published versions). Both packages are # (3.0.3 is still newest); minimatch's patch (11.0.1) breaks ESLint -
# build-time-only paths under nitropack (listhen dev-cert generation, # both are build-time-only paths. node-forge was removed from this list
# globby file globbing) - not in the running server's bundle. Remove an # on 2026-10-31 when 1.4.1 shipped and is now forced through `overrides`.
# entry when a patched version ships. # Remove an entry when a compatible patched version ships.
ignoreGhsas: ignoreGhsas:
- GHSA-86w9-cpqp-85rv
- GHSA-vfj7-8cjw-p6xm - GHSA-vfj7-8cjw-p6xm
# GHSA-g3hv-75wg-m249 (minimatch DoS): the patched 11.0.1 dropped the
# `makeRe` export that eslint-plugin-import-x imports, so `pnpm lint`
# fails with "does not provide an export named 'makeRe'"; forcing it
# also breaks ESLint's config loader. Affected paths are build/lint
# only (Nitro, i18n, ESLint via vite-plugin-checker), never in the
# server bundle.
- GHSA-g3hv-75wg-m249
overrides: overrides:
# Fixable advisories get the patched version forced here, not an ignore # Fixable advisories get the patched version forced here, not an ignore
# (audit policy: upgrade when a patch exists). # (audit policy: upgrade when a patch exists).
@@ -27,6 +33,16 @@ overrides:
# smallest version that clears both advisories. Remove this when Nuxt ships # smallest version that clears both advisories. Remove this when Nuxt ships
# a vite-builder that resolves >= 1.6.11 itself. # a vite-builder that resolves >= 1.6.11 itself.
seroval: 1.6.11 seroval: 1.6.11
# GHSA-g3hv-75wg-m249 (moderate, 2026-10-31): minimatch < 11.0.1 has a
# globparts amplification DoS. Deliberately NOT overridden - see the
# auditConfig ignore note above.
# GHSA-3g3m-2fjr-6pw4 (moderate, 2026-10-31): glob 9.0.0-14.0.1 bypasses
# AbortSignal cancellation. Patched in 14.0.2; the range keeps glob 7 for
# tailwind-config-viewer.
"glob@>=9.0.0 <=14.0.1": 14.0.2
# node-forge 1.4.1 shipped (2026-10-31) and clears every node-forge
# advisory that was previously ignored - no ignore needed anymore.
node-forge: 1.4.1
minimumReleaseAgeExclude: minimumReleaseAgeExclude:
- '@rollup/rollup-darwin-x64@4.64.8' - '@rollup/rollup-darwin-x64@4.64.8'
- '@rollup/rollup-freebsd-arm64@4.64.8' - '@rollup/rollup-freebsd-arm64@4.64.8'
-176
View File
@@ -1,176 +0,0 @@
// Repairs the release-please state that its Gitea fork cannot recover from.
//
// Why this exists (evidence in OKF_Nuxt/decisions/release-engineering.md):
//
// Gitea rewrites a merged PR's `head.ref` to `refs/pull/<n>/head` when the
// head branch is deleted. The fork parses that field as the release branch,
// logs `Bad branch name`, creates no tag - and still exits successfully.
// The merged PR keeps `autorelease: pending`, so every later run aborts with
// `There are untagged, merged release PRs outstanding` and opens no new
// release PR. That is a permanent deadlock, not a transient failure.
//
// This script runs before the action and reconciles the state:
//
// * a merged pending PR whose merge commit already has a tag -> swap
// `autorelease: pending` for `autorelease: tagged` (the release exists,
// only the label is stale);
// * a merged pending PR whose head branch is gone and has no tag -> create
// the tag from the version recorded in the manifest at that merge commit.
// This is exactly the tag release-please would have made if the branch had
// survived; without it the PR blocks every future release;
// * a merged pending PR whose head branch still exists -> leave it alone,
// release-please tags it in the same run.
//
// Run locally against the public API with:
// DRY_RUN=1 node scripts/reconcile-release-please.mjs
// Reads work unauthenticated for a public repository; writes are skipped.
const API_URL = process.env.GITHUB_API_URL
const REPOSITORY = process.env.GITHUB_REPOSITORY
const TOKEN = process.env.GITEA_TOKEN
const DRY_RUN = process.env.DRY_RUN === '1' || process.argv.includes('--dry-run')
const PENDING = 'autorelease: pending'
const TAGGED = 'autorelease: tagged'
if (!API_URL || !REPOSITORY) {
console.error('::error::GITHUB_API_URL and GITHUB_REPOSITORY must be set')
process.exit(1)
}
if (!TOKEN && !DRY_RUN) {
console.error('::error::GITEA_TOKEN is required (or set DRY_RUN=1)')
process.exit(1)
}
const repoUrl = `${API_URL}/repos/${REPOSITORY}`
const api = async (path, init = {}) => {
const response = await fetch(`${repoUrl}${path}`, {
...init,
headers: {
Accept: 'application/json',
...(TOKEN ? { Authorization: `token ${TOKEN}` } : {}),
...(init.headers ?? {}),
},
})
const body = await response.text()
if (!response.ok) {
throw new Error(`${init.method ?? 'GET'} ${path} -> HTTP ${response.status}: ${body.slice(0, 300)}`)
}
return body ? JSON.parse(body) : null
}
// Gitea caps page size at 50. Follow pages until a short page ends the list.
const listAll = async (path) => {
const items = []
for (let page = 1; ; page++) {
const separator = path.includes('?') ? '&' : '?'
const batch = await api(`${path}${separator}limit=50&page=${page}`)
items.push(...batch)
if (batch.length < 50) return items
}
}
const replaceLabels = async (number, labels) => {
if (DRY_RUN) {
console.log(`[dry-run] #${number}: labels -> ${labels.join(', ')}`)
return
}
await api(`/issues/${number}/labels`, {
method: 'PUT',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ labels }),
})
}
const createTag = async (name, sha) => {
if (DRY_RUN) {
console.log(`[dry-run] create tag ${name} at ${sha}`)
return
}
await api('/tags', {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ tag_name: name, target: sha, message: `Release ${name}` }),
})
}
const versionAt = async (sha) => {
const file = await api(`/contents/.release-please-manifest.json?ref=${sha}`)
if (!file?.content) throw new Error(`no manifest content at ${sha}`)
const manifest = JSON.parse(Buffer.from(file.content, 'base64').toString('utf8'))
// Single-package repository: the root path is ".". Keep a fallback so a
// future second package cannot silently produce `vundefined`.
return manifest['.'] ?? Object.values(manifest)[0]
}
const run = async () => {
const tags = await listAll('/tags')
const tagSha = new Map(tags.map(tag => [tag.commit?.sha, tag.name]))
const tagsByName = new Map(tags.map(tag => [tag.name, tag.commit?.sha]))
const pulls = await listAll('/pulls?state=closed')
const pending = pulls
.filter(pull => pull.merged_at)
.filter(pull => (pull.labels ?? []).some(label => label.name === PENDING))
.sort((a, b) => a.number - b.number)
if (pending.length === 0) {
console.log('No merged release PR is pending - nothing to reconcile.')
return
}
const failures = []
for (const pull of pending) {
const mergeSha = pull.merge_commit_sha
const headRef = pull.head?.ref ?? ''
const branchGone = headRef.startsWith('refs/pull/') || headRef === ''
const existingTag = tagSha.get(mergeSha)
const labels = (pull.labels ?? []).map(label => label.name)
if (existingTag) {
console.log(`#${pull.number}: ${existingTag} already points at merge commit ${mergeSha} - marking as tagged`)
const next = labels.filter(name => name !== PENDING)
if (!next.includes(TAGGED)) next.push(TAGGED)
await replaceLabels(pull.number, next)
continue
}
if (!branchGone) {
console.log(`#${pull.number}: head branch ${headRef} still exists - leaving it for release-please to tag`)
continue
}
// The branch is gone and no tag exists, so release-please will never get
// past `Bad branch name` for this PR. Recreate the tag it should have
// made, using the version the merged release PR wrote into the manifest.
try {
const version = await versionAt(mergeSha)
if (!version) throw new Error('manifest has no version for the root package')
const name = `v${version}`
if (tagsByName.has(name)) {
throw new Error(`${name} already exists at ${tagsByName.get(name)}, not at merge commit ${mergeSha}; refusing to move a release tag`)
}
console.log(`#${pull.number}: head branch is gone (${headRef}) - creating ${name} at ${mergeSha}`)
await createTag(name, mergeSha)
const next = labels.filter(label => label !== PENDING)
if (!next.includes(TAGGED)) next.push(TAGGED)
await replaceLabels(pull.number, next)
}
catch (error) {
failures.push(`#${pull.number}: ${error.message}`)
}
}
if (failures.length > 0) {
for (const failure of failures) console.error(`::error::${failure}`)
console.error('::error::release-please state is unrecoverable automatically; repair the PR/tag by hand before the next release')
process.exit(1)
}
}
run().catch((error) => {
console.error(`::error::${error.message}`)
process.exit(1)
})