Compare commits
8
Commits
fdce59d77d
..
v1.5.1
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
d9ae9da14c | ||
|
|
a2ed208d3e | ||
|
|
1fb47dc4e1 | ||
|
|
26abef948d | ||
|
|
0268a11e14 | ||
|
|
42b07e9ab9 | ||
|
|
c8250c9ca3 | ||
|
|
93fcd4127c |
No files matched your search
@@ -1,3 +1,3 @@
|
|||||||
{
|
{
|
||||||
".": "1.5.0"
|
".": "1.5.1"
|
||||||
}
|
}
|
||||||
@@ -1,5 +1,14 @@
|
|||||||
# Changelog
|
# Changelog
|
||||||
|
|
||||||
|
## [1.5.1](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/compare/v1.5.0...v1.5.1) (2026-10-31)
|
||||||
|
|
||||||
|
|
||||||
|
### Bug Fixes
|
||||||
|
|
||||||
|
* **ci:** remove the release-please component mismatch ([e23f8d2](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/e23f8d26185443093f6aff949a22a9e785662c2f))
|
||||||
|
* **ci:** use an empty package-name so release-please tags v1.5.0 ([c8250c9](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/c8250c9ca3f9a7d820d891733f225692f18fa3b3))
|
||||||
|
* updated pnpm lockfile ([42b07e9](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/42b07e9ab938a4eadbcf0b3785fbb86e87f605a1))
|
||||||
|
|
||||||
## [1.5.0](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/compare/v1.4.0...v1.5.0) (2026-10-31)
|
## [1.5.0](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/compare/v1.4.0...v1.5.0) (2026-10-31)
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
@@ -175,10 +175,38 @@ component is empty. `include-component-in-tag: false` makes
|
|||||||
`package-name` - here `CV_Site_Frontend`. The two never match, so the
|
`package-name` - here `CV_Site_Frontend`. The two never match, so the
|
||||||
release is dropped before the tag is created.
|
release is dropped before the tag is created.
|
||||||
|
|
||||||
The fix is to remove `package-name` from the package config. The strategy
|
Removing `package-name` is not enough. Run 183 (after #36 merged) shows
|
||||||
component is then empty as well, the comparison matches, and the tag is
|
the node strategy falling back to the `package.json` name:
|
||||||
created. Nothing else changes: the changelog headings are already
|
|
||||||
version-only (`## [1.5.0]`), not component-prefixed.
|
```
|
||||||
|
⚠ PR component: undefined does not match configured component: nuxt-app
|
||||||
|
```
|
||||||
|
|
||||||
|
`BaseStrategy.getDefaultPackageName()` is overridden by the node strategy
|
||||||
|
to read `package.json` `name`, so an absent `package-name` resolves to
|
||||||
|
`nuxt-app`.
|
||||||
|
|
||||||
|
The working setting is `"package-name": ""` (an empty string, not an
|
||||||
|
omitted key). An empty string is not nullish, so `getBranchComponent()`
|
||||||
|
returns empty and matches the legacy default branch
|
||||||
|
`release-please--branches--main`. This was verified by running the
|
||||||
|
action's bundled release-please 16.15.6 locally against the live Gitea
|
||||||
|
API, with writes intercepted: the release phase produced
|
||||||
|
|
||||||
|
```
|
||||||
|
POST /repos/CV_Website/CV_Site_Nuxt/releases
|
||||||
|
{"name":"v1.5.0","tag_name":"v1.5.0",...,"target_commitish":"a80c9ebf..."}
|
||||||
|
```
|
||||||
|
|
||||||
|
then swapped #35 to `autorelease: tagged`. That is release-please creating
|
||||||
|
the tag itself, not a manual `git tag`.
|
||||||
|
|
||||||
|
The action's official default mode (`release-type: node`, no manifest
|
||||||
|
config) was tested the same way and still fails for #35 with
|
||||||
|
`configured component: nuxt-app`. It cannot retroactively accept the
|
||||||
|
already-merged legacy PR; it would only help a release PR created after
|
||||||
|
the switch. The empty `package-name` is therefore the compatibility
|
||||||
|
setting that lets release-please finish v1.5.0.
|
||||||
|
|
||||||
# Recovering the versions that never got a tag
|
# Recovering the versions that never got a tag
|
||||||
|
|
||||||
@@ -204,9 +232,10 @@ whole history.
|
|||||||
|
|
||||||
# Not verified
|
# Not verified
|
||||||
|
|
||||||
* That the release phase now tags #35 after the component fix. The previous
|
* That the live run tags #35. The exact release-phase request was verified
|
||||||
run (181) kept the branch but dropped the release on the component
|
locally with writes intercepted (`POST /releases` with `tag_name:
|
||||||
mismatch, so the next run is the proof.
|
v1.5.0` at `a80c9eb`); the run after merging the empty `package-name` is
|
||||||
|
the final proof.
|
||||||
* That the reconcile step's tag-creation fallback works with a live
|
* That the reconcile step's tag-creation fallback works with a live
|
||||||
token. Only the tag-already-exists path was exercised, in dry-run,
|
token. Only the tag-already-exists path was exercised, in dry-run,
|
||||||
against the live PR #22. The fallback is written from the same Gitea
|
against the live PR #22. The fallback is written from the same Gitea
|
||||||
|
|||||||
@@ -1,5 +1,12 @@
|
|||||||
# Update Log
|
# Update Log
|
||||||
|
|
||||||
|
## 2026-10-31 (release-please tag: empty package-name is the verified fix)
|
||||||
|
|
||||||
|
* **Correction**: removing `package-name` in #36 was not enough. Run 183 shows the node strategy falling back to `package.json` `name`, so the release phase still failed with `PR component: undefined does not match configured component: nuxt-app`.
|
||||||
|
* **Fix**: [release-please-config.json](../release-please-config.json) sets `"package-name": ""`. An empty string is not nullish, so `getBranchComponent()` stays empty and matches the legacy `release-please--branches--main` branch. This is the only setting that lets release-please accept the already-merged #35.
|
||||||
|
* **Evidence**: the action's bundled release-please 16.15.6 was run locally against the live Gitea API with writes intercepted. It produced `POST /repos/CV_Website/CV_Site_Nuxt/releases` with `{"name":"v1.5.0","tag_name":"v1.5.0","target_commitish":"a80c9ebf..."}`, then swapped #35 to `autorelease: tagged`. The official default `release-type: node` mode was tested the same way and still fails for #35 with `configured component: nuxt-app`, so it cannot retroactively tag the legacy PR.
|
||||||
|
* **Expected result**: the run after this merge creates `v1.5.0` at `a80c9eb` through the release-please action itself. No manual `git tag`.
|
||||||
|
|
||||||
## 2026-10-31 (release-please component mismatch: no v1.5.0 tag)
|
## 2026-10-31 (release-please component mismatch: no v1.5.0 tag)
|
||||||
|
|
||||||
* **Fix**: [release-please-config.json](../release-please-config.json) - removed `package-name: CV_Site_Frontend`. With `include-component-in-tag: false` the strategy component and the release PR body component are empty, but `getBranchComponent()` still returned `package-name`; the release phase logged `PR component: undefined does not match configured component: CV_Site_Frontend` and returned before creating the tag. The component now matches, so the next run should tag #35.
|
* **Fix**: [release-please-config.json](../release-please-config.json) - removed `package-name: CV_Site_Frontend`. With `include-component-in-tag: false` the strategy component and the release PR body component are empty, but `getBranchComponent()` still returned `package-name`; the release phase logged `PR component: undefined does not match configured component: CV_Site_Frontend` and returned before creating the tag. The component now matches, so the next run should tag #35.
|
||||||
|
|||||||
+1
-1
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "nuxt-app",
|
"name": "nuxt-app",
|
||||||
"version": "1.5.0",
|
"version": "1.5.1",
|
||||||
"type": "module",
|
"type": "module",
|
||||||
"private": true,
|
"private": true,
|
||||||
"engines": {
|
"engines": {
|
||||||
|
|||||||
Generated
+970
-1089
File diff suppressed because it is too large.
Load diff
@@ -56,3 +56,8 @@ minimumReleaseAgeExclude:
|
|||||||
- '@rollup/rollup-openharmony-arm64@4.64.8'
|
- '@rollup/rollup-openharmony-arm64@4.64.8'
|
||||||
- '@rollup/rollup-win32-ia32-msvc@4.64.8'
|
- '@rollup/rollup-win32-ia32-msvc@4.64.8'
|
||||||
- '@nuxt/icon@2.6.0'
|
- '@nuxt/icon@2.6.0'
|
||||||
|
permissions:
|
||||||
|
'@nuxtjs/seo':
|
||||||
|
skills:
|
||||||
|
dirs:
|
||||||
|
- .agents/skills
|
||||||
@@ -6,6 +6,7 @@
|
|||||||
"changelog-host": "https://git.noelsabia.dev",
|
"changelog-host": "https://git.noelsabia.dev",
|
||||||
"packages": {
|
"packages": {
|
||||||
".": {
|
".": {
|
||||||
|
"package-name": "",
|
||||||
"changelog-path": "CHANGELOG.md",
|
"changelog-path": "CHANGELOG.md",
|
||||||
"extra-files": [],
|
"extra-files": [],
|
||||||
"versioning": "default"
|
"versioning": "default"
|
||||||
|
|||||||
Reference in new issue
Block a user