Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
1c516ea115 |
No files matched your search
@@ -2,10 +2,6 @@ on:
|
|||||||
push:
|
push:
|
||||||
branches:
|
branches:
|
||||||
- main
|
- main
|
||||||
# Manual trigger so a missed release can be replayed without waiting for
|
|
||||||
# the next push. The job is idempotent: it tags only merged release PRs
|
|
||||||
# that carry the pending label.
|
|
||||||
workflow_dispatch:
|
|
||||||
|
|
||||||
permissions:
|
permissions:
|
||||||
contents: write
|
contents: write
|
||||||
@@ -17,38 +13,6 @@ jobs:
|
|||||||
release-please:
|
release-please:
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
steps:
|
steps:
|
||||||
# release-please marks its release PR with `autorelease: pending` and
|
|
||||||
# later finds the merged PR by that label. Gitea's label API resolves
|
|
||||||
# names and *silently ignores unknown ones* (GetLabelIDsInRepoByNames
|
|
||||||
# filters by name in SQL), so on a repository without these labels the
|
|
||||||
# PR is created unlabeled, the release phase finds no merged release PR
|
|
||||||
# and creates no tag - while the run still reports success. That is the
|
|
||||||
# bug this step prevents: make the labels exist first, every run.
|
|
||||||
- name: Ensure release-please labels exist
|
|
||||||
env:
|
|
||||||
GITEA_TOKEN: ${{ secrets.PR_GITEA_TOKEN }}
|
|
||||||
run: |
|
|
||||||
set -eu
|
|
||||||
existing="$(curl -sS -H "Authorization: token ${GITEA_TOKEN}" \
|
|
||||||
"${GITHUB_API_URL}/repos/${GITHUB_REPOSITORY}/labels?limit=50")"
|
|
||||||
for name in "autorelease: pending" "autorelease: tagged"; do
|
|
||||||
if printf '%s' "$existing" | grep -qF "\"name\":\"${name}\""; then
|
|
||||||
echo "label exists: ${name}"
|
|
||||||
continue
|
|
||||||
fi
|
|
||||||
code="$(curl -sS -o /tmp/label.json -w '%{http_code}' -X POST \
|
|
||||||
-H "Authorization: token ${GITEA_TOKEN}" \
|
|
||||||
-H 'Content-Type: application/json' \
|
|
||||||
-d "{\"name\":\"${name}\",\"color\":\"ededed\",\"description\":\"release-please state\"}" \
|
|
||||||
"${GITHUB_API_URL}/repos/${GITHUB_REPOSITORY}/labels")"
|
|
||||||
if [ "$code" != "201" ]; then
|
|
||||||
echo "::error::could not create label '${name}' (HTTP ${code})"
|
|
||||||
cat /tmp/label.json
|
|
||||||
exit 1
|
|
||||||
fi
|
|
||||||
echo "created label: ${name}"
|
|
||||||
done
|
|
||||||
|
|
||||||
- uses: joaquinjsb/gitea-release-please-action@v4
|
- uses: joaquinjsb/gitea-release-please-action@v4
|
||||||
with:
|
with:
|
||||||
# One well-scoped token for all workflow API work (see
|
# One well-scoped token for all workflow API work (see
|
||||||
|
|||||||
@@ -1,47 +0,0 @@
|
|||||||
name: Renovate
|
|
||||||
|
|
||||||
# Renovate is not hosted for Gitea, so this repository runs it itself.
|
|
||||||
# The bot opens dependency PRs through the API; the PR pipeline checks them
|
|
||||||
# (a branch protection rule should require those checks before automerge).
|
|
||||||
#
|
|
||||||
# Manual setup: create a bot account with its full name and email set, give
|
|
||||||
# it write access to this repository, and store a token with
|
|
||||||
# repository read/write, issue read/write, user read and organization read
|
|
||||||
# as the RENOVATE_TOKEN Actions secret. Release notes also need a github.com
|
|
||||||
# token (any account, read-only, no scopes for public repositories) as the
|
|
||||||
# RENOVATE_GITHUB_COM_TOKEN secret.
|
|
||||||
on:
|
|
||||||
schedule:
|
|
||||||
# Daily at 04:00 UTC. Gitea only schedules workflows that exist on the
|
|
||||||
# default branch.
|
|
||||||
- cron: "0 4 * * *"
|
|
||||||
workflow_dispatch:
|
|
||||||
|
|
||||||
concurrency:
|
|
||||||
group: renovate
|
|
||||||
cancel-in-progress: false
|
|
||||||
|
|
||||||
jobs:
|
|
||||||
renovate:
|
|
||||||
name: Run Renovate
|
|
||||||
runs-on: ubuntu-latest
|
|
||||||
timeout-minutes: 30
|
|
||||||
# Pinned and multi-arch (the runner is arm64). The image installs the
|
|
||||||
# Node-based toolchain it needs on demand.
|
|
||||||
container: renovate/renovate:44.198.2
|
|
||||||
steps:
|
|
||||||
- name: Run Renovate
|
|
||||||
env:
|
|
||||||
RENOVATE_PLATFORM: gitea
|
|
||||||
# API root, not the web root. Renovate reads renovate.json from the
|
|
||||||
# default branch through this endpoint.
|
|
||||||
RENOVATE_ENDPOINT: https://git.noelsabia.dev/api/v1
|
|
||||||
RENOVATE_TOKEN: ${{ secrets.RENOVATE_TOKEN }}
|
|
||||||
# github.com is only used to fetch release notes and other public
|
|
||||||
# metadata. Anonymous requests are rate-limited, which is why the
|
|
||||||
# PR body warned that release notes were skipped.
|
|
||||||
RENOVATE_GITHUB_COM_TOKEN: ${{ secrets.RENOVATE_GITHUB_COM_TOKEN }}
|
|
||||||
# This workflow lives in the repository it updates, so scope the bot
|
|
||||||
# to it instead of every repository its account can see.
|
|
||||||
RENOVATE_REPOSITORIES: CV_Website/CV_Site_Nuxt
|
|
||||||
run: renovate
|
|
||||||
+1
-2
@@ -1,6 +1,6 @@
|
|||||||
# Changelog
|
# Changelog
|
||||||
|
|
||||||
## [1.4.0](https://github.com/CV_Website/CV_Site_Nuxt/compare/v1.3.0...v1.4.0) (2026-10-27)
|
## [1.4.0](https://github.com/CV_Website/CV_Site_Nuxt/compare/v1.3.0...v1.4.0) (2026-10-24)
|
||||||
|
|
||||||
|
|
||||||
### Features
|
### Features
|
||||||
@@ -25,7 +25,6 @@
|
|||||||
* **ci:** address AI review findings (credentials, supply chain) ([85f488a](https://github.com/CV_Website/CV_Site_Nuxt/commit/85f488a94dd8796ea5f11c292edddd32e21398cd))
|
* **ci:** address AI review findings (credentials, supply chain) ([85f488a](https://github.com/CV_Website/CV_Site_Nuxt/commit/85f488a94dd8796ea5f11c292edddd32e21398cd))
|
||||||
* **ci:** apply review findings round two ([a3e6aef](https://github.com/CV_Website/CV_Site_Nuxt/commit/a3e6aef901086f5f8b416e2aa7d29596517f9550))
|
* **ci:** apply review findings round two ([a3e6aef](https://github.com/CV_Website/CV_Site_Nuxt/commit/a3e6aef901086f5f8b416e2aa7d29596517f9550))
|
||||||
* **ci:** close the fail-open gate, enforce read-only sandbox ([3e68e63](https://github.com/CV_Website/CV_Site_Nuxt/commit/3e68e630dff92a7abd791b7a8808eb682f37a060))
|
* **ci:** close the fail-open gate, enforce read-only sandbox ([3e68e63](https://github.com/CV_Website/CV_Site_Nuxt/commit/3e68e630dff92a7abd791b7a8808eb682f37a060))
|
||||||
* **ci:** create the release-please labels before the action runs ([0a3c90c](https://github.com/CV_Website/CV_Site_Nuxt/commit/0a3c90cc7489b7657a9a142fb2b6248ae0738a63))
|
|
||||||
* **ci:** deny write tools, never swallow review errors ([f8d1287](https://github.com/CV_Website/CV_Site_Nuxt/commit/f8d128705faa9493202cf724ae0a451d4dc6d1e5))
|
* **ci:** deny write tools, never swallow review errors ([f8d1287](https://github.com/CV_Website/CV_Site_Nuxt/commit/f8d128705faa9493202cf724ae0a451d4dc6d1e5))
|
||||||
* **ci:** gate the ai review to pull_request events, restore route announcer ([9be6298](https://github.com/CV_Website/CV_Site_Nuxt/commit/9be62982a4a2494351006463ae71bd99f4e49fe4))
|
* **ci:** gate the ai review to pull_request events, restore route announcer ([9be6298](https://github.com/CV_Website/CV_Site_Nuxt/commit/9be62982a4a2494351006463ae71bd99f4e49fe4))
|
||||||
* **ci:** give release-please git credentials for the release-branch push ([a27bbbb](https://github.com/CV_Website/CV_Site_Nuxt/commit/a27bbbb2abf0fa8ddedd20c05bba2128e88faa3a))
|
* **ci:** give release-please git credentials for the release-branch push ([a27bbbb](https://github.com/CV_Website/CV_Site_Nuxt/commit/a27bbbb2abf0fa8ddedd20c05bba2128e88faa3a))
|
||||||
|
|||||||
+2
-2
@@ -16,7 +16,7 @@
|
|||||||
# runner's arm64 and this workstation's x86_64.
|
# runner's arm64 and this workstation's x86_64.
|
||||||
# syntax: no BuildKit-only features used, so the default frontend suffices.
|
# syntax: no BuildKit-only features used, so the default frontend suffices.
|
||||||
|
|
||||||
FROM node:26-slim@sha256:18f03e4b532a63baf09809fe8349c2171807f1818cb6c5230fb12aecd5beda65 AS build
|
FROM node:26-slim@sha256:d62f13676d530f7edf97782729df69713c8ccfe6631e7f62f9ccab65968719a8 AS build
|
||||||
|
|
||||||
# pnpm pinned to the same version as CI (pr-checker.yml pins major 11) and
|
# pnpm pinned to the same version as CI (pr-checker.yml pins major 11) and
|
||||||
# the local toolchain (11.26.0). Installed via npm from the node image - no
|
# the local toolchain (11.26.0). Installed via npm from the node image - no
|
||||||
@@ -38,7 +38,7 @@ COPY . .
|
|||||||
RUN pnpm build
|
RUN pnpm build
|
||||||
|
|
||||||
|
|
||||||
FROM node:26-slim@sha256:18f03e4b532a63baf09809fe8349c2171807f1818cb6c5230fb12aecd5beda65
|
FROM node:26-slim@sha256:d62f13676d530f7edf97782729df69713c8ccfe6631e7f62f9ccab65968719a8
|
||||||
|
|
||||||
# pnpm is NOT installed in the runtime image: nothing here runs pnpm.
|
# pnpm is NOT installed in the runtime image: nothing here runs pnpm.
|
||||||
ENV NODE_ENV=production \
|
ENV NODE_ENV=production \
|
||||||
|
|||||||
+1
-1
@@ -1,4 +1,4 @@
|
|||||||
FROM node:26-slim@sha256:18f03e4b532a63baf09809fe8349c2171807f1818cb6c5230fb12aecd5beda65
|
FROM node:26-slim@sha256:d62f13676d530f7edf97782729df69713c8ccfe6631e7f62f9ccab65968719a8
|
||||||
|
|
||||||
# Node no longer bundles pnpm (corepack and pnpm are both absent from this
|
# Node no longer bundles pnpm (corepack and pnpm are both absent from this
|
||||||
# image), so install it. First instruction, so later changes reuse the layer.
|
# image), so install it. First instruction, so later changes reuse the layer.
|
||||||
|
|||||||
@@ -48,81 +48,10 @@ feeds this machine is enforced locally by the commitizen pre-commit hook.
|
|||||||
3. Merge the release PR → version bumped, changelog written, tag
|
3. Merge the release PR → version bumped, changelog written, tag
|
||||||
`vX.Y.Z` created.
|
`vX.Y.Z` created.
|
||||||
|
|
||||||
# The label is load-bearing (2026-10-24)
|
|
||||||
|
|
||||||
Steps 2 and 3 are connected by a label, not by the merge alone:
|
|
||||||
|
|
||||||
* release-please creates the release PR with `autorelease: pending`;
|
|
||||||
* on the next run it lists merged PRs and keeps only those carrying that
|
|
||||||
label; those are the releases it tags.
|
|
||||||
|
|
||||||
Gitea resolves label **names** in `POST /issues/{index}/labels` with
|
|
||||||
`GetLabelIDsInRepoByNames`, which is a SQL `IN` filter: names that do not
|
|
||||||
exist are dropped **without an error**. A repository with no labels
|
|
||||||
therefore accepts the call, returns 200, and attaches nothing.
|
|
||||||
|
|
||||||
That is exactly what happened here: PRs #20 and #21 were merged as release
|
|
||||||
PRs with no label at all, so every run found zero merged release PRs,
|
|
||||||
created zero tags, and opened the next release PR instead — while reporting
|
|
||||||
success. Three release PRs, no tags.
|
|
||||||
|
|
||||||
The workflow now creates both labels (`autorelease: pending`,
|
|
||||||
`autorelease: tagged`) before the action runs. Idempotent: it reads the
|
|
||||||
label list and creates only what is missing.
|
|
||||||
|
|
||||||
# The head branch must survive the merge (2026-10-27)
|
|
||||||
|
|
||||||
The label fix was necessary but not sufficient. PR #22 carried
|
|
||||||
`autorelease: pending` when it was merged, and the run after it still
|
|
||||||
created no tag. From its log (task 475):
|
|
||||||
|
|
||||||
```
|
|
||||||
❯ Found pull request #22: 'chore: release main'
|
|
||||||
✖ Bad branch name: refs/pull/22/head
|
|
||||||
⚠ Expected 1 releases, only found 0
|
|
||||||
```
|
|
||||||
|
|
||||||
Gitea rewrites a merged PR's `head.ref` to `refs/pull/<n>/head` once the
|
|
||||||
head branch is deleted; the branch name survives only in `head.label`.
|
|
||||||
The Gitea build of release-please reads `head.ref`
|
|
||||||
(`BranchName.parse(mergedPullRequest.headBranchName)`, bundled at
|
|
||||||
`dist/index.js:15288`) and abandons the release when it is not a release
|
|
||||||
branch. GitHub keeps the branch name there, which is why the plugin's
|
|
||||||
assumption holds on GitHub and not here.
|
|
||||||
|
|
||||||
The repository deleted the head branch of every merged PR
|
|
||||||
(`default_delete_branch_after_merge: true`). It is `false` now, and a
|
|
||||||
release PR must be merged with its branch kept. The mechanism was
|
|
||||||
confirmed by comparison, not inference: while `fix/release_please` still
|
|
||||||
existed, PR #23 reported `head.ref = fix/release_please`; every PR whose
|
|
||||||
branch was gone reported `refs/pull/<n>/head`.
|
|
||||||
|
|
||||||
# Recovering the versions that never got a tag
|
|
||||||
|
|
||||||
The label alone cannot recover them — #20, #21 and #22 all lost their head
|
|
||||||
branch, so release-please skips them for the reason above. Creating those
|
|
||||||
tags is a one-time manual step:
|
|
||||||
|
|
||||||
| Version | Merge commit |
|
|
||||||
|---|---|
|
|
||||||
| `v1.1.0` | `67cf232` (#12) |
|
|
||||||
| `v1.2.0` | `4e8aa28` (#20) |
|
|
||||||
| `v1.3.0` | `08eb042` (#21) |
|
|
||||||
| `v1.4.0` | `0c937e6` (#22) |
|
|
||||||
|
|
||||||
`v1.0.0` is the bootstrap changelog entry from the configuration commit
|
|
||||||
`c89747e` (2026-10-18); no release PR produced it.
|
|
||||||
|
|
||||||
The manifest moved to 1.4.0 without any tag existing, so until a tag is
|
|
||||||
present release-please has no baseline: it reported "No latest release
|
|
||||||
found for path: ., component: , but a previous version (1.4.0) was
|
|
||||||
specified in the manifest" and would compute the next release from the
|
|
||||||
whole history.
|
|
||||||
|
|
||||||
# Not verified
|
# Not verified
|
||||||
|
|
||||||
* That the release phase tags correctly once the head branch survives a
|
* The first release PR end to end — needs at least one `feat:`/`fix:`
|
||||||
merge. The next release cycle proves it.
|
commit on `main` after the workflow merge.
|
||||||
* That `RELEASE_PLEASE_TOKEN_CV_SITE_NUXT` carries the `write:issue`
|
* That `RELEASE_PLEASE_TOKEN_CV_SITE_NUXT` carries the `write:issue`
|
||||||
scope the same way `PR_GITEA_TOKEN` needed it; the previous failure
|
scope the same way `PR_GITEA_TOKEN` needed it; the previous failure
|
||||||
was an immediate API rejection consistent with a scope problem.
|
was an immediate API rejection consistent with a scope problem.
|
||||||
@@ -133,6 +62,3 @@ whole history.
|
|||||||
`include-component-in-tag` and `separate-pull-requests` matter).
|
`include-component-in-tag` and `separate-pull-requests` matter).
|
||||||
* A release must trigger a deploy — the workflow gains a step after
|
* A release must trigger a deploy — the workflow gains a step after
|
||||||
`release_created` is set.
|
`release_created` is set.
|
||||||
* The label step breaks: if Gitea ever starts rejecting unknown label
|
|
||||||
names, the `Ensure release-please labels exist` step will fail loudly
|
|
||||||
instead of silently, which is the point.
|
|
||||||
@@ -1,13 +1,5 @@
|
|||||||
# Update Log
|
# Update Log
|
||||||
|
|
||||||
## 2026-10-27 (release-please still never tagged: the deleted head branch)
|
|
||||||
|
|
||||||
* **Fix**: [release-please-config.json](../release-please-config.json) gained `"changelog-host": "https://git.noelsabia.dev"` - the changelog compare links were generated against `github.com/CV_Website/CV_Site_Nuxt`, a host this repository does not live on. Root cause of the missing tags: **Gitea rewrites `head.ref` to `refs/pull/<n>/head` when the merged PR's branch is deleted**, and release-please parses that field as the release branch, so `BranchName.parse` fails and the release is dropped - silently, exit code 0. Evidence: run 143 (task 475) logs `✖ Bad branch name: refs/pull/22/head` right after `Found pull request #22`, then `Expected 1 releases, only found 0`; #22 did carry `autorelease: pending`. The repository deleted every merged branch (`default_delete_branch_after_merge: true`); it is `false` now. Four versions (1.1.0-1.4.0) were consumed by the manifest with no tag ever created, so the release baseline has to be restored by hand. See [Release engineering](decisions/release-engineering.md).
|
|
||||||
|
|
||||||
## 2026-10-24 (release-please never tagged: the missing labels)
|
|
||||||
|
|
||||||
* **Fix**: [release-please.yml](../.gitea/workflows/release-please.yml) - the workflow now creates `autorelease: pending` and `autorelease: tagged` before the action runs, and gained `workflow_dispatch` so a missed release can be replayed. Root cause: release-please finds merged release PRs **by label**, and Gitea resolves label names with `GetLabelIDsInRepoByNames`, a SQL `IN` filter that silently drops unknown names. The repository had no labels at all, so PRs #20 and #21 were merged unlabeled, every run found zero merged release PRs, created zero tags and opened the next release PR instead - reporting success each time. Evidence: run 137 green, 0 tags, 0 releases, `labels: []` on #20/#21/#22, and the repo's label list empty. See [Release engineering](decisions/release-engineering.md).
|
|
||||||
|
|
||||||
## 2026-10-24 (release publishes an image)
|
## 2026-10-24 (release publishes an image)
|
||||||
|
|
||||||
* **Creation**: [publish-image.yml](../.gitea/workflows/publish-image.yml) - a `vX.Y.Z` tag push builds `Dockerfile` on the arm64 runner and pushes `registry.noelsabia.dev/cv_website/nuxt` as the version and `sha-<12>`, plus `latest` when that tag is the newest release. Main pushes deliberately do not build: the registry holds releases, not commits. The job uses the runner's own Docker daemon (client only in the `node:22-bookworm` container), so the act_runner needs `container.docker_host: automount`; the first step fails with that cause if it is missing. That socket is root-equivalent, so it may only sit on a label PR jobs cannot use - recorded under the trust boundary in [Publishing images to the own registry](decisions/registry-publishing.md). Repo secrets: `REGISTRY_USERNAME`, `REGISTRY_PASSWORD`.
|
* **Creation**: [publish-image.yml](../.gitea/workflows/publish-image.yml) - a `vX.Y.Z` tag push builds `Dockerfile` on the arm64 runner and pushes `registry.noelsabia.dev/cv_website/nuxt` as the version and `sha-<12>`, plus `latest` when that tag is the newest release. Main pushes deliberately do not build: the registry holds releases, not commits. The job uses the runner's own Docker daemon (client only in the `node:22-bookworm` container), so the act_runner needs `container.docker_host: automount`; the first step fails with that cause if it is missing. That socket is root-equivalent, so it may only sit on a label PR jobs cannot use - recorded under the trust boundary in [Publishing images to the own registry](decisions/registry-publishing.md). Repo secrets: `REGISTRY_USERNAME`, `REGISTRY_PASSWORD`.
|
||||||
|
|||||||
+1
-1
@@ -20,7 +20,7 @@
|
|||||||
},
|
},
|
||||||
"dependencies": {
|
"dependencies": {
|
||||||
"@iconify-json/material-symbols": "^1.2.95",
|
"@iconify-json/material-symbols": "^1.2.95",
|
||||||
"@nuxt/icon": "2.6.2",
|
"@nuxt/icon": "2.6.0",
|
||||||
"@nuxtjs/i18n": "10.6.0",
|
"@nuxtjs/i18n": "10.6.0",
|
||||||
"@nuxtjs/seo": "6.0.1",
|
"@nuxtjs/seo": "6.0.1",
|
||||||
"@nuxtjs/tailwindcss": "6.14.0",
|
"@nuxtjs/tailwindcss": "6.14.0",
|
||||||
|
|||||||
@@ -3,7 +3,6 @@
|
|||||||
"release-type": "node",
|
"release-type": "node",
|
||||||
"include-component-in-tag": false,
|
"include-component-in-tag": false,
|
||||||
"separate-pull-requests": false,
|
"separate-pull-requests": false,
|
||||||
"changelog-host": "https://git.noelsabia.dev",
|
|
||||||
"packages": {
|
"packages": {
|
||||||
".": {
|
".": {
|
||||||
"package-name": "CV_Site_Frontend",
|
"package-name": "CV_Site_Frontend",
|
||||||
|
|||||||
@@ -1,4 +0,0 @@
|
|||||||
{
|
|
||||||
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
|
|
||||||
"automerge": true
|
|
||||||
}
|
|
||||||
Reference in new issue
Block a user