Compare commits

..
1 Commits
Author SHA1 Message Date
Gitea Actions [Bot] 1c516ea115 chore: release main
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m7s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 4s
PR Check / AI code review (opencode) (pull_request) Successful in 20s
2026-10-24 17:54:58 +00:00
4 changed files with 3 additions and 88 deletions

No files matched your search

-36
View File
@@ -2,10 +2,6 @@ on:
push: push:
branches: branches:
- main - main
# Manual trigger so a missed release can be replayed without waiting for
# the next push. The job is idempotent: it tags only merged release PRs
# that carry the pending label.
workflow_dispatch:
permissions: permissions:
contents: write contents: write
@@ -17,38 +13,6 @@ jobs:
release-please: release-please:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
# release-please marks its release PR with `autorelease: pending` and
# later finds the merged PR by that label. Gitea's label API resolves
# names and *silently ignores unknown ones* (GetLabelIDsInRepoByNames
# filters by name in SQL), so on a repository without these labels the
# PR is created unlabeled, the release phase finds no merged release PR
# and creates no tag - while the run still reports success. That is the
# bug this step prevents: make the labels exist first, every run.
- name: Ensure release-please labels exist
env:
GITEA_TOKEN: ${{ secrets.PR_GITEA_TOKEN }}
run: |
set -eu
existing="$(curl -sS -H "Authorization: token ${GITEA_TOKEN}" \
"${GITHUB_API_URL}/repos/${GITHUB_REPOSITORY}/labels?limit=50")"
for name in "autorelease: pending" "autorelease: tagged"; do
if printf '%s' "$existing" | grep -qF "\"name\":\"${name}\""; then
echo "label exists: ${name}"
continue
fi
code="$(curl -sS -o /tmp/label.json -w '%{http_code}' -X POST \
-H "Authorization: token ${GITEA_TOKEN}" \
-H 'Content-Type: application/json' \
-d "{\"name\":\"${name}\",\"color\":\"ededed\",\"description\":\"release-please state\"}" \
"${GITHUB_API_URL}/repos/${GITHUB_REPOSITORY}/labels")"
if [ "$code" != "201" ]; then
echo "::error::could not create label '${name}' (HTTP ${code})"
cat /tmp/label.json
exit 1
fi
echo "created label: ${name}"
done
- uses: joaquinjsb/gitea-release-please-action@v4 - uses: joaquinjsb/gitea-release-please-action@v4
with: with:
# One well-scoped token for all workflow API work (see # One well-scoped token for all workflow API work (see
+1 -2
View File
@@ -1,6 +1,6 @@
# Changelog # Changelog
## [1.4.0](https://github.com/CV_Website/CV_Site_Nuxt/compare/v1.3.0...v1.4.0) (2026-10-27) ## [1.4.0](https://github.com/CV_Website/CV_Site_Nuxt/compare/v1.3.0...v1.4.0) (2026-10-24)
### Features ### Features
@@ -25,7 +25,6 @@
* **ci:** address AI review findings (credentials, supply chain) ([85f488a](https://github.com/CV_Website/CV_Site_Nuxt/commit/85f488a94dd8796ea5f11c292edddd32e21398cd)) * **ci:** address AI review findings (credentials, supply chain) ([85f488a](https://github.com/CV_Website/CV_Site_Nuxt/commit/85f488a94dd8796ea5f11c292edddd32e21398cd))
* **ci:** apply review findings round two ([a3e6aef](https://github.com/CV_Website/CV_Site_Nuxt/commit/a3e6aef901086f5f8b416e2aa7d29596517f9550)) * **ci:** apply review findings round two ([a3e6aef](https://github.com/CV_Website/CV_Site_Nuxt/commit/a3e6aef901086f5f8b416e2aa7d29596517f9550))
* **ci:** close the fail-open gate, enforce read-only sandbox ([3e68e63](https://github.com/CV_Website/CV_Site_Nuxt/commit/3e68e630dff92a7abd791b7a8808eb682f37a060)) * **ci:** close the fail-open gate, enforce read-only sandbox ([3e68e63](https://github.com/CV_Website/CV_Site_Nuxt/commit/3e68e630dff92a7abd791b7a8808eb682f37a060))
* **ci:** create the release-please labels before the action runs ([0a3c90c](https://github.com/CV_Website/CV_Site_Nuxt/commit/0a3c90cc7489b7657a9a142fb2b6248ae0738a63))
* **ci:** deny write tools, never swallow review errors ([f8d1287](https://github.com/CV_Website/CV_Site_Nuxt/commit/f8d128705faa9493202cf724ae0a451d4dc6d1e5)) * **ci:** deny write tools, never swallow review errors ([f8d1287](https://github.com/CV_Website/CV_Site_Nuxt/commit/f8d128705faa9493202cf724ae0a451d4dc6d1e5))
* **ci:** gate the ai review to pull_request events, restore route announcer ([9be6298](https://github.com/CV_Website/CV_Site_Nuxt/commit/9be62982a4a2494351006463ae71bd99f4e49fe4)) * **ci:** gate the ai review to pull_request events, restore route announcer ([9be6298](https://github.com/CV_Website/CV_Site_Nuxt/commit/9be62982a4a2494351006463ae71bd99f4e49fe4))
* **ci:** give release-please git credentials for the release-branch push ([a27bbbb](https://github.com/CV_Website/CV_Site_Nuxt/commit/a27bbbb2abf0fa8ddedd20c05bba2128e88faa3a)) * **ci:** give release-please git credentials for the release-branch push ([a27bbbb](https://github.com/CV_Website/CV_Site_Nuxt/commit/a27bbbb2abf0fa8ddedd20c05bba2128e88faa3a))
+2 -46
View File
@@ -48,54 +48,13 @@ feeds this machine is enforced locally by the commitizen pre-commit hook.
3. Merge the release PR → version bumped, changelog written, tag 3. Merge the release PR → version bumped, changelog written, tag
`vX.Y.Z` created. `vX.Y.Z` created.
# The label is load-bearing (2026-10-24)
Steps 2 and 3 are connected by a label, not by the merge alone:
* release-please creates the release PR with `autorelease: pending`;
* on the next run it lists merged PRs and keeps only those carrying that
label; those are the releases it tags.
Gitea resolves label **names** in `POST /issues/{index}/labels` with
`GetLabelIDsInRepoByNames`, which is a SQL `IN` filter: names that do not
exist are dropped **without an error**. A repository with no labels
therefore accepts the call, returns 200, and attaches nothing.
That is exactly what happened here: PRs #20 and #21 were merged as release
PRs with no label at all, so every run found zero merged release PRs,
created zero tags, and opened the next release PR instead — while reporting
success. Three release PRs, no tags.
The workflow now creates both labels (`autorelease: pending`,
`autorelease: tagged`) before the action runs. Idempotent: it reads the
label list and creates only what is missing.
# Recovering a release that was merged without a label
Labels exist only from the fixed workflow onwards. PRs merged before that
still carry none, so tagging them is a one-time manual step:
```sh
# add the pending label to the merged release PRs
for n in 20 21; do
curl -sS -X POST -H "Authorization: token $TOKEN" \
-H 'Content-Type: application/json' \
-d '{"labels":["autorelease: pending"]}' \
"https://git.noelsabia.dev/api/v1/repos/CV_Website/CV_Site_Nuxt/issues/$n/labels"
done
```
Then run the release-please workflow again (it now has
`workflow_dispatch`). It creates `v1.2.0` and `v1.3.0` from those PRs'
bodies and replaces the label with `autorelease: tagged`.
# Not verified # Not verified
* The first release PR end to end — needs at least one `feat:`/`fix:`
commit on `main` after the workflow merge.
* That `RELEASE_PLEASE_TOKEN_CV_SITE_NUXT` carries the `write:issue` * That `RELEASE_PLEASE_TOKEN_CV_SITE_NUXT` carries the `write:issue`
scope the same way `PR_GITEA_TOKEN` needed it; the previous failure scope the same way `PR_GITEA_TOKEN` needed it; the previous failure
was an immediate API rejection consistent with a scope problem. was an immediate API rejection consistent with a scope problem.
* That the release phase tags correctly once the label is present. The
label path is now fixed at the source; the first recovery run proves it.
# Revisit when # Revisit when
@@ -103,6 +62,3 @@ bodies and replaces the label with `autorelease: tagged`.
`include-component-in-tag` and `separate-pull-requests` matter). `include-component-in-tag` and `separate-pull-requests` matter).
* A release must trigger a deploy — the workflow gains a step after * A release must trigger a deploy — the workflow gains a step after
`release_created` is set. `release_created` is set.
* The label step breaks: if Gitea ever starts rejecting unknown label
names, the `Ensure release-please labels exist` step will fail loudly
instead of silently, which is the point.
-4
View File
@@ -1,9 +1,5 @@
# Update Log # Update Log
## 2026-10-24 (release-please never tagged: the missing labels)
* **Fix**: [release-please.yml](../.gitea/workflows/release-please.yml) - the workflow now creates `autorelease: pending` and `autorelease: tagged` before the action runs, and gained `workflow_dispatch` so a missed release can be replayed. Root cause: release-please finds merged release PRs **by label**, and Gitea resolves label names with `GetLabelIDsInRepoByNames`, a SQL `IN` filter that silently drops unknown names. The repository had no labels at all, so PRs #20 and #21 were merged unlabeled, every run found zero merged release PRs, created zero tags and opened the next release PR instead - reporting success each time. Evidence: run 137 green, 0 tags, 0 releases, `labels: []` on #20/#21/#22, and the repo's label list empty. See [Release engineering](decisions/release-engineering.md).
## 2026-10-24 (release publishes an image) ## 2026-10-24 (release publishes an image)
* **Creation**: [publish-image.yml](../.gitea/workflows/publish-image.yml) - a `vX.Y.Z` tag push builds `Dockerfile` on the arm64 runner and pushes `registry.noelsabia.dev/cv_website/nuxt` as the version and `sha-<12>`, plus `latest` when that tag is the newest release. Main pushes deliberately do not build: the registry holds releases, not commits. The job uses the runner's own Docker daemon (client only in the `node:22-bookworm` container), so the act_runner needs `container.docker_host: automount`; the first step fails with that cause if it is missing. That socket is root-equivalent, so it may only sit on a label PR jobs cannot use - recorded under the trust boundary in [Publishing images to the own registry](decisions/registry-publishing.md). Repo secrets: `REGISTRY_USERNAME`, `REGISTRY_PASSWORD`. * **Creation**: [publish-image.yml](../.gitea/workflows/publish-image.yml) - a `vX.Y.Z` tag push builds `Dockerfile` on the arm64 runner and pushes `registry.noelsabia.dev/cv_website/nuxt` as the version and `sha-<12>`, plus `latest` when that tag is the newest release. Main pushes deliberately do not build: the registry holds releases, not commits. The job uses the runner's own Docker daemon (client only in the `node:22-bookworm` container), so the act_runner needs `container.docker_host: automount`; the first step fails with that cause if it is missing. That socket is root-equivalent, so it may only sit on a label PR jobs cannot use - recorded under the trust boundary in [Publishing images to the own registry](decisions/registry-publishing.md). Repo secrets: `REGISTRY_USERNAME`, `REGISTRY_PASSWORD`.