Compare commits
8
Commits
v1.5.0
..
1fb47dc4e1
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
1fb47dc4e1 | ||
|
|
26abef948d | ||
|
|
0268a11e14 | ||
|
|
42b07e9ab9 | ||
|
|
c8250c9ca3 | ||
|
|
fdce59d77d | ||
|
|
e23f8d2618 | ||
|
|
93fcd4127c |
No files matched your search
@@ -152,6 +152,62 @@ Two details keep the reconciliation from suppressing a real release:
|
|||||||
`v<manifest version>`. A CI or annotation tag on the same commit is
|
`v<manifest version>`. A CI or annotation tag on the same commit is
|
||||||
logged and ignored, and the release tag is still created.
|
logged and ignored, and the release tag is still created.
|
||||||
|
|
||||||
|
# The release phase drops the PR on a component mismatch (2026-10-31)
|
||||||
|
|
||||||
|
With the branch kept and the label reconciled, PR #35 was still not
|
||||||
|
tagged. Run 181 (task 578, immediately after #35 merged) shows why:
|
||||||
|
|
||||||
|
```
|
||||||
|
❯ Found pull request #35: 'chore: release main'
|
||||||
|
...
|
||||||
|
⚠ PR component: undefined does not match configured component: CV_Site_Frontend
|
||||||
|
...
|
||||||
|
⚠ There are untagged, merged release PRs outstanding - aborting
|
||||||
|
```
|
||||||
|
|
||||||
|
`buildRelease()` compares the component parsed from the merged PR with the
|
||||||
|
strategy's component when the release body contains one component and that
|
||||||
|
component is empty. `include-component-in-tag: false` makes
|
||||||
|
`getComponent()` return an empty string, so the release PR is
|
||||||
|
`chore: release main` with an empty component and the branch is
|
||||||
|
`release-please--branches--main` (parsed component: undefined). But
|
||||||
|
`getBranchComponent()` ignores `include-component-in-tag` and returns
|
||||||
|
`package-name` - here `CV_Site_Frontend`. The two never match, so the
|
||||||
|
release is dropped before the tag is created.
|
||||||
|
|
||||||
|
Removing `package-name` is not enough. Run 183 (after #36 merged) shows
|
||||||
|
the node strategy falling back to the `package.json` name:
|
||||||
|
|
||||||
|
```
|
||||||
|
⚠ PR component: undefined does not match configured component: nuxt-app
|
||||||
|
```
|
||||||
|
|
||||||
|
`BaseStrategy.getDefaultPackageName()` is overridden by the node strategy
|
||||||
|
to read `package.json` `name`, so an absent `package-name` resolves to
|
||||||
|
`nuxt-app`.
|
||||||
|
|
||||||
|
The working setting is `"package-name": ""` (an empty string, not an
|
||||||
|
omitted key). An empty string is not nullish, so `getBranchComponent()`
|
||||||
|
returns empty and matches the legacy default branch
|
||||||
|
`release-please--branches--main`. This was verified by running the
|
||||||
|
action's bundled release-please 16.15.6 locally against the live Gitea
|
||||||
|
API, with writes intercepted: the release phase produced
|
||||||
|
|
||||||
|
```
|
||||||
|
POST /repos/CV_Website/CV_Site_Nuxt/releases
|
||||||
|
{"name":"v1.5.0","tag_name":"v1.5.0",...,"target_commitish":"a80c9ebf..."}
|
||||||
|
```
|
||||||
|
|
||||||
|
then swapped #35 to `autorelease: tagged`. That is release-please creating
|
||||||
|
the tag itself, not a manual `git tag`.
|
||||||
|
|
||||||
|
The action's official default mode (`release-type: node`, no manifest
|
||||||
|
config) was tested the same way and still fails for #35 with
|
||||||
|
`configured component: nuxt-app`. It cannot retroactively accept the
|
||||||
|
already-merged legacy PR; it would only help a release PR created after
|
||||||
|
the switch. The empty `package-name` is therefore the compatibility
|
||||||
|
setting that lets release-please finish v1.5.0.
|
||||||
|
|
||||||
# Recovering the versions that never got a tag
|
# Recovering the versions that never got a tag
|
||||||
|
|
||||||
The label alone cannot recover them — #20, #21 and #22 all lost their head
|
The label alone cannot recover them — #20, #21 and #22 all lost their head
|
||||||
@@ -176,8 +232,10 @@ whole history.
|
|||||||
|
|
||||||
# Not verified
|
# Not verified
|
||||||
|
|
||||||
* That the release phase tags correctly once the head branch survives a
|
* That the live run tags #35. The exact release-phase request was verified
|
||||||
merge. The next release cycle proves it.
|
locally with writes intercepted (`POST /releases` with `tag_name:
|
||||||
|
v1.5.0` at `a80c9eb`); the run after merging the empty `package-name` is
|
||||||
|
the final proof.
|
||||||
* That the reconcile step's tag-creation fallback works with a live
|
* That the reconcile step's tag-creation fallback works with a live
|
||||||
token. Only the tag-already-exists path was exercised, in dry-run,
|
token. Only the tag-already-exists path was exercised, in dry-run,
|
||||||
against the live PR #22. The fallback is written from the same Gitea
|
against the live PR #22. The fallback is written from the same Gitea
|
||||||
|
|||||||
@@ -1,5 +1,18 @@
|
|||||||
# Update Log
|
# Update Log
|
||||||
|
|
||||||
|
## 2026-10-31 (release-please tag: empty package-name is the verified fix)
|
||||||
|
|
||||||
|
* **Correction**: removing `package-name` in #36 was not enough. Run 183 shows the node strategy falling back to `package.json` `name`, so the release phase still failed with `PR component: undefined does not match configured component: nuxt-app`.
|
||||||
|
* **Fix**: [release-please-config.json](../release-please-config.json) sets `"package-name": ""`. An empty string is not nullish, so `getBranchComponent()` stays empty and matches the legacy `release-please--branches--main` branch. This is the only setting that lets release-please accept the already-merged #35.
|
||||||
|
* **Evidence**: the action's bundled release-please 16.15.6 was run locally against the live Gitea API with writes intercepted. It produced `POST /repos/CV_Website/CV_Site_Nuxt/releases` with `{"name":"v1.5.0","tag_name":"v1.5.0","target_commitish":"a80c9ebf..."}`, then swapped #35 to `autorelease: tagged`. The official default `release-type: node` mode was tested the same way and still fails for #35 with `configured component: nuxt-app`, so it cannot retroactively tag the legacy PR.
|
||||||
|
* **Expected result**: the run after this merge creates `v1.5.0` at `a80c9eb` through the release-please action itself. No manual `git tag`.
|
||||||
|
|
||||||
|
## 2026-10-31 (release-please component mismatch: no v1.5.0 tag)
|
||||||
|
|
||||||
|
* **Fix**: [release-please-config.json](../release-please-config.json) - removed `package-name: CV_Site_Frontend`. With `include-component-in-tag: false` the strategy component and the release PR body component are empty, but `getBranchComponent()` still returned `package-name`; the release phase logged `PR component: undefined does not match configured component: CV_Site_Frontend` and returned before creating the tag. The component now matches, so the next run should tag #35.
|
||||||
|
* **Evidence**: run 181 (task 578, immediately after #35 merged) - the reconcile step correctly left #35 for the action because its branch survived, then the action found #35, hit the component mismatch and aborted with "There are untagged, merged release PRs outstanding". The earlier label/branch fixes were correct; this was the remaining check.
|
||||||
|
* **Expected result**: the run after this merge creates `v1.5.0` at the #35 merge commit (`a80c9eb`), marks #35 `autorelease: tagged`, and stops opening duplicate release PRs.
|
||||||
|
|
||||||
## 2026-10-31 (release-please reconcile step needs a checkout)
|
## 2026-10-31 (release-please reconcile step needs a checkout)
|
||||||
|
|
||||||
* **Fix**: [release-please.yml](../.gitea/workflows/release-please.yml) - added `actions/checkout@v4` before the reconcile step. The job had no checkout because the release-please action clones the repository into its own temp directory; the new step runs `scripts/reconcile-release-please.mjs` from the workspace, so the first post-merge run failed with `Cannot find module '/workspace/CV_Website/CV_Site_Nuxt/scripts/reconcile-release-please.mjs'` (task 571). The checkout supplies the file; the action still uses its own temp clone for the release branch.
|
* **Fix**: [release-please.yml](../.gitea/workflows/release-please.yml) - added `actions/checkout@v4` before the reconcile step. The job had no checkout because the release-please action clones the repository into its own temp directory; the new step runs `scripts/reconcile-release-please.mjs` from the workspace, so the first post-merge run failed with `Cannot find module '/workspace/CV_Website/CV_Site_Nuxt/scripts/reconcile-release-please.mjs'` (task 571). The checkout supplies the file; the action still uses its own temp clone for the release branch.
|
||||||
|
|||||||
Generated
+970
-1089
File diff suppressed because it is too large.
Load diff
@@ -56,3 +56,8 @@ minimumReleaseAgeExclude:
|
|||||||
- '@rollup/rollup-openharmony-arm64@4.64.8'
|
- '@rollup/rollup-openharmony-arm64@4.64.8'
|
||||||
- '@rollup/rollup-win32-ia32-msvc@4.64.8'
|
- '@rollup/rollup-win32-ia32-msvc@4.64.8'
|
||||||
- '@nuxt/icon@2.6.0'
|
- '@nuxt/icon@2.6.0'
|
||||||
|
permissions:
|
||||||
|
'@nuxtjs/seo':
|
||||||
|
skills:
|
||||||
|
dirs:
|
||||||
|
- .agents/skills
|
||||||
@@ -6,7 +6,7 @@
|
|||||||
"changelog-host": "https://git.noelsabia.dev",
|
"changelog-host": "https://git.noelsabia.dev",
|
||||||
"packages": {
|
"packages": {
|
||||||
".": {
|
".": {
|
||||||
"package-name": "CV_Site_Frontend",
|
"package-name": "",
|
||||||
"changelog-path": "CHANGELOG.md",
|
"changelog-path": "CHANGELOG.md",
|
||||||
"extra-files": [],
|
"extra-files": [],
|
||||||
"versioning": "default"
|
"versioning": "default"
|
||||||
|
|||||||
Reference in new issue
Block a user