fix: unblock the release PR - real production image, reviewed audit ignores #11

Merged
Noel merged 2 commits from fix/action_fails_fix into main 2026-10-18 19:26:17 +00:00
Owner

The release PR (chore: release main) failed two checks, both verified
locally before pushing:

  • droast: the empty production Dockerfile failed DF071 (no
    instructions). The new Dockerfile is a runnable Node server (SSR):
    multi-stage, manifests-first layers, digest-pinned node:26-slim (same
    digest as the dev container), non-root uid 1000, node-fetch
    HEALTHCHECK. Measured: docker build succeeds in-image, container
    serves HTTP 200 and reports healthy; droast reports 0 errors.
  • audit: two high advisories with NO patched release anywhere
    (node-forge <=1.4.0 and braces <=3.0.3 are the newest npm versions;
    both build-time-only paths under nitropack). Recorded as
    auditConfig.ignoreGhsas in pnpm-workspace.yaml with the reason and
    removal condition - the audit output still names what it skipped.
    pnpm 11 ignores the pnpm field in package.json (caught locally via
    the WARN before pushing); settings live in pnpm-workspace.yaml.

OKF_Nuxt: recorded the production-image and audit-policy decisions,
updated log, indexes and open questions.

The release PR (chore: release main) failed two checks, both verified locally before pushing: - droast: the empty production Dockerfile failed DF071 (no instructions). The new Dockerfile is a runnable Node server (SSR): multi-stage, manifests-first layers, digest-pinned node:26-slim (same digest as the dev container), non-root uid 1000, node-fetch HEALTHCHECK. Measured: docker build succeeds in-image, container serves HTTP 200 and reports healthy; droast reports 0 errors. - audit: two high advisories with NO patched release anywhere (node-forge <=1.4.0 and braces <=3.0.3 are the newest npm versions; both build-time-only paths under nitropack). Recorded as auditConfig.ignoreGhsas in pnpm-workspace.yaml with the reason and removal condition - the audit output still names what it skipped. pnpm 11 ignores the pnpm field in package.json (caught locally via the WARN before pushing); settings live in pnpm-workspace.yaml. OKF_Nuxt: recorded the production-image and audit-policy decisions, updated log, indexes and open questions.
Noel added 1 commit 2026-10-18 19:17:15 +00:00
fix: unblock the release PR - real production image, reviewed audit ignores
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Canceled after 28s
PR Check / Typecheck (pull_request) Canceled after 0s
PR Check / Secret scan (gitleaks) (pull_request) Canceled after 0s
PR Check / Dependency audit (pull_request) Canceled after 0s
PR Check / Dockerfile lint (droast) (pull_request) Canceled after 0s
PR Check / AI code review (opencode) (pull_request) Canceled after 0s
f32ad07648
The release PR (chore: release main) failed two checks, both verified
locally before pushing:

- droast: the empty production Dockerfile failed DF071 (no
  instructions). The new Dockerfile is a runnable Node server (SSR):
  multi-stage, manifests-first layers, digest-pinned node:26-slim (same
  digest as the dev container), non-root uid 1000, node-fetch
  HEALTHCHECK. Measured: docker build succeeds in-image, container
  serves HTTP 200 and reports healthy; droast reports 0 errors.
- audit: two high advisories with NO patched release anywhere
  (node-forge <=1.4.0 and braces <=3.0.3 are the newest npm versions;
  both build-time-only paths under nitropack). Recorded as
  auditConfig.ignoreGhsas in pnpm-workspace.yaml with the reason and
  removal condition - the audit output still names what it skipped.
  pnpm 11 ignores the pnpm field in package.json (caught locally via
  the WARN before pushing); settings live in pnpm-workspace.yaml.

OKF_Nuxt: recorded the production-image and audit-policy decisions,
updated log, indexes and open questions.
Noel added 1 commit 2026-10-18 19:17:47 +00:00
Merge branch 'main' into fix/action_fails_fix
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 35s
PR Check / Typecheck (pull_request) Successful in 39s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 8s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
PR Check / AI code review (opencode) (pull_request) Successful in 4m22s
f5ed820abf
Author
Owner



build · deepseek-v4-pro
→ Read .pr-review-diff.patch
build · deepseek-v4-pro
→ Read .
→ Read package.json
✱ Glob ".dockerignore" 0 matches
build · deepseek-v4-pro
→ Read .dockerignore
→ Read nuxt.config.ts
build · deepseek-v4-pro
⚙ execute {"code":"const files = await tools.glob({ pattern: "/*", path: "/workspace/CV_Website/CV_Site_Nuxt/app" });\nconst files2 = await tools.glob({ pattern: "/", path: "/workspace/CV_Website/CV_Site_Nuxt/public" });\nreturn { app: files, public: files2 };\n"}
build · deepseek-v4-pro
✱ Glob "app/**/
" 1 match
✱ Glob "server/**/*" 0 matches
build · deepseek-v4-pro
✱ Grep "^ (dependencies|devDependencies):" in pnpm-lock.yaml · 0 matches
✱ Grep "listhen|node-forge" in pnpm-lock.yaml · 6 matches
build · deepseek-v4-pro
→ Read pnpm-lock.yaml [offset=6715, limit=30]
→ Read pnpm-lock.yaml [offset=6890, limit=60]
build · deepseek-v4-pro
Reviewed the diff (Dockerfile, pnpm-workspace.yaml, decision docs) plus repo context (.dockerignore, package.json, nuxt.config.ts, pnpm-lock.yaml).

[WARN] pnpm-workspace.yaml:10 - The node-forge ignore rationale ("build/dev-time only, not in the server bundle") contradicts the repo's own lockfile: listhen is a production dependency of nitropack (pnpm-lock.yaml:6909), and Nitro's node-server preset imports listhen, which statically imports node-forge (certificate module). It is very likely traced into .output/server/node_modules. Risk is contained — the cert code never executes without HTTPS config, and the gateway terminates TLS — so not a blocker, but the recorded justification is factually shaky. Fix: run the build and check find .output/server/node_modules -name '*forge*'; if present, re-record the rationale as "bundled but unreachable code path", not "not in the bundle".

[WARN] Dockerfile:57 - /app itself remains root-owned: WORKDIR creates it as root and --chown only applies to .output. Today the app is read-only (no server/ routes, no storage usage), so it runs — but the first filesystem-backed Nitro feature (the default data storage writes .data/kv, cache dir, or any upload route) will crash with EACCES under uid 1000. Fix: RUN mkdir -p /app/.data && chown -R node:node /app in the runtime stage, or declare a writable volume.

[NIT] Dockerfile:39 - --ignore-scripts is safe and measured today, but fails silently when a future dependency gains a required postinstall (native compilation). Add a comment/CI check asserting scripts are intentionally skipped so the failure mode is visible.

[NIT] Dockerfile:24 - node:26 is the Current line, not LTS, for a production image; node:24 is the active LTS. If parity with the dev container is the tie-breaker, say so in the decision doc (currently only the digest pin is justified).

[NIT] Dockerfile:20-21 vs OKF_Nuxt/decisions/production-image.md:143 - The comment claims arm64 is "verified for the runner", while the decision doc says the image build has only run on x86_64; clarify which claim covers the base digest vs the built image.

Docs-only changes (decisions, log, open-questions) are otherwise fine; .dockerignore correctly excludes secrets, .git, and node_modules, which the COPY . . layer depends on.

VERDICT: APPROVE

 > build · deepseek-v4-pro → Read .pr-review-diff.patch > build · deepseek-v4-pro → Read . → Read package.json ✱ Glob ".dockerignore" 0 matches > build · deepseek-v4-pro → Read .dockerignore → Read nuxt.config.ts > build · deepseek-v4-pro ⚙ execute {"code":"const files = await tools.glob({ pattern: \"**/*\", path: \"/workspace/CV_Website/CV_Site_Nuxt/app\" });\nconst files2 = await tools.glob({ pattern: \"**/*\", path: \"/workspace/CV_Website/CV_Site_Nuxt/public\" });\nreturn { app: files, public: files2 };\n"} > build · deepseek-v4-pro ✱ Glob "app/**/*" 1 match ✱ Glob "server/**/*" 0 matches > build · deepseek-v4-pro ✱ Grep "^ (dependencies|devDependencies):" in pnpm-lock.yaml · 0 matches ✱ Grep "listhen|node-forge" in pnpm-lock.yaml · 6 matches > build · deepseek-v4-pro → Read pnpm-lock.yaml [offset=6715, limit=30] → Read pnpm-lock.yaml [offset=6890, limit=60] > build · deepseek-v4-pro Reviewed the diff (Dockerfile, `pnpm-workspace.yaml`, decision docs) plus repo context (`.dockerignore`, `package.json`, `nuxt.config.ts`, `pnpm-lock.yaml`). [WARN] pnpm-workspace.yaml:10 - The `node-forge` ignore rationale ("build/dev-time only, not in the server bundle") contradicts the repo's own lockfile: `listhen` is a **production** dependency of `nitropack` (pnpm-lock.yaml:6909), and Nitro's node-server preset imports `listhen`, which statically imports `node-forge` (certificate module). It is very likely traced into `.output/server/node_modules`. Risk is contained — the cert code never executes without HTTPS config, and the gateway terminates TLS — so not a blocker, but the recorded justification is factually shaky. Fix: run the build and check `find .output/server/node_modules -name '*forge*'`; if present, re-record the rationale as "bundled but unreachable code path", not "not in the bundle". [WARN] Dockerfile:57 - `/app` itself remains root-owned: `WORKDIR` creates it as root and `--chown` only applies to `.output`. Today the app is read-only (no `server/` routes, no storage usage), so it runs — but the first filesystem-backed Nitro feature (the default `data` storage writes `.data/kv`, cache dir, or any upload route) will crash with EACCES under uid 1000. Fix: `RUN mkdir -p /app/.data && chown -R node:node /app` in the runtime stage, or declare a writable volume. [NIT] Dockerfile:39 - `--ignore-scripts` is safe and measured today, but fails silently when a future dependency gains a required postinstall (native compilation). Add a comment/CI check asserting scripts are intentionally skipped so the failure mode is visible. [NIT] Dockerfile:24 - `node:26` is the Current line, not LTS, for a production image; `node:24` is the active LTS. If parity with the dev container is the tie-breaker, say so in the decision doc (currently only the digest pin is justified). [NIT] Dockerfile:20-21 vs OKF_Nuxt/decisions/production-image.md:143 - The comment claims arm64 is "verified for the runner", while the decision doc says the image build has only run on x86_64; clarify which claim covers the base digest vs the built image. Docs-only changes (decisions, log, open-questions) are otherwise fine; `.dockerignore` correctly excludes secrets, `.git`, and `node_modules`, which the `COPY . .` layer depends on. VERDICT: APPROVE
Noel merged commit 14a991ecec into main 2026-10-18 19:26:17 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: CV_Website/CV_Site_Nuxt#11