Locale files in i18n/locales for en, de, es, it and pl; English stays at / and the others are prefixed. One flag dropdown after the GitHub link on desktop, logo plus the language button on phones. Nav, quick links and footer strings go through $t, and the footer line drops "self-healing on purpose".
Locale files in i18n/locales for en, de, es, it and pl; English stays at / and the others are prefixed. One flag dropdown after the GitHub link on desktop, logo plus the language button on phones. Nav, quick links and footer strings go through $t, and the footer line drops "self-healing on purpose".
Locale files in i18n/locales for en, de, es, it and pl; English stays at / and the others are prefixed. One flag dropdown after the GitHub link on desktop, logo plus the language button on phones. Nav, quick links and footer strings go through $t, and the footer line drops "self-healing on purpose".
[WARN] app/components/AppNav.vue:2 - md:flex was changed to lg:flex, so the nav is now hidden from 768px to 1023px with no mobile fallback. Tablet users lose the nav links. Restore md:flex and adjust the header layout at md, or add a menu toggle for smaller viewports.
[WARN] i18n/locales/en.json:238 - The English footer dropped "self-healing on purpose" from the original string. This is an unintended content change on the default locale. Restore the original text: "Served from my own server · k8s · Terraform · self-healing on purpose". Then decide whether the other locales need the same clause.
[WARN] pnpm-lock.yaml (not in patch) - @nuxtjs/i18n is added to package.json, but the patch contains no lockfile change. The workspace lockfile already references it, so the PR may be missing the lock update or the lock may be out of sync with the base. Confirm that pnpm-lock.yaml is committed in this PR. Otherwise pnpm install --frozen-lockfile in CI will fail.
[WARN] nuxt.config.ts:326-335 - No strategy or detectBrowserLanguage is set, so the module defaults apply. Those defaults can add locale-prefixed routes and cookie-based redirects that were not reviewed. Set strategy and detectBrowserLanguage explicitly, and add hreflang/seo settings if SEO matters for this CV site.
[NIT] app/components/AppLanguageSwitcher.vue:117 - aria-label replaces the visible text (the locale code) with "Language". This violates WCAG 2.5.3 label-in-name. Use aria-label that includes the visible code, or drop it and rely on the visible text.
[NIT] app/components/AppLanguageSwitcher.vue:115 - aria-haspopup="true" implies a menu, but the list has no role="menu"/menuitem and no arrow-key navigation. Focus also does not return to the trigger on Escape. Either use aria-haspopup="listbox"-style semantics with full keyboard support, or keep the disclosure pattern and drop aria-haspopup.
[NIT] app/components/AppLanguageSwitcher.vue:94-102 - Document-level listeners are attached on every mount. Consider VueUse's onClickOutside / onKeyStroke to reduce boilerplate and handle cleanup automatically.
VERDICT: APPROVE
[0m
> build · claude-haiku-5-5
[0m→ [0mRead .pr-review-diff.patch
> build · claude-haiku-5-5
[0m✱ [0mGrep "@nuxtjs/i18n|^lockfileVersion" [90min . · 4 matches[0m
[0m✱ [0mGlob "{i18n,app/pages,pnpm-lock.yaml}" [90min . · 1 match[0m
> build · claude-haiku-5-5
**Findings**
[WARN] app/components/AppNav.vue:2 - `md:flex` was changed to `lg:flex`, so the nav is now hidden from 768px to 1023px with no mobile fallback. Tablet users lose the nav links. Restore `md:flex` and adjust the header layout at `md`, or add a menu toggle for smaller viewports.
[WARN] i18n/locales/en.json:238 - The English footer dropped "self-healing on purpose" from the original string. This is an unintended content change on the default locale. Restore the original text: "Served from my own server · k8s · Terraform · self-healing on purpose". Then decide whether the other locales need the same clause.
[WARN] pnpm-lock.yaml (not in patch) - `@nuxtjs/i18n` is added to `package.json`, but the patch contains no lockfile change. The workspace lockfile already references it, so the PR may be missing the lock update or the lock may be out of sync with the base. Confirm that `pnpm-lock.yaml` is committed in this PR. Otherwise `pnpm install --frozen-lockfile` in CI will fail.
[WARN] nuxt.config.ts:326-335 - No `strategy` or `detectBrowserLanguage` is set, so the module defaults apply. Those defaults can add locale-prefixed routes and cookie-based redirects that were not reviewed. Set `strategy` and `detectBrowserLanguage` explicitly, and add `hreflang`/`seo` settings if SEO matters for this CV site.
[NIT] app/components/AppLanguageSwitcher.vue:117 - `aria-label` replaces the visible text (the locale code) with "Language". This violates WCAG 2.5.3 label-in-name. Use `aria-label` that includes the visible code, or drop it and rely on the visible text.
[NIT] app/components/AppLanguageSwitcher.vue:115 - `aria-haspopup="true"` implies a menu, but the list has no `role="menu"`/`menuitem` and no arrow-key navigation. Focus also does not return to the trigger on Escape. Either use `aria-haspopup="listbox"`-style semantics with full keyboard support, or keep the disclosure pattern and drop `aria-haspopup`.
[NIT] app/components/AppLanguageSwitcher.vue:94-102 - Document-level listeners are attached on every mount. Consider VueUse's `onClickOutside` / `onKeyStroke` to reduce boilerplate and handle cleanup automatically.
VERDICT: APPROVE
Resolved: nuxt.config modules now carry @nuxt/icon and @nuxtjs/seo alongside @nuxtjs/i18n; package.json keeps both dependency sets; pnpm-lock.yaml regenerated. Also set i18n.baseUrl from site.config.mjs so sitemap alternates and future hreflang links are absolute.
build · claude-haiku-5-5
[0m→ [0mRead .pr-review-diff.patch
build · claude-haiku-5-5
[BLOCKER] app/components/AppNav.vue:4 - The Overview link uses a plain <NuxtLink to="/">. With @nuxtjs/i18n and the default prefix_except_default strategy, that path points at the English root, so clicking "Overview" on /de, /es, /it, or /pl drops the user back to English. The aria-current="page" is also hardcoded. Fix: use <NuxtLinkLocale to="/"> or :to="localePath('/')", and set aria-current from the route, not as a constant. I haven't checked the route setup or the module's NuxtLink behaviour in this repo, so verify on a non-English page before merging.
[WARN] i18n/locales/en.json:12 - The English footer text was changed from "Served from my own server · k8s · Terraform · self-healing on purpose" to drop "self-healing on purpose". This is an unrequested content change that also propagates to every locale. If it's not intended, restore it in en.json and in the other four locale files.
[WARN] app/components/AppLanguageSwitcher.vue:42 - The toggle button's aria-label replaces its visible text, so screen readers hear only "Language" and never the current locale. The button also uses aria-haspopup="true" with a plain <ul> that isn't a menu, and it never moves focus into or out of the list. Fix: drop the aria-label in favour of a visible label such as Language: EN, use aria-haspopup="listbox" with proper roles, or make the list a real menu with focus management.
[WARN] app/components/AppFlag.vue:29 - The final v-else renders the Polish flag for any unknown code. Any locale added later without a matching branch would silently show the wrong flag. Fix: make the fallback explicit, for example with a v-else that renders nothing or a neutral placeholder, or type-narrow code so an unknown value is a compile error.
[NIT] nuxt.config.ts:332 - The comment says the config provides "per-locale sitemaps", but nothing in this diff configures sitemaps. That relies on implicit @nuxtjs/seo / @nuxtjs/i18n integration. Either verify the generated sitemap output or correct the comment.
[NIT] app/components/AppHeader.vue:64 - The / divider is added between AppQuickLinks and AppLanguageSwitcher, but AppQuickLinks already renders its own / separators. Check the rendered spacing at sm and lg breakpoints.
VERDICT: REQUEST_CHANGES
[0m
> build · claude-haiku-5-5
[0m→ [0mRead .pr-review-diff.patch
> build · claude-haiku-5-5
[BLOCKER] app/components/AppNav.vue:4 - The Overview link uses a plain `<NuxtLink to="/">`. With `@nuxtjs/i18n` and the default `prefix_except_default` strategy, that path points at the English root, so clicking "Overview" on `/de`, `/es`, `/it`, or `/pl` drops the user back to English. The `aria-current="page"` is also hardcoded. Fix: use `<NuxtLinkLocale to="/">` or `:to="localePath('/')"`, and set `aria-current` from the route, not as a constant. I haven't checked the route setup or the module's NuxtLink behaviour in this repo, so verify on a non-English page before merging.
[WARN] i18n/locales/en.json:12 - The English footer text was changed from "Served from my own server · k8s · Terraform · self-healing on purpose" to drop "self-healing on purpose". This is an unrequested content change that also propagates to every locale. If it's not intended, restore it in `en.json` and in the other four locale files.
[WARN] app/components/AppLanguageSwitcher.vue:42 - The toggle button's `aria-label` replaces its visible text, so screen readers hear only "Language" and never the current locale. The button also uses `aria-haspopup="true"` with a plain `<ul>` that isn't a menu, and it never moves focus into or out of the list. Fix: drop the `aria-label` in favour of a visible label such as `Language: EN`, use `aria-haspopup="listbox"` with proper roles, or make the list a real menu with focus management.
[WARN] app/components/AppFlag.vue:29 - The final `v-else` renders the Polish flag for any unknown `code`. Any locale added later without a matching branch would silently show the wrong flag. Fix: make the fallback explicit, for example with a `v-else` that renders nothing or a neutral placeholder, or type-narrow `code` so an unknown value is a compile error.
[NIT] nuxt.config.ts:332 - The comment says the config provides "per-locale sitemaps", but nothing in this diff configures sitemaps. That relies on implicit `@nuxtjs/seo` / `@nuxtjs/i18n` integration. Either verify the generated sitemap output or correct the comment.
[NIT] app/components/AppHeader.vue:64 - The `/` divider is added between `AppQuickLinks` and `AppLanguageSwitcher`, but `AppQuickLinks` already renders its own `/` separators. Check the rendered spacing at `sm` and `lg` breakpoints.
VERDICT: REQUEST_CHANGES
AppNav, AppLogo and AppBottomNav used NuxtLink to "/", which resolves to the English root under prefix_except_default; they now use NuxtLinkLocale and drop the hardcoded aria-current. Bottom-nav labels go through $t as well. The switcher's accessible name now contains the visible locale code, aria-haspopup is gone in favour of a plain disclosure with aria-controls, and Escape returns focus to the trigger.
build · claude-haiku-5-5
[0m→ [0mRead .pr-review-diff.patch
build · claude-haiku-5-5
[0m✱ [0mGlob "app/{pages,layouts,app.vue}*" [90min . · 1 match[0m
build · claude-haiku-5-5
[WARN] app/components/AppNav.vue:2 - The breakpoint change leaves a gap. AppBottomNav is hidden at md: and up, but this nav now shows only at lg: and up, so 768–1023px has no site navigation. Fix: keep md:flex here, or move the bottom nav to lg:hidden.
[WARN] nuxt.config.ts:60 - @nuxtjs/i18n enables browser-language detection by default. That redirects / based on Accept-Language and sets a cookie. Crawlers and cached / responses can get the wrong locale, and it conflicts with the hreflang/sitemap goal stated in the config comment. Fix: set detectBrowserLanguage: false unless the redirect is intentional. If it is intentional, document it and check the Vary header.
[WARN] i18n/locales/en.json:12 (same change in de, es, it, pl footers) - The English footer drops "· self-healing on purpose" from the original copy. This is an unrequested content change. Fix: restore the original text in each locale, translated where needed.
[WARN] app/app.vue (routing, unverified) - The repo has no app/pages/, so there are no route-level pages for /de, /es, /it, or /pl. NuxtLinkLocale and setLocale may not change the URL or produce distinct, crawlable URLs. Fix: confirm that switching locale updates the path and renders on SSR for each prefix. If not, add the pages or drop the URL-based locale strategy.
[WARN] app/components/AppLanguageSwitcher.vue:49 - aria-controls points to a ul that does not exist while the menu is closed. The menu also stays open when focus leaves it with Tab, since only outside clicks and Escape close it. Fix: add a focusout handler that closes the menu when focus moves outside root, and set aria-controls only while open.
[NIT] app/components/AppLogo.vue:25 - "Im using Arch btw" is still hardcoded, so the i18n coverage is incomplete.
[NIT] app/components/AppFlag.vue:29 - The final v-else renders the Polish flag for any unknown code. Use an explicit pl branch and a fallback that does not show a real country flag.
VERDICT: APPROVE
[0m
> build · claude-haiku-5-5
[0m→ [0mRead .pr-review-diff.patch
> build · claude-haiku-5-5
[0m✱ [0mGlob "app/{pages,layouts,app.vue}*" [90min . · 1 match[0m
> build · claude-haiku-5-5
[WARN] app/components/AppNav.vue:2 - The breakpoint change leaves a gap. `AppBottomNav` is hidden at `md:` and up, but this nav now shows only at `lg:` and up, so 768–1023px has no site navigation. Fix: keep `md:flex` here, or move the bottom nav to `lg:hidden`.
[WARN] nuxt.config.ts:60 - `@nuxtjs/i18n` enables browser-language detection by default. That redirects `/` based on `Accept-Language` and sets a cookie. Crawlers and cached `/` responses can get the wrong locale, and it conflicts with the hreflang/sitemap goal stated in the config comment. Fix: set `detectBrowserLanguage: false` unless the redirect is intentional. If it is intentional, document it and check the `Vary` header.
[WARN] i18n/locales/en.json:12 (same change in de, es, it, pl footers) - The English footer drops "· self-healing on purpose" from the original copy. This is an unrequested content change. Fix: restore the original text in each locale, translated where needed.
[WARN] app/app.vue (routing, unverified) - The repo has no `app/pages/`, so there are no route-level pages for `/de`, `/es`, `/it`, or `/pl`. `NuxtLinkLocale` and `setLocale` may not change the URL or produce distinct, crawlable URLs. Fix: confirm that switching locale updates the path and renders on SSR for each prefix. If not, add the pages or drop the URL-based locale strategy.
[WARN] app/components/AppLanguageSwitcher.vue:49 - `aria-controls` points to a `ul` that does not exist while the menu is closed. The menu also stays open when focus leaves it with Tab, since only outside clicks and Escape close it. Fix: add a `focusout` handler that closes the menu when focus moves outside `root`, and set `aria-controls` only while `open`.
[NIT] app/components/AppLogo.vue:25 - "Im using Arch btw" is still hardcoded, so the i18n coverage is incomplete.
[NIT] app/components/AppFlag.vue:29 - The final `v-else` renders the Polish flag for any unknown code. Use an explicit `pl` branch and a fallback that does not show a real country flag.
VERDICT: APPROVE
Noel
merged commit ce941cad2d into main2026-10-23 20:40:17 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Locale files in i18n/locales for en, de, es, it and pl; English stays at / and the others are prefixed. One flag dropdown after the GitHub link on desktop, logo plus the language button on phones. Nav, quick links and footer strings go through $t, and the footer line drops "self-healing on purpose".
[0m
[WARN] app/components/AppNav.vue:2 -
md:flexwas changed tolg:flex, so the nav is now hidden from 768px to 1023px with no mobile fallback. Tablet users lose the nav links. Restoremd:flexand adjust the header layout atmd, or add a menu toggle for smaller viewports.[WARN] i18n/locales/en.json:238 - The English footer dropped "self-healing on purpose" from the original string. This is an unintended content change on the default locale. Restore the original text: "Served from my own server · k8s · Terraform · self-healing on purpose". Then decide whether the other locales need the same clause.
[WARN] pnpm-lock.yaml (not in patch) -
@nuxtjs/i18nis added topackage.json, but the patch contains no lockfile change. The workspace lockfile already references it, so the PR may be missing the lock update or the lock may be out of sync with the base. Confirm thatpnpm-lock.yamlis committed in this PR. Otherwisepnpm install --frozen-lockfilein CI will fail.[WARN] nuxt.config.ts:326-335 - No
strategyordetectBrowserLanguageis set, so the module defaults apply. Those defaults can add locale-prefixed routes and cookie-based redirects that were not reviewed. SetstrategyanddetectBrowserLanguageexplicitly, and addhreflang/seosettings if SEO matters for this CV site.[NIT] app/components/AppLanguageSwitcher.vue:117 -
aria-labelreplaces the visible text (the locale code) with "Language". This violates WCAG 2.5.3 label-in-name. Usearia-labelthat includes the visible code, or drop it and rely on the visible text.[NIT] app/components/AppLanguageSwitcher.vue:115 -
aria-haspopup="true"implies a menu, but the list has norole="menu"/menuitemand no arrow-key navigation. Focus also does not return to the trigger on Escape. Either usearia-haspopup="listbox"-style semantics with full keyboard support, or keep the disclosure pattern and droparia-haspopup.[NIT] app/components/AppLanguageSwitcher.vue:94-102 - Document-level listeners are attached on every mount. Consider VueUse's
onClickOutside/onKeyStroketo reduce boilerplate and handle cleanup automatically.VERDICT: APPROVE
[0m
[WARN] i18n/locales/en.json:12 - The English footer text was changed from "Served from my own server · k8s · Terraform · self-healing on purpose" to drop "self-healing on purpose". This is an unrequested content change that also propagates to every locale. If it's not intended, restore it in
en.jsonand in the other four locale files.[WARN] app/components/AppLanguageSwitcher.vue:42 - The toggle button's
aria-labelreplaces its visible text, so screen readers hear only "Language" and never the current locale. The button also usesaria-haspopup="true"with a plain<ul>that isn't a menu, and it never moves focus into or out of the list. Fix: drop thearia-labelin favour of a visible label such asLanguage: EN, usearia-haspopup="listbox"with proper roles, or make the list a real menu with focus management.[WARN] app/components/AppFlag.vue:29 - The final
v-elserenders the Polish flag for any unknowncode. Any locale added later without a matching branch would silently show the wrong flag. Fix: make the fallback explicit, for example with av-elsethat renders nothing or a neutral placeholder, or type-narrowcodeso an unknown value is a compile error.[NIT] nuxt.config.ts:332 - The comment says the config provides "per-locale sitemaps", but nothing in this diff configures sitemaps. That relies on implicit
@nuxtjs/seo/@nuxtjs/i18nintegration. Either verify the generated sitemap output or correct the comment.[NIT] app/components/AppHeader.vue:64 - The
/divider is added betweenAppQuickLinksandAppLanguageSwitcher, butAppQuickLinksalready renders its own/separators. Check the rendered spacing atsmandlgbreakpoints.VERDICT: REQUEST_CHANGES
[0m
[WARN] nuxt.config.ts:60 -
@nuxtjs/i18nenables browser-language detection by default. That redirects/based onAccept-Languageand sets a cookie. Crawlers and cached/responses can get the wrong locale, and it conflicts with the hreflang/sitemap goal stated in the config comment. Fix: setdetectBrowserLanguage: falseunless the redirect is intentional. If it is intentional, document it and check theVaryheader.[WARN] i18n/locales/en.json:12 (same change in de, es, it, pl footers) - The English footer drops "· self-healing on purpose" from the original copy. This is an unrequested content change. Fix: restore the original text in each locale, translated where needed.
[WARN] app/app.vue (routing, unverified) - The repo has no
app/pages/, so there are no route-level pages for/de,/es,/it, or/pl.NuxtLinkLocaleandsetLocalemay not change the URL or produce distinct, crawlable URLs. Fix: confirm that switching locale updates the path and renders on SSR for each prefix. If not, add the pages or drop the URL-based locale strategy.[WARN] app/components/AppLanguageSwitcher.vue:49 -
aria-controlspoints to aulthat does not exist while the menu is closed. The menu also stays open when focus leaves it with Tab, since only outside clicks and Escape close it. Fix: add afocusouthandler that closes the menu when focus moves outsideroot, and setaria-controlsonly whileopen.[NIT] app/components/AppLogo.vue:25 - "Im using Arch btw" is still hardcoded, so the i18n coverage is incomplete.
[NIT] app/components/AppFlag.vue:29 - The final
v-elserenders the Polish flag for any unknown code. Use an explicitplbranch and a fallback that does not show a real country flag.VERDICT: APPROVE