build · deepseek-v4-pro
[0m→ [0mRead .pr-review-diff.patch
build · deepseek-v4-pro
[0m→ [0mRead .pr-review-diff.patch [90m[offset=80][0m
build · deepseek-v4-pro
[BLOCKER] .pre-commit-config.yaml:63 - entry: bash -c 'pnpm exec eslint --fix' is broken. pre-commit (system hooks) appends staged filenames as args, but bash -c 'cmd' assigns the first filename to $0 and discards the rest — eslint receives zero file arguments. Consequences: (1) eslint lints the entire repo instead of staged files, contradicting the hook's stated purpose ("only staged files are linted (fast)"); (2) --fix silently rewrites files that are not part of your commit — pre-commit only detects modifications to files it passed, so unstaged fixes slip into your working tree unnoticed and get swept into the next unrelated commit; (3) lint errors in other people's unstaged WIP block your commit. Fix: entry: pnpm exec eslint --fix (pre-commit passes filenames directly, no shell) or entry: bash -c 'pnpm exec eslint --fix "$@"' --.
[NIT] .pre-commit-config.yaml:66 - types: [file] matches every file type, making it redundant alongside the files regex; drop it (or use real tags like types: [javascript]) so intent is clear.
[NIT] .pre-commit-config.yaml:69 - Even with the entry fixed, --fix will cause pre-commit to abort commits with "files were modified by this hook" whenever a fix is applied, forcing a re-stage loop on every autofixable commit. Consider leaving --fix out and letting CI lint, or document the re-stage workflow.
Otherwise the diff is a single new .pre-commit-config.yaml; pinning, stages, and file regexes are correct.
VERDICT: REQUEST_CHANGES
[0m
> build · deepseek-v4-pro
[0m→ [0mRead .pr-review-diff.patch
> build · deepseek-v4-pro
[0m→ [0mRead .pr-review-diff.patch [90m[offset=80][0m
> build · deepseek-v4-pro
[BLOCKER] .pre-commit-config.yaml:63 - `entry: bash -c 'pnpm exec eslint --fix'` is broken. pre-commit (system hooks) appends staged filenames as args, but `bash -c 'cmd'` assigns the first filename to `$0` and discards the rest — eslint receives zero file arguments. Consequences: (1) eslint lints the entire repo instead of staged files, contradicting the hook's stated purpose ("only staged files are linted (fast)"); (2) `--fix` silently rewrites files that are not part of your commit — pre-commit only detects modifications to files it passed, so unstaged fixes slip into your working tree unnoticed and get swept into the next unrelated commit; (3) lint errors in other people's unstaged WIP block your commit. Fix: `entry: pnpm exec eslint --fix` (pre-commit passes filenames directly, no shell) or `entry: bash -c 'pnpm exec eslint --fix "$@"' --`.
[NIT] .pre-commit-config.yaml:66 - `types: [file]` matches every file type, making it redundant alongside the `files` regex; drop it (or use real tags like `types: [javascript]`) so intent is clear.
[NIT] .pre-commit-config.yaml:69 - Even with the entry fixed, `--fix` will cause pre-commit to abort commits with "files were modified by this hook" whenever a fix is applied, forcing a re-stage loop on every autofixable commit. Consider leaving `--fix` out and letting CI lint, or document the re-stage workflow.
Otherwise the diff is a single new `.pre-commit-config.yaml`; pinning, stages, and file regexes are correct.
VERDICT: REQUEST_CHANGES
Validated from review comment 82 on this PR: the 'bash -c' wrapper
consumed the first staged filename as $0 and the command never
referenced $@, so eslint received zero file arguments and linted the
whole repo - --fix silently rewrote unstaged files and WIP lint errors
blocked unrelated commits. The entry now receives filenames directly
from pre-commit (empirically verified with an arg probe); documented
the re-stage loop for --fix and dropped the redundant 'types: [file]'
filter.
Noel
merged commit f13fc7668c into main2026-10-18 17:25:59 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
merge-conflict markers, large files, private keys
release-please always sees releaseable messages
[0m
[NIT] .pre-commit-config.yaml:66 -
types: [file]matches every file type, making it redundant alongside thefilesregex; drop it (or use real tags liketypes: [javascript]) so intent is clear.[NIT] .pre-commit-config.yaml:69 - Even with the entry fixed,
--fixwill cause pre-commit to abort commits with "files were modified by this hook" whenever a fix is applied, forcing a re-stage loop on every autofixable commit. Consider leaving--fixout and letting CI lint, or document the re-stage workflow.Otherwise the diff is a single new
.pre-commit-config.yaml; pinning, stages, and file regexes are correct.VERDICT: REQUEST_CHANGES