Files
CV_Site_Nuxt/OKF_Nuxt/log.md
T
Noel Sabia eebd6ca697
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m6s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
PR Check / AI code review (opencode) (pull_request) Successful in 48s
fix(ci): publish on a dedicated runner label, immutable version tags
The review's blocker was real: runs-on: ubuntu-latest is the label
pr-checker.yml uses, and the job needs a runner-wide Docker socket, so the
only working configuration violated the trust boundary in the decision
doc. The job now runs on a dedicated 'publish' label that only a second
act_runner registration (docker_host: automount) may carry.

Version tags are now immutable: before building, the registry v2 API is
asked for manifests/<version> and 200 aborts the run. docker manifest
inspect cannot do this job - the pinned Debian 20.10 client fails on OCI
indexes for existing and missing tags alike (measured).

Also: the smoke test requires a rendered body (10 kB floor) on top of the
2xx, .github/actionlint.yaml declares the custom label, and the actionlint
hook passes that config explicitly because this repo keeps workflows in
.gitea/workflows, where actionlint does not auto-discover it.
2026-10-24 19:24:47 +02:00

13 KiB

Update Log

2026-10-24 (release publishes an image)

  • Creation: publish-image.yml - a vX.Y.Z tag push builds Dockerfile on the arm64 runner and pushes registry.noelsabia.dev/cv_website/nuxt as the version and sha-<12>, plus latest when that tag is the newest release. Main pushes deliberately do not build: the registry holds releases, not commits. The job uses the runner's own Docker daemon (client only in the node:22-bookworm container), so the act_runner needs container.docker_host: automount; the first step fails with that cause if it is missing. That socket is root-equivalent, so it may only sit on a label PR jobs cannot use - recorded under the trust boundary in Publishing images to the own registry. Repo secrets: REGISTRY_USERNAME, REGISTRY_PASSWORD.
  • Review follow-up (PR #19, 1 BLOCKER + 4 WARN + 2 NIT): applied the strict vMAJOR.MINOR.PATCH check, the newest-release rule for latest, a smoke test that starts the image and requires 2xx on /, and timeout-minutes: 20. Rejected with evidence: the .dockerignore leak (.env*, *.pem, .git are excluded) and the Docker-client/daemon API mismatch (20.10.24 client against a 29.9.2 daemon built successfully over the socket).
  • Second review follow-up (PR #19): the job now runs on the dedicated publish label instead of ubuntu-latest, so the host socket it needs can never be shared with PR jobs - the earlier version required a runner configuration its own trust boundary forbade. Added the immutability guard (registry v2 manifests/<version>: 200 aborts, 404 continues) after measuring that docker manifest inspect fails on OCI indexes with the pinned 20.10 client; the smoke test now also requires a rendered body (10 kB floor) rather than a bare 2xx. .github/actionlint.yaml declares the custom label, and the hook passes it with -config-file because this repo keeps workflows in .gitea/.

2026-10-23 (PR #16 review checked, three findings applied)

  • Update: pr-checker.yml - the review prompt now states that pnpm-lock.yaml is excluded from .pr-review-diff.patch on purpose. The reviewer read the exclusion as an uncommitted lockfile and raised a false BLOCKER; the lockfile is in the PR and matches package.json.
  • Fix: scripts/generate-favicon.mjs - BACKGROUND = null now writes alpha 0 instead of opaque black, matching the transparency the comment promises. The committed icons are unchanged (regenerated byte-identical).
  • Update: deleted public/_robots.txt - unreferenced leftover from the rename; @nuxtjs/seo writes robots.txt itself.

2026-10-23 (Nuxt SEO configured, static OG card)

  • Decision: Recorded SEO stack and site metadata - @nuxtjs/seo 6.0.1 registered; site and schemaOrg.identity (Person) read site.config.mjs; canonical, sitemap, robots and social tags need no per-page setup. ogImage: false and skewProtection: false because the card is a committed PNG and the site deploys as static files.
  • Update: public/og-image.png (1200x630) and og-image.alt.txt generated from the pixel avatar and the site metadata by pnpm og-image (scripts/generate-og-image.mjs; needs woff2_decompress + rsvg-convert, output committed). SEO Utils emits og:image, twitter:image and their dimensions/alt automatically.
  • Detail: app/pages/index.vue sets the title to Noel Sabia — <role> and twitter:card: summary_large_image; useHead({ titleTemplate: '%s' }) removes the | Noel Sabia suffix SEO Utils would add. theme-color is #031428.
  • Detail: engines.node is ^22.22.3 || ^24.15.0 || >=26.0.0, the floor @nuxtjs/seo 6 enforces. Verified nuxt build and nuxt generate: canonical is https://noelsabia.dev/, sitemap has one URL, robots allows crawling and names the sitemap, schema graph carries the Person node, and all SEO assets return 200.

2026-10-23 (generated pixel favicon)

  • Update: public/favicon.svg and public/favicon.ico are generated from the header's pixel avatar by pnpm favicon (scripts/generate-favicon.mjs). No image library: the ICO is an uncompressed 32bpp BMP in a one-image ICO container (4.2 kB) and the SVG merges same-coloured cells into per-row runs (3.7 kB); a 256px render of both matches.
  • Update: app/utils/avatar.js now holds the palette and the 32x32 sprite as the single source, imported by AppLogo.vue and by the generator (plain JS, so Node can import it without a loader). app.head.link declares the SVG first and the ICO as the 32x32 fallback.
  • Detail: the icon keeps the header chip colour #1b2b3f as its background so the portrait stays readable on a dark tab bar; BACKGROUND = null in the generator makes it transparent.

2026-10-23 (icons from Nuxt Icon, icon webfont removed)

  • Decision: Recorded Icons via Nuxt Icon - all icons come from @nuxt/icon with @iconify-json/material-symbols installed locally, mode: 'svg', serverBundle: { collections: [] }, clientBundle: { scan: true }. Deleted public/fonts/material-symbols-outlined-var.woff2 (3.9 MiB), its @font-face and the .material-symbols-outlined class in app/assets/css/main.css. Build reports 3 icons, 1.23 kB; SSR HTML carries the inline <svg>.
  • Update: The module's defaults would have called api.iconify.design at runtime (mode: css, fallbackToApi: true), which the local collection avoids; serverBundle: 'auto' would have bundled the whole set as an 8 MB server chunk.

2026-10-20 (cheaper review model, cached installs, merged checks)

  • Update: pr-checker.yml - the review model is now opencode-go/claude-haiku-5-5#medium: cheap per token and, unlike deepseek-v4.1-flash, it has a real #medium effort level (flash exposes only low/high/max). ESLint and typecheck are merged into one checks job with a single pnpm install, and the pnpm store plus the opencode binary are restored with actions/cache@v4.1.0 (v1 cache API, so it also works on a v1-only runner). Cache keys are built from sha256sum pnpm-lock.yaml, the pnpm store layout (v11) and the opencode version in shell steps, because hashFiles() evaluates empty in this act runner. See AI review setup and PR pipeline layering.

2026-10-20 (first flash review validated, two findings applied)

  • Update: PR #14 review (flash model, VERDICT: APPROVE) was fact-checked finding by finding. Applied: <NuxtRouteAnnouncer /> restored in app.vue (this PR's diff had dropped it with the NuxtWelcome swap), and the review job now requires github.event_name == 'pull_request' (manual dispatch - the new snyk trigger - would otherwise launch a paid review with no PR to post to). Rejected with evidence: the reviewer's postcss-selector-parser 6.1.5 override suggestion - the 6.1.5 backport exists on npm, but the blocking audit still flags it (<7.1.6 covers 6.x), verified empirically; 7.1.6 stays. Deferred as design decisions: mobile nav, aria-current via NuxtLink, sprite-to-SVG, font fallback stacks, borderRadius.full token, the fall-endpoint budget in the API contract.

2026-10-20 (snyk pause made actionlint-clean)

  • Update: pr-checker.yml - the paused snyk job's if: false (flagged by actionlint as a constant condition once this PR touched the workflow file) became if: github.event_name == 'workflow_dispatch' plus a workflow_dispatch: trigger. Same pause semantics (snyk paused) - pushes/PRs burn no credits; the job is now runnable manually instead of dead code.

2026-10-20 (review model switched to flash after endpoint outage)

  • Update: open questions - the review-model question is decided: opencode-go/deepseek-v4.1-flash#max in pr-checker.yml. The deepseek-v4-pro#max endpoint answered two consecutive runs with Upstream request failed: Endpoint is unavailable (runs 67 and 68 on PR #14, ~10 min apart, model still listed active) - the recorded default ("switch to flash") was applied.

2026-10-20 (blocking audit catches the tailwind dep, first override)

  • Update: vulnerability audit policy - the first PR run after adding @nuxtjs/tailwindcss failed the blocking audit on GHSA-rj75-hqrm-r3gf (moderate: postcss-selector-parser < 7.1.6, quadratic flat-selector parsing, pulled in by tailwindcss 3.4.19 → postcss-nested 6.2.0). Fixed per policy with the first overrides entry in pnpm-workspace.yaml, pinning 7.1.6 (already in the tree via postcss-nesting, build verified, audit green except the two reviewed highs). Same run: AI review job failed transiently (Upstream request failed: Endpoint is unavailable on opencode-go/deepseek-v4-pro#max; the model is still listed active, so retry on next push - the model-switch question stays open in open questions).

2026-10-20 (frontend API contract)

  • Creation: Added backend endpoints - the smallest endpoint set the UI needs: GET /api/health (footer dot, SYS_STABLE), GET /api/chapters (terminal rows; counters computed client-side), and the later POST /api/fall/{chapter} and SSE GET /api/events, with polling-first as the deliberately simple start.

2026-10-19 (pipeline improvement backlog)

  • Creation: Added future updates - five candidate improvements from Anthropic's code-review post (build job, PR intent input, no-repeat re-review, PR template, reviewer eval set), with effort estimates, batching advice for the review budget, and the list of scale-dependent machinery deliberately not adopted.

2026-10-19 (stale anonymous volume aborts pnpm)

  • Update: Dev container shape — the anonymous-volume remedy docker compose up --build -V moved from "not verified" to evidence (build, volume renewal, server ready in 2.62s). New failure mode recorded: after the mounted manifests drift from the volume's snapshot, pnpm 11's pre-run check wants to purge node_modules and aborts without a TTY (ERR_PNPM_ABORTED_REMOVE_MODULES_DIR_NO_TTY). Fix: CI: "true" in the compose service.

2026-10-18 (evening — release PR unblocked)

  • Decision: Recorded the production image shape - multi-stage, digest-pinned node:26-slim, non-root, healthchecked runnable Node server. Built and served locally: HTTP 200, uid 1000, healthcheck healthy. This decides the question that had kept Dockerfile empty (and failing the droast job with DF071).
  • Decision: Recorded the vulnerability audit policy - blocking audit with two reviewed ignores (node-forge, braces: no patched release exists; both build-time-only paths under nitropack). Learned en route: pnpm 11 ignores the pnpm field in package.json - settings live in pnpm-workspace.yaml.
  • Update: Added both decisions to the decisions index.

2026-10-18 (later — CI/CD and releases)

  • Creation: Recorded the PR pipeline layering — three layers (pre-commit, Gitea Actions, AI review), the cost rule that assigns checks to layers, and the failure modes the pipeline was designed against.
  • Creation: Recorded the AI review setup: the opencode-go provider prefix (the wrong one failed every run with "Insufficient account funds"), the v2 installer (v1 cannot resolve model variants), env-only auth after the prompt-injection finding, the read-only permission set, and the verdict line as the posting gate.
  • Creation: Recorded release engineering: release-please in manifest mode, plain v-tags, the version field requirement, and why conventional commits are enforced at commit time.
  • Creation: Recorded Snyk paused and secrets policy: quota-paused job kept in the workflow, and the write:issue scope requirement for all workflow tokens (learned from a 403 that named its missing scope).
  • Update: Rewrote index to group Docker-era and CI-era decisions and added a one-paragraph history.

2026-10-18