fix(ci): gate the ai review to pull_request events, restore route announcer
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Canceled after 27s
PR Check / Typecheck (pull_request) Canceled after 0s
PR Check / Secret scan (gitleaks) (pull_request) Canceled after 0s
PR Check / Dependency audit (pull_request) Canceled after 0s
PR Check / Dockerfile lint (droast) (pull_request) Canceled after 0s
PR Check / AI code review (opencode) (pull_request) Canceled after 0s
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Canceled after 27s
PR Check / Typecheck (pull_request) Canceled after 0s
PR Check / Secret scan (gitleaks) (pull_request) Canceled after 0s
PR Check / Dependency audit (pull_request) Canceled after 0s
PR Check / Dockerfile lint (droast) (pull_request) Canceled after 0s
PR Check / AI code review (opencode) (pull_request) Canceled after 0s
This commit is contained in:
1 parent
9b0f89ef38
commit
9be62982a4
3 files changed
+9
-2
No files matched your search
@@ -1,5 +1,8 @@
|
||||
# Update Log
|
||||
|
||||
## 2026-10-20 (first flash review validated, two findings applied)
|
||||
* **Update**: PR #14 review (flash model, `VERDICT: APPROVE`) was fact-checked finding by finding. Applied: `<NuxtRouteAnnouncer />` restored in `app.vue` (this PR's diff had dropped it with the NuxtWelcome swap), and the review job now requires `github.event_name == 'pull_request'` (manual dispatch - the new snyk trigger - would otherwise launch a paid review with no PR to post to). Rejected with evidence: the reviewer's `postcss-selector-parser` 6.1.5 override suggestion - the 6.1.5 backport exists on npm, but the blocking audit still flags it (`<7.1.6` covers 6.x), verified empirically; 7.1.6 stays. Deferred as design decisions: mobile nav, aria-current via NuxtLink, sprite-to-SVG, font fallback stacks, `borderRadius.full` token, the fall-endpoint budget in the API contract.
|
||||
|
||||
## 2026-10-20 (snyk pause made actionlint-clean)
|
||||
* **Update**: pr-checker.yml - the paused snyk job's `if: false` (flagged by actionlint as a constant condition once this PR touched the workflow file) became `if: github.event_name == 'workflow_dispatch'` plus a `workflow_dispatch:` trigger. Same pause semantics ([snyk paused](decisions/snyk-paused-and-secrets-policy.md)) - pushes/PRs burn no credits; the job is now runnable manually instead of dead code.
|
||||
|
||||
|
||||
Reference in new issue
Block a user