fix(ci): gate the ai review to pull_request events, restore route announcer
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Canceled after 27s
PR Check / Typecheck (pull_request) Canceled after 0s
PR Check / Secret scan (gitleaks) (pull_request) Canceled after 0s
PR Check / Dependency audit (pull_request) Canceled after 0s
PR Check / Dockerfile lint (droast) (pull_request) Canceled after 0s
PR Check / AI code review (opencode) (pull_request) Canceled after 0s

This commit is contained in:
Noel Sabia committed 2026-10-20 20:46:43 +02:00
1 parent 9b0f89ef38
commit 9be62982a4
3 files changed
+9 -2

No files matched your search

+5 -2
View File
@@ -224,8 +224,11 @@ jobs:
name: AI code review (opencode) name: AI code review (opencode)
runs-on: ubuntu-latest runs-on: ubuntu-latest
container: node:22-bookworm container: node:22-bookworm
# Draft PRs don't get a (paid) review yet # Draft PRs don't get a (paid) review yet. The event_name check is
if: ${{ !github.event.pull_request.draft }} # load-bearing: manual (workflow_dispatch) triggers - which exist to
# run the paused snyk job - must NOT launch a paid review, which on
# a dispatch event has no PR to post to.
if: ${{ github.event_name == 'pull_request' && !github.event.pull_request.draft }}
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
with: with:
+3
View File
@@ -1,5 +1,8 @@
# Update Log # Update Log
## 2026-10-20 (first flash review validated, two findings applied)
* **Update**: PR #14 review (flash model, `VERDICT: APPROVE`) was fact-checked finding by finding. Applied: `<NuxtRouteAnnouncer />` restored in `app.vue` (this PR's diff had dropped it with the NuxtWelcome swap), and the review job now requires `github.event_name == 'pull_request'` (manual dispatch - the new snyk trigger - would otherwise launch a paid review with no PR to post to). Rejected with evidence: the reviewer's `postcss-selector-parser` 6.1.5 override suggestion - the 6.1.5 backport exists on npm, but the blocking audit still flags it (`<7.1.6` covers 6.x), verified empirically; 7.1.6 stays. Deferred as design decisions: mobile nav, aria-current via NuxtLink, sprite-to-SVG, font fallback stacks, `borderRadius.full` token, the fall-endpoint budget in the API contract.
## 2026-10-20 (snyk pause made actionlint-clean) ## 2026-10-20 (snyk pause made actionlint-clean)
* **Update**: pr-checker.yml - the paused snyk job's `if: false` (flagged by actionlint as a constant condition once this PR touched the workflow file) became `if: github.event_name == 'workflow_dispatch'` plus a `workflow_dispatch:` trigger. Same pause semantics ([snyk paused](decisions/snyk-paused-and-secrets-policy.md)) - pushes/PRs burn no credits; the job is now runnable manually instead of dead code. * **Update**: pr-checker.yml - the paused snyk job's `if: false` (flagged by actionlint as a constant condition once this PR touched the workflow file) became `if: github.event_name == 'workflow_dispatch'` plus a `workflow_dispatch:` trigger. Same pause semantics ([snyk paused](decisions/snyk-paused-and-secrets-policy.md)) - pushes/PRs burn no credits; the job is now runnable manually instead of dead code.
+1
View File
@@ -1,4 +1,5 @@
<template> <template>
<NuxtRouteAnnouncer />
<NuxtLayout> <NuxtLayout>
<NuxtPage /> <NuxtPage />
</NuxtLayout> </NuxtLayout>