Commit Graph
31 Commits
Author SHA1 Message Date
Noel Sabia ad4e8d7bd9 fix(ci): tell the reviewer the lockfile is excluded on purpose
The diff filter drops pnpm-lock.yaml to keep the patch small; the model read
that as an uncommitted lockfile and raised a BLOCKER on PR #16. Say so in the
prompt instead of widening the diff.
2026-10-23 21:50:17 +02:00
Noel Sabia fa8fafb7ef ci: use cheaper review model and cache pipeline installs
PR Check / Lint + typecheck (pull_request) Successful in 1m42s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / AI code review (opencode) (pull_request) Successful in 45s
- review model: opencode-go/claude-haiku-5-5#medium instead of
  deepseek-v4.1-flash#max; flash has no medium variant
- merge lint and typecheck into one job with a single pnpm install
- cache the pnpm store and opencode binary via actions/cache@v4.1.0,
  keyed on a sha256 of the lockfile (hashFiles is empty on this runner)
- update the decision records and log
2026-10-20 20:56:52 +02:00
Noel Sabia 9be62982a4 fix(ci): gate the ai review to pull_request events, restore route announcer
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Canceled after 27s
PR Check / Typecheck (pull_request) Canceled after 0s
PR Check / Secret scan (gitleaks) (pull_request) Canceled after 0s
PR Check / Dependency audit (pull_request) Canceled after 0s
PR Check / Dockerfile lint (droast) (pull_request) Canceled after 0s
PR Check / AI code review (opencode) (pull_request) Canceled after 0s
2026-10-20 20:46:43 +02:00
Noel Sabia 9b0f89ef38 fix(ci): switch review model to deepseek-v4.1-flash, pause snyk via workflow_dispatch
PR Check / AI code review (opencode) (pull_request) Successful in 5m12s
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 36s
PR Check / Typecheck (pull_request) Successful in 44s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
2026-10-20 20:36:54 +02:00
Noel Sabia 3e68e630df fix(ci): close the fail-open gate, enforce read-only sandbox
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 35s
PR Check / Typecheck (pull_request) Canceled after 21s
PR Check / Secret scan (gitleaks) (pull_request) Canceled after 0s
PR Check / Dependency audit (pull_request) Canceled after 0s
PR Check / Dockerfile lint (droast) (pull_request) Canceled after 0s
PR Check / AI code review (opencode) (pull_request) Canceled after 0s
Findings validated from review comments 71 and 75:

- [BLOCKER] the no-verdict branch exited \${EXIT_CODE:-1} which is 0
  when opencode succeeded without a verdict - job went green and the
  post step published non-review output. The else branch now exits 1
  unconditionally, the verdict is anchored to the last five lines (the
  prompt itself contains VERDICT lines), and the post step re-verifies
  the contract before posting.
- [BLOCKER] the v1 'permission' object is ignored by the opencode v2
  CLI - shell commands executed in both review runs despite deny. The
  config now uses the v2 'permissions' array with 'shell' as the
  action name, denying edit/shell/webfetch/websearch/external_directory.
- hygiene: droast linting prunes node_modules, audit comment names the
  exact key to re-add, shell blocks verified with sh -n.
2026-10-18 18:24:06 +02:00
Noel Sabia a3e6aef901 fix(ci): apply review findings round two
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 36s
PR Check / Typecheck (pull_request) Successful in 39s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Failing after 9s
PR Check / Dockerfile lint (droast) (pull_request) Failing after 5s
PR Check / AI code review (opencode) (pull_request) Successful in 4m17s
- droast: chmod +x was lost in the checksum rewrite (would have
  failed with exit 126); checksums now pinned in the workflow
  instead of trust-on-first-use
- permission config migrated to the OpenCode v2 schema (permissions
  array, bash renamed shell, websearch and external_directory denied)
- posting gate is now the output contract (verdict line present)
  instead of the exit code: opencode can exit 1 on benign tool
  denials after a completed review
- find -print -quit instead of piping into head (SIGPIPE, exit 141)
- audit comment now says to re-add continue-on-error
2026-10-18 18:01:13 +02:00
Noel Sabia 85f488a94d fix(ci): address AI review findings (credentials, supply chain)
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 33s
PR Check / Typecheck (pull_request) Successful in 38s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 5s
PR Check / Dependency audit (pull_request) Failing after 9s
PR Check / Dockerfile lint (droast) (pull_request) Failing after 4s
PR Check / AI code review (opencode) (pull_request) Failing after 3m9s
- [BLOCKER] remove opencode.json from the checkout: it held the API
  key in plaintext, readable by the review agent, and a malicious PR
  diff could prompt-inject the agent into quoting it in the publicly
  visible review comment. Env-only auth (verified headless). The
  permission config moves to $HOME/.config/opencode - outside the
  checkout and secret-free.
- [WARN] verify the droast binary against the publisher's
  sha256sums.txt of the same pinned release
- [WARN] pin the opencode v2 installer to 2.0.32

Findings validated with the validate-pr-review skill; findings 4/5
are moot with the blocker fix.
2026-10-18 17:54:06 +02:00
Noel Sabia f8d128705f fix(ci): deny write tools, never swallow review errors
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 34s
PR Check / Typecheck (pull_request) Successful in 37s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Failing after 8s
PR Check / Dockerfile lint (droast) (pull_request) Failing after 4s
PR Check / AI code review (opencode) (pull_request) Successful in 3m9s
- deny edit/bash/webfetch in the generated opencode.json: headless
  permission prompts are the most likely cause of the review agent
  working silently for minutes and then dying; denying write tools
  also makes the reviewer provably read-only
- capture the exit code without triggering 'set -e' ('|| EXIT_CODE=$?')
  so the captured output is always printed before failing - the
  previous version aborted before 'cat' and produced silent failures
2026-10-18 17:34:17 +02:00
Noel Sabia 783c9ccda3 fix(ci): install opencode v2 for the review job
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 34s
PR Check / Typecheck (pull_request) Successful in 37s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Failing after 8s
PR Check / Dockerfile lint (droast) (pull_request) Failing after 4s
PR Check / AI code review (opencode) (pull_request) Failing after 2m43s
The classic installer (opencode.ai/install) ships only OpenCode 1.x
- v1.19.3 on arm64 - which cannot resolve model variants and failed
with ProviderModelNotFoundError for deepseek-v4-pro#max. Use the v2
installer (currently v2.0.32, same version as local dev); verified
working in a fresh arm64 container with key-only auth.
2026-10-18 17:18:54 +02:00
Noel Sabia cf6f209ebf fix(ci): make droast job actually run
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 35s
PR Check / Typecheck (pull_request) Successful in 37s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 5s
PR Check / Dependency audit (pull_request) Failing after 9s
PR Check / Dockerfile lint (droast) (pull_request) Failing after 5s
PR Check / AI code review (opencode) (pull_request) Failing after 12s
The dockerfile-lint job skipped on every PR despite Dockerfiles
existing: the act runner's hashFiles() evaluation returned empty.
Replace it with an explicit file-discovery step. Also run the droast
binary in node:22-bookworm (arch-aware install) instead of the
vendor image, which ships no node and would fail actions/checkout
with exit 127 - same failure mode as the gitleaks image.
2026-10-18 17:11:31 +02:00
Noel Sabia 5f1d64db90 ci: bind opencode API key explicitly via opencode.json
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Typecheck (pull_request) Successful in 37s
PR Check / ESLint (pull_request) Successful in 35s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Failing after 9s
PR Check / AI code review (opencode) (pull_request) Failing after 11s
The headless CI container has no stored credentials, so auth depends
entirely on the injected key. Generate an opencode.json at runtime
that binds OPENCODE_API_KEY to the opencode-go provider explicitly,
removing any dependence on env-var-to-provider mapping behavior.
2026-10-18 17:08:46 +02:00
Noel Sabia a6761fae9a ci: make dependency audit blocking, log opencode errors
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 34s
PR Check / Typecheck (pull_request) Successful in 37s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 5s
PR Check / Dependency audit (pull_request) Failing after 8s
PR Check / AI code review (opencode) (pull_request) Failing after 13s
- audit no longer runs with continue-on-error: a failed audit must
  turn the pipeline red, not pass silently
- opencode review runs with --print-logs so auth and provider errors
  (e.g. invalid API key vs missing Go subscription) appear in the job
  log instead of an opaque exit 1
2026-10-18 17:04:15 +02:00
Noel Sabia 8f36f14720 fix: remove leftover merge conflict marker from pr-checker.yml
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 35s
PR Check / Typecheck (pull_request) Successful in 37s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 8s
PR Check / AI code review (opencode) (pull_request) Failing after 11s
2026-10-18 16:58:10 +02:00
Noel Sabia 066bcec47c merge: resolve pr-checker.yml in favour of opencode-go plan model
pr-checker.yml (push) Invalid workflow file
main changed the review model to the default thinking budget; keep
opencode-go/deepseek-v4-pro#max (plan-included, max effort) which
supersedes both earlier variants.
2026-10-18 16:57:46 +02:00
Noel Sabia 8b6bcb6d70 fix(ci): use opencode-go plan model for AI review
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 34s
PR Check / Typecheck (pull_request) Successful in 38s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 5s
PR Check / Dependency audit (pull_request) Successful in 8s
PR Check / AI code review (opencode) (pull_request) Failing after 13s
The 'opencode' provider prefix points at OpenCode Zen (pay-per-call,
no funds), which failed every review run with 'Insufficient account
funds'. The opencode-go $10 plan covers deepseek-v4-pro with high
and max variants - use opencode-go/deepseek-v4-pro#max.
2026-10-18 16:53:16 +02:00
Noel Sabia 7d508a5d9a ci: use deepseek-v4-pro at default thinking budget
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 34s
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / Typecheck (pull_request) Successful in 39s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 5s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / AI code review (opencode) (pull_request) Failing after 1m20s
#max exceeded the available opencode account funds; the default
thinking budget keeps the flagship model at lower cost. #max remains
available by re-adding the variant.
2026-10-18 16:38:01 +02:00
Noel Sabia 16b9291a51 fix(ci): hand review diff to agent as file, not argv
PR Check / ESLint (pull_request) Successful in 35s
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Typecheck (pull_request) Successful in 38s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 5s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / AI code review (opencode) (pull_request) Failing after 11s
Passing the PR diff as a command-line argument exceeded
MAX_ARG_STRLEN (128KiB per single argument; the diff was 190KB,
mostly pnpm-lock.yaml). The shell failed with E2BIG ('Argument list
too long') and the tee pipeline masked the failure, so the raw error
log got posted as a 'review' comment.

- exclude pnpm-lock.yaml from the review diff (pnpm audit covers deps)
- write the diff to .pr-review-diff.patch in the workspace; the agent
  reads it with file tools
- redirect output instead of piping through tee and fail the job when
  opencode fails, so errors are never posted as review comments
2026-10-18 16:25:30 +02:00
Noel Sabia 99f6e28ad0 ci: max-effort DeepSeek review with Nuxt/Go-specific prompt
PR Check / AI code review (opencode) (pull_request) Successful in 7s
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 34s
PR Check / Typecheck (pull_request) Successful in 37s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 5s
PR Check / Dependency audit (pull_request) Successful in 8s
- model: opencode/deepseek-v4-pro#max (requires funds on the opencode
  account; flash fallback documented in a comment)
- review prompt rewritten: SSR/hydration/reactivity pitfalls, Nuxt
  server-route security, runtime config leaks, Go error handling,
  concurrency and resource hygiene, frontend/backend contract checks
- strict output format with [BLOCKER]/[WARN]/[NIT] severities mapped
  to the approve/request-changes verdict
2026-10-18 16:22:26 +02:00
Noel Sabia 3204fab323 ci: disable Snyk (free plan quota), log comment-post errors
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 34s
PR Check / Typecheck (pull_request) Successful in 38s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / AI code review (opencode) (pull_request) Successful in 7s
- Snyk job disabled via 'if: false': free plan only has ~100 test
  credits/month and the job runs 2 tests per PR push
- PR comment step no longer fails silently: curl prints the HTTP
  status and response body, making token/URL errors visible
2026-10-18 16:12:05 +02:00
Noel Sabia a061fad9b1 fix(ci): JSON-encode review with node instead of jq
PR Check / Security scan (Snyk) (pull_request) Failing after 32s
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 34s
PR Check / Typecheck (pull_request) Successful in 37s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 5s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / AI code review (opencode) (pull_request) Successful in 8s
The node:22-bookworm image does not ship jq. Also use the renamed
PR_GITEA_TOKEN secret.
2026-10-18 16:08:39 +02:00
Noel Sabia 34d9577322 ci: replace Snyk docker scan with Snyk Code SAST scan
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 34s
PR Check / Typecheck (pull_request) Successful in 39s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 8s
PR Check / Security scan (Snyk) (pull_request) Failing after 43s
PR Check / AI code review (opencode) (pull_request) Successful in 7s
Dockerfile linting is already covered by the droast job; the second
Snyk step now scans our own source for code vulnerabilities (XSS,
injection, unsafe patterns) instead of the base image.
2026-10-18 16:02:18 +02:00
Noel Sabia 7197f757a6 fix(ci): pass --all-projects to snyk test
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 35s
PR Check / Typecheck (pull_request) Successful in 38s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Security scan (Snyk) (pull_request) Failing after 29s
PR Check / AI code review (opencode) (pull_request) Canceled after 8s
The pnpm-workspace.yaml makes Snyk treat the project as a package
workspace; without --all-projects it aborts with SNYK-CLI-0000
(422 Unprocessable Entity).
2026-10-18 16:00:08 +02:00
Noel Sabia 8d2a00062e fix(ci): run Snyk CLI via npm on arm64 runner
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 35s
PR Check / Typecheck (pull_request) Successful in 37s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 8s
PR Check / Security scan (Snyk) (pull_request) Failing after 35s
PR Check / AI code review (opencode) (pull_request) Successful in 8s
The snyk/snyk:node image is amd64-only and cannot start on an arm64
runner. Install the Snyk CLI through npm (supports linux/arm64) in
the multi-arch node:22-bookworm image instead.
2026-10-18 15:56:27 +02:00
Noel Sabia affd17f068 ci: switch AI review to deepseek-v4-pro
PR Check / ESLint (pull_request) Successful in 34s
PR Check / Typecheck (pull_request) Successful in 37s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 5s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Security scan (Snyk) (pull_request) Failing after 1s
PR Check / AI code review (opencode) (pull_request) Successful in 7s
PR Check / Dockerfile lint (droast) (pull_request) Skipped
Replace anthropic/claude-sonnet-4-5 with opencode/deepseek-v4-pro for
a large cost reduction while keeping thorough, high-effort reviews.
Documented cheaper fallback: deepseek-v4.1-flash(-free).
2026-10-18 15:54:38 +02:00
Noel Sabia 390538f2e8 ci: log runner architecture in gitleaks install step
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 34s
PR Check / Typecheck (pull_request) Successful in 39s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 5s
PR Check / Dependency audit (pull_request) Successful in 8s
PR Check / Security scan (Snyk) (pull_request) Failing after 1s
PR Check / AI code review (opencode) (pull_request) Successful in 8s
2026-10-18 15:50:53 +02:00
Noel Sabia 88dadd5846 fix(ci): pick gitleaks binary by CPU architecture
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 34s
PR Check / Typecheck (pull_request) Successful in 38s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 5s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Security scan (Snyk) (pull_request) Failing after 1s
PR Check / AI code review (opencode) (pull_request) Successful in 7s
The runner is arm64; the hardcoded x64 binary failed with 'Exec
format error'. Resolve the arch at runtime (x86_64/aarch64).
2026-10-18 15:47:50 +02:00
Noel Sabia 779cf20f45 fix(ci): run gitleaks as binary in node image
PR Check / Typecheck (pull_request) Successful in 40s
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 37s
PR Check / Secret scan (gitleaks) (pull_request) Failing after 4s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Security scan (Snyk) (pull_request) Failing after 1s
PR Check / AI code review (opencode) (pull_request) Successful in 7s
The gitleaks container image ships no node binary, so node-based
actions like actions/checkout fail with exit code 127. Install the
gitleaks v8.28.0 binary in the standard node:22-bookworm image
instead.
2026-10-18 15:44:45 +02:00
Noel Sabia ce9c090a15 fix(ci): pull gitleaks from GHCR and pin version
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / Typecheck (pull_request) Successful in 38s
PR Check / Secret scan (gitleaks) (pull_request) Failing after 5s
PR Check / Dependency audit (pull_request) Successful in 8s
PR Check / Security scan (Snyk) (pull_request) Failing after 1s
PR Check / ESLint (pull_request) Successful in 35s
PR Check / AI code review (opencode) (pull_request) Successful in 7s
gitleaks is not published on Docker Hub, so the container image pull
failed with 'pull access denied'. Use ghcr.io/gitleaks/gitleaks and
pin v8.28.0 for reproducible scans.
2026-10-18 15:42:40 +02:00
Noel Sabia ecd0192466 fix(ci): use pnpm 11 in runner
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 36s
PR Check / Typecheck (pull_request) Successful in 39s
PR Check / Secret scan (gitleaks) (pull_request) Failing after 1s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Security scan (Snyk) (pull_request) Failing after 1s
PR Check / AI code review (opencode) (pull_request) Successful in 8s
pnpm 9 treats the config-only pnpm-workspace.yaml (allowBuilds, no
packages field) as a workspace definition and fails with 'packages
field missing or empty'. Pin the same major version as local dev.
2026-10-18 15:39:35 +02:00
Noel Sabia bb13f1a187 fix(ci): run app jobs from repo root
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / ESLint (pull_request) Failing after 7s
PR Check / Typecheck (pull_request) Failing after 7s
PR Check / Secret scan (gitleaks) (pull_request) Failing after 1s
PR Check / Dependency audit (pull_request) Successful in 7s
PR Check / Security scan (Snyk) (pull_request) Failing after 1s
PR Check / AI code review (opencode) (pull_request) Successful in 7s
The Gitea repo CV_Website/CV_Site_Nuxt checks out to a workspace that
already is the app root, so working-directory CV_Site_Nuxt resolved to
a doubled, non-existent path.
2026-10-18 15:37:21 +02:00
Noel Sabia 1d9da87986 ci: add PR checker workflow
Runs on every pull request:
- ESLint and vue-tsc typecheck
- gitleaks secret scan over full history
- pnpm dependency audit (advisory)
- droast Dockerfile lint (skips until a Dockerfile exists)
- Snyk dependency and base image scan
- opencode AI code review posted as PR comment
2026-10-18 15:16:12 +02:00