- AppBottomNav: fixed bar below md with Overview, Life Map and Dev View
- default.vue mounts it and carries pb-16 md:pb-0 so the footer stays clear
- AppFooter is hidden below md, where the bar takes over
- icons come from @nuxt/icon (mode svg, scanned client bundle) with the
Material Symbols collection installed locally, replacing the webfont
- deletes the 3.9 MiB Material Symbols woff2 and its @font-face
- decisions/icons-via-nuxt-icon.md: local collection, mode svg,
serverBundle collections empty, scanned client bundle; 3 icons, 1.23 kB
- linked from the bundle index and the decisions index, logged
- generate favicon.ico and favicon.svg from the header avatar; the sprite
moves to app/utils/avatar.js so component and generators share one source
- register @nuxtjs/seo with site and Person schema.org data from
site.config.mjs; canonical, robots, sitemap and llms.txt follow the routes
- title "Noel Sabia — <role>", summary_large_image, and no duplicate
"| Noel Sabia" suffix from SEO Utils
- add a committed 1200x630 OG card generated by pnpm og-image; the dynamic
OG renderer and skew protection stay off for the static deployment
- pin the Node version @nuxtjs/seo 6 requires and document the setup in the
OKF bundle
build · claude-haiku-5-5
[0m→ [0mRead .pr-review-diff.patch
build · claude-haiku-5-5
[0m→ [0mRead app/components/AppFooter.vue
[0m✱ [0mGrep "material-symbols|Material Symbols|@nuxtjs/seo|frozen-lockfile|NUXT_SITE_ENV" [90min . · 50 matches[0m
build · claude-haiku-5-5
[0m✱ [0mGrep "material-symbols-outlined|@nuxtjs/seo@|@nuxt/icon@" [90min . · 4 matches[0m
build · claude-haiku-5-5
[BLOCKER-GENERAL] pnpm-lock.yaml - package.json adds @nuxt/icon, @nuxtjs/seo and @iconify-json/material-symbols, but the patch has no lockfile hunk. The working-tree lockfile does contain these entries, so either it was left uncommitted or the diff is incomplete. Dockerfile.dev runs pnpm install --frozen-lockfile, so the build fails or drifts without it. Commit the regenerated lockfile in this PR.
[WARN] pnpm-workspace.yaml:36 - minimumReleaseAgeExclude for @nuxt/icon@2.6.0 bypasses the release-age quarantine, which exists to delay newly published (possibly compromised) versions. Also, @nuxt/icon is pinned exactly while the other packages use ^. Wait out the age window, or verify provenance and document why, then remove the exclusion.
[WARN] nuxt.config.ts:11 - site.url is hardcoded to production. Any staging or preview build emits production canonical URLs and is indexable unless NUXT_SITE_ENV is set, and nothing in the diff sets it. Derive the URL from an env var, or disallow indexing by default outside production.
[WARN] app/components/AppBottomNav.vue:9 - aria-current="page" is hardcoded on Overview and shows on every route. Compute it from useRoute().
[WARN] app/components/AppBottomNav.vue:16,23 - The "Life Map" and "Dev View" links are href="#" placeholders that ship to production as dead navigation. Hide them or mark them aria-disabled until the routes exist.
[WARN] app/components/AppFooter.vue:2 - hidden md:block removes the footer, including the location link and status line, from mobile entirely. Keep it visible on small screens and only add bottom padding for the nav.
[WARN] scripts/generate-favicon.mjs:75-78 - BACKGROUND = null is documented as producing a transparent icon. The ICO writer falls back to '#000000' and always writes alpha 0xff, so the output is an opaque black square. Write alpha 0 for null cells and set the matching AND-mask bits.
[WARN] public/_robots.txt - The rename makes this file publicly reachable at /_robots.txt. If the SEO module generates /robots.txt itself, the file is dead. Confirm that /robots.txt is the module output, then delete the file.
[NIT] nuxt.config.ts:32 - schemaOrg.identity.email puts the email in JSON-LD on every page, which makes it easy to harvest. This is probably intentional for a CV, so confirm it.
[NIT] scripts/generate-og-image.mjs:95,114 - The current year in the card makes the committed PNG non-reproducible. The alt-text quote is duplicated from the card text, and SITE.* values are interpolated into SVG without XML escaping. Use one constant and escape the values.
VERDICT: REQUEST_CHANGES
[0m
> build · claude-haiku-5-5
[0m→ [0mRead .pr-review-diff.patch
> build · claude-haiku-5-5
[0m→ [0mRead app/components/AppFooter.vue
[0m✱ [0mGrep "material-symbols|Material Symbols|@nuxtjs/seo|frozen-lockfile|NUXT_SITE_ENV" [90min . · 50 matches[0m
> build · claude-haiku-5-5
[0m✱ [0mGrep "material-symbols-outlined|@nuxtjs/seo@|@nuxt/icon@" [90min . · 4 matches[0m
> build · claude-haiku-5-5
[BLOCKER-GENERAL] pnpm-lock.yaml - `package.json` adds `@nuxt/icon`, `@nuxtjs/seo` and `@iconify-json/material-symbols`, but the patch has no lockfile hunk. The working-tree lockfile does contain these entries, so either it was left uncommitted or the diff is incomplete. `Dockerfile.dev` runs `pnpm install --frozen-lockfile`, so the build fails or drifts without it. Commit the regenerated lockfile in this PR.
[WARN] pnpm-workspace.yaml:36 - `minimumReleaseAgeExclude` for `@nuxt/icon@2.6.0` bypasses the release-age quarantine, which exists to delay newly published (possibly compromised) versions. Also, `@nuxt/icon` is pinned exactly while the other packages use `^`. Wait out the age window, or verify provenance and document why, then remove the exclusion.
[WARN] nuxt.config.ts:11 - `site.url` is hardcoded to production. Any staging or preview build emits production canonical URLs and is indexable unless `NUXT_SITE_ENV` is set, and nothing in the diff sets it. Derive the URL from an env var, or disallow indexing by default outside production.
[WARN] app/components/AppBottomNav.vue:9 - `aria-current="page"` is hardcoded on Overview and shows on every route. Compute it from `useRoute()`.
[WARN] app/components/AppBottomNav.vue:16,23 - The "Life Map" and "Dev View" links are `href="#"` placeholders that ship to production as dead navigation. Hide them or mark them `aria-disabled` until the routes exist.
[WARN] app/components/AppFooter.vue:2 - `hidden md:block` removes the footer, including the location link and status line, from mobile entirely. Keep it visible on small screens and only add bottom padding for the nav.
[WARN] scripts/generate-favicon.mjs:75-78 - `BACKGROUND = null` is documented as producing a transparent icon. The ICO writer falls back to `'#000000'` and always writes alpha `0xff`, so the output is an opaque black square. Write alpha 0 for null cells and set the matching AND-mask bits.
[WARN] public/_robots.txt - The rename makes this file publicly reachable at `/_robots.txt`. If the SEO module generates `/robots.txt` itself, the file is dead. Confirm that `/robots.txt` is the module output, then delete the file.
[NIT] nuxt.config.ts:32 - `schemaOrg.identity.email` puts the email in JSON-LD on every page, which makes it easy to harvest. This is probably intentional for a CV, so confirm it.
[NIT] scripts/generate-og-image.mjs:95,114 - The current year in the card makes the committed PNG non-reproducible. The alt-text quote is duplicated from the card text, and `SITE.*` values are interpolated into SVG without XML escaping. Use one constant and escape the values.
VERDICT: REQUEST_CHANGES
The diff filter drops pnpm-lock.yaml to keep the patch small; the model read
that as an uncommitted lockfile and raised a BLOCKER on PR #16. Say so in the
prompt instead of widening the diff.
build · claude-haiku-5-5
[0m→ [0mRead .pr-review-diff.patch
build · claude-haiku-5-5
[0m→ [0mRead app/components/AppFooter.vue
[0m✗ [0mGrep "remote|fallbackToApi" failed
[91m[1mError: [0mSearch path does not exist: /workspace/CV_Website/CV_Site_Nuxt/node_modules/@nuxt/icon
build · claude-haiku-5-5
No blocking defects in the changed code. The findings below are warnings and nits, and most of them need a quick check before merge.
[WARN] .gitea/workflows/pr-checker.yml:341-346 - This PR edits the AI reviewer's own prompt to permanently exclude lockfile and frozen-install findings, so future PRs lose that check too. Scope the exclusion to this PR, or move the lockfile handling into the diff generator so the gate's instructions don't change with each PR.
[WARN] pnpm-workspace.yaml:36 - minimumReleaseAgeExclude now bypasses the release-age cooldown for @nuxt/icon@2.6.0, a freshly published version. Document why the exception is needed, or wait until the version clears the cooldown. The exact pin and the lockfile limit the blast radius, but the cooldown exists to catch new releases.
[WARN] nuxt.config.ts:551-558 - serverBundle: { collections: [] } may still let SSR fall back to api.iconify.design for icons missing from the bundle. That is the third-party runtime dependency the decision doc says this change avoids. I could not confirm the default remote behaviour because node_modules/@nuxt/icon is not installed here. Check the @nuxt/icon 2.6.0 docs for a remote: 'none' option and add it if it exists.
[WARN] app/components/AppBottomNav.vue:318, 325 - "Life Map" and "Dev View" are href="#" placeholders that render as links going nowhere. aria-current="page" is hardcoded on Overview and will be wrong once other routes exist. Render the placeholders as non-link elements with aria-disabled until their routes exist, and derive aria-current from useRoute().
[WARN] nuxt.config.ts:529 and the NUXT_SITE_ENV note in the SEO decision doc - site.url is hardcoded to production, so a staging build emits production canonical URLs. The doc says staging must set NUXT_SITE_ENV=staging to block indexing, but nothing in this diff sets that variable. Confirm the Docker and CI config sets it, or the staging deployment can get indexed.
[WARN] app/components/AppFooter.vue:2 - hidden md:block removes the footer, including the location link, on mobile, and the new bottom nav does not replace it. Keep the footer visible on mobile (the pb-16 on the layout already reserves room for the nav), or move the location link into the nav.
[NIT] scripts/generate-og-image.mjs:927 - new Date().getUTCFullYear() makes the committed card change on the next regeneration after a year boundary. Hardcode the year or derive it from SITE.
[NIT] nuxt.config.ts:541-549 - The email address is published in the Person JSON-LD. That is probably intended for a CV, but it is an easy scraping target.
VERDICT: APPROVE
[0m
> build · claude-haiku-5-5
[0m→ [0mRead .pr-review-diff.patch
> build · claude-haiku-5-5
[0m→ [0mRead app/components/AppFooter.vue
[0m✗ [0mGrep "remote|fallbackToApi" failed
[91m[1mError: [0mSearch path does not exist: /workspace/CV_Website/CV_Site_Nuxt/node_modules/@nuxt/icon
> build · claude-haiku-5-5
No blocking defects in the changed code. The findings below are warnings and nits, and most of them need a quick check before merge.
[WARN] .gitea/workflows/pr-checker.yml:341-346 - This PR edits the AI reviewer's own prompt to permanently exclude lockfile and frozen-install findings, so future PRs lose that check too. Scope the exclusion to this PR, or move the lockfile handling into the diff generator so the gate's instructions don't change with each PR.
[WARN] pnpm-workspace.yaml:36 - `minimumReleaseAgeExclude` now bypasses the release-age cooldown for `@nuxt/icon@2.6.0`, a freshly published version. Document why the exception is needed, or wait until the version clears the cooldown. The exact pin and the lockfile limit the blast radius, but the cooldown exists to catch new releases.
[WARN] nuxt.config.ts:551-558 - `serverBundle: { collections: [] }` may still let SSR fall back to `api.iconify.design` for icons missing from the bundle. That is the third-party runtime dependency the decision doc says this change avoids. I could not confirm the default remote behaviour because `node_modules/@nuxt/icon` is not installed here. Check the `@nuxt/icon` 2.6.0 docs for a `remote: 'none'` option and add it if it exists.
[WARN] app/components/AppBottomNav.vue:318, 325 - "Life Map" and "Dev View" are `href="#"` placeholders that render as links going nowhere. `aria-current="page"` is hardcoded on Overview and will be wrong once other routes exist. Render the placeholders as non-link elements with `aria-disabled` until their routes exist, and derive `aria-current` from `useRoute()`.
[WARN] nuxt.config.ts:529 and the `NUXT_SITE_ENV` note in the SEO decision doc - `site.url` is hardcoded to production, so a staging build emits production canonical URLs. The doc says staging must set `NUXT_SITE_ENV=staging` to block indexing, but nothing in this diff sets that variable. Confirm the Docker and CI config sets it, or the staging deployment can get indexed.
[WARN] app/components/AppFooter.vue:2 - `hidden md:block` removes the footer, including the location link, on mobile, and the new bottom nav does not replace it. Keep the footer visible on mobile (the `pb-16` on the layout already reserves room for the nav), or move the location link into the nav.
[NIT] scripts/generate-og-image.mjs:927 - `new Date().getUTCFullYear()` makes the committed card change on the next regeneration after a year boundary. Hardcode the year or derive it from `SITE`.
[NIT] nuxt.config.ts:541-549 - The email address is published in the Person JSON-LD. That is probably intended for a CV, but it is an easy scraping target.
VERDICT: APPROVE
Noel
merged commit 9b7222dd4d into main2026-10-23 19:53:14 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
[0m
[WARN] pnpm-workspace.yaml:36 -
minimumReleaseAgeExcludefor@nuxt/icon@2.6.0bypasses the release-age quarantine, which exists to delay newly published (possibly compromised) versions. Also,@nuxt/iconis pinned exactly while the other packages use^. Wait out the age window, or verify provenance and document why, then remove the exclusion.[WARN] nuxt.config.ts:11 -
site.urlis hardcoded to production. Any staging or preview build emits production canonical URLs and is indexable unlessNUXT_SITE_ENVis set, and nothing in the diff sets it. Derive the URL from an env var, or disallow indexing by default outside production.[WARN] app/components/AppBottomNav.vue:9 -
aria-current="page"is hardcoded on Overview and shows on every route. Compute it fromuseRoute().[WARN] app/components/AppBottomNav.vue:16,23 - The "Life Map" and "Dev View" links are
href="#"placeholders that ship to production as dead navigation. Hide them or mark themaria-disableduntil the routes exist.[WARN] app/components/AppFooter.vue:2 -
hidden md:blockremoves the footer, including the location link and status line, from mobile entirely. Keep it visible on small screens and only add bottom padding for the nav.[WARN] scripts/generate-favicon.mjs:75-78 -
BACKGROUND = nullis documented as producing a transparent icon. The ICO writer falls back to'#000000'and always writes alpha0xff, so the output is an opaque black square. Write alpha 0 for null cells and set the matching AND-mask bits.[WARN] public/_robots.txt - The rename makes this file publicly reachable at
/_robots.txt. If the SEO module generates/robots.txtitself, the file is dead. Confirm that/robots.txtis the module output, then delete the file.[NIT] nuxt.config.ts:32 -
schemaOrg.identity.emailputs the email in JSON-LD on every page, which makes it easy to harvest. This is probably intentional for a CV, so confirm it.[NIT] scripts/generate-og-image.mjs:95,114 - The current year in the card makes the committed PNG non-reproducible. The alt-text quote is duplicated from the card text, and
SITE.*values are interpolated into SVG without XML escaping. Use one constant and escape the values.VERDICT: REQUEST_CHANGES
[0m
[WARN] .gitea/workflows/pr-checker.yml:341-346 - This PR edits the AI reviewer's own prompt to permanently exclude lockfile and frozen-install findings, so future PRs lose that check too. Scope the exclusion to this PR, or move the lockfile handling into the diff generator so the gate's instructions don't change with each PR.
[WARN] pnpm-workspace.yaml:36 -
minimumReleaseAgeExcludenow bypasses the release-age cooldown for@nuxt/icon@2.6.0, a freshly published version. Document why the exception is needed, or wait until the version clears the cooldown. The exact pin and the lockfile limit the blast radius, but the cooldown exists to catch new releases.[WARN] nuxt.config.ts:551-558 -
serverBundle: { collections: [] }may still let SSR fall back toapi.iconify.designfor icons missing from the bundle. That is the third-party runtime dependency the decision doc says this change avoids. I could not confirm the default remote behaviour becausenode_modules/@nuxt/iconis not installed here. Check the@nuxt/icon2.6.0 docs for aremote: 'none'option and add it if it exists.[WARN] app/components/AppBottomNav.vue:318, 325 - "Life Map" and "Dev View" are
href="#"placeholders that render as links going nowhere.aria-current="page"is hardcoded on Overview and will be wrong once other routes exist. Render the placeholders as non-link elements witharia-disableduntil their routes exist, and derivearia-currentfromuseRoute().[WARN] nuxt.config.ts:529 and the
NUXT_SITE_ENVnote in the SEO decision doc -site.urlis hardcoded to production, so a staging build emits production canonical URLs. The doc says staging must setNUXT_SITE_ENV=stagingto block indexing, but nothing in this diff sets that variable. Confirm the Docker and CI config sets it, or the staging deployment can get indexed.[WARN] app/components/AppFooter.vue:2 -
hidden md:blockremoves the footer, including the location link, on mobile, and the new bottom nav does not replace it. Keep the footer visible on mobile (thepb-16on the layout already reserves room for the nav), or move the location link into the nav.[NIT] scripts/generate-og-image.mjs:927 -
new Date().getUTCFullYear()makes the committed card change on the next regeneration after a year boundary. Hardcode the year or derive it fromSITE.[NIT] nuxt.config.ts:541-549 - The email address is published in the Person JSON-LD. That is probably intended for a CV, but it is an easy scraping target.
VERDICT: APPROVE