Compare commits

..
3 Commits
Author SHA1 Message Date
Noel Sabia b1a2eae48a chore: drop the unused public/_robots.txt
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m3s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 4s
PR Check / AI code review (opencode) (pull_request) Successful in 55s
@nuxtjs/seo writes robots.txt; the renamed copy was only reachable at
/_robots.txt and referenced nowhere.
2026-10-23 21:50:17 +02:00
Noel Sabia 2f9f236f13 fix(favicon): keep the ICO transparent when BACKGROUND is null
The documented null option fell through to opaque black: the BGRA writer
defaulted to #000000 and hardcoded alpha 0xff.
2026-10-23 21:50:17 +02:00
Noel Sabia ad4e8d7bd9 fix(ci): tell the reviewer the lockfile is excluded on purpose
The diff filter drops pnpm-lock.yaml to keep the patch small; the model read
that as an uncommitted lockfile and raised a BLOCKER on PR #16. Say so in the
prompt instead of widening the diff.
2026-10-23 21:50:17 +02:00
4 changed files with 16 additions and 6 deletions

No files matched your search

+5
View File
@@ -341,6 +341,11 @@ jobs:
The full PR diff is in the file .pr-review-diff.patch in the repo
root. Read it first with your file tools.
pnpm-lock.yaml is deliberately excluded from that patch to keep it
small, not forgotten. It is committed in the PR, pnpm audit covers
the dependencies, and CI runs `pnpm install --frozen-lockfile`.
Do not report a missing lockfile or a frozen-install drift.
## Project context
- Stack: Nuxt 4 (Vue 3, TypeScript) SSR web app in the repo root.
Backend/API services are being added in Golang.
+5
View File
@@ -1,5 +1,10 @@
# Update Log
## 2026-10-23 (PR #16 review checked, three findings applied)
* **Update**: [pr-checker.yml](../.gitea/workflows/pr-checker.yml) - the review prompt now states that `pnpm-lock.yaml` is excluded from `.pr-review-diff.patch` on purpose. The reviewer read the exclusion as an uncommitted lockfile and raised a false BLOCKER; the lockfile is in the PR and matches `package.json`.
* **Fix**: `scripts/generate-favicon.mjs` - `BACKGROUND = null` now writes alpha 0 instead of opaque black, matching the transparency the comment promises. The committed icons are unchanged (regenerated byte-identical).
* **Update**: deleted `public/_robots.txt` - unreferenced leftover from the rename; `@nuxtjs/seo` writes `robots.txt` itself.
## 2026-10-23 (Nuxt SEO configured, static OG card)
* **Decision**: Recorded [SEO stack and site metadata](decisions/seo-and-metadata.md) - `@nuxtjs/seo` 6.0.1 registered; `site` and `schemaOrg.identity` (Person) read `site.config.mjs`; canonical, sitemap, robots and social tags need no per-page setup. `ogImage: false` and `skewProtection: false` because the card is a committed PNG and the site deploys as static files.
* **Update**: `public/og-image.png` (1200x630) and `og-image.alt.txt` generated from the pixel avatar and the site metadata by `pnpm og-image` (`scripts/generate-og-image.mjs`; needs `woff2_decompress` + `rsvg-convert`, output committed). SEO Utils emits `og:image`, `twitter:image` and their dimensions/alt automatically.
-2
View File
@@ -1,2 +0,0 @@
User-Agent: *
Disallow:
+6 -4
View File
@@ -67,18 +67,20 @@ const ico = () => {
bitmap.writeUInt16LE(32, 14) // bits per pixel
bitmap.writeUInt32LE(xorSize + maskSize, 20) // image size
// XOR bitmap: bottom-up rows of BGRA.
// XOR bitmap: bottom-up rows of BGRA. With a null BACKGROUND the pixel stays
// zeroed and alpha 0, which is how a 32bpp ICO carries transparency.
let offset = 40
for (let y = SIZE - 1; y >= 0; y--) {
for (let x = 0; x < SIZE; x++) {
const [r, g, b] = hex(colorAt(x, y) ?? '#000000')
const color = colorAt(x, y)
const [r, g, b] = color ? hex(color) : [0, 0, 0]
bitmap[offset++] = b
bitmap[offset++] = g
bitmap[offset++] = r
bitmap[offset++] = 0xff
bitmap[offset++] = color ? 0xff : 0
}
}
// AND mask stays zeroed: every pixel is opaque.
// AND mask stays zeroed: 32bpp readers use the alpha channel instead.
const header = Buffer.alloc(6)
header.writeUInt16LE(0, 0) // reserved