Compare commits

...
4 Commits
Author SHA1 Message Date
Noel f13fc7668c Merge pull request 'chore: add pre-commit guardrails' (#6) from feat/pre-commit-hooks into main
release-please / release-please (push) Failing after 4s
Reviewed-on: #6
2026-10-18 17:25:59 +00:00
Noel Sabia 81d658a871 fix: pass staged filenames to the eslint pre-commit hook
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 35s
PR Check / Typecheck (pull_request) Canceled after 15s
PR Check / Secret scan (gitleaks) (pull_request) Canceled after 0s
PR Check / Dependency audit (pull_request) Canceled after 0s
PR Check / Dockerfile lint (droast) (pull_request) Canceled after 0s
PR Check / AI code review (opencode) (pull_request) Canceled after 0s
Validated from review comment 82 on this PR: the 'bash -c' wrapper
consumed the first staged filename as $0 and the command never
referenced $@, so eslint received zero file arguments and linted the
whole repo - --fix silently rewrote unstaged files and WIP lint errors
blocked unrelated commits. The entry now receives filenames directly
from pre-commit (empirically verified with an arg probe); documented
the re-stage loop for --fix and dropped the redundant 'types: [file]'
filter.
2026-10-18 19:25:06 +02:00
Noel 8fa8eb63b2 Merge branch 'main' into feat/pre-commit-hooks
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 35s
PR Check / Typecheck (pull_request) Successful in 38s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 5s
PR Check / Dependency audit (pull_request) Failing after 8s
PR Check / Dockerfile lint (droast) (pull_request) Failing after 5s
PR Check / AI code review (opencode) (pull_request) Successful in 1m19s
2026-10-18 16:25:25 +00:00
Noel Sabia ab7626d5f7 chore: add pre-commit guardrails
PR Check / Dockerfile lint (droast) (pull_request) Skipped
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / ESLint (pull_request) Successful in 34s
PR Check / Typecheck (pull_request) Successful in 37s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 8s
PR Check / AI code review (opencode) (pull_request) Failing after 11s
- gitleaks: block secrets before they enter history
- pre-commit-hooks: whitespace/eof hygiene, yaml/json/toml checks,
  merge-conflict markers, large files, private keys
- commitizen (commit-msg stage): enforce conventional commits so
  release-please always sees releaseable messages
- actionlint: validate workflow files offline
- eslint --fix on staged files (local hook, needs pnpm install)
2026-10-18 18:15:44 +02:00
+81
View File
@@ -0,0 +1,81 @@
# Pre-commit guardrails — deterministic checks that run before every commit.
# Cheap things live here (seconds); slow things (typecheck, build, tests,
# Snyk, AI review) stay in CI (.gitea/workflows/pr-checker.yml).
#
# One-time setup per machine:
# pre-commit install # pre-commit stage
# pre-commit install --hook-type commit-msg # commit-msg stage (release-please!)
# pre-commit run --all-files # first full pass
#
# ARM64 + x86_64 both supported by every hook below.
repos:
# ---------------------------------------------------------------- gitleaks
# Block secrets before they enter history. CI scans history too (gitleaks
# job), but this prevents the commit from ever existing.
- repo: https://github.com/gitleaks/gitleaks
rev: v8.30.1
hooks:
- id: gitleaks
# -------------------------------------------------- basic file hygiene ---
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v6.0.0
hooks:
- id: trailing-whitespace
- id: end-of-file-fixer
- id: mixed-line-ending
args: [--fix=lf]
- id: check-yaml
- id: check-json
- id: check-toml
- id: check-merge-conflict
- id: check-added-large-files
args: [--maxkb=1024]
- id: detect-private-key
# ------------------------------------------------ conventional commits ---
# release-please silently ignores non-conventional messages, so a bad
# subject line means "no release and no idea why". This makes it
# impossible. Runs on the commit-msg stage, not pre-commit.
- repo: https://github.com/commitizen-tools/commitizen
rev: v4.19.2
hooks:
- id: commitizen
stages: [commit-msg]
# ---------------------------------------------------- workflow linting ---
# Validates .gitea/workflows syntax and ${{ }} expressions - the class of
# bug that hashFiles-skipping and broken YAML came from.
- repo: https://github.com/rhysd/actionlint
rev: v1.7.12
hooks:
- id: actionlint
files: \.gitea/workflows/.*\.ya?ml$
# --------------------------------------------------------- ESLint (Nuxt) -
# Local hook: needs `pnpm install` to have run in this repo. --fix makes
# it a helper; only staged files are linted (fast). When --fix rewrites
# a staged file, pre-commit aborts the commit ("files were modified") -
# re-stage and commit again; that re-stage loop is the standard price
# of a fixer hook.
- repo: local
hooks:
- id: eslint
name: eslint --fix (staged files)
# no shell wrapper: pre-commit appends the staged filenames to the
# entry itself. A 'bash -c' wrapper would eat the first filename
# as $0 and eslint would get no file arguments at all (linting the
# whole repo instead - review finding on this PR, empirically
# verified).
entry: pnpm exec eslint --fix
language: system
files: \.(vue|ts|js|mjs|cjs)$
# When Go services arrive, add:
# - repo: https://github.com/dnephin/pre-commit-golang
# rev: <latest>
# hooks:
# - id: go-fmt
# - id: go-imports
# - id: golangci-lint # or go-vet for a lighter pass