Compare commits

..
Author SHA1 Message Date
Noel Sabia e23f8d2618 fix(ci): remove the release-please component mismatch
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m59s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
PR #35 merged with its branch kept, but the release phase logged 'PR component: undefined does not match configured component: CV_Site_Frontend' and returned before creating the tag. With include-component-in-tag false the strategy component and release body component are empty, while getBranchComponent still returns package-name. Remove package-name so both sides are empty; the changelog headings are already version-only.

Evidence: run 181 (task 578) after #35 merged. The next run should create v1.5.0 at a80c9eb and mark #35 autorelease: tagged.
2026-10-31 20:34:49 +01:00
Noel a80c9ebf02 Merge pull request 'chore: release main' (#35) from release-please--branches--main into main
release-please / release-please (push) Successful in 27s
Publish image / Build and push image (push) Failing after 45s
Reviewed-on: #35
2026-10-31 19:31:31 +00:00
3 changed files with 37 additions and 3 deletions

No files matched your search

+31 -2
View File
@@ -152,6 +152,34 @@ Two details keep the reconciliation from suppressing a real release:
`v<manifest version>`. A CI or annotation tag on the same commit is
logged and ignored, and the release tag is still created.
# The release phase drops the PR on a component mismatch (2026-10-31)
With the branch kept and the label reconciled, PR #35 was still not
tagged. Run 181 (task 578, immediately after #35 merged) shows why:
```
❯ Found pull request #35: 'chore: release main'
...
⚠ PR component: undefined does not match configured component: CV_Site_Frontend
...
⚠ There are untagged, merged release PRs outstanding - aborting
```
`buildRelease()` compares the component parsed from the merged PR with the
strategy's component when the release body contains one component and that
component is empty. `include-component-in-tag: false` makes
`getComponent()` return an empty string, so the release PR is
`chore: release main` with an empty component and the branch is
`release-please--branches--main` (parsed component: undefined). But
`getBranchComponent()` ignores `include-component-in-tag` and returns
`package-name` - here `CV_Site_Frontend`. The two never match, so the
release is dropped before the tag is created.
The fix is to remove `package-name` from the package config. The strategy
component is then empty as well, the comparison matches, and the tag is
created. Nothing else changes: the changelog headings are already
version-only (`## [1.5.0]`), not component-prefixed.
# Recovering the versions that never got a tag
The label alone cannot recover them — #20, #21 and #22 all lost their head
@@ -176,8 +204,9 @@ whole history.
# Not verified
* That the release phase tags correctly once the head branch survives a
merge. The next release cycle proves it.
* That the release phase now tags #35 after the component fix. The previous
run (181) kept the branch but dropped the release on the component
mismatch, so the next run is the proof.
* That the reconcile step's tag-creation fallback works with a live
token. Only the tag-already-exists path was exercised, in dry-run,
against the live PR #22. The fallback is written from the same Gitea
+6
View File
@@ -1,5 +1,11 @@
# Update Log
## 2026-10-31 (release-please component mismatch: no v1.5.0 tag)
* **Fix**: [release-please-config.json](../release-please-config.json) - removed `package-name: CV_Site_Frontend`. With `include-component-in-tag: false` the strategy component and the release PR body component are empty, but `getBranchComponent()` still returned `package-name`; the release phase logged `PR component: undefined does not match configured component: CV_Site_Frontend` and returned before creating the tag. The component now matches, so the next run should tag #35.
* **Evidence**: run 181 (task 578, immediately after #35 merged) - the reconcile step correctly left #35 for the action because its branch survived, then the action found #35, hit the component mismatch and aborted with "There are untagged, merged release PRs outstanding". The earlier label/branch fixes were correct; this was the remaining check.
* **Expected result**: the run after this merge creates `v1.5.0` at the #35 merge commit (`a80c9eb`), marks #35 `autorelease: tagged`, and stops opening duplicate release PRs.
## 2026-10-31 (release-please reconcile step needs a checkout)
* **Fix**: [release-please.yml](../.gitea/workflows/release-please.yml) - added `actions/checkout@v4` before the reconcile step. The job had no checkout because the release-please action clones the repository into its own temp directory; the new step runs `scripts/reconcile-release-please.mjs` from the workspace, so the first post-merge run failed with `Cannot find module '/workspace/CV_Website/CV_Site_Nuxt/scripts/reconcile-release-please.mjs'` (task 571). The checkout supplies the file; the action still uses its own temp clone for the release branch.
-1
View File
@@ -6,7 +6,6 @@
"changelog-host": "https://git.noelsabia.dev",
"packages": {
".": {
"package-name": "CV_Site_Frontend",
"changelog-path": "CHANGELOG.md",
"extra-files": [],
"versioning": "default"