Compare commits

...
Author SHA1 Message Date
Noel Sabia 81bfae7489 ci(publish): add a manual build-only rehearsal trigger
workflow_dispatch with version/push/latest inputs: push defaults to
false, so the runner, socket and registry login can be verified without
creating a tag or a package version. latest is never moved unless asked.
2026-10-31 20:40:10 +01:00
Noel Sabia e0c69c1b77 fix(deps): unblock the dependency audit
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m7s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 8s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
Bump nuxt to 4.6.3 and override node-forge 1.4.1 and glob 14.0.2.
minimatch stays a reviewed ignore: its patch drops makeRe, which
eslint-plugin-import-x imports.

Verified locally: lint, typecheck, build, and the exact audit command.
2026-10-31 19:57:38 +01:00
7 changed files with 607 additions and 503 deletions

No files matched your search

+52 -4
View File
@@ -9,6 +9,24 @@ on:
push:
tags:
- 'v*'
# Manual rehearsal from the Gitea UI (Actions -> Publish image -> Run
# workflow). `push` defaults to false: the job builds and smoke-tests, then
# stops without publishing, so the runner can be verified without creating
# a tag or a package version. Set `push` to true (and `latest` only for a
# real release) to publish.
workflow_dispatch:
inputs:
version:
description: 'Version to build, e.g. v0.0.1 (vMAJOR.MINOR.PATCH)'
required: true
push:
description: 'Push the image to the registry'
required: false
default: 'false'
latest:
description: 'Also move :latest (real releases only)'
required: false
default: 'false'
# The runner has capacity 1, so releases already serialize. This keeps a
# manual re-run from racing a fresh release on the same tags.
@@ -72,10 +90,19 @@ jobs:
- name: Resolve version and tags
id: version
env:
# Inputs go through env, not direct interpolation: a value pasted
# into a `run:` block is shell code before any check can run.
INPUT_VERSION: ${{ github.event.inputs.version }}
INPUT_LATEST: ${{ github.event.inputs.latest }}
run: |
# GITHUB_REF_NAME is the tag on a tag push. The git fallback keeps
# this working if a runner version does not set it.
version="${GITHUB_REF_NAME:-$(git describe --tags --exact-match HEAD)}"
# On a tag push GITHUB_REF_NAME is the tag; on workflow_dispatch it
# is the BRANCH, so the manual version input must win. The git
# fallback keeps tag pushes working if a runner omits the variable.
version="$INPUT_VERSION"
if [ -z "$version" ]; then
version="${GITHUB_REF_NAME:-$(git describe --tags --exact-match HEAD)}"
fi
# Strict semver, not a `v[0-9]*` prefix match: that would accept
# `v1`, `v1-anything` and prereleases, all valid registry tags.
if ! printf '%s' "$version" | grep -qE '^v[0-9]+\.[0-9]+\.[0-9]+$'; then
@@ -91,7 +118,13 @@ jobs:
# A tag comparison needs the other tags, which a depth-1 tag
# checkout does not have. If the fetch fails, skip `latest` and
# say so - a wrong tag is worse than a missing one.
if git fetch --tags --force --quiet origin 2>/dev/null; then
#
# A manual run moves `latest` only when the `latest` input says so;
# a rehearsal must never repoint the production tag.
if [ "$INPUT_LATEST" = "true" ]; then
latest=true
echo "manual run requested :latest"
elif git fetch --tags --force --quiet origin 2>/dev/null; then
newest="$(git tag -l | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$' | sort -V | tail -n 1)"
if [ "$version" = "$newest" ]; then
latest=true
@@ -128,6 +161,9 @@ jobs:
| docker login git.noelsabia.dev -u "$REGISTRY_USERNAME" --password-stdin
- name: Refuse to overwrite a published version
# Build-only rehearsals publish nothing, so an existing tag is not a
# conflict there; the guard only protects actual pushes.
if: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.push == 'true' }}
env:
REGISTRY_USERNAME: ${{ secrets.REGISTRY_USERNAME }}
REGISTRY_PASSWORD: ${{ secrets.REGISTRY_PASSWORD }}
@@ -213,6 +249,8 @@ jobs:
run: docker tag "${IMAGE}:${VERSION}" "${IMAGE}:latest"
- name: Push image
# Manual run with `push` left at false: build and smoke test only.
if: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.push == 'true' }}
env:
VERSION: ${{ steps.version.outputs.version }}
SHA: ${{ steps.version.outputs.sha }}
@@ -228,3 +266,13 @@ jobs:
else
echo "Pushed ${IMAGE}:${VERSION}, :sha-${SHA} (:latest untouched)"
fi
- name: Rehearsal summary
if: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.push != 'true' }}
env:
VERSION: ${{ steps.version.outputs.version }}
SHA: ${{ steps.version.outputs.sha }}
run: |
echo "Build-only rehearsal for ${VERSION} (${SHA}) - the image passed the smoke test and was NOT pushed."
echo "Re-run with push=true to publish it."
+19
View File
@@ -142,6 +142,25 @@ appears in the process list or the log.
4. Namespace `cv` has an `imagePullSecret` for the same credentials.
5. `git.noelsabia.dev` answers over HTTPS.
# Manual rehearsal (workflow_dispatch)
The workflow can be started from the Gitea UI (Actions → Publish image →
Run workflow) without creating a tag:
| Input | Use |
|---|---|
| `version` | required, `vMAJOR.MINOR.PATCH` |
| `push` | `false` (default) builds and smoke-tests only; `true` publishes |
| `latest` | `false` unless this is a real release |
A build-only run publishes nothing, so it creates no package version and
the immutability guard is skipped. This is the way to prove the runner,
socket and registry login before the first release - a rehearsal must never
move `latest`, which is why that input is explicit.
Gitea only offers the Run-workflow button for workflows present on the
default branch, so this trigger is available once the change is on `main`.
# Guards in the workflow
| Guard | Why |
@@ -31,23 +31,32 @@ patched 7.1.6 was already in the tree via `postcss-nesting` and proved
API-compatible through a full build. The override is removed when
`tailwindcss` ships `>= 7.1.6` itself or the site moves to Tailwind v4.
Currently ignored (both verified against the advisory database and the npm
registries on 2026-10-18 - the newest published versions are the vulnerable
ones):
Currently ignored (verified against the advisory database and the npm
registries on 2026-10-31):
* `GHSA-86w9-cpqp-85rv` - node-forge <= 1.4.0, high. Path:
`nuxt > @nuxt/nitro-server > nitropack > listhen > node-forge` - listhen
generates dev certificates; build/dev-time only, not in the server bundle.
* `GHSA-vfj7-8cjw-p6xm` - braces <= 3.0.3, high. Path:
`nitropack > globby > micromatch > braces` - globbing during build, no
attacker-controlled patterns at runtime.
* `GHSA-g3hv-75wg-m249` - minimatch < 11.0.1, moderate. The patch
(11.0.1) dropped the `makeRe` export that `eslint-plugin-import-x`
imports, so forcing it breaks `pnpm lint` with "does not provide an
export named 'makeRe'"; it also breaks ESLint's config loader. All
affected paths are build/lint-time (Nitro, i18n, ESLint via
vite-plugin-checker), never in the running server.
The 2026-10-31 round also upgraded `nuxt` 4.6.2 -> 4.6.3 (fixes the Nuxt
dot-segment, dev-server and appSecret advisories) and added overrides for
`node-forge: 1.4.1` (the old node-forge ignore, `GHSA-86w9-cpqp-85rv`,
is gone - a patch now exists) and `glob: 14.0.2` for
`GHSA-3g3m-2fjr-6pw4` (scoped to `>=9.0.0 <=14.0.1` so
tailwind-config-viewer keeps glob 7).
# Why
A red job that can never go green trains everyone to ignore red - the same
silent-failure outcome "nothing fails silently" exists to prevent. The
ignore list is the opposite of silence: the audit still names what it
skipped ("2 ignored: 2 high") and the decision lives in a reviewable file.
skipped ("1 ignored: 1 high") and the decision lives in a reviewable file.
# The pnpm 11 lesson
+11
View File
@@ -30,6 +30,17 @@
* **Creation**: `deploy/pr-agent/` (later removed; the service now lives in the Gitea compose stack) - compose service, example environment and operator README. The real `.env` lived only at `/home/noel/self-hosted/pr-agent/.env` (mode 600) on `server0`.
* **State**: the container is running and the webhook signature path is verified. Gitea gained `[webhook] ALLOWED_HOST_LIST = private:3000` (one restart, healthy) and the repository has a signed webhook. The OpenCode Go API key was still missing at commit time, so no model call or real review has run yet.
## 2026-10-31 (manual publish rehearsal without a tag)
* **Creation**: [publish-image.yml](../.gitea/workflows/publish-image.yml) gained `workflow_dispatch` with `version`, `push` and `latest` inputs. Default is **build + smoke test only** (`push=false`): no tag, no package version, immutability guard skipped, `latest` never moved unless explicitly requested. Use it to verify the `publish` runner (socket + `automount`) before the first release. Manual runs do not replace the tag path - a published image still always maps to a release tag.
## 2026-10-31 (audit green again: nuxt 4.6.3 and dependency overrides)
* **Fix**: `pnpm audit --prod --audit-level moderate` failed on every branch (#30, #31, #33 and this PR) - new advisories plus a Nuxt patch release. `nuxt` 4.6.2 -> **4.6.3** clears GHSA-9v7c-q64q-vv33 (dot-segment middleware bypass), GHSA-3xf4-9g3c-4h4w and GHSA-x287-wcfc-q46c (dev-server file read/runtime config).
* **Fix**: [pnpm-workspace.yaml](../pnpm-workspace.yaml) - overrides for `node-forge: 1.4.1` (the old GHSA-86w9-cpqp-85rv ignore is removed - a patch exists now) and `glob@>=9.0.0 <=14.0.1: 14.0.2` (GHSA-3g3m-2fjr-6pw4; glob 7 is kept for tailwind-config-viewer).
* **Decision**: minimatch GHSA-g3hv-75wg-m249 stays a reviewed ignore. Its patch (11.0.1) dropped `makeRe`, which `eslint-plugin-import-x` imports - forcing it makes `pnpm lint` fail with "does not provide an export named 'makeRe'" (measured). All affected paths are build/lint-time. See [Vulnerability audit policy](decisions/vulnerability-audit-policy.md).
* **Verified locally**: `pnpm lint`, `pnpm typecheck`, `pnpm build` and the exact audit command all pass on the merged tree.
## 2026-10-27 (release-please still never tagged: the deleted head branch)
* **Fix**: [release-please-config.json](../release-please-config.json) gained `"changelog-host": "https://git.noelsabia.dev"` - the changelog compare links were generated against `github.com/CV_Website/CV_Site_Nuxt`, a host this repository does not live on. Root cause of the missing tags: **Gitea rewrites `head.ref` to `refs/pull/<n>/head` when the merged PR's branch is deleted**, and release-please parses that field as the release branch, so `BranchName.parse` fails and the release is dropped - silently, exit code 0. Evidence: run 143 (task 475) logs `✖ Bad branch name: refs/pull/22/head` right after `Found pull request #22`, then `Expected 1 releases, only found 0`; #22 did carry `autorelease: pending`. The repository deleted every merged branch (`default_delete_branch_after_merge: true`); it is `false` now. Four versions (1.1.0-1.4.0) were consumed by the manifest with no tag ever created, so the release baseline has to be restored by hand. See [Release engineering](decisions/release-engineering.md).
+1 -1
View File
@@ -24,7 +24,7 @@
"@nuxtjs/i18n": "10.6.0",
"@nuxtjs/seo": "6.0.1",
"@nuxtjs/tailwindcss": "6.14.0",
"nuxt": "^4.6.2",
"nuxt": "^4.6.3",
"vue": "^3.5.43",
"vue-router": "^5.4.0"
},
+485 -484
View File
File diff suppressed because it is too large. Load diff
+23 -7
View File
@@ -2,15 +2,21 @@ allowBuilds:
esbuild: true
unrs-resolver: true
auditConfig:
# Reviewed ignores for advisories with NO patched release (verified against
# the advisory database and npm registries on 2026-10-18: node-forge 1.4.0
# and braces 3.0.3 are the newest published versions). Both packages are
# build-time-only paths under nitropack (listhen dev-cert generation,
# globby file globbing) - not in the running server's bundle. Remove an
# entry when a patched version ships.
# Reviewed ignores for advisories with NO patched release, or whose patch
# is incompatible with a consumer in this tree. braces is unfixable
# (3.0.3 is still newest); minimatch's patch (11.0.1) breaks ESLint -
# both are build-time-only paths. node-forge was removed from this list
# on 2026-10-31 when 1.4.1 shipped and is now forced through `overrides`.
# Remove an entry when a compatible patched version ships.
ignoreGhsas:
- GHSA-86w9-cpqp-85rv
- GHSA-vfj7-8cjw-p6xm
# GHSA-g3hv-75wg-m249 (minimatch DoS): the patched 11.0.1 dropped the
# `makeRe` export that eslint-plugin-import-x imports, so `pnpm lint`
# fails with "does not provide an export named 'makeRe'"; forcing it
# also breaks ESLint's config loader. Affected paths are build/lint
# only (Nitro, i18n, ESLint via vite-plugin-checker), never in the
# server bundle.
- GHSA-g3hv-75wg-m249
overrides:
# Fixable advisories get the patched version forced here, not an ignore
# (audit policy: upgrade when a patch exists).
@@ -27,6 +33,16 @@ overrides:
# smallest version that clears both advisories. Remove this when Nuxt ships
# a vite-builder that resolves >= 1.6.11 itself.
seroval: 1.6.11
# GHSA-g3hv-75wg-m249 (moderate, 2026-10-31): minimatch < 11.0.1 has a
# globparts amplification DoS. Deliberately NOT overridden - see the
# auditConfig ignore note above.
# GHSA-3g3m-2fjr-6pw4 (moderate, 2026-10-31): glob 9.0.0-14.0.1 bypasses
# AbortSignal cancellation. Patched in 14.0.2; the range keeps glob 7 for
# tailwind-config-viewer.
"glob@>=9.0.0 <=14.0.1": 14.0.2
# node-forge 1.4.1 shipped (2026-10-31) and clears every node-forge
# advisory that was previously ignored - no ignore needed anymore.
node-forge: 1.4.1
minimumReleaseAgeExclude:
- '@rollup/rollup-darwin-x64@4.64.8'
- '@rollup/rollup-freebsd-arm64@4.64.8'