Compare commits
98
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
04d6c5483c | ||
|
|
e19dee90f3 | ||
|
|
2498c35072 | ||
|
|
f4a8f47121 | ||
|
|
4b29ff808f | ||
|
|
7dec3eb826 | ||
|
|
2a1cebd5cc | ||
|
|
d77f03133d | ||
|
|
28230b9551 | ||
|
|
dfb574593f | ||
|
|
c5df303c72 | ||
|
|
ce662cda9a | ||
|
|
328cf73b34 | ||
|
|
f203b2b182 | ||
|
|
da10a7b11c | ||
|
|
54ad6f056d | ||
|
|
749ae3a380 | ||
|
|
cd97b70efd | ||
|
|
47f6262619 | ||
|
|
68536910f5 | ||
|
|
f4509e752a | ||
|
|
dcb3099182 | ||
|
|
6954325c86 | ||
|
|
b786774773 | ||
|
|
0cbc0e4293 | ||
|
|
d2243a694f | ||
|
|
1cfa36f006 | ||
|
|
953fff2ce6 | ||
|
|
4d5ba1ecb1 | ||
|
|
aa89212003 | ||
|
|
0228e891cf | ||
|
|
fcbf203a85 | ||
|
|
96f4eacfae | ||
|
|
f0d45577e3 | ||
|
|
7572b4e5f6 | ||
|
|
d63360b980 | ||
|
|
a0192a6515 | ||
|
|
d76f2f54d1 | ||
|
|
068c6c41e8 | ||
|
|
f71a119f17 | ||
|
|
66cfdc1ec0 | ||
|
|
44f697f8f7 | ||
|
|
71107ad11e | ||
|
|
373dc4f677 | ||
|
|
52e05bab79 | ||
|
|
a89a19c809 | ||
|
|
023ee7fad2 | ||
|
|
2276b92268 | ||
|
|
ab20f54b86 | ||
|
|
a764a6b931 | ||
|
|
965f3bc03e | ||
|
|
466555f69c | ||
|
|
33655c034b | ||
|
|
c11a33fc1e | ||
|
|
f619e5cbec | ||
|
|
e3e0b8d28c | ||
|
|
3614bfd3ae | ||
|
|
7981575f86 | ||
|
|
d9ae9da14c | ||
|
|
a2ed208d3e | ||
|
|
1fb47dc4e1 | ||
|
|
26abef948d | ||
|
|
0268a11e14 | ||
|
|
42b07e9ab9 | ||
|
|
c8250c9ca3 | ||
|
|
fdce59d77d | ||
|
|
e23f8d2618 | ||
|
|
a80c9ebf02 | ||
|
|
b1082b52fe | ||
|
|
ac2f919bf5 | ||
|
|
90ef58a8cb | ||
|
|
06e1d24977 | ||
|
|
7ffc6d73b6 | ||
|
|
1860e88156 | ||
|
|
e0c69c1b77 | ||
|
|
c00db55f98 | ||
|
|
700b1030fc | ||
|
|
5f7027bd86 | ||
|
|
93fcd4127c | ||
|
|
e29927bef7 | ||
|
|
06508be0e0 | ||
|
|
8f4eb24e77 | ||
|
|
6dfa2c8aa6 | ||
|
|
8b7d9bce81 | ||
|
|
da28885588 | ||
|
|
723c38d2e3 | ||
|
|
636a65dd05 | ||
|
|
a43134ad83 | ||
|
|
3eac73255f | ||
|
|
b84d353dcb | ||
|
|
f5810960a8 | ||
|
|
679c0b4858 | ||
|
|
efb73378e9 | ||
|
|
a8355d976b | ||
|
|
214ec46fed | ||
|
|
c332c195a9 | ||
|
|
c626cc9c1d | ||
|
|
a129e89aec |
No files matched your search
@@ -27,7 +27,7 @@ jobs:
|
||||
runs-on: ubuntu-latest
|
||||
container: node:22-bookworm
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
- uses: actions/checkout@v7
|
||||
|
||||
- uses: pnpm/action-setup@v4
|
||||
with:
|
||||
@@ -55,7 +55,7 @@ jobs:
|
||||
# A cache outage must not turn into a red PR: install still works
|
||||
# without the store, just slower.
|
||||
continue-on-error: true
|
||||
uses: actions/cache@v4.1.0
|
||||
uses: actions/cache@v6.1.0
|
||||
with:
|
||||
path: ${{ steps.pnpm.outputs.store }}
|
||||
key: pnpm-store-${{ runner.os }}-${{ steps.pnpm.outputs.layout }}-${{ steps.pnpm.outputs.lockfile }}
|
||||
@@ -82,7 +82,7 @@ jobs:
|
||||
# breaks node-based actions like actions/checkout
|
||||
container: node:22-bookworm
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
- uses: actions/checkout@v7
|
||||
with:
|
||||
fetch-depth: 0 # gitleaks scans the full history
|
||||
|
||||
@@ -110,7 +110,7 @@ jobs:
|
||||
runs-on: ubuntu-latest
|
||||
container: node:22-bookworm
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
- uses: actions/checkout@v7
|
||||
|
||||
- uses: pnpm/action-setup@v4
|
||||
with:
|
||||
@@ -135,7 +135,7 @@ jobs:
|
||||
# binary in the multi-arch node image instead
|
||||
container: node:22-bookworm
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
- uses: actions/checkout@v7
|
||||
|
||||
- name: Install droast
|
||||
run: |
|
||||
@@ -202,7 +202,7 @@ jobs:
|
||||
# so install the CLI via npm in the multi-arch node image instead
|
||||
container: node:22-bookworm
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
- uses: actions/checkout@v7
|
||||
|
||||
- name: Install Snyk CLI
|
||||
run: npm install -g snyk@1 && snyk --version
|
||||
@@ -229,229 +229,3 @@ jobs:
|
||||
# Dockerfile/base image checks are covered by the droast job
|
||||
snyk code test \
|
||||
--severity-threshold=high
|
||||
|
||||
# -------------------------------------------------------- ai code review --
|
||||
review:
|
||||
name: AI code review (opencode)
|
||||
runs-on: ubuntu-latest
|
||||
container: node:22-bookworm
|
||||
# Draft PRs don't get a (paid) review yet. The event_name check is
|
||||
# load-bearing: manual (workflow_dispatch) triggers - which exist to
|
||||
# run the paused snyk job - must NOT launch a paid review, which on
|
||||
# a dispatch event has no PR to post to.
|
||||
if: ${{ github.event_name == 'pull_request' && !github.event.pull_request.draft }}
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
with:
|
||||
fetch-depth: 0
|
||||
|
||||
- name: Restore opencode binary
|
||||
id: opencode-cache
|
||||
# The installer writes to $HOME/.opencode/bin. Caching it saves the
|
||||
# ~4s download+extract per run - small next to the model call, but
|
||||
# free to keep. Key includes the pinned version, so bumping the
|
||||
# version below invalidates the cached binary automatically.
|
||||
# As above, a cache outage falls back to the installer.
|
||||
continue-on-error: true
|
||||
uses: actions/cache@v4.1.0
|
||||
with:
|
||||
path: ~/.opencode/bin
|
||||
key: opencode-v2.0.32-${{ runner.os }}
|
||||
|
||||
- name: Install opencode CLI
|
||||
if: steps.opencode-cache.outputs.cache-hit != 'true'
|
||||
run: curl -fsSL https://opencode.ai/v2/install | bash -s -- -v 2.0.32
|
||||
# v2 installer is required: the classic /install URL ships only
|
||||
# OpenCode 1.x (resolved to v1.19.3 on arm64), which cannot resolve
|
||||
# model variants like "#medium" and failed with ProviderModelNotFoundError.
|
||||
# Version pinned (-v 2.0.32) so a breaking v2 release cannot fail
|
||||
# the job mid-PR; bump deliberately, not automatically.
|
||||
|
||||
- name: Add opencode to PATH
|
||||
# The installer appends the directory to $GITHUB_PATH itself, but that
|
||||
# step is skipped on a cache hit. Add it unconditionally.
|
||||
run: echo "$HOME/.opencode/bin" >> "$GITHUB_PATH"
|
||||
|
||||
- name: Get PR diff
|
||||
run: |
|
||||
# lockfile changes bloat the diff (175KB here) and are pointless to
|
||||
# review - pnpm audit already covers dependencies. Excluding the
|
||||
# lockfile also keeps the diff small enough to hand to the model.
|
||||
# The diff goes to a file IN the workspace so the agent can read it
|
||||
# with its file tools (passing 190KB as a CLI argument fails with
|
||||
# "Argument list too long", MAX_ARG_STRLEN is 128KiB).
|
||||
git diff --merge-base "origin/${{ github.base_ref }}" \
|
||||
-- . ':(exclude)pnpm-lock.yaml' > .pr-review-diff.patch
|
||||
wc -c .pr-review-diff.patch
|
||||
|
||||
- name: Run opencode review
|
||||
env:
|
||||
OPENCODE_API_KEY: ${{ secrets.OPENCODE_API_KEY }}
|
||||
run: |
|
||||
# opencode-go/claude-haiku-5-5#medium: cheap ($0.10/$0.50 per M
|
||||
# tokens) and, unlike deepseek-v4.1-flash, it has a #medium
|
||||
# reasoning variant - flash only exposes low/high/max, so every
|
||||
# review there ran at maximum effort. #medium keeps the review
|
||||
# competent without paying for max reasoning on each push.
|
||||
# History: deepseek-v4-pro#max -> deepseek-v4.1-flash#max ->
|
||||
# haiku-5-5#medium (2026-10-20). The pro endpoint failed two
|
||||
# consecutive runs with "Upstream request failed: Endpoint is
|
||||
# unavailable" before the flash switch; that fallback is recorded
|
||||
# in OKF_Nuxt/open-questions.md. NOTE the provider prefix must be
|
||||
# "opencode-go", NOT "opencode" (Zen is a different, pay-per-call
|
||||
# provider and fails with 'Insufficient account funds').
|
||||
#
|
||||
# Auth is env-only: the CLI picks up OPENCODE_API_KEY from the
|
||||
# environment (verified headless). Deliberately NO opencode.json:
|
||||
# a config file in the checkout would hold the API key in
|
||||
# plaintext, readable by the agent - a malicious PR diff could
|
||||
# prompt-inject the agent into quoting the key in the review
|
||||
# comment (publicly visible). Env vars are invisible to file reads.
|
||||
# Permissions live in a global config OUTSIDE the checkout (no
|
||||
# secrets in it, so nothing can leak). OpenCode v2 schema: the
|
||||
# field is "permissions" (plural) - an ordered array of
|
||||
# {action, resource, effect}; "bash" was renamed "shell" in v2.
|
||||
# The singular v1 "permission" object is ignored by the v2 CLI
|
||||
# (verified empirically: shell commands executed despite deny).
|
||||
# Denying shell/edit/webfetch/websearch/external_directory means
|
||||
# no headless permission prompts can hang or kill the run, and
|
||||
# the reviewer physically cannot modify the repo or browse
|
||||
# attacker-controlled URLs.
|
||||
mkdir -p "$HOME/.config/opencode"
|
||||
printf '{
|
||||
"$schema": "https://opencode.ai/config.json",
|
||||
"permissions": [
|
||||
{ "action": "edit", "resource": "*", "effect": "deny" },
|
||||
{ "action": "shell", "resource": "*", "effect": "deny" },
|
||||
{ "action": "webfetch", "resource": "*", "effect": "deny" },
|
||||
{ "action": "websearch", "resource": "*", "effect": "deny" },
|
||||
{ "action": "external_directory", "resource": "*", "effect": "deny" }
|
||||
]
|
||||
}' > "$HOME/.config/opencode/opencode.json"
|
||||
# --print-logs: surface auth/provider errors in the CI log instead
|
||||
# of failing with an opaque exit code
|
||||
EXIT_CODE=0
|
||||
opencode run \
|
||||
--print-logs \
|
||||
--model opencode-go/claude-haiku-5-5#medium \
|
||||
"You are a principal engineer performing a rigorous code review on a
|
||||
pull request. You have tool access: read repo files for context when
|
||||
the diff alone is ambiguous, but review ONLY code changed in this PR.
|
||||
|
||||
The full PR diff is in the file .pr-review-diff.patch in the repo
|
||||
root. Read it first with your file tools.
|
||||
|
||||
pnpm-lock.yaml is deliberately excluded from that patch to keep it
|
||||
small, not forgotten. It is committed in the PR, pnpm audit covers
|
||||
the dependencies, and CI runs `pnpm install --frozen-lockfile`.
|
||||
Do not report a missing lockfile or a frozen-install drift.
|
||||
|
||||
## Project context
|
||||
- Stack: Nuxt 4 (Vue 3, TypeScript) SSR web app in the repo root.
|
||||
Backend/API services are being added in Golang.
|
||||
- Deployment target: a personal production CV website.
|
||||
- Already covered by other CI jobs, do NOT repeat their findings:
|
||||
ESLint (style), vue-tsc (types), gitleaks (secrets in git history),
|
||||
pnpm audit (dependency CVEs), droast (Dockerfile lint).
|
||||
- Your job is everything those tools CANNOT see: logic, security,
|
||||
architecture, correctness.
|
||||
|
||||
## Nuxt / Vue / TypeScript focus
|
||||
- SSR pitfalls: window/document/localStorage access without
|
||||
<ClientOnly> or process.client guards; hydration mismatch risks
|
||||
(Date.now(), Math.random(), locale formatting in render path).
|
||||
- useAsyncData/useFetch: missing or colliding keys, duplicate
|
||||
requests between server and client, wrong caching/refresh setup.
|
||||
- Reactivity bugs: destructuring reactive objects losing reactivity,
|
||||
missing await on async setup, watch on getters vs refs.
|
||||
- Security: v-html with unsanitized data, user input flowing into
|
||||
meta/URLs, open redirects, missing validation in /server/api and
|
||||
Nitro route handlers, auth checks on both page and API level.
|
||||
- Config hygiene: server-only runtime config (no NUXT_PUBLIC_
|
||||
prefix) leaking secrets into the client bundle.
|
||||
|
||||
## Golang focus (when Go code is in the diff)
|
||||
- Errors: unchecked errors, errors discarded, wrapping with %w,
|
||||
sentinel vs typed errors, panic in library code.
|
||||
- Concurrency: goroutine leaks (missing context cancellation),
|
||||
data races (shared state without mutex/channel), WaitGroup
|
||||
misuse, defer in loops.
|
||||
- Resources: unclosed response bodies/files/rows, missing
|
||||
timeouts on http.Client, unbounded buffering.
|
||||
- Correctness: slice aliasing surprises, copy vs reference
|
||||
semantics, nil map writes, integer truncation.
|
||||
|
||||
## Cross-cutting
|
||||
- API contract mismatches between Nuxt frontend and Go backends
|
||||
(field names, nullability, status codes, date formats).
|
||||
- Missing authorization checks on new endpoints or pages.
|
||||
- Secrets/credentials ending up in logs or client-visible output.
|
||||
- Performance on the critical render path (heavy components,
|
||||
unoptimized images, blocking Nitro middleware).
|
||||
|
||||
## Output format (strict)
|
||||
Review the diff in .pr-review-diff.patch. For every finding:
|
||||
[BLOCKER] file:line - what and why + concrete fix suggestion
|
||||
[WARN] file:line - what and why + concrete fix suggestion
|
||||
[NIT] file:line - optional improvement
|
||||
BLOCKER = must fix before merge (security, data loss, broken
|
||||
behavior). WARN = should fix soon. NIT = optional.
|
||||
If a finding cannot be localized to a file, prefix [BLOCKER-GENERAL].
|
||||
No compliments, no summaries of what the diff does, no style nits.
|
||||
Keep it under 400 words unless there are more than 10 findings.
|
||||
If the diff contains no reviewable code (docs/config only), say so
|
||||
in one line.
|
||||
|
||||
End your response with a final verdict line, exactly one of:
|
||||
VERDICT: APPROVE (no BLOCKER findings)
|
||||
VERDICT: REQUEST_CHANGES (at least one BLOCKER)" \
|
||||
> /tmp/review.md 2>&1 || EXIT_CODE=$?
|
||||
# always show the output - never swallow the error text
|
||||
cat /tmp/review.md
|
||||
# The posting gate is the OUTPUT CONTRACT, not the exit code:
|
||||
# a completed review always ends with a VERDICT line - error
|
||||
# dumps never do. opencode can exit 1 on benign tool denials
|
||||
# even after a full review, so a present verdict means post;
|
||||
# anything else means the review did not complete.
|
||||
# Anchored to the tail: the prompt itself contains VERDICT
|
||||
# lines, so scanning the whole file could pass on echoed
|
||||
# prompt text or injected quotes - only the last lines count.
|
||||
if tail -n 5 /tmp/review.md | grep -qE '^VERDICT: (APPROVE|REQUEST_CHANGES)'; then
|
||||
[ "$EXIT_CODE" -ne 0 ] && echo "::warning::opencode exited ${EXIT_CODE} but produced a valid verdict - posting review"
|
||||
echo "Review completed with verdict."
|
||||
else
|
||||
# fail closed: no verdict = no review. exit 1 unconditionally -
|
||||
# falling back to EXIT_CODE would exit 0 when opencode succeeded
|
||||
# but produced no review, and the job would go green.
|
||||
echo "::error::opencode produced no valid review (exit ${EXIT_CODE:-1}) - NOT posting this output as a review comment"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
- name: Post review as PR comment
|
||||
continue-on-error: true # token missing/expired must not fail the build
|
||||
env:
|
||||
GITEA_TOKEN: ${{ secrets.PR_GITEA_TOKEN }}
|
||||
PR_NUMBER: ${{ github.event.pull_request.number }}
|
||||
REPO: ${{ github.repository }}
|
||||
# Gitea sets GITHUB_API_URL, e.g. https://gitea.example.com/api/v1
|
||||
run: |
|
||||
# re-verify the output contract here: never post anything that is
|
||||
# not a completed review, regardless of how the previous step ended
|
||||
if ! tail -n 5 /tmp/review.md | grep -qE '^VERDICT: (APPROVE|REQUEST_CHANGES)'; then
|
||||
echo "::error::no verdict in review output - nothing to post"
|
||||
exit 1
|
||||
fi
|
||||
# jq is not in the node image - use node for JSON encoding
|
||||
BODY=$(node -e 'process.stdout.write(JSON.stringify(require("fs").readFileSync("/tmp/review.md","utf8")))')
|
||||
HTTP_CODE=$(curl -s -o /tmp/comment-response.json -w "%{http_code}" \
|
||||
-X POST \
|
||||
-H "Authorization: token ${GITEA_TOKEN}" \
|
||||
-H "Content-Type: application/json" \
|
||||
-d "{\"body\": ${BODY}}" \
|
||||
"${GITHUB_API_URL}/repos/${REPO}/issues/${PR_NUMBER}/comments")
|
||||
echo "POST status: ${HTTP_CODE}"
|
||||
cat /tmp/comment-response.json
|
||||
case "$HTTP_CODE" in
|
||||
200|201) echo "Review comment posted." ;;
|
||||
*) echo "::error::Failed to post review comment (HTTP ${HTTP_CODE}) - check PR_GITEA_TOKEN scope and expiry" ;;
|
||||
esac
|
||||
@@ -9,6 +9,24 @@ on:
|
||||
push:
|
||||
tags:
|
||||
- 'v*'
|
||||
# Manual rehearsal from the Gitea UI (Actions -> Publish image -> Run
|
||||
# workflow). `push` defaults to false: the job builds and smoke-tests, then
|
||||
# stops without publishing, so the runner can be verified without creating
|
||||
# a tag or a package version. Set `push` to true (and `latest` only for a
|
||||
# real release) to publish.
|
||||
workflow_dispatch:
|
||||
inputs:
|
||||
version:
|
||||
description: 'Version to build, e.g. v0.0.1 (vMAJOR.MINOR.PATCH)'
|
||||
required: true
|
||||
push:
|
||||
description: 'Push the image to the registry'
|
||||
required: false
|
||||
default: 'false'
|
||||
latest:
|
||||
description: 'Also move :latest (real releases only)'
|
||||
required: false
|
||||
default: 'false'
|
||||
|
||||
# The runner has capacity 1, so releases already serialize. This keeps a
|
||||
# manual re-run from racing a fresh release on the same tags.
|
||||
@@ -18,8 +36,8 @@ concurrency:
|
||||
|
||||
env:
|
||||
# Registry host + repository path. The path segment is the Gitea
|
||||
# organisation, so k3s pulls registry.noelsabia.dev/cv_website/nuxt:<tag>.
|
||||
IMAGE: registry.noelsabia.dev/cv_website/nuxt
|
||||
# organisation, so k3s pulls git.noelsabia.dev/cv_website/nuxt:<tag>.
|
||||
IMAGE: git.noelsabia.dev/cv_website/nuxt
|
||||
APP_DIR: .
|
||||
|
||||
jobs:
|
||||
@@ -41,7 +59,7 @@ jobs:
|
||||
# the CLI - see OKF_Nuxt/decisions/registry-publishing.md.
|
||||
container: node:22-bookworm
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
- uses: actions/checkout@v7
|
||||
|
||||
- name: Install Docker CLI
|
||||
# Debian's docker.io, not a curl-piped binary from GitHub: apt is a
|
||||
@@ -72,10 +90,19 @@ jobs:
|
||||
|
||||
- name: Resolve version and tags
|
||||
id: version
|
||||
env:
|
||||
# Inputs go through env, not direct interpolation: a value pasted
|
||||
# into a `run:` block is shell code before any check can run.
|
||||
INPUT_VERSION: ${{ github.event.inputs.version }}
|
||||
INPUT_LATEST: ${{ github.event.inputs.latest }}
|
||||
run: |
|
||||
# GITHUB_REF_NAME is the tag on a tag push. The git fallback keeps
|
||||
# this working if a runner version does not set it.
|
||||
version="${GITHUB_REF_NAME:-$(git describe --tags --exact-match HEAD)}"
|
||||
# On a tag push GITHUB_REF_NAME is the tag; on workflow_dispatch it
|
||||
# is the BRANCH, so the manual version input must win. The git
|
||||
# fallback keeps tag pushes working if a runner omits the variable.
|
||||
version="$INPUT_VERSION"
|
||||
if [ -z "$version" ]; then
|
||||
version="${GITHUB_REF_NAME:-$(git describe --tags --exact-match HEAD)}"
|
||||
fi
|
||||
# Strict semver, not a `v[0-9]*` prefix match: that would accept
|
||||
# `v1`, `v1-anything` and prereleases, all valid registry tags.
|
||||
if ! printf '%s' "$version" | grep -qE '^v[0-9]+\.[0-9]+\.[0-9]+$'; then
|
||||
@@ -91,7 +118,13 @@ jobs:
|
||||
# A tag comparison needs the other tags, which a depth-1 tag
|
||||
# checkout does not have. If the fetch fails, skip `latest` and
|
||||
# say so - a wrong tag is worse than a missing one.
|
||||
if git fetch --tags --force --quiet origin 2>/dev/null; then
|
||||
#
|
||||
# A manual run moves `latest` only when the `latest` input says so;
|
||||
# a rehearsal must never repoint the production tag.
|
||||
if [ "$INPUT_LATEST" = "true" ]; then
|
||||
latest=true
|
||||
echo "manual run requested :latest"
|
||||
elif git fetch --tags --force --quiet origin 2>/dev/null; then
|
||||
newest="$(git tag -l | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$' | sort -V | tail -n 1)"
|
||||
if [ "$version" = "$newest" ]; then
|
||||
latest=true
|
||||
@@ -125,9 +158,12 @@ jobs:
|
||||
[ -n "$REGISTRY_USERNAME" ] || { echo "::error::secret REGISTRY_USERNAME is empty"; exit 1; }
|
||||
[ -n "$REGISTRY_PASSWORD" ] || { echo "::error::secret REGISTRY_PASSWORD is empty"; exit 1; }
|
||||
printf '%s' "$REGISTRY_PASSWORD" \
|
||||
| docker login registry.noelsabia.dev -u "$REGISTRY_USERNAME" --password-stdin
|
||||
| docker login git.noelsabia.dev -u "$REGISTRY_USERNAME" --password-stdin
|
||||
|
||||
- name: Refuse to overwrite a published version
|
||||
# Build-only rehearsals publish nothing, so an existing tag is not a
|
||||
# conflict there; the guard only protects actual pushes.
|
||||
if: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.push == 'true' }}
|
||||
env:
|
||||
REGISTRY_USERNAME: ${{ secrets.REGISTRY_USERNAME }}
|
||||
REGISTRY_PASSWORD: ${{ secrets.REGISTRY_PASSWORD }}
|
||||
@@ -143,7 +179,7 @@ jobs:
|
||||
# Debian 20.10 client fails that command on OCI indexes with
|
||||
# "unsupported manifest media type and no default available",
|
||||
# for existing and missing tags alike.
|
||||
url="https://registry.noelsabia.dev/v2/cv_website/nuxt/manifests/${VERSION}"
|
||||
url="https://git.noelsabia.dev/v2/cv_website/nuxt/manifests/${VERSION}"
|
||||
code=$(curl -s -o /dev/null -w '%{http_code}' \
|
||||
-u "${REGISTRY_USERNAME}:${REGISTRY_PASSWORD}" \
|
||||
-H 'Accept: application/vnd.docker.distribution.manifest.v2+json' \
|
||||
@@ -213,6 +249,8 @@ jobs:
|
||||
run: docker tag "${IMAGE}:${VERSION}" "${IMAGE}:latest"
|
||||
|
||||
- name: Push image
|
||||
# Manual run with `push` left at false: build and smoke test only.
|
||||
if: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.push == 'true' }}
|
||||
env:
|
||||
VERSION: ${{ steps.version.outputs.version }}
|
||||
SHA: ${{ steps.version.outputs.sha }}
|
||||
@@ -228,3 +266,13 @@ jobs:
|
||||
else
|
||||
echo "Pushed ${IMAGE}:${VERSION}, :sha-${SHA} (:latest untouched)"
|
||||
fi
|
||||
|
||||
- name: Rehearsal summary
|
||||
if: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.push != 'true' }}
|
||||
env:
|
||||
VERSION: ${{ steps.version.outputs.version }}
|
||||
SHA: ${{ steps.version.outputs.sha }}
|
||||
run: |
|
||||
echo "Build-only rehearsal for ${VERSION} (${SHA}) - the image passed the smoke test and was NOT pushed."
|
||||
echo "Re-run with push=true to publish it."
|
||||
|
||||
@@ -17,6 +17,12 @@ jobs:
|
||||
release-please:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
# The reconcile step below runs a file from this repository. The
|
||||
# release-please action clones into its own temp directory and does not
|
||||
# check the workspace out, so without this step the job fails with
|
||||
# "Cannot find module .../scripts/reconcile-release-please.mjs".
|
||||
- uses: actions/checkout@v7
|
||||
|
||||
# release-please marks its release PR with `autorelease: pending` and
|
||||
# later finds the merged PR by that label. Gitea's label API resolves
|
||||
# names and *silently ignores unknown ones* (GetLabelIDsInRepoByNames
|
||||
@@ -49,6 +55,21 @@ jobs:
|
||||
echo "created label: ${name}"
|
||||
done
|
||||
|
||||
# The label fix above is not retroactive. PR #22 was merged with
|
||||
# `autorelease: pending` but its head branch had already been deleted,
|
||||
# so the action reports `Bad branch name: refs/pull/22/head`, creates no
|
||||
# tag and leaves the label behind. Every later run then aborts with
|
||||
# "There are untagged, merged release PRs outstanding" and never opens a
|
||||
# new release PR - green, no tags. This step reconciles that state before
|
||||
# the action runs: mark a pending PR tagged when its tag already exists,
|
||||
# or recreate the tag when the head branch is gone and release-please
|
||||
# therefore cannot. See scripts/reconcile-release-please.mjs and
|
||||
# OKF_Nuxt/decisions/release-engineering.md.
|
||||
- name: Reconcile stale release-please state
|
||||
env:
|
||||
GITEA_TOKEN: ${{ secrets.PR_GITEA_TOKEN }}
|
||||
run: node scripts/reconcile-release-please.mjs
|
||||
|
||||
- uses: joaquinjsb/gitea-release-please-action@v4
|
||||
with:
|
||||
# One well-scoped token for all workflow API work (see
|
||||
|
||||
@@ -7,7 +7,9 @@ name: Renovate
|
||||
# Manual setup: create a bot account with its full name and email set, give
|
||||
# it write access to this repository, and store a token with
|
||||
# repository read/write, issue read/write, user read and organization read
|
||||
# as the RENOVATE_TOKEN Actions secret.
|
||||
# as the RENOVATE_TOKEN Actions secret. Release notes also need a github.com
|
||||
# token (any account, read-only, no scopes for public repositories) as the
|
||||
# RENOVATE_GITHUB_COM_TOKEN secret.
|
||||
on:
|
||||
schedule:
|
||||
# Daily at 04:00 UTC. Gitea only schedules workflows that exist on the
|
||||
@@ -26,7 +28,7 @@ jobs:
|
||||
timeout-minutes: 30
|
||||
# Pinned and multi-arch (the runner is arm64). The image installs the
|
||||
# Node-based toolchain it needs on demand.
|
||||
container: renovate/renovate:44.198.2
|
||||
container: renovate/renovate:44.227.4
|
||||
steps:
|
||||
- name: Run Renovate
|
||||
env:
|
||||
@@ -35,6 +37,10 @@ jobs:
|
||||
# default branch through this endpoint.
|
||||
RENOVATE_ENDPOINT: https://git.noelsabia.dev/api/v1
|
||||
RENOVATE_TOKEN: ${{ secrets.RENOVATE_TOKEN }}
|
||||
# github.com is only used to fetch release notes and other public
|
||||
# metadata. Anonymous requests are rate-limited, which is why the
|
||||
# PR body warned that release notes were skipped.
|
||||
RENOVATE_GITHUB_COM_TOKEN: ${{ secrets.RENOVATE_GITHUB_COM_TOKEN }}
|
||||
# This workflow lives in the repository it updates, so scope the bot
|
||||
# to it instead of every repository its account can see.
|
||||
RENOVATE_REPOSITORIES: CV_Website/CV_Site_Nuxt
|
||||
|
||||
@@ -1,3 +1,3 @@
|
||||
{
|
||||
".": "1.4.0"
|
||||
".": "1.5.2"
|
||||
}
|
||||
@@ -1,5 +1,38 @@
|
||||
# Changelog
|
||||
|
||||
## [1.5.2](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/compare/v1.5.1...v1.5.2) (2026-10-31)
|
||||
|
||||
|
||||
### Bug Fixes
|
||||
|
||||
* **docker:** pin the multi-platform base image index digest ([7981575](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/7981575f862eb2c4d298327e21f7a006fec66591))
|
||||
|
||||
## [1.5.1](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/compare/v1.5.0...v1.5.1) (2026-10-31)
|
||||
|
||||
|
||||
### Bug Fixes
|
||||
|
||||
* **ci:** remove the release-please component mismatch ([e23f8d2](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/e23f8d26185443093f6aff949a22a9e785662c2f))
|
||||
* **ci:** use an empty package-name so release-please tags v1.5.0 ([c8250c9](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/c8250c9ca3f9a7d820d891733f225692f18fa3b3))
|
||||
* updated pnpm lockfile ([42b07e9](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/42b07e9ab938a4eadbcf0b3785fbb86e87f605a1))
|
||||
|
||||
## [1.5.0](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/compare/v1.4.0...v1.5.0) (2026-10-31)
|
||||
|
||||
|
||||
### Features
|
||||
|
||||
* **ci:** replace opencode review with PR-Agent ([c626cc9](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/c626cc9c1dc7db94e645d33eab3c7c7b9a860438))
|
||||
|
||||
|
||||
### Bug Fixes
|
||||
|
||||
* **ci:** check out the repo before the release-please reconcile step ([90ef58a](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/90ef58a8cb8917d547947ae0046a56b8be882114))
|
||||
* **ci:** point changelog compare links at our Gitea ([a2259df](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/a2259df877615c34311a41c1a218ff4bea169d72))
|
||||
* **ci:** repair PR-Agent model routing ([a43134a](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/a43134ad83bece7670543e557f40407892dbf48e))
|
||||
* **ci:** validate the release tag and query pending PRs by label ([7ffc6d7](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/7ffc6d73b607d697a6086a6fe17d077ffc50d5c2))
|
||||
* **deps:** sync lockfile and pin patched seroval ([3eac732](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/3eac73255ff5f5b34233576fc8cbcfa97a50d3dc))
|
||||
* **deps:** unblock the dependency audit ([e0c69c1](https://git.noelsabia.dev/CV_Website/CV_Site_Nuxt/commit/e0c69c1b7727a65b240e5bcab91dad98cd80fdec))
|
||||
|
||||
## [1.4.0](https://github.com/CV_Website/CV_Site_Nuxt/compare/v1.3.0...v1.4.0) (2026-10-27)
|
||||
|
||||
|
||||
|
||||
+7
-4
@@ -12,11 +12,14 @@
|
||||
# edits invalidate almost nothing.
|
||||
#
|
||||
# Base image is digest-pinned to the same node:26-slim digest as the dev
|
||||
# container (OKF_Nuxt/decisions/dev-container-shape.md) - verified for the
|
||||
# runner's arm64 and this workstation's x86_64.
|
||||
# container (OKF_Nuxt/decisions/dev-container-shape.md). The digest is the
|
||||
# multi-platform OCI INDEX, not a platform manifest: the previous pin was
|
||||
# the linux/amd64 manifest digest, so `--platform linux/arm64` on the arm64
|
||||
# runner failed instantly with "no matching manifest for linux/arm64".
|
||||
# Index digest verified 2026-10-31 to contain linux/amd64 and linux/arm64/v8.
|
||||
# syntax: no BuildKit-only features used, so the default frontend suffices.
|
||||
|
||||
FROM node:26-slim@sha256:d62f13676d530f7edf97782729df69713c8ccfe6631e7f62f9ccab65968719a8 AS build
|
||||
FROM node:26-slim@sha256:e6bedef217677b276c591795e169840edd9096dbf13f29df8ef8d1856b8820bc AS build
|
||||
|
||||
# pnpm pinned to the same version as CI (pr-checker.yml pins major 11) and
|
||||
# the local toolchain (11.26.0). Installed via npm from the node image - no
|
||||
@@ -38,7 +41,7 @@ COPY . .
|
||||
RUN pnpm build
|
||||
|
||||
|
||||
FROM node:26-slim@sha256:d62f13676d530f7edf97782729df69713c8ccfe6631e7f62f9ccab65968719a8
|
||||
FROM node:26-slim@sha256:e6bedef217677b276c591795e169840edd9096dbf13f29df8ef8d1856b8820bc
|
||||
|
||||
# pnpm is NOT installed in the runtime image: nothing here runs pnpm.
|
||||
ENV NODE_ENV=production \
|
||||
|
||||
+1
-1
@@ -1,4 +1,4 @@
|
||||
FROM node:26-slim@sha256:d62f13676d530f7edf97782729df69713c8ccfe6631e7f62f9ccab65968719a8
|
||||
FROM node:26-slim@sha256:e6bedef217677b276c591795e169840edd9096dbf13f29df8ef8d1856b8820bc
|
||||
|
||||
# Node no longer bundles pnpm (corepack and pnpm are both absent from this
|
||||
# image), so install it. First instruction, so later changes reuse the layer.
|
||||
|
||||
@@ -3,7 +3,7 @@ type: Decision
|
||||
title: AI code review setup
|
||||
description: The review job runs opencode with a cheap medium-effort opencode-go model, env-only auth, a read-only permission set, and posts only reviews that end with a verdict line.
|
||||
tags: [decision, ci, ai, opencode, security]
|
||||
status: draft
|
||||
status: deprecated
|
||||
generated: { by: opencode-go/glm-5.3-flash, at: 2026-10-18T16:05:00Z }
|
||||
verified: { by: human:noel, at: not yet }
|
||||
sources:
|
||||
@@ -15,6 +15,10 @@ sources:
|
||||
title: OpenCode Go plan documentation
|
||||
---
|
||||
|
||||
> Superseded by [PR-Agent for Gitea reviews](pr-agent.md) on 2026-10-30.
|
||||
> The opencode job was removed from `pr-checker.yml`; this document remains
|
||||
> as the record of the earlier setup and the failures it fixed.
|
||||
|
||||
# Decision
|
||||
|
||||
The review job installs opencode v2 from the dedicated v2 installer,
|
||||
|
||||
@@ -1,11 +1,12 @@
|
||||
# Decisions
|
||||
|
||||
* [PR pipeline layering](pr-pipeline-layering.md) - What runs pre-commit, what runs in Gitea Actions, what the AI review does, and the cost rule that decides.
|
||||
* [AI review setup](ai-review-setup.md) - Plan model, env-only auth against prompt injection, read-only agent, and the verdict line as the posting gate.
|
||||
* [PR-Agent for Gitea reviews](pr-agent.md) - A pinned webhook server replaces the per-PR opencode job; internal-only, scoped bot, OpenCode Go model.
|
||||
* [AI review setup (opencode)](ai-review-setup.md) - Superseded 2026-10-30; kept for the env-only auth and verdict-gate reasoning.
|
||||
* [Vulnerability audit policy](vulnerability-audit-policy.md) - Blocking audit, reviewed ignore-list for unfixable advisories, and the pnpm-11 settings home.
|
||||
* [Release engineering](release-engineering.md) - release-please in manifest mode, conventional commits as input, message format enforced at commit time.
|
||||
* [Snyk paused and secrets policy](snyk-paused-and-secrets-policy.md) - Why the job is skipped rather than deleted, and the token scopes every workflow secret needs.
|
||||
* [Publishing images to the own registry](registry-publishing.md) - A release tag builds and pushes to registry.noelsabia.dev; main pushes do not build.
|
||||
* [Publishing images to the own registry](registry-publishing.md) - A release tag builds and pushes to git.noelsabia.dev; main pushes do not build.
|
||||
* [Dev container shape](dev-container-shape.md) - The source is bind-mounted into a container that already holds the dependencies, and the dev server runs as the image's `node` user.
|
||||
* [Build layer order](build-layer-order.md) - Why the manifests are copied before the source, and what invalidates what.
|
||||
* [Build context filter](build-context-filter.md) - What `.dockerignore` may exclude, and the one thing it must never exclude.
|
||||
|
||||
@@ -0,0 +1,119 @@
|
||||
---
|
||||
type: Decision
|
||||
title: PR-Agent for Gitea reviews
|
||||
description: A pinned PR-Agent service inside the Gitea compose stack reviews pull requests through a scoped Gitea bot user, replacing the per-PR opencode job.
|
||||
tags: [decision, ci, ai, gitea, pr-agent, security]
|
||||
status: draft
|
||||
generated: { by: opencode-go/deepseek-v4.1-flash, at: 2026-10-30T20:00:00Z }
|
||||
verified: { by: human:noel, at: not yet }
|
||||
sources:
|
||||
- id: gitea-compose
|
||||
resource: /home/noel/self-hosted/gitea/docker-compose.yml
|
||||
title: Gitea compose stack, pr-agent service
|
||||
- id: operations
|
||||
resource: OKF_Nuxt/pr-agent.md
|
||||
title: PR-Agent operations and configuration
|
||||
- id: pr-checker
|
||||
resource: .gitea/workflows/pr-checker.yml
|
||||
title: PR Check workflow, opencode job removed
|
||||
- id: install
|
||||
resource: https://docs.pr-agent.ai/installation/gitea/
|
||||
title: PR-Agent Gitea installation
|
||||
- id: images
|
||||
resource: https://hub.docker.com/r/pragent/pr-agent
|
||||
title: Published gitea_app image tags
|
||||
- id: gitea-egress
|
||||
resource: https://docs.gitea.com/administration/config-cheat-sheet#webhook
|
||||
title: Gitea webhook egress allowlist
|
||||
---
|
||||
|
||||
# Decision
|
||||
|
||||
PR-Agent runs as `pragent/pr-agent:0.49.0-gitea_app` in a long-lived
|
||||
container on `server0`, as the `pr-agent` service in the Gitea compose
|
||||
stack. It attaches to the existing `gitea_gitea` Docker network and
|
||||
publishes no ports. Gitea delivers pull-request and comment events to
|
||||
`http://pr-agent:3000/api/v1/gitea_webhooks`; the bot user `pr-agent`
|
||||
posts the result with a scoped personal access token. The service
|
||||
definition lives in `/home/noel/self-hosted/gitea/docker-compose.yml`; the
|
||||
operator guide is [PR-Agent operations](../pr-agent.md).
|
||||
|
||||
The opencode review job is removed from `pr-checker.yml`. PR-Agent runs
|
||||
`/describe` and `/review` on pull request open/reopen and answers slash
|
||||
commands in the conversation. Push-triggered re-review is disabled, so a
|
||||
PR is reviewed once when it opens, not on every push.
|
||||
|
||||
The model is OpenCode Go's OpenAI-compatible endpoint:
|
||||
|
||||
```text
|
||||
model openai/glm-5.3-flash
|
||||
fallback openai/glm-5.3
|
||||
api base https://opencode.ai/inference/go/openai/v1
|
||||
```
|
||||
|
||||
`CONFIG__CUSTOM_MODEL_MAX_TOKENS=128000` supplies the context limit the
|
||||
model table does not know; PR-Agent's default `config.max_model_tokens`
|
||||
still caps the review budget at 32000.
|
||||
|
||||
OpenCode Go requires an `x-opencode-session` header. PR-Agent sends the
|
||||
stable id `pr-agent` through `LITELLM__EXTRA_HEADERS`; without it the
|
||||
provider rejects the request before it reaches the model.
|
||||
|
||||
# Why
|
||||
|
||||
* One container replaces a per-PR CLI install, binary cache and prompt
|
||||
wrapper. The review path is then the same code for every PR.
|
||||
* PR-Agent owns the Gitea webhook and comment plumbing, including the slash
|
||||
commands (`/review`, `/improve`, `/ask`) the repository previously had no
|
||||
way to trigger.
|
||||
* The webhook endpoint stays on the Docker network. Nothing new is exposed
|
||||
to the internet, and comment links still use the public Gitea URL.
|
||||
* The image tag is pinned. A new PR-Agent release is a deliberate change,
|
||||
not a rollout underneath the repository.
|
||||
|
||||
# Gitea configuration
|
||||
|
||||
* Bot user `pr-agent` is a collaborator with write permission on
|
||||
`CV_Website/CV_Site_Nuxt`. The token scopes are `read:repository`,
|
||||
`write:issue` and `read:user`. Gitea has no comment-only collaborator
|
||||
role, so write is the narrowest role that can post comments and labels.
|
||||
* `[webhook] ALLOWED_HOST_LIST = private:3000` is required: Gitea's default
|
||||
lax egress policy allows public targets but refuses private ones, and the
|
||||
webhook target is a Docker-network address. The API is reached at
|
||||
`http://gitea:3000`; `GITEA__WEB_URL=https://git.noelsabia.dev` keeps
|
||||
published links on the public host.
|
||||
* The webhook sends `push`, `issues`, `pull_request` and `issue_comment`
|
||||
events. Only the last two change behaviour today; `push` is kept because
|
||||
PR-Agent may handle push commands in a later configuration.
|
||||
* Auto commands are `/describe` and `/review`. `/improve` stays available
|
||||
on demand; the default auto list would add a second model call and a
|
||||
second comment to every PR.
|
||||
* Secrets live only in `/home/noel/self-hosted/gitea/pr-agent.env` (mode
|
||||
600) on `server0`. The repository contains the decision and the operator
|
||||
guide, never the token, webhook secret or model key.
|
||||
|
||||
# Evidence
|
||||
|
||||
* 2026-10-30: a direct `glm-5.3-flash` call through the handler returned
|
||||
`OK`, and `/review` on PR #28 posted a PR Reviewer Guide through the Gitea
|
||||
comment API. The key is set only in `gitea/pr-agent.env`.
|
||||
|
||||
# Not verified
|
||||
|
||||
* Whether the model finds the same class of issues as the opencode prompt on
|
||||
larger diffs. The first review found none; `glm-5.3` remains the fallback.
|
||||
* Whether two gunicorn workers and the 1 GB memory limit hold under
|
||||
concurrent reviews. The host has roughly 2.5 GB available with Gitea and
|
||||
its runner idle.
|
||||
* Whether the default review prompt is specific enough for this repository.
|
||||
A `.pr_agent.toml` with project instructions is deliberately absent until
|
||||
a real review shows what it misses.
|
||||
|
||||
# Revisit when
|
||||
|
||||
* The first review fails, returns unstructured output, or misses the kind
|
||||
of finding the opencode prompt used to catch.
|
||||
* A newer `gitea_app` image tag is worth taking; bump the tag in the Gitea
|
||||
compose file and run `docker compose up -d pr-agent` from that directory.
|
||||
* Review volume makes the container's memory limit tight, or Gitea adds a
|
||||
role that can comment without push access.
|
||||
@@ -26,8 +26,8 @@ Every pull request is checked by three layers, ordered by cost:
|
||||
in one job (one install, cached pnpm store), gitleaks over full
|
||||
history, pnpm audit (blocking), droast Dockerfile lint, Snyk
|
||||
(currently disabled).
|
||||
3. **AI code review** (per PR push): opencode with a plan-covered model,
|
||||
verdict-based, posted as a PR comment.
|
||||
3. **AI code review** (on PR open, or on a slash command): the PR-Agent
|
||||
webhook server, posted as a PR comment.
|
||||
|
||||
The split rule: anything that finishes in seconds and auto-fixes goes in
|
||||
pre-commit; anything slow, network-bound or quota-bound goes in CI; anything
|
||||
@@ -45,15 +45,16 @@ already passed the deterministic gates.
|
||||
|
||||
# Caching
|
||||
|
||||
Two caches, both served by the runner's own cache server (no external
|
||||
service, entries stay on the home server):
|
||||
One cache, served by the runner's own cache server (no external service,
|
||||
entries stay on the home server):
|
||||
|
||||
* **pnpm store**, keyed on the store layout version (v11) and a `sha256sum`
|
||||
of `pnpm-lock.yaml`. Installs hardlink from the store instead of
|
||||
downloading tarballs again. The key is built in a shell step because
|
||||
`hashFiles()` evaluates empty in this act runner.
|
||||
* **opencode binary**, keyed on the pinned CLI version (`~/.opencode/bin`).
|
||||
Small next to the model call, but it removes a network fetch per review.
|
||||
|
||||
The opencode binary cache is gone with the opencode job. PR-Agent is a
|
||||
long-running container on `server0`, so a review no longer downloads a CLI.
|
||||
|
||||
Lint and typecheck also share one job: same image, same lockfile, same
|
||||
install. Splitting them duplicated the install and made both compete for
|
||||
@@ -71,6 +72,10 @@ exposure in the review setup — each fixed where it was cheapest.
|
||||
|
||||
# Failure modes deliberately designed against
|
||||
|
||||
The opencode-specific rows are historical since the review moved to
|
||||
[PR-Agent](pr-agent.md); they are kept because the failure classes still
|
||||
apply to any review implementation.
|
||||
|
||||
| Failure seen | Guard now in place |
|
||||
|---|---|
|
||||
| Error logs posted as review comments | Posting gate is the output contract (a `VERDICT:` line), not the exit code |
|
||||
|
||||
@@ -34,6 +34,17 @@ the gateway must now **proxy to this server** instead of embedding
|
||||
`.output/public/`. That sibling decision needs updating; the compose wiring
|
||||
is still open.
|
||||
|
||||
# The arm64 digest lesson (2026-10-31)
|
||||
|
||||
The first real release (`v1.5.0`, `v1.5.1`) failed at `Build image` after one
|
||||
second: the pinned `sha256:18f03e4b...` was the **linux/amd64 platform
|
||||
manifest**, not the multi-platform index, so `docker build --platform
|
||||
linux/arm64` on the arm64 runner found no arm64 entry. The base is now
|
||||
pinned to the OCI **index** digest (`sha256:e4db4c91...`, contains
|
||||
linux/amd64 and linux/arm64/v8). Rule: a digest pin for a multi-arch image
|
||||
must be the index digest; `docker buildx imagetools inspect` prints both,
|
||||
and the platform manifests carry a `Platform:` line.
|
||||
|
||||
# Why `--ignore-scripts`
|
||||
|
||||
The `postinstall` script (`nuxt prepare`) runs before the source is copied
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
---
|
||||
type: Decision
|
||||
title: Publishing images to the own registry
|
||||
description: A release tag builds the production image and pushes it to registry.noelsabia.dev, because that is the only way Kubernetes can pull it.
|
||||
description: A release tag builds the production image and pushes it to git.noelsabia.dev, because that is the only way Kubernetes can pull it.
|
||||
tags: [decision, ci, docker, registry, gitea-actions]
|
||||
status: draft
|
||||
generated: { by: opencode-go/deepseek-v4.1-flash, at: 2026-10-24T00:00:00Z }
|
||||
@@ -20,13 +20,36 @@ sources:
|
||||
|
||||
# Decision
|
||||
|
||||
**The registry is Gitea's own, served on the Gitea host.** Gitea ships a
|
||||
built-in container registry per owner/organisation
|
||||
([docs.gitea.com - container](https://docs.gitea.com/usage/packages/container/)).
|
||||
The endpoint is the Gitea hostname itself - `git.noelsabia.dev` - and the
|
||||
`/cv_website/` path segment is the Gitea organisation; images live under
|
||||
the package of the repository that pushed them:
|
||||
|
||||
```
|
||||
docker login git.noelsabia.dev
|
||||
git.noelsabia.dev/cv_website/nuxt:<tag>
|
||||
```
|
||||
|
||||
There is nothing to stand up and nothing to reinvent: no separate
|
||||
Registry/Harbor deployment, no extra hostname, no extra certificate.
|
||||
TLS and auth are the ones Gitea already serves. The publishing workflow
|
||||
exists only to automate pushes to this built-in registry.
|
||||
|
||||
**Corrected 2026-10-31:** `registry.noelsabia.dev` was a separate
|
||||
hostname set up before this was known. It is not needed and is being
|
||||
removed on the server side; this repository now uses
|
||||
`git.noelsabia.dev` everywhere. Any leftover `registry.noelsabia.dev`
|
||||
reference is a bug.
|
||||
|
||||
`.gitea/workflows/publish-image.yml` builds `Dockerfile` and pushes the
|
||||
result to the own registry:
|
||||
|
||||
```
|
||||
registry.noelsabia.dev/cv_website/nuxt:v1.2.3
|
||||
registry.noelsabia.dev/cv_website/nuxt:sha-<12-char-sha>
|
||||
registry.noelsabia.dev/cv_website/nuxt:latest # newest release only
|
||||
git.noelsabia.dev/cv_website/nuxt:v1.2.3
|
||||
git.noelsabia.dev/cv_website/nuxt:sha-<12-char-sha>
|
||||
git.noelsabia.dev/cv_website/nuxt:latest # newest release only
|
||||
```
|
||||
|
||||
**Trigger is the release tag, not the main push.** release-please creates
|
||||
@@ -103,7 +126,7 @@ run.
|
||||
|
||||
| Gitea secret | Use |
|
||||
|---|---|
|
||||
| `REGISTRY_USERNAME` | basic-auth user for `docker login registry.noelsabia.dev` |
|
||||
| `REGISTRY_USERNAME` | basic-auth user for `docker login git.noelsabia.dev` |
|
||||
| `REGISTRY_PASSWORD` | basic-auth password (or token) for the same login |
|
||||
|
||||
Both are repo secrets. The login uses `--password-stdin` so the value never
|
||||
@@ -117,7 +140,26 @@ appears in the process list or the log.
|
||||
forever; without the socket it fails at `Check daemon access`.
|
||||
3. `pr-checker.yml` still runs on a label whose runner has no socket.
|
||||
4. Namespace `cv` has an `imagePullSecret` for the same credentials.
|
||||
5. `registry.noelsabia.dev` answers over HTTPS.
|
||||
5. `git.noelsabia.dev` answers over HTTPS.
|
||||
|
||||
# Manual rehearsal (workflow_dispatch)
|
||||
|
||||
The workflow can be started from the Gitea UI (Actions → Publish image →
|
||||
Run workflow) without creating a tag:
|
||||
|
||||
| Input | Use |
|
||||
|---|---|
|
||||
| `version` | required, `vMAJOR.MINOR.PATCH` |
|
||||
| `push` | `false` (default) builds and smoke-tests only; `true` publishes |
|
||||
| `latest` | `false` unless this is a real release |
|
||||
|
||||
A build-only run publishes nothing, so it creates no package version and
|
||||
the immutability guard is skipped. This is the way to prove the runner,
|
||||
socket and registry login before the first release - a rehearsal must never
|
||||
move `latest`, which is why that input is explicit.
|
||||
|
||||
Gitea only offers the Run-workflow button for workflows present on the
|
||||
default branch, so this trigger is available once the change is on `main`.
|
||||
|
||||
# Guards in the workflow
|
||||
|
||||
@@ -153,7 +195,7 @@ appears in the process list or the log.
|
||||
* That the smoke test passes on arm64. The same script was run against an
|
||||
x86_64 build of the merged tree and answered 2xx; the arm64 run is the
|
||||
first release.
|
||||
* That `registry.noelsabia.dev` is reachable over HTTPS from the runner.
|
||||
* That `git.noelsabia.dev` is reachable over HTTPS from the runner.
|
||||
A plain-HTTP endpoint fails `docker login` with `server gave HTTP
|
||||
response to HTTPS client` and needs `insecure-registries` on the daemon
|
||||
plus `registries.yaml` on k3s.
|
||||
|
||||
@@ -16,6 +16,9 @@ sources:
|
||||
- id: workflow
|
||||
resource: .gitea/workflows/release-please.yml
|
||||
title: release-please workflow
|
||||
- id: reconcile
|
||||
resource: scripts/reconcile-release-please.mjs
|
||||
title: release-please state reconciliation
|
||||
---
|
||||
|
||||
# Decision
|
||||
@@ -97,6 +100,114 @@ confirmed by comparison, not inference: while `fix/release_please` still
|
||||
existed, PR #23 reported `head.ref = fix/release_please`; every PR whose
|
||||
branch was gone reported `refs/pull/<n>/head`.
|
||||
|
||||
# A pending label outlives the branch and blocks every later release (2026-10-31)
|
||||
|
||||
Flipping `default_delete_branch_after_merge` to `false` only protects
|
||||
branches deleted *after* the change. PR #22's branch was already gone, so
|
||||
its `head.ref` stayed `refs/pull/22/head` and its `autorelease: pending`
|
||||
label stayed attached. Run 143 (task 475, 2026-10-27, the run immediately
|
||||
after #22 merged) shows the full deadlock:
|
||||
|
||||
```
|
||||
❯ Found pull request #22: 'chore: release main'
|
||||
✖ Bad branch name: refs/pull/22/head
|
||||
...
|
||||
✔ Building candidate release pull request for path: .
|
||||
❯ Found pull request #22: 'chore: release main'
|
||||
⚠ There are untagged, merged release PRs outstanding - aborting
|
||||
::set-output:: prs_created=false
|
||||
::set-output:: releases_created=false
|
||||
```
|
||||
|
||||
The first block fails the tagging phase. The second finds the same
|
||||
still-pending PR and aborts the propose phase, so no new release PR is
|
||||
even opened. Every later run (145, 148, 151, 153, 162, 164, 167) has the
|
||||
same shape. The hand-created `v1.4.0` tag restores the baseline (`found:
|
||||
v1.4.0`) but does not clear the label, so it does not break the
|
||||
deadlock. This is the current reason the pipeline is still healthy-looking
|
||||
and tagless.
|
||||
|
||||
The workflow now reconciles that state before the action runs
|
||||
(`scripts/reconcile-release-please.mjs`):
|
||||
|
||||
* merged + `autorelease: pending` + a tag already at the merge commit ->
|
||||
replace the label with `autorelease: tagged`;
|
||||
* merged + `autorelease: pending` + head branch gone + no tag -> create
|
||||
the tag from the version recorded in the manifest at the merge commit
|
||||
(the exact tag release-please would have made), then swap the label;
|
||||
* merged + `autorelease: pending` + head branch still present -> leave
|
||||
it; release-please tags it in the same run.
|
||||
|
||||
The step is idempotent and runs on every push to `main` and every manual
|
||||
dispatch, so a deleted branch cannot silently poison the release pipeline
|
||||
again. #20 and #21 are not labelled pending, so they do not block; their
|
||||
tags remain the one-time manual recovery in the table below.
|
||||
|
||||
Two details keep the reconciliation from suppressing a real release:
|
||||
|
||||
* pending PRs are fetched through the `autorelease: pending` label filter,
|
||||
not by paging every closed PR, so concurrent PR closes cannot shift a
|
||||
page and hide one;
|
||||
* a tag at the merge commit counts only when its name is exactly
|
||||
`v<manifest version>`. A CI or annotation tag on the same commit is
|
||||
logged and ignored, and the release tag is still created.
|
||||
|
||||
# The release phase drops the PR on a component mismatch (2026-10-31)
|
||||
|
||||
With the branch kept and the label reconciled, PR #35 was still not
|
||||
tagged. Run 181 (task 578, immediately after #35 merged) shows why:
|
||||
|
||||
```
|
||||
❯ Found pull request #35: 'chore: release main'
|
||||
...
|
||||
⚠ PR component: undefined does not match configured component: CV_Site_Frontend
|
||||
...
|
||||
⚠ There are untagged, merged release PRs outstanding - aborting
|
||||
```
|
||||
|
||||
`buildRelease()` compares the component parsed from the merged PR with the
|
||||
strategy's component when the release body contains one component and that
|
||||
component is empty. `include-component-in-tag: false` makes
|
||||
`getComponent()` return an empty string, so the release PR is
|
||||
`chore: release main` with an empty component and the branch is
|
||||
`release-please--branches--main` (parsed component: undefined). But
|
||||
`getBranchComponent()` ignores `include-component-in-tag` and returns
|
||||
`package-name` - here `CV_Site_Frontend`. The two never match, so the
|
||||
release is dropped before the tag is created.
|
||||
|
||||
Removing `package-name` is not enough. Run 183 (after #36 merged) shows
|
||||
the node strategy falling back to the `package.json` name:
|
||||
|
||||
```
|
||||
⚠ PR component: undefined does not match configured component: nuxt-app
|
||||
```
|
||||
|
||||
`BaseStrategy.getDefaultPackageName()` is overridden by the node strategy
|
||||
to read `package.json` `name`, so an absent `package-name` resolves to
|
||||
`nuxt-app`.
|
||||
|
||||
The working setting is `"package-name": ""` (an empty string, not an
|
||||
omitted key). An empty string is not nullish, so `getBranchComponent()`
|
||||
returns empty and matches the legacy default branch
|
||||
`release-please--branches--main`. This was verified by running the
|
||||
action's bundled release-please 16.15.6 locally against the live Gitea
|
||||
API, with writes intercepted: the release phase produced
|
||||
|
||||
```
|
||||
POST /repos/CV_Website/CV_Site_Nuxt/releases
|
||||
{"name":"v1.5.0","tag_name":"v1.5.0",...,"target_commitish":"a80c9ebf..."}
|
||||
```
|
||||
|
||||
then swapped #35 to `autorelease: tagged`. That is release-please creating
|
||||
the tag itself, not a manual `git tag`.
|
||||
|
||||
The action's official default mode (`release-type: node`, no manifest
|
||||
config) was tested the same way and still fails for #35 with
|
||||
`configured component: nuxt-app`. It cannot retroactively accept the
|
||||
already-merged legacy PR; it would only help a release PR created after
|
||||
the switch. The empty `package-name` is therefore the compatibility
|
||||
setting that lets release-please finish v1.5.0.
|
||||
|
||||
# Recovering the versions that never got a tag
|
||||
|
||||
The label alone cannot recover them — #20, #21 and #22 all lost their head
|
||||
@@ -121,8 +232,15 @@ whole history.
|
||||
|
||||
# Not verified
|
||||
|
||||
* That the release phase tags correctly once the head branch survives a
|
||||
merge. The next release cycle proves it.
|
||||
* That the live run tags #35. The exact release-phase request was verified
|
||||
locally with writes intercepted (`POST /releases` with `tag_name:
|
||||
v1.5.0` at `a80c9eb`); the run after merging the empty `package-name` is
|
||||
the final proof.
|
||||
* That the reconcile step's tag-creation fallback works with a live
|
||||
token. Only the tag-already-exists path was exercised, in dry-run,
|
||||
against the live PR #22. The fallback is written from the same Gitea
|
||||
API shapes (`POST /tags`, `PUT /issues/{index}/labels`) the rest of the
|
||||
workflow uses.
|
||||
* That `RELEASE_PLEASE_TOKEN_CV_SITE_NUXT` carries the `write:issue`
|
||||
scope the same way `PR_GITEA_TOKEN` needed it; the previous failure
|
||||
was an immediate API rejection consistent with a scope problem.
|
||||
|
||||
@@ -31,23 +31,32 @@ patched 7.1.6 was already in the tree via `postcss-nesting` and proved
|
||||
API-compatible through a full build. The override is removed when
|
||||
`tailwindcss` ships `>= 7.1.6` itself or the site moves to Tailwind v4.
|
||||
|
||||
Currently ignored (both verified against the advisory database and the npm
|
||||
registries on 2026-10-18 - the newest published versions are the vulnerable
|
||||
ones):
|
||||
Currently ignored (verified against the advisory database and the npm
|
||||
registries on 2026-10-31):
|
||||
|
||||
* `GHSA-86w9-cpqp-85rv` - node-forge <= 1.4.0, high. Path:
|
||||
`nuxt > @nuxt/nitro-server > nitropack > listhen > node-forge` - listhen
|
||||
generates dev certificates; build/dev-time only, not in the server bundle.
|
||||
* `GHSA-vfj7-8cjw-p6xm` - braces <= 3.0.3, high. Path:
|
||||
`nitropack > globby > micromatch > braces` - globbing during build, no
|
||||
attacker-controlled patterns at runtime.
|
||||
* `GHSA-g3hv-75wg-m249` - minimatch < 11.0.1, moderate. The patch
|
||||
(11.0.1) dropped the `makeRe` export that `eslint-plugin-import-x`
|
||||
imports, so forcing it breaks `pnpm lint` with "does not provide an
|
||||
export named 'makeRe'"; it also breaks ESLint's config loader. All
|
||||
affected paths are build/lint-time (Nitro, i18n, ESLint via
|
||||
vite-plugin-checker), never in the running server.
|
||||
|
||||
The 2026-10-31 round also upgraded `nuxt` 4.6.2 -> 4.6.3 (fixes the Nuxt
|
||||
dot-segment, dev-server and appSecret advisories) and added overrides for
|
||||
`node-forge: 1.4.1` (the old node-forge ignore, `GHSA-86w9-cpqp-85rv`,
|
||||
is gone - a patch now exists) and `glob: 14.0.2` for
|
||||
`GHSA-3g3m-2fjr-6pw4` (scoped to `>=9.0.0 <=14.0.1` so
|
||||
tailwind-config-viewer keeps glob 7).
|
||||
|
||||
# Why
|
||||
|
||||
A red job that can never go green trains everyone to ignore red - the same
|
||||
silent-failure outcome "nothing fails silently" exists to prevent. The
|
||||
ignore list is the opposite of silence: the audit still names what it
|
||||
skipped ("2 ignored: 2 high") and the decision lives in a reviewable file.
|
||||
skipped ("1 ignored: 1 high") and the decision lives in a reviewable file.
|
||||
|
||||
# The pnpm 11 lesson
|
||||
|
||||
|
||||
+4
-2
@@ -11,6 +11,7 @@ config files — the configs say what, these documents say why.
|
||||
* [Open questions](open-questions.md) - What is still undecided for the Nuxt site.
|
||||
* [Backend endpoints](backend-endpoints.md) - The smallest API the frontend needs from the Go gateway: health, chapters, metrics, knockdown, events.
|
||||
* [Profile data](profile.md) - The LinkedIn export behind the terminal chapters, what is real vs mock, and how to refresh it.
|
||||
* [PR-Agent operations](pr-agent.md) - The Gitea-side review service: configuration, commands, logs and model.
|
||||
* [Future updates](future-updates.md) - Pipeline improvement backlog with effort estimates, not yet decided.
|
||||
* [Update log](log.md) - History of changes to this bundle.
|
||||
|
||||
@@ -19,11 +20,12 @@ config files — the configs say what, these documents say why.
|
||||
## CI/CD and releases (2026-10-18)
|
||||
|
||||
* [PR pipeline layering](decisions/pr-pipeline-layering.md) - Three layers: pre-commit for cheap deterministic checks, Gitea Actions for thorough ones, AI review for judgment.
|
||||
* [AI review setup](decisions/ai-review-setup.md) - Plan model, env-only auth against prompt injection, read-only agent, verdict line as the posting gate.
|
||||
* [PR-Agent for Gitea reviews](decisions/pr-agent.md) - A pinned review service inside the Gitea compose stack replaces the per-PR opencode job; internal-only, scoped bot, OpenCode Go model.
|
||||
* [AI review setup (opencode)](decisions/ai-review-setup.md) - Superseded 2026-10-30; kept for the env-only auth and verdict-gate reasoning.
|
||||
* [Vulnerability audit policy](decisions/vulnerability-audit-policy.md) - Blocking audit; reviewed ignore-list for unfixable advisories in pnpm-workspace.yaml.
|
||||
* [Release engineering](decisions/release-engineering.md) - release-please in manifest mode; conventional commits enforced at commit time.
|
||||
* [Snyk paused and secrets policy](decisions/snyk-paused-and-secrets-policy.md) - Quota-paused job kept in place; `write:issue` scope required on every workflow token.
|
||||
* [Publishing images to the own registry](decisions/registry-publishing.md) - A release tag builds the image and pushes it to registry.noelsabia.dev; the runner socket it needs is root-equivalent and belongs on a separate label.
|
||||
* [Publishing images to the own registry](decisions/registry-publishing.md) - A release tag builds the image and pushes it to git.noelsabia.dev; the runner socket it needs is root-equivalent and belongs on a separate label.
|
||||
|
||||
## Docker and development environment
|
||||
|
||||
|
||||
+71
-1
@@ -1,5 +1,75 @@
|
||||
# Update Log
|
||||
|
||||
## 2026-10-31 (first release builds failed: pinned the amd64 manifest)
|
||||
|
||||
* **Fix**: [Dockerfile](../Dockerfile) and [Dockerfile.dev](../Dockerfile.dev) - the base digest `sha256:18f03e4b...` was the **linux/amd64 platform manifest**, so `docker build --platform linux/arm64` on the arm64 runner failed at `Build image` one second after the step started (run 157, v1.5.1; run 153, v1.5.0). Both now pin the multi-platform OCI **index** digest `sha256:e4db4c91...`, verified with `docker buildx imagetools inspect` to contain linux/amd64 and linux/arm64/v8. See [Production image shape](decisions/production-image.md).
|
||||
* **Detail**: checkout, Docker CLI install, `Check daemon access`, registry login, the immutability guard and version resolution all passed - the runner and registry setup were correct; only the base image pin was wrong.
|
||||
|
||||
## 2026-10-31 (release-please tag: empty package-name is the verified fix)
|
||||
|
||||
* **Correction**: removing `package-name` in #36 was not enough. Run 183 shows the node strategy falling back to `package.json` `name`, so the release phase still failed with `PR component: undefined does not match configured component: nuxt-app`.
|
||||
* **Fix**: [release-please-config.json](../release-please-config.json) sets `"package-name": ""`. An empty string is not nullish, so `getBranchComponent()` stays empty and matches the legacy `release-please--branches--main` branch. This is the only setting that lets release-please accept the already-merged #35.
|
||||
* **Evidence**: the action's bundled release-please 16.15.6 was run locally against the live Gitea API with writes intercepted. It produced `POST /repos/CV_Website/CV_Site_Nuxt/releases` with `{"name":"v1.5.0","tag_name":"v1.5.0","target_commitish":"a80c9ebf..."}`, then swapped #35 to `autorelease: tagged`. The official default `release-type: node` mode was tested the same way and still fails for #35 with `configured component: nuxt-app`, so it cannot retroactively tag the legacy PR.
|
||||
* **Expected result**: the run after this merge creates `v1.5.0` at `a80c9eb` through the release-please action itself. No manual `git tag`.
|
||||
|
||||
## 2026-10-31 (release-please component mismatch: no v1.5.0 tag)
|
||||
|
||||
* **Fix**: [release-please-config.json](../release-please-config.json) - removed `package-name: CV_Site_Frontend`. With `include-component-in-tag: false` the strategy component and the release PR body component are empty, but `getBranchComponent()` still returned `package-name`; the release phase logged `PR component: undefined does not match configured component: CV_Site_Frontend` and returned before creating the tag. The component now matches, so the next run should tag #35.
|
||||
* **Evidence**: run 181 (task 578, immediately after #35 merged) - the reconcile step correctly left #35 for the action because its branch survived, then the action found #35, hit the component mismatch and aborted with "There are untagged, merged release PRs outstanding". The earlier label/branch fixes were correct; this was the remaining check.
|
||||
* **Expected result**: the run after this merge creates `v1.5.0` at the #35 merge commit (`a80c9eb`), marks #35 `autorelease: tagged`, and stops opening duplicate release PRs.
|
||||
|
||||
## 2026-10-31 (release-please reconcile step needs a checkout)
|
||||
|
||||
* **Fix**: [release-please.yml](../.gitea/workflows/release-please.yml) - added `actions/checkout@v4` before the reconcile step. The job had no checkout because the release-please action clones the repository into its own temp directory; the new step runs `scripts/reconcile-release-please.mjs` from the workspace, so the first post-merge run failed with `Cannot find module '/workspace/CV_Website/CV_Site_Nuxt/scripts/reconcile-release-please.mjs'` (task 571). The checkout supplies the file; the action still uses its own temp clone for the release branch.
|
||||
|
||||
## 2026-10-31 (PR #33 second review: release tag validated, pending PRs queried by label)
|
||||
|
||||
* **Fix**: [reconcile-release-please.mjs](../scripts/reconcile-release-please.mjs) - both PR-Agent findings were confirmed. A tag at the merge commit now counts only when it is exactly `v<manifest version>`; a foreign CI/annotation tag is logged and ignored. Pending release PRs are fetched through the `autorelease: pending` label filter instead of paging every closed PR, so a concurrent close cannot shift a page and hide one.
|
||||
* **Guard**: a merged PR without `merge_commit_sha`, or a manifest without a version, now fails loudly instead of producing `vundefined`.
|
||||
* **Verified locally**: dry-run against the live repo still matches #22 to `v1.4.0`; `pnpm lint`, `pnpm typecheck`, `pnpm build` and `pnpm audit --prod --audit-level moderate` pass on the rebased tree.
|
||||
* **Known issue**: PR-Agent's `/describe` posts `Failed to update PR description`; the bot token has `write:issue` but not the PR-edit scope. Recorded with the fix in [PR-Agent operations](pr-agent.md).
|
||||
|
||||
## 2026-10-31 (registry host corrected: Gitea's built-in registry on git.noelsabia.dev)
|
||||
|
||||
* **Correction**: `registry.noelsabia.dev` is gone from the documentation and the workflow. Gitea's built-in container registry is served on the Gitea hostname itself, so the image is **`git.noelsabia.dev/cv_website/nuxt:<tag>`** ([docs.gitea.com/usage/packages/container](https://docs.gitea.com/usage/packages/container/)). `registry.noelsabia.dev` was a separate hostname set up before that was known; the server-side setup is being reverted. No separate registry, no extra hostname, no extra certificate - Gitea already provides this by default.
|
||||
* **Update**: [publish-image.yml](../.gitea/workflows/publish-image.yml) - `IMAGE`, `docker login` and the v2 `manifests/<version>` immutability check all point at `git.noelsabia.dev`. [Publishing images to the own registry](decisions/registry-publishing.md) records the corrected host and the reason.
|
||||
|
||||
## 2026-10-31 (registry confirmed: Gitea's built-in container registry)
|
||||
|
||||
* **Confirmation**: Logged in and pushed by hand - push access works. The registry is **Gitea's built-in container registry** ([docs.gitea.com/usage/packages/container](https://docs.gitea.com/usage/packages/container/)), not a separately deployed component: it is served on the Gitea host, and the `/cv_website/` path segment is the organisation namespace. This is the default - no Registry/Harbor to stand up, nothing to reinvent. Host corrected in the entry above; see [Publishing images to the own registry](decisions/registry-publishing.md).
|
||||
|
||||
## 2026-10-30 (PR-Agent moved into the Gitea compose stack)
|
||||
|
||||
* **Refactor**: the `pr-agent` service now lives in `/home/noel/self-hosted/gitea/docker-compose.yml` with `/home/noel/self-hosted/gitea/pr-agent.env`. The separate `/home/noel/self-hosted/pr-agent` stack and the unused `/opt` operator-access scripts were removed; the service is managed with the Gitea stack.
|
||||
* **Docs**: the operator README moved to [PR-Agent operations](pr-agent.md). The decision, index and update log point at the new topology.
|
||||
* **Evidence**: after the move, the container is healthy, a signed webhook from the Gitea container returns 200, and a direct `glm-5.3-flash` call returns `OK`.
|
||||
|
||||
## 2026-10-30 (PR #28: lockfile and PR-Agent routing repaired)
|
||||
|
||||
* **Fix**: `pnpm-lock.yaml` - merging `main` left the lockfile at `@nuxt/icon` 2.6.0 while `package.json` asked for 2.6.2, so `pnpm install --frozen-lockfile` aborted in CI. The lockfile now resolves 2.6.2.
|
||||
* **Fix**: `pnpm-workspace.yaml` - `seroval` 1.6.9 was the two moderate audit findings (GHSA-f86p-h4j2-7qgj, GHSA-9wx9-5pv9-3349). The patched 1.6.11 is forced through `overrides`; the blocking audit now reports only two low-severity advisories and passes the moderate gate.
|
||||
* **Fix**: PR-Agent model routing - OpenCode Go rejects requests without `x-opencode-session`; `LITELLM__EXTRA_HEADERS` now supplies it, and the fallback keeps the `openai/` prefix. Auto commands are `/describe` and `/review`; `/improve` is on demand. A dummy-key call reaches the provider's auth check instead of failing on the missing header.
|
||||
* **Evidence**: the key was wired into the live `.env`; a direct `glm-5.3-flash` call returned `OK`, and `/review` on PR #28 posted a PR Reviewer Guide (no findings). The failed-review comment was removed.
|
||||
* **State**: the key is set only in `gitea/pr-agent.env`; the first `/review` posted on PR #28 with no findings.
|
||||
|
||||
## 2026-10-30 (PR-Agent replaces the opencode review job)
|
||||
|
||||
* **Decision**: [PR-Agent for Gitea reviews](decisions/pr-agent.md) - a pinned `pragent/pr-agent:0.49.0-gitea_app` container on `server0` reviews PRs through the Gitea bot user `pr-agent`; the endpoint stays on the `gitea_gitea` Docker network.
|
||||
* **Update**: [pr-checker.yml](../.gitea/workflows/pr-checker.yml) - removed the `review` job, the opencode installer and the verdict-posting step. PR-Agent now runs `/describe` and `/review` on PR open/reopen and answers slash commands.
|
||||
* **Creation**: `deploy/pr-agent/` (later removed; the service now lives in the Gitea compose stack) - compose service, example environment and operator README. The real `.env` lived only at `/home/noel/self-hosted/pr-agent/.env` (mode 600) on `server0`.
|
||||
* **State**: the container is running and the webhook signature path is verified. Gitea gained `[webhook] ALLOWED_HOST_LIST = private:3000` (one restart, healthy) and the repository has a signed webhook. The OpenCode Go API key was still missing at commit time, so no model call or real review has run yet.
|
||||
|
||||
## 2026-10-31 (manual publish rehearsal without a tag)
|
||||
|
||||
* **Creation**: [publish-image.yml](../.gitea/workflows/publish-image.yml) gained `workflow_dispatch` with `version`, `push` and `latest` inputs. Default is **build + smoke test only** (`push=false`): no tag, no package version, immutability guard skipped, `latest` never moved unless explicitly requested. Use it to verify the `publish` runner (socket + `automount`) before the first release. Manual runs do not replace the tag path - a published image still always maps to a release tag.
|
||||
|
||||
## 2026-10-31 (audit green again: nuxt 4.6.3 and dependency overrides)
|
||||
|
||||
* **Fix**: `pnpm audit --prod --audit-level moderate` failed on every branch (#30, #31, #33 and this PR) - new advisories plus a Nuxt patch release. `nuxt` 4.6.2 -> **4.6.3** clears GHSA-9v7c-q64q-vv33 (dot-segment middleware bypass), GHSA-3xf4-9g3c-4h4w and GHSA-x287-wcfc-q46c (dev-server file read/runtime config).
|
||||
* **Fix**: [pnpm-workspace.yaml](../pnpm-workspace.yaml) - overrides for `node-forge: 1.4.1` (the old GHSA-86w9-cpqp-85rv ignore is removed - a patch exists now) and `glob@>=9.0.0 <=14.0.1: 14.0.2` (GHSA-3g3m-2fjr-6pw4; glob 7 is kept for tailwind-config-viewer).
|
||||
* **Decision**: minimatch GHSA-g3hv-75wg-m249 stays a reviewed ignore. Its patch (11.0.1) dropped `makeRe`, which `eslint-plugin-import-x` imports - forcing it makes `pnpm lint` fail with "does not provide an export named 'makeRe'" (measured). All affected paths are build/lint-time. See [Vulnerability audit policy](decisions/vulnerability-audit-policy.md).
|
||||
* **Verified locally**: `pnpm lint`, `pnpm typecheck`, `pnpm build` and the exact audit command all pass on the merged tree.
|
||||
|
||||
## 2026-10-27 (release-please still never tagged: the deleted head branch)
|
||||
|
||||
* **Fix**: [release-please-config.json](../release-please-config.json) gained `"changelog-host": "https://git.noelsabia.dev"` - the changelog compare links were generated against `github.com/CV_Website/CV_Site_Nuxt`, a host this repository does not live on. Root cause of the missing tags: **Gitea rewrites `head.ref` to `refs/pull/<n>/head` when the merged PR's branch is deleted**, and release-please parses that field as the release branch, so `BranchName.parse` fails and the release is dropped - silently, exit code 0. Evidence: run 143 (task 475) logs `✖ Bad branch name: refs/pull/22/head` right after `Found pull request #22`, then `Expected 1 releases, only found 0`; #22 did carry `autorelease: pending`. The repository deleted every merged branch (`default_delete_branch_after_merge: true`); it is `false` now. Four versions (1.1.0-1.4.0) were consumed by the manifest with no tag ever created, so the release baseline has to be restored by hand. See [Release engineering](decisions/release-engineering.md).
|
||||
@@ -10,7 +80,7 @@
|
||||
|
||||
## 2026-10-24 (release publishes an image)
|
||||
|
||||
* **Creation**: [publish-image.yml](../.gitea/workflows/publish-image.yml) - a `vX.Y.Z` tag push builds `Dockerfile` on the arm64 runner and pushes `registry.noelsabia.dev/cv_website/nuxt` as the version and `sha-<12>`, plus `latest` when that tag is the newest release. Main pushes deliberately do not build: the registry holds releases, not commits. The job uses the runner's own Docker daemon (client only in the `node:22-bookworm` container), so the act_runner needs `container.docker_host: automount`; the first step fails with that cause if it is missing. That socket is root-equivalent, so it may only sit on a label PR jobs cannot use - recorded under the trust boundary in [Publishing images to the own registry](decisions/registry-publishing.md). Repo secrets: `REGISTRY_USERNAME`, `REGISTRY_PASSWORD`.
|
||||
* **Creation**: [publish-image.yml](../.gitea/workflows/publish-image.yml) - a `vX.Y.Z` tag push builds `Dockerfile` on the arm64 runner and pushes `git.noelsabia.dev/cv_website/nuxt` as the version and `sha-<12>`, plus `latest` when that tag is the newest release. Main pushes deliberately do not build: the registry holds releases, not commits. The job uses the runner's own Docker daemon (client only in the `node:22-bookworm` container), so the act_runner needs `container.docker_host: automount`; the first step fails with that cause if it is missing. That socket is root-equivalent, so it may only sit on a label PR jobs cannot use - recorded under the trust boundary in [Publishing images to the own registry](decisions/registry-publishing.md). Repo secrets: `REGISTRY_USERNAME`, `REGISTRY_PASSWORD`.
|
||||
* **Review follow-up** (PR #19, 1 BLOCKER + 4 WARN + 2 NIT): applied the strict `vMAJOR.MINOR.PATCH` check, the newest-release rule for `latest`, a smoke test that starts the image and requires 2xx on `/`, and `timeout-minutes: 20`. Rejected with evidence: the `.dockerignore` leak (`.env*`, `*.pem`, `.git` are excluded) and the Docker-client/daemon API mismatch (20.10.24 client against a 29.9.2 daemon built successfully over the socket).
|
||||
* **Second review follow-up** (PR #19): the job now runs on the dedicated `publish` label instead of `ubuntu-latest`, so the host socket it needs can never be shared with PR jobs - the earlier version required a runner configuration its own trust boundary forbade. Added the immutability guard (registry v2 `manifests/<version>`: `200` aborts, `404` continues) after measuring that `docker manifest inspect` fails on OCI indexes with the pinned 20.10 client; the smoke test now also requires a rendered body (10 kB floor) rather than a bare 2xx. `.github/actionlint.yaml` declares the custom label, and the hook passes it with `-config-file` because this repo keeps workflows in `.gitea/`.
|
||||
|
||||
|
||||
@@ -16,7 +16,8 @@ generated: { by: opencode-go/glm-5.3-flash, at: 2026-10-18T12:41:52Z }
|
||||
| Whether these decisions stay in this bundle or fold into the sibling `OKF_CV_Website` bundle, which already describes the frontend at design level | after the production image exists | None. |
|
||||
| When and how often Snyk runs once re-enabled: weekly schedule, ready-for-review gate, or per-push | re-enabling the snyk job | Stay disabled. |
|
||||
| Whether the AI review job should gate merges (required status check on the verdict) or stay advisory | branch protection setup | Advisory. The review comment is information; blocking merges on an AI verdict is a policy choice, not a technical one. |
|
||||
| How the opencode CLI version in CI gets upgraded: manually bump the pinned 2.0.32, or automate when a new major appears | first review failure after an opencode release | Manual bump. Pinning exists so upgrades are decisions. |
|
||||
| ~~How the opencode CLI version in CI gets upgraded~~ - **closed** (2026-10-30): the opencode job was removed; the review path is a pinned PR-Agent container. See [PR-Agent for Gitea reviews](decisions/pr-agent.md) | done | — |
|
||||
| Whether `glm-5.3-flash` through PR-Agent produces acceptable reviews on this repository | first PR after the OpenCode Go key is set | Keep it; `glm-5.3` is the configured fallback. |
|
||||
| ~~Whether the Go plan's per-model usage windows survive real review frequency, and which model the review should use~~ - **decided** (2026-10-20): review model is `opencode-go/claude-haiku-5-5#medium` in [pr-checker.yml](../.gitea/workflows/pr-checker.yml). Cheap per token, and it has a real `#medium` effort level; `deepseek-v4.1-flash` only exposes low/high/max, so it always paid for maximum reasoning. The earlier pro -> flash switch (two consecutive `Endpoint is unavailable` failures) is in the [log](../log.md) | done | — |
|
||||
| Removing the two reviewed audit ignores when `node-forge` or `braces` ship patched releases | next dependency update round | Watch for new releases. |
|
||||
|
||||
|
||||
@@ -0,0 +1,133 @@
|
||||
---
|
||||
type: Reference
|
||||
title: PR-Agent operations
|
||||
description: The Gitea-side pull-request review service, its configuration in the Gitea compose stack, and the commands it answers.
|
||||
tags: [pr-agent, gitea, operations, ci, ai]
|
||||
status: draft
|
||||
generated: { by: opencode-go/deepseek-v4.1-flash, at: 2026-10-30T20:40:00Z }
|
||||
verified: { by: human:noel, at: not yet }
|
||||
sources:
|
||||
- id: gitea-compose
|
||||
resource: /home/noel/self-hosted/gitea/docker-compose.yml
|
||||
title: Gitea compose stack, pr-agent service
|
||||
- id: install
|
||||
resource: https://docs.pr-agent.ai/installation/gitea/
|
||||
title: PR-Agent Gitea installation
|
||||
- id: gitea-egress
|
||||
resource: https://docs.gitea.com/administration/config-cheat-sheet#webhook
|
||||
title: Gitea webhook egress allowlist
|
||||
---
|
||||
|
||||
# What runs
|
||||
|
||||
PR-Agent is the `pr-agent` service inside the Gitea compose stack on
|
||||
`server0`. It listens on the internal `gitea_gitea` network at
|
||||
`http://pr-agent:3000`; no port is published. Gitea calls its signed
|
||||
webhook at `/api/v1/gitea_webhooks`, and the bot user `pr-agent` posts the
|
||||
results.
|
||||
|
||||
| Piece | Value |
|
||||
|---|---|
|
||||
| Service | `pr-agent` in `/home/noel/self-hosted/gitea/docker-compose.yml` |
|
||||
| Image | `pragent/pr-agent:0.49.0-gitea_app` |
|
||||
| Config | `/home/noel/self-hosted/gitea/pr-agent.env` (mode 600) |
|
||||
| Logs | `cd /home/noel/self-hosted/gitea && docker compose logs -f pr-agent` |
|
||||
| Restart | `cd /home/noel/self-hosted/gitea && docker compose up -d pr-agent` |
|
||||
| Upgrade | bump the image tag in the compose file, then restart the service |
|
||||
|
||||
The service is managed with the same access as the rest of the Gitea
|
||||
stack. The earlier plan for a separate `/opt/pr-agent` stack and a
|
||||
restricted `agent` account was not applied; those scripts were removed when
|
||||
the service moved into this stack. Hardening the Gitea stack's operator
|
||||
access is a separate change.
|
||||
|
||||
# Gitea side
|
||||
|
||||
1. Bot user `pr-agent` is a collaborator with write permission on
|
||||
`CV_Website/CV_Site_Nuxt`. Its personal access token is scoped to
|
||||
`read:repository`, `write:issue` and `read:user`.
|
||||
2. The repository webhook sends `push`, `issues`, `pull_request` and
|
||||
`issue_comment` events, with JSON content type and the shared secret.
|
||||
3. Gitea's `[webhook] ALLOWED_HOST_LIST` includes `private:3000`. Without
|
||||
it, Gitea's default egress policy refuses deliveries to the Docker
|
||||
network.
|
||||
|
||||
# Known issue: "Failed to update PR description"
|
||||
|
||||
On PR #33 (2026-10-31) `/describe` posted `Failed to update PR description`
|
||||
before the reviewer guide. Comments work because the bot token has
|
||||
`write:issue`; editing the PR body is a repository-route write and needs
|
||||
`write:repository` as well. Add that scope to the `pr-agent` token and
|
||||
restart the service, or remove `/describe` from `GITEA__PR_COMMANDS` if the
|
||||
description update is not wanted. The review comment is still posted; this
|
||||
affects only the description sync.
|
||||
|
||||
# Commands
|
||||
|
||||
| Trigger | What runs |
|
||||
|---|---|
|
||||
| PR opened or reopened | `/describe` and `/review` automatically |
|
||||
| New push to an open PR | nothing; comment `/review` or `/review -i` |
|
||||
| Comment `/review`, `/improve`, `/ask` | that command |
|
||||
|
||||
`/review -i` reviews only the commits added since the previous review.
|
||||
`/improve` stays on demand; adding it to the auto list would make a second
|
||||
model call and a second comment on every PR. Draft PRs are not skipped.
|
||||
|
||||
# Configuration
|
||||
|
||||
`pr-agent.env` holds the deployment values. The repository never contains
|
||||
the token, webhook secret, or API key:
|
||||
|
||||
```ini
|
||||
CONFIG__GIT_PROVIDER=gitea
|
||||
GITEA__URL=http://gitea:3000
|
||||
GITEA__WEB_URL=https://git.noelsabia.dev
|
||||
GITEA__PERSONAL_ACCESS_TOKEN=...
|
||||
GITEA__WEBHOOK_SECRET=...
|
||||
CONFIG__MODEL=openai/glm-5.3-flash
|
||||
CONFIG__FALLBACK_MODELS=["openai/glm-5.3"]
|
||||
CONFIG__CUSTOM_MODEL_MAX_TOKENS=128000
|
||||
OPENAI__API_BASE=https://opencode.ai/inference/go/openai/v1
|
||||
OPENAI__KEY=...
|
||||
LITELLM__EXTRA_HEADERS={"x-opencode-session":"pr-agent"}
|
||||
GITEA__PR_COMMANDS=["/describe","/review"]
|
||||
```
|
||||
|
||||
OpenCode Go requires the `x-opencode-session` header. The fallback keeps
|
||||
the `openai/` prefix; a bare `glm-5.3` is treated by LiteLLM as a
|
||||
provider-less model. `CONFIG__CUSTOM_MODEL_MAX_TOKENS` supplies the context
|
||||
limit; the effective review budget is capped by PR-Agent's default
|
||||
`max_model_tokens` of 32000.
|
||||
|
||||
The compose service:
|
||||
|
||||
```yaml
|
||||
pr-agent:
|
||||
image: pragent/pr-agent:0.49.0-gitea_app
|
||||
container_name: pr-agent
|
||||
restart: unless-stopped
|
||||
env_file:
|
||||
- ./pr-agent.env
|
||||
environment:
|
||||
PORT: "3000"
|
||||
GUNICORN_WORKERS: "2"
|
||||
mem_limit: 1g
|
||||
networks:
|
||||
- gitea
|
||||
healthcheck:
|
||||
test: ["CMD", "python", "-c", "import socket; socket.create_connection(('127.0.0.1', 3000), 3).close()"]
|
||||
interval: 30s
|
||||
timeout: 5s
|
||||
retries: 3
|
||||
start_period: 30s
|
||||
```
|
||||
|
||||
# Checks
|
||||
|
||||
A signed webhook from the Gitea container returns 200, and a direct
|
||||
`glm-5.3-flash` call returns a completion. A `403` in the Gitea webhook
|
||||
delivery log means the secret does not match or `ALLOWED_HOST_LIST` is
|
||||
missing; a `401` from PR-Agent means the signature and secret disagree.
|
||||
On a model failure, check `docker compose logs pr-agent` and confirm
|
||||
`OPENAI__KEY` is set in `pr-agent.env`.
|
||||
+3
-3
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "nuxt-app",
|
||||
"version": "1.4.0",
|
||||
"version": "1.5.2",
|
||||
"type": "module",
|
||||
"private": true,
|
||||
"engines": {
|
||||
@@ -20,11 +20,11 @@
|
||||
},
|
||||
"dependencies": {
|
||||
"@iconify-json/material-symbols": "^1.2.95",
|
||||
"@nuxt/icon": "2.6.0",
|
||||
"@nuxt/icon": "2.6.2",
|
||||
"@nuxtjs/i18n": "10.6.0",
|
||||
"@nuxtjs/seo": "6.0.1",
|
||||
"@nuxtjs/tailwindcss": "6.14.0",
|
||||
"nuxt": "^4.6.2",
|
||||
"nuxt": "^4.6.3",
|
||||
"vue": "^3.5.43",
|
||||
"vue-router": "^5.4.0"
|
||||
},
|
||||
|
||||
Generated
+1323
-1266
File diff suppressed because it is too large.
Load diff
+35
-8
@@ -2,15 +2,21 @@ allowBuilds:
|
||||
esbuild: true
|
||||
unrs-resolver: true
|
||||
auditConfig:
|
||||
# Reviewed ignores for advisories with NO patched release (verified against
|
||||
# the advisory database and npm registries on 2026-10-18: node-forge 1.4.0
|
||||
# and braces 3.0.3 are the newest published versions). Both packages are
|
||||
# build-time-only paths under nitropack (listhen dev-cert generation,
|
||||
# globby file globbing) - not in the running server's bundle. Remove an
|
||||
# entry when a patched version ships.
|
||||
# Reviewed ignores for advisories with NO patched release, or whose patch
|
||||
# is incompatible with a consumer in this tree. braces is unfixable
|
||||
# (3.0.3 is still newest); minimatch's patch (11.0.1) breaks ESLint -
|
||||
# both are build-time-only paths. node-forge was removed from this list
|
||||
# on 2026-10-31 when 1.4.1 shipped and is now forced through `overrides`.
|
||||
# Remove an entry when a compatible patched version ships.
|
||||
ignoreGhsas:
|
||||
- GHSA-86w9-cpqp-85rv
|
||||
- GHSA-vfj7-8cjw-p6xm
|
||||
# GHSA-g3hv-75wg-m249 (minimatch DoS): the patched 11.0.1 dropped the
|
||||
# `makeRe` export that eslint-plugin-import-x imports, so `pnpm lint`
|
||||
# fails with "does not provide an export named 'makeRe'"; forcing it
|
||||
# also breaks ESLint's config loader. Affected paths are build/lint
|
||||
# only (Nitro, i18n, ESLint via vite-plugin-checker), never in the
|
||||
# server bundle.
|
||||
- GHSA-g3hv-75wg-m249
|
||||
overrides:
|
||||
# Fixable advisories get the patched version forced here, not an ignore
|
||||
# (audit policy: upgrade when a patch exists).
|
||||
@@ -20,7 +26,23 @@ overrides:
|
||||
# already in the tree via postcss-nesting and is API-compatible. Remove
|
||||
# the override when tailwindcss ships >= 7.1.6 itself (or the site moves
|
||||
# to Tailwind v4).
|
||||
postcss-selector-parser: 7.1.6
|
||||
postcss-selector-parser: 7.2.1
|
||||
# GHSA-f86p-h4j2-7qgj and GHSA-9wx9-5pv9-3349 (moderate, 2026-10-30):
|
||||
# seroval < 1.6.11 allows code/script injection through serialized output.
|
||||
# Nuxt's vite-builder still resolves 1.6.9; the patched 1.6.11 is the
|
||||
# smallest version that clears both advisories. Remove this when Nuxt ships
|
||||
# a vite-builder that resolves >= 1.6.11 itself.
|
||||
seroval: 1.8.0
|
||||
# GHSA-g3hv-75wg-m249 (moderate, 2026-10-31): minimatch < 11.0.1 has a
|
||||
# globparts amplification DoS. Deliberately NOT overridden - see the
|
||||
# auditConfig ignore note above.
|
||||
# GHSA-3g3m-2fjr-6pw4 (moderate, 2026-10-31): glob 9.0.0-14.0.1 bypasses
|
||||
# AbortSignal cancellation. Patched in 14.0.2; the range keeps glob 7 for
|
||||
# tailwind-config-viewer.
|
||||
"glob@>=9.0.0 <=14.0.1": 14.0.6
|
||||
# node-forge 1.4.1 shipped (2026-10-31) and clears every node-forge
|
||||
# advisory that was previously ignored - no ignore needed anymore.
|
||||
node-forge: 1.4.1
|
||||
minimumReleaseAgeExclude:
|
||||
- '@rollup/rollup-darwin-x64@4.64.8'
|
||||
- '@rollup/rollup-freebsd-arm64@4.64.8'
|
||||
@@ -34,3 +56,8 @@ minimumReleaseAgeExclude:
|
||||
- '@rollup/rollup-openharmony-arm64@4.64.8'
|
||||
- '@rollup/rollup-win32-ia32-msvc@4.64.8'
|
||||
- '@nuxt/icon@2.6.0'
|
||||
permissions:
|
||||
'@nuxtjs/seo':
|
||||
skills:
|
||||
dirs:
|
||||
- .agents/skills
|
||||
@@ -6,7 +6,7 @@
|
||||
"changelog-host": "https://git.noelsabia.dev",
|
||||
"packages": {
|
||||
".": {
|
||||
"package-name": "CV_Site_Frontend",
|
||||
"package-name": "",
|
||||
"changelog-path": "CHANGELOG.md",
|
||||
"extra-files": [],
|
||||
"versioning": "default"
|
||||
|
||||
@@ -0,0 +1,205 @@
|
||||
// Repairs the release-please state that its Gitea fork cannot recover from.
|
||||
//
|
||||
// Why this exists (evidence in OKF_Nuxt/decisions/release-engineering.md):
|
||||
//
|
||||
// Gitea rewrites a merged PR's `head.ref` to `refs/pull/<n>/head` when the
|
||||
// head branch is deleted. The fork parses that field as the release branch,
|
||||
// logs `Bad branch name`, creates no tag - and still exits successfully.
|
||||
// The merged PR keeps `autorelease: pending`, so every later run aborts with
|
||||
// `There are untagged, merged release PRs outstanding` and opens no new
|
||||
// release PR. That is a permanent deadlock, not a transient failure.
|
||||
//
|
||||
// This script runs before the action and reconciles the state:
|
||||
//
|
||||
// * a merged pending PR whose merge commit already has the expected
|
||||
// `v<manifest version>` tag -> swap `autorelease: pending` for
|
||||
// `autorelease: tagged` (the release exists, only the label is stale);
|
||||
// * a merged pending PR whose head branch is gone and has no expected tag
|
||||
// -> create the tag from the version recorded in the manifest at that
|
||||
// merge commit. This is exactly the tag release-please would have made if
|
||||
// the branch had survived; without it the PR blocks every future release;
|
||||
// * a merged pending PR whose head branch still exists -> leave it alone,
|
||||
// release-please tags it in the same run.
|
||||
//
|
||||
// Pending PRs are looked up by the label itself, not by paging through every
|
||||
// closed PR: the set is tiny (normally zero or one) and cannot race with PRs
|
||||
// closing while the pages are being read.
|
||||
//
|
||||
// Run locally against the public API with:
|
||||
// DRY_RUN=1 node scripts/reconcile-release-please.mjs
|
||||
// Reads work unauthenticated for a public repository; writes are skipped.
|
||||
|
||||
const API_URL = process.env.GITHUB_API_URL
|
||||
const REPOSITORY = process.env.GITHUB_REPOSITORY
|
||||
const TOKEN = process.env.GITEA_TOKEN
|
||||
const DRY_RUN = process.env.DRY_RUN === '1' || process.argv.includes('--dry-run')
|
||||
|
||||
const PENDING = 'autorelease: pending'
|
||||
const TAGGED = 'autorelease: tagged'
|
||||
const MANIFEST = '.release-please-manifest.json'
|
||||
|
||||
if (!API_URL || !REPOSITORY) {
|
||||
console.error('::error::GITHUB_API_URL and GITHUB_REPOSITORY must be set')
|
||||
process.exit(1)
|
||||
}
|
||||
if (!TOKEN && !DRY_RUN) {
|
||||
console.error('::error::GITEA_TOKEN is required (or set DRY_RUN=1)')
|
||||
process.exit(1)
|
||||
}
|
||||
|
||||
const repoUrl = `${API_URL}/repos/${REPOSITORY}`
|
||||
|
||||
const api = async (path, init = {}) => {
|
||||
const response = await fetch(`${repoUrl}${path}`, {
|
||||
...init,
|
||||
headers: {
|
||||
Accept: 'application/json',
|
||||
...(TOKEN ? { Authorization: `token ${TOKEN}` } : {}),
|
||||
...(init.headers ?? {}),
|
||||
},
|
||||
})
|
||||
const body = await response.text()
|
||||
if (!response.ok) {
|
||||
throw new Error(`${init.method ?? 'GET'} ${path} -> HTTP ${response.status}: ${body.slice(0, 300)}`)
|
||||
}
|
||||
return body ? JSON.parse(body) : null
|
||||
}
|
||||
|
||||
// Gitea caps page size at 50. The label-filtered issue list is normally one
|
||||
// page; loop anyway so a backlog of stale pending PRs is still reconciled.
|
||||
const listAll = async (path, params = {}) => {
|
||||
const items = []
|
||||
for (let page = 1; ; page++) {
|
||||
const query = new URLSearchParams({ ...params, limit: '50', page: String(page) })
|
||||
const batch = await api(`${path}?${query}`)
|
||||
items.push(...batch)
|
||||
if (batch.length < 50) return items
|
||||
}
|
||||
}
|
||||
|
||||
const replaceLabels = async (number, labels) => {
|
||||
if (DRY_RUN) {
|
||||
console.log(`[dry-run] #${number}: labels -> ${labels.join(', ')}`)
|
||||
return
|
||||
}
|
||||
await api(`/issues/${number}/labels`, {
|
||||
method: 'PUT',
|
||||
headers: { 'Content-Type': 'application/json' },
|
||||
body: JSON.stringify({ labels }),
|
||||
})
|
||||
}
|
||||
|
||||
const createTag = async (name, sha) => {
|
||||
if (DRY_RUN) {
|
||||
console.log(`[dry-run] create tag ${name} at ${sha}`)
|
||||
return
|
||||
}
|
||||
await api('/tags', {
|
||||
method: 'POST',
|
||||
headers: { 'Content-Type': 'application/json' },
|
||||
body: JSON.stringify({ tag_name: name, target: sha, message: `Release ${name}` }),
|
||||
})
|
||||
}
|
||||
|
||||
const versionAt = async (sha) => {
|
||||
const file = await api(`/contents/${MANIFEST}?ref=${sha}`)
|
||||
if (!file?.content) throw new Error(`no manifest content at ${sha}`)
|
||||
const manifest = JSON.parse(Buffer.from(file.content, 'base64').toString('utf8'))
|
||||
// Single-package repository: the root path is ".". Keep a fallback so a
|
||||
// future second package cannot silently produce `vundefined`.
|
||||
const version = manifest['.'] ?? Object.values(manifest)[0]
|
||||
if (!version) throw new Error(`manifest at ${sha} has no version`)
|
||||
return version
|
||||
}
|
||||
|
||||
const run = async () => {
|
||||
// One tag can point at the merge commit for a non-release reason (CI
|
||||
// tooling, a manual annotation). Only the `v<manifest version>` tag proves
|
||||
// the release exists; every other tag at that commit is ignored.
|
||||
const tags = await listAll('/tags')
|
||||
const tagsAtSha = new Map()
|
||||
const tagSha = new Map()
|
||||
for (const tag of tags) {
|
||||
const sha = tag.commit?.sha
|
||||
if (!sha) continue
|
||||
if (!tagsAtSha.has(sha)) tagsAtSha.set(sha, [])
|
||||
tagsAtSha.get(sha).push(tag.name)
|
||||
tagSha.set(tag.name, sha)
|
||||
}
|
||||
|
||||
const pendingIssues = await listAll('/issues', {
|
||||
state: 'closed',
|
||||
type: 'pulls',
|
||||
labels: PENDING,
|
||||
})
|
||||
if (pendingIssues.length === 0) {
|
||||
console.log('No merged release PR is pending - nothing to reconcile.')
|
||||
return
|
||||
}
|
||||
|
||||
const failures = []
|
||||
const versionCache = new Map()
|
||||
|
||||
for (const issue of pendingIssues) {
|
||||
const pull = await api(`/pulls/${issue.number}`)
|
||||
if (!pull.merged_at) continue
|
||||
|
||||
const mergeSha = pull.merge_commit_sha
|
||||
if (!mergeSha) {
|
||||
failures.push(`#${pull.number}: merged PR has no merge_commit_sha`)
|
||||
continue
|
||||
}
|
||||
const headRef = pull.head?.ref ?? ''
|
||||
const branchGone = headRef.startsWith('refs/pull/') || headRef === ''
|
||||
const labels = (pull.labels ?? []).map(label => label.name)
|
||||
if (!versionCache.has(mergeSha)) versionCache.set(mergeSha, await versionAt(mergeSha))
|
||||
const expectedTag = `v${versionCache.get(mergeSha)}`
|
||||
const tagsHere = tagsAtSha.get(mergeSha) ?? []
|
||||
|
||||
if (tagsHere.includes(expectedTag)) {
|
||||
console.log(`#${pull.number}: ${expectedTag} already points at merge commit ${mergeSha} - marking as tagged`)
|
||||
const next = labels.filter(name => name !== PENDING)
|
||||
if (!next.includes(TAGGED)) next.push(TAGGED)
|
||||
await replaceLabels(pull.number, next)
|
||||
continue
|
||||
}
|
||||
|
||||
if (tagsHere.length > 0) {
|
||||
console.log(`#${pull.number}: ignoring non-release tag(s) at merge commit: ${tagsHere.join(', ')}`)
|
||||
}
|
||||
|
||||
if (!branchGone) {
|
||||
console.log(`#${pull.number}: head branch ${headRef} still exists - leaving it for release-please to tag`)
|
||||
continue
|
||||
}
|
||||
|
||||
// The branch is gone and the expected tag is missing, so release-please
|
||||
// will never get past `Bad branch name` for this PR. Recreate the tag it
|
||||
// should have made, using the version the merged release PR wrote into the
|
||||
// manifest.
|
||||
try {
|
||||
if (tagSha.has(expectedTag)) {
|
||||
throw new Error(`${expectedTag} already exists at ${tagSha.get(expectedTag)}, not at merge commit ${mergeSha}; refusing to move a release tag`)
|
||||
}
|
||||
console.log(`#${pull.number}: head branch is gone (${headRef}) - creating ${expectedTag} at ${mergeSha}`)
|
||||
await createTag(expectedTag, mergeSha)
|
||||
const next = labels.filter(name => name !== PENDING)
|
||||
if (!next.includes(TAGGED)) next.push(TAGGED)
|
||||
await replaceLabels(pull.number, next)
|
||||
}
|
||||
catch (error) {
|
||||
failures.push(`#${pull.number}: ${error.message}`)
|
||||
}
|
||||
}
|
||||
|
||||
if (failures.length > 0) {
|
||||
for (const failure of failures) console.error(`::error::${failure}`)
|
||||
console.error('::error::release-please state is unrecoverable automatically; repair the PR/tag by hand before the next release')
|
||||
process.exit(1)
|
||||
}
|
||||
}
|
||||
|
||||
run().catch((error) => {
|
||||
console.error(`::error::${error.message}`)
|
||||
process.exit(1)
|
||||
})
|
||||
Reference in new issue
Block a user