Compare commits

..
7 Commits
Author SHA1 Message Date
Noel 26abef948d Merge branch 'main' into renovate/nuxt-4.x-lockfile
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m19s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 7s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
2026-10-31 19:56:57 +00:00
Noel 0268a11e14 Merge pull request 'fix(ci): use an empty package-name so release-please tags v1.5.0' (#37) from fix/release-please-package-name into main
release-please / release-please (push) Successful in 17s
Reviewed-on: #37
2026-10-31 19:56:51 +00:00
Noel Sabia 42b07e9ab9 fix: updated pnpm lockfile
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m9s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
2026-10-31 20:55:05 +01:00
Noel Sabia c8250c9ca3 fix(ci): use an empty package-name so release-please tags v1.5.0
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m10s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 8s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
Removing package-name in #36 was not enough: the node strategy falls back to package.json name 'nuxt-app', so run 183 still failed with 'PR component: undefined does not match configured component: nuxt-app'.

An empty package-name is not nullish, so getBranchComponent() stays empty and matches the legacy release-please--branches--main branch. Verified by running the action's bundled release-please locally against the live Gitea API with writes intercepted: it produced POST /releases with tag_name v1.5.0 at a80c9eb and swapped #35 to autorelease: tagged. The official default release-type:node mode was tested the same way and still fails for #35.
2026-10-31 20:53:09 +01:00
Noel fdce59d77d Merge pull request 'fix(ci): remove the release-please component mismatch' (#36) from fix/release-please-component into main
release-please / release-please (push) Successful in 11s
Reviewed-on: #36
2026-10-31 19:43:35 +00:00
Noel Sabia e23f8d2618 fix(ci): remove the release-please component mismatch
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m59s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
PR #35 merged with its branch kept, but the release phase logged 'PR component: undefined does not match configured component: CV_Site_Frontend' and returned before creating the tag. With include-component-in-tag false the strategy component and release body component are empty, while getBranchComponent still returns package-name. Remove package-name so both sides are empty; the changelog headings are already version-only.

Evidence: run 181 (task 578) after #35 merged. The next run should create v1.5.0 at a80c9eb and mark #35 autorelease: tagged.
2026-10-31 20:34:49 +01:00
Noel 93fcd4127c chore(deps): update dependency nuxt to v4.6.3
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m8s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Failing after 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 4s
2026-10-31 04:02:31 +00:00
5 changed files with 1049 additions and 1092 deletions

No files matched your search

+60 -2
View File
@@ -152,6 +152,62 @@ Two details keep the reconciliation from suppressing a real release:
`v<manifest version>`. A CI or annotation tag on the same commit is
logged and ignored, and the release tag is still created.
# The release phase drops the PR on a component mismatch (2026-10-31)
With the branch kept and the label reconciled, PR #35 was still not
tagged. Run 181 (task 578, immediately after #35 merged) shows why:
```
❯ Found pull request #35: 'chore: release main'
...
⚠ PR component: undefined does not match configured component: CV_Site_Frontend
...
⚠ There are untagged, merged release PRs outstanding - aborting
```
`buildRelease()` compares the component parsed from the merged PR with the
strategy's component when the release body contains one component and that
component is empty. `include-component-in-tag: false` makes
`getComponent()` return an empty string, so the release PR is
`chore: release main` with an empty component and the branch is
`release-please--branches--main` (parsed component: undefined). But
`getBranchComponent()` ignores `include-component-in-tag` and returns
`package-name` - here `CV_Site_Frontend`. The two never match, so the
release is dropped before the tag is created.
Removing `package-name` is not enough. Run 183 (after #36 merged) shows
the node strategy falling back to the `package.json` name:
```
⚠ PR component: undefined does not match configured component: nuxt-app
```
`BaseStrategy.getDefaultPackageName()` is overridden by the node strategy
to read `package.json` `name`, so an absent `package-name` resolves to
`nuxt-app`.
The working setting is `"package-name": ""` (an empty string, not an
omitted key). An empty string is not nullish, so `getBranchComponent()`
returns empty and matches the legacy default branch
`release-please--branches--main`. This was verified by running the
action's bundled release-please 16.15.6 locally against the live Gitea
API, with writes intercepted: the release phase produced
```
POST /repos/CV_Website/CV_Site_Nuxt/releases
{"name":"v1.5.0","tag_name":"v1.5.0",...,"target_commitish":"a80c9ebf..."}
```
then swapped #35 to `autorelease: tagged`. That is release-please creating
the tag itself, not a manual `git tag`.
The action's official default mode (`release-type: node`, no manifest
config) was tested the same way and still fails for #35 with
`configured component: nuxt-app`. It cannot retroactively accept the
already-merged legacy PR; it would only help a release PR created after
the switch. The empty `package-name` is therefore the compatibility
setting that lets release-please finish v1.5.0.
# Recovering the versions that never got a tag
The label alone cannot recover them — #20, #21 and #22 all lost their head
@@ -176,8 +232,10 @@ whole history.
# Not verified
* That the release phase tags correctly once the head branch survives a
merge. The next release cycle proves it.
* That the live run tags #35. The exact release-phase request was verified
locally with writes intercepted (`POST /releases` with `tag_name:
v1.5.0` at `a80c9eb`); the run after merging the empty `package-name` is
the final proof.
* That the reconcile step's tag-creation fallback works with a live
token. Only the tag-already-exists path was exercised, in dry-run,
against the live PR #22. The fallback is written from the same Gitea
+13
View File
@@ -1,5 +1,18 @@
# Update Log
## 2026-10-31 (release-please tag: empty package-name is the verified fix)
* **Correction**: removing `package-name` in #36 was not enough. Run 183 shows the node strategy falling back to `package.json` `name`, so the release phase still failed with `PR component: undefined does not match configured component: nuxt-app`.
* **Fix**: [release-please-config.json](../release-please-config.json) sets `"package-name": ""`. An empty string is not nullish, so `getBranchComponent()` stays empty and matches the legacy `release-please--branches--main` branch. This is the only setting that lets release-please accept the already-merged #35.
* **Evidence**: the action's bundled release-please 16.15.6 was run locally against the live Gitea API with writes intercepted. It produced `POST /repos/CV_Website/CV_Site_Nuxt/releases` with `{"name":"v1.5.0","tag_name":"v1.5.0","target_commitish":"a80c9ebf..."}`, then swapped #35 to `autorelease: tagged`. The official default `release-type: node` mode was tested the same way and still fails for #35 with `configured component: nuxt-app`, so it cannot retroactively tag the legacy PR.
* **Expected result**: the run after this merge creates `v1.5.0` at `a80c9eb` through the release-please action itself. No manual `git tag`.
## 2026-10-31 (release-please component mismatch: no v1.5.0 tag)
* **Fix**: [release-please-config.json](../release-please-config.json) - removed `package-name: CV_Site_Frontend`. With `include-component-in-tag: false` the strategy component and the release PR body component are empty, but `getBranchComponent()` still returned `package-name`; the release phase logged `PR component: undefined does not match configured component: CV_Site_Frontend` and returned before creating the tag. The component now matches, so the next run should tag #35.
* **Evidence**: run 181 (task 578, immediately after #35 merged) - the reconcile step correctly left #35 for the action because its branch survived, then the action found #35, hit the component mismatch and aborted with "There are untagged, merged release PRs outstanding". The earlier label/branch fixes were correct; this was the remaining check.
* **Expected result**: the run after this merge creates `v1.5.0` at the #35 merge commit (`a80c9eb`), marks #35 `autorelease: tagged`, and stops opening duplicate release PRs.
## 2026-10-31 (release-please reconcile step needs a checkout)
* **Fix**: [release-please.yml](../.gitea/workflows/release-please.yml) - added `actions/checkout@v4` before the reconcile step. The job had no checkout because the release-please action clones the repository into its own temp directory; the new step runs `scripts/reconcile-release-please.mjs` from the workspace, so the first post-merge run failed with `Cannot find module '/workspace/CV_Website/CV_Site_Nuxt/scripts/reconcile-release-please.mjs'` (task 571). The checkout supplies the file; the action still uses its own temp clone for the release branch.
+970 -1089
View File
File diff suppressed because it is too large. Load diff
+5
View File
@@ -56,3 +56,8 @@ minimumReleaseAgeExclude:
- '@rollup/rollup-openharmony-arm64@4.64.8'
- '@rollup/rollup-win32-ia32-msvc@4.64.8'
- '@nuxt/icon@2.6.0'
permissions:
'@nuxtjs/seo':
skills:
dirs:
- .agents/skills
+1 -1
View File
@@ -6,7 +6,7 @@
"changelog-host": "https://git.noelsabia.dev",
"packages": {
".": {
"package-name": "CV_Site_Frontend",
"package-name": "",
"changelog-path": "CHANGELOG.md",
"extra-files": [],
"versioning": "default"