feat: index.vue #18

Merged
Noel merged 5 commits from feat/index.vue into main 2026-10-23 21:10:18 +00:00
Owner
No description provided.
Noel added 3 commits 2026-10-23 20:59:29 +00:00
Compose pages/index.vue from the desktop homepage mockup: decorative
backdrop scoped to the hero but not clipped at its bottom edge, hero with
status pill, quote and contact chips with copy buttons, terminal panel fed
by a chapter array with derived counters, and the three feature cards.

Split into app/components/home/ (auto-imported with the Home* prefix) and
keep the chapter data in app/data/chapters.ts so GET /api/chapters can
replace the mockup values later.
Contact bar: Gmail, Heilbronn and a LinkedIn link; the phone chip is
removed. Hero: System Architect / Programmer, new pill and quote.
Feature cards: humility, learning and helpfulness instead of the
infrastructure copy.

Terminal: six chapters from the LinkedIn export (PreZero active;
Defifort, Alignerr, Outlier, freelance and 42 finished), each with a
context label. Rows use a fixed grid so names, context badges, status,
uptime and outcome line up vertically; the title bar has red/yellow/green
traffic lights and the footer pluralises its counters (1/5/14).

OKF: new profile data document for the export and chapter mapping;
backend endpoint examples and totals match the real rows.
feat(ui): simplify terminal and contact bar on mobile
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 52s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 6s
PR Check / AI code review (opencode) (pull_request) Successful in 47s
47f4e64f24
Below lg the chapter rows show only the context badge and the status, so
the terminal no longer needs 760px on a phone; the desktop grid is
unchanged. The contact bar stacks the email full width and puts LinkedIn
and the location side by side.

Contact values truncate instead of forcing the bar wider. Also fixes the
"someone we pull" typo in the third feature card and lets the hero quote
use the wider column.
Author
Owner



build · claude-haiku-5-5
→ Read .pr-review-diff.patch
build · claude-haiku-5-5
[BLOCKER] app/components/home/HeroSection.vue:27 - The primary "Download CV (PDF)" button uses href="#", so it does nothing on a CV site. Point it at a real PDF (for example /cv.pdf in public/, with the file committed) and add the download attribute.

[BLOCKER] app/components/home/TerminalPanel.vue:26 and app/data/chapters.ts:21-26 - The terminal presents mock values as live telemetry: a "LIVE" badge, cv --runtime=active, uptime=100.0% on finished jobs, self_healed=14x, and "Cumulative Rebounds: 14 events". The profile.md notes say these are mock, but nothing on the page does. Publishing invented metrics about a real person's work is misleading to recruiters. Remove the numeric telemetry and the LIVE framing until /api/metrics exists, or label the values as illustrative in the UI.

[WARN] app/data/chapters.ts:26 - graduated is 2024, but the export says 2025 (profile.md:210-216 flags this as open). Resolve it against Profile.pdf before merge rather than shipping a known factual mismatch on a CV.

[WARN] app/data/chapters.ts:11 - uptime is a string ('99.98%') and rebounds is the frontend name, while backend-endpoints.md defines uptime as a number and selfHealed as the field name. The mismatch will bite when the Go gateway lands. Align the Chapter type with the documented contract (numeric uptime, selfHealed) and format % in ChapterRow.vue.

[WARN] app/components/home/TerminalPanel.vue:7-8 - The footer totals are computed in the browser, but backend-endpoints.md (section 3) says the footer "must not recompute them client-side". profile.md:50 also says the terminal derives its footer from the list. Either update the decision docs to match the implementation, or move the totals into the data source now. The docs currently contradict each other.

VERDICT: REQUEST_CHANGES

 > build · claude-haiku-5-5 → Read .pr-review-diff.patch > build · claude-haiku-5-5 [BLOCKER] app/components/home/HeroSection.vue:27 - The primary "Download CV (PDF)" button uses `href="#"`, so it does nothing on a CV site. Point it at a real PDF (for example `/cv.pdf` in `public/`, with the file committed) and add the `download` attribute. [BLOCKER] app/components/home/TerminalPanel.vue:26 and app/data/chapters.ts:21-26 - The terminal presents mock values as live telemetry: a "LIVE" badge, `cv --runtime=active`, `uptime=100.0%` on finished jobs, `self_healed=14x`, and "Cumulative Rebounds: 14 events". The profile.md notes say these are mock, but nothing on the page does. Publishing invented metrics about a real person's work is misleading to recruiters. Remove the numeric telemetry and the LIVE framing until `/api/metrics` exists, or label the values as illustrative in the UI. [WARN] app/data/chapters.ts:26 - `graduated` is `2024`, but the export says 2025 (profile.md:210-216 flags this as open). Resolve it against Profile.pdf before merge rather than shipping a known factual mismatch on a CV. [WARN] app/data/chapters.ts:11 - `uptime` is a string (`'99.98%'`) and `rebounds` is the frontend name, while backend-endpoints.md defines `uptime` as a number and `selfHealed` as the field name. The mismatch will bite when the Go gateway lands. Align the `Chapter` type with the documented contract (numeric `uptime`, `selfHealed`) and format `%` in `ChapterRow.vue`. [WARN] app/components/home/TerminalPanel.vue:7-8 - The footer totals are computed in the browser, but backend-endpoints.md (section 3) says the footer "must not recompute them client-side". profile.md:50 also says the terminal derives its footer from the list. Either update the decision docs to match the implementation, or move the totals into the data source now. The docs currently contradict each other. VERDICT: REQUEST_CHANGES
Noel added 2 commits 2026-10-23 21:07:50 +00:00
Conflicts:
- app/pages/index.vue: kept main's SEO setup (SITE, useSeoMeta,
  titleTemplate) alongside the branch's chapters import.
- OKF_Nuxt/log.md: both sides prepended entries; kept the profile and
  metrics entries above main's PR #16, SEO, favicon and icon entries.

Also takes main's @nuxtjs/seo and @nuxt/icon setup, favicon/OG assets,
site.config.mjs and the CI review changes. lint, typecheck and build pass
after a frozen-lockfile install.
Merge remote-tracking branch 'origin/main' into feat/index.vue
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Successful in 1m4s
PR Check / Secret scan (gitleaks) (pull_request) Successful in 6s
PR Check / Dependency audit (pull_request) Successful in 9s
PR Check / Dockerfile lint (droast) (pull_request) Successful in 5s
PR Check / AI code review (opencode) (pull_request) Successful in 42s
f1c4227375
Author
Owner



build · claude-haiku-5-5
→ Read .pr-review-diff.patch
build · claude-haiku-5-5
[BLOCKER] OKF_Nuxt/../app/components/home/HeroSection.vue:28: The primary "Download CV (PDF)" button is href="#", so the main call to action on a CV site goes nowhere. Point it at the real PDF (for example /cv/noel-sabia-cv.pdf in public/) with download, or remove the button until the file exists.

[WARN] app/data/chapters.ts:21-26: Every row has invented uptime values (99.98%, 100.0%), and prezero has a mock rebounds: 14. The terminal presents these as measured data beside a LIVE badge (TerminalPanel.vue:28) and a watch --interval=5s line, but nothing polls or measures anything. Recruiters will read these as real telemetry. Either hide the uptime and rebounds fields until /api/metrics exists, or label the panel as illustrative.

[WARN] app/data/chapters.ts:26: 42-school shows graduated=2024, but the export says 2023–2025. profile.md calls this an open discrepancy, yet the wrong value ships to production. Resolve it before merge, or hide the year.

[WARN] app/data/chapters.ts:1-8: The Chapter type does not match the API contract documented in OKF_Nuxt/backend-endpoints.md (around line 89). The type uses uptime: string and rebounds, while the contract uses uptime: number and selfHealed. The doc also says the page maps the response into Chapter "in one place", which will not work for a shape that differs in type and field name. Align the names and types now (for example uptime: number, selfHealed), and format % in the component.

[WARN] app/components/home/ChapterRow.vue:20: Below lg, the chapter name span is hidden, along with uptime and the detail span. On mobile, a row shows only the context label and status, so the chapter identity is lost. Show the name on all breakpoints and hide only the decorative prefix (chapter=).

[NIT] app/components/home/TerminalPanel.vue:16-17: sealedCount is derived as length - activeCount, which is correct only while every chapter is either active or finished. Filtering on status === 'finished' directly is more robust when the API adds a third status.

VERDICT: REQUEST_CHANGES

 > build · claude-haiku-5-5 → Read .pr-review-diff.patch > build · claude-haiku-5-5 **[BLOCKER] OKF_Nuxt/../app/components/home/HeroSection.vue:28**: The primary "Download CV (PDF)" button is `href="#"`, so the main call to action on a CV site goes nowhere. Point it at the real PDF (for example `/cv/noel-sabia-cv.pdf` in `public/`) with `download`, or remove the button until the file exists. **[WARN] app/data/chapters.ts:21-26**: Every row has invented `uptime` values (`99.98%`, `100.0%`), and `prezero` has a mock `rebounds: 14`. The terminal presents these as measured data beside a `LIVE` badge (`TerminalPanel.vue:28`) and a `watch --interval=5s` line, but nothing polls or measures anything. Recruiters will read these as real telemetry. Either hide the uptime and rebounds fields until `/api/metrics` exists, or label the panel as illustrative. **[WARN] app/data/chapters.ts:26**: `42-school` shows `graduated=2024`, but the export says 2023–2025. `profile.md` calls this an open discrepancy, yet the wrong value ships to production. Resolve it before merge, or hide the year. **[WARN] app/data/chapters.ts:1-8**: The `Chapter` type does not match the API contract documented in `OKF_Nuxt/backend-endpoints.md` (around line 89). The type uses `uptime: string` and `rebounds`, while the contract uses `uptime: number` and `selfHealed`. The doc also says the page maps the response into `Chapter` "in one place", which will not work for a shape that differs in type and field name. Align the names and types now (for example `uptime: number`, `selfHealed`), and format `%` in the component. **[WARN] app/components/home/ChapterRow.vue:20**: Below `lg`, the chapter `name` span is `hidden`, along with `uptime` and the detail span. On mobile, a row shows only the context label and status, so the chapter identity is lost. Show the name on all breakpoints and hide only the decorative prefix (`chapter=`). **[NIT] app/components/home/TerminalPanel.vue:16-17**: `sealedCount` is derived as `length - activeCount`, which is correct only while every chapter is either `active` or `finished`. Filtering on `status === 'finished'` directly is more robust when the API adds a third status. VERDICT: REQUEST_CHANGES
Noel merged commit ab022c9b57 into main 2026-10-23 21:10:18 +00:00
Noel deleted branch feat/index.vue 2026-10-23 21:10:19 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: CV_Website/CV_Site_Nuxt#18