Files
CV_Site_Nuxt/OKF_Nuxt/open-questions.md
Noel Sabia c626cc9c1d
PR Check / Security scan (Snyk) (pull_request) Skipped
PR Check / Lint + typecheck (pull_request) Canceled after 45s
PR Check / Secret scan (gitleaks) (pull_request) Canceled after 0s
PR Check / Dependency audit (pull_request) Canceled after 0s
PR Check / Dockerfile lint (droast) (pull_request) Canceled after 0s
feat(ci): replace opencode review with PR-Agent
Run PR-Agent as a pinned webhook server on the Gitea Docker network and review on PR open plus slash commands. The per-PR opencode installer and verdict-posting step are removed.

The server-side .env stays outside the repository; deploy/pr-agent/ holds the compose definition and operator notes.
2026-10-30 21:00:53 +01:00

46 lines
3.8 KiB
Markdown

---
type: Open Questions
title: Open questions
description: Decisions still to make for the Nuxt site, with what needs each answer.
tags: [decision, open]
status: draft
generated: { by: opencode-go/glm-5.3-flash, at: 2026-10-18T12:41:52Z }
---
| Question | Needed by | Default if nobody decides |
|---|---|---|
| ~~Shape of the production image~~ - **decided**: runnable Node server, see [production image](decisions/production-image.md) | done | — |
| How the compose service mounts the source: the whole repository plus a volume for `node_modules`, or only the directories that get edited | finishing `Local_Development/docker-compose.yml` | None. The compose file is not yet valid. |
| Which pnpm version the production image pins | ~~writing the production image~~ **decided**: 11.26.0, same as dev ([production image](decisions/production-image.md)) | done |
| How the gateway serves the site now that the production image is an SSR Node server (proxy to the server, instead of embedding static files) | updating the sibling `OKF_CV_Website` decision `static-nuxt-in-gateway` | Proxy to the server. |
| Whether these decisions stay in this bundle or fold into the sibling `OKF_CV_Website` bundle, which already describes the frontend at design level | after the production image exists | None. |
| When and how often Snyk runs once re-enabled: weekly schedule, ready-for-review gate, or per-push | re-enabling the snyk job | Stay disabled. |
| Whether the AI review job should gate merges (required status check on the verdict) or stay advisory | branch protection setup | Advisory. The review comment is information; blocking merges on an AI verdict is a policy choice, not a technical one. |
| ~~How the opencode CLI version in CI gets upgraded~~ - **closed** (2026-10-30): the opencode job was removed; the review path is a pinned PR-Agent container. See [PR-Agent for Gitea reviews](decisions/pr-agent.md) | done | — |
| Whether `glm-5.3-flash` through PR-Agent produces acceptable reviews on this repository | first PR after the OpenCode Go key is set | Keep it; `glm-5.3` is the configured fallback. |
| ~~Whether the Go plan's per-model usage windows survive real review frequency, and which model the review should use~~ - **decided** (2026-10-20): review model is `opencode-go/claude-haiku-5-5#medium` in [pr-checker.yml](../.gitea/workflows/pr-checker.yml). Cheap per token, and it has a real `#medium` effort level; `deepseek-v4.1-flash` only exposes low/high/max, so it always paid for maximum reasoning. The earlier pro -> flash switch (two consecutive `Endpoint is unavailable` failures) is in the [log](../log.md) | done | — |
| Removing the two reviewed audit ignores when `node-forge` or `braces` ship patched releases | next dependency update round | Watch for new releases. |
# The mount trade-off, in detail
Measured on the whole-repository mount:
* An anonymous volume is created once. After a dependency change the stale
contents persist unless the volume is renewed, and the renewal command has not
been tested.
* Docker creates an empty, root-owned `node_modules` directory in the repository
on the first run, unless that directory already exists.
The alternative — mounting only the directories that get edited — removes the
volume, the renewal step and the root-owned directory entirely, and keeps `.nuxt`
inside the container rather than in the working tree. It costs one compose line
per top-level directory, so a new directory silently fails to appear in the
container until the compose file is updated.
# Related
The Nuxt frontend is described at design level in `OKF_CV_Website`, in
`architecture/frontend.md` and `decisions/static-nuxt-in-gateway.md`. Those
documents state that the site is generated to static files and embedded in the
gateway image, which is an input to the production-image question above.