The release PR (chore: release main) failed two checks, both verified
locally before pushing:
- droast: the empty production Dockerfile failed DF071 (no
instructions). The new Dockerfile is a runnable Node server (SSR):
multi-stage, manifests-first layers, digest-pinned node:26-slim (same
digest as the dev container), non-root uid 1000, node-fetch
HEALTHCHECK. Measured: docker build succeeds in-image, container
serves HTTP 200 and reports healthy; droast reports 0 errors.
- audit: two high advisories with NO patched release anywhere
(node-forge <=1.4.0 and braces <=3.0.3 are the newest npm versions;
both build-time-only paths under nitropack). Recorded as
auditConfig.ignoreGhsas in pnpm-workspace.yaml with the reason and
removal condition - the audit output still names what it skipped.
pnpm 11 ignores the pnpm field in package.json (caught locally via
the WARN before pushing); settings live in pnpm-workspace.yaml.
OKF_Nuxt: recorded the production-image and audit-policy decisions,
updated log, indexes and open questions.
The 401 in run 89 was the final isomorphic-git push inside
code-suggester's createPullRequest, not an API call: tree, commit and
local ref update all ran through the token-authenticated octokit API,
then 'git push' used the git-username/git-password inputs - unset in
our workflow, so the push was anonymous. The remote branch
release-please--branches--main still sat at an old commit, proving the
push never landed. Pass the account name and the same token.
Validated from review comment 82 on this PR: the 'bash -c' wrapper
consumed the first staged filename as $0 and the command never
referenced $@, so eslint received zero file arguments and linted the
whole repo - --fix silently rewrote unstaged files and WIP lint errors
blocked unrelated commits. The entry now receives filenames directly
from pre-commit (empirically verified with an arg probe); documented
the re-stage loop for --fix and dropped the redundant 'types: [file]'
filter.
The dedicated RELEASE_PLEASE_TOKEN_CV_SITE_NUXT secret authenticated for
reads but threw when creating the release PR (exit 1, releases_created
false, no PR created): it lacks write:repository / write:issue. Use the
proven PR_GITEA_TOKEN instead, per the one-well-scoped-token policy in
OKF_Nuxt/decisions/snyk-paused-and-secrets-policy.md.
Findings validated from review comments 71 and 75:
- [BLOCKER] the no-verdict branch exited \${EXIT_CODE:-1} which is 0
when opencode succeeded without a verdict - job went green and the
post step published non-review output. The else branch now exits 1
unconditionally, the verdict is anchored to the last five lines (the
prompt itself contains VERDICT lines), and the post step re-verifies
the contract before posting.
- [BLOCKER] the v1 'permission' object is ignored by the opencode v2
CLI - shell commands executed in both review runs despite deny. The
config now uses the v2 'permissions' array with 'shell' as the
action name, denying edit/shell/webfetch/websearch/external_directory.
- hygiene: droast linting prunes node_modules, audit comment names the
exact key to re-add, shell blocks verified with sh -n.
Four new decision documents covering the pipeline work: layering,
AI review setup (provider prefix, v2 CLI, env-only auth, verdict
gate), release engineering (release-please manifest mode), and the
Snyk pause with the token scope policy. Index grouped, log extended,
open questions updated.
- release-please-config.json: node release type, root package,
plain v-tags, default versioning
- .release-please-manifest.json: track current version (1.0.0)
- package.json: add version field required by the node release type
- release-please.yml: use the config/manifest files
- droast: chmod +x was lost in the checksum rewrite (would have
failed with exit 126); checksums now pinned in the workflow
instead of trust-on-first-use
- permission config migrated to the OpenCode v2 schema (permissions
array, bash renamed shell, websearch and external_directory denied)
- posting gate is now the output contract (verdict line present)
instead of the exit code: opencode can exit 1 on benign tool
denials after a completed review
- find -print -quit instead of piping into head (SIGPIPE, exit 141)
- audit comment now says to re-add continue-on-error
Merge origin/main (Dockerfile, Dockerfile.dev, .dockerignore) into
the release-please branch; resolve pr-checker.yml in favour of
opencode-go/deepseek-v4-pro#max.
- [BLOCKER] remove opencode.json from the checkout: it held the API
key in plaintext, readable by the review agent, and a malicious PR
diff could prompt-inject the agent into quoting it in the publicly
visible review comment. Env-only auth (verified headless). The
permission config moves to $HOME/.config/opencode - outside the
checkout and secret-free.
- [WARN] verify the droast binary against the publisher's
sha256sums.txt of the same pinned release
- [WARN] pin the opencode v2 installer to 2.0.32
Findings validated with the validate-pr-review skill; findings 4/5
are moot with the blocker fix.
- deny edit/bash/webfetch in the generated opencode.json: headless
permission prompts are the most likely cause of the review agent
working silently for minutes and then dying; denying write tools
also makes the reviewer provably read-only
- capture the exit code without triggering 'set -e' ('|| EXIT_CODE=$?')
so the captured output is always printed before failing - the
previous version aborted before 'cat' and produced silent failures
The classic installer (opencode.ai/install) ships only OpenCode 1.x
- v1.19.3 on arm64 - which cannot resolve model variants and failed
with ProviderModelNotFoundError for deepseek-v4-pro#max. Use the v2
installer (currently v2.0.32, same version as local dev); verified
working in a fresh arm64 container with key-only auth.
The dockerfile-lint job skipped on every PR despite Dockerfiles
existing: the act runner's hashFiles() evaluation returned empty.
Replace it with an explicit file-discovery step. Also run the droast
binary in node:22-bookworm (arch-aware install) instead of the
vendor image, which ships no node and would fail actions/checkout
with exit 127 - same failure mode as the gitleaks image.
The headless CI container has no stored credentials, so auth depends
entirely on the injected key. Generate an opencode.json at runtime
that binds OPENCODE_API_KEY to the opencode-go provider explicitly,
removing any dependence on env-var-to-provider mapping behavior.
- audit no longer runs with continue-on-error: a failed audit must
turn the pipeline red, not pass silently
- opencode review runs with --print-logs so auth and provider errors
(e.g. invalid API key vs missing Go subscription) appear in the job
log instead of an opaque exit 1
main changed the review model to the default thinking budget; keep
opencode-go/deepseek-v4-pro#max (plan-included, max effort) which
supersedes both earlier variants.
The 'opencode' provider prefix points at OpenCode Zen (pay-per-call,
no funds), which failed every review run with 'Insufficient account
funds'. The opencode-go $10 plan covers deepseek-v4-pro with high
and max variants - use opencode-go/deepseek-v4-pro#max.
The 'opencode' provider prefix points at OpenCode Zen (pay-per-call,
no funds). The opencode-go $10 plan covers deepseek-v4-pro with high
and max variants - use opencode-go/deepseek-v4-pro#max.
Replace the inline 'release-type: simple' with references to
release-please-config.json and .release-please-manifest.json so the
manifest-driven release strategy is used.
- release-please-config.json: node release type, root package,
plain v-tags, default versioning (fix->patch, feat->minor,
BREAKING CHANGE->major)
- .release-please-manifest.json: track current version (1.0.0)
- package.json: add version field required by the node release type
#max exceeded the available opencode account funds; the default
thinking budget keeps the flagship model at lower cost. #max remains
available by re-adding the variant.
Passing the PR diff as a command-line argument exceeded
MAX_ARG_STRLEN (128KiB per single argument; the diff was 190KB,
mostly pnpm-lock.yaml). The shell failed with E2BIG ('Argument list
too long') and the tee pipeline masked the failure, so the raw error
log got posted as a 'review' comment.
- exclude pnpm-lock.yaml from the review diff (pnpm audit covers deps)
- write the diff to .pr-review-diff.patch in the workspace; the agent
reads it with file tools
- redirect output instead of piping through tee and fail the job when
opencode fails, so errors are never posted as review comments