The review's blocker was real: runs-on: ubuntu-latest is the label
pr-checker.yml uses, and the job needs a runner-wide Docker socket, so the
only working configuration violated the trust boundary in the decision
doc. The job now runs on a dedicated 'publish' label that only a second
act_runner registration (docker_host: automount) may carry.
Version tags are now immutable: before building, the registry v2 API is
asked for manifests/<version> and 200 aborts the run. docker manifest
inspect cannot do this job - the pinned Debian 20.10 client fails on OCI
indexes for existing and missing tags alike (measured).
Also: the smoke test requires a rendered body (10 kB floor) on top of the
2xx, .github/actionlint.yaml declares the custom label, and the actionlint
hook passes that config explicitly because this repo keeps workflows in
.gitea/workflows, where actionlint does not auto-discover it.
Applied the findings that held up against the code:
- strict vMAJOR.MINOR.PATCH guard; v[0-9]* accepted v1, v1-foo and
prereleases, all valid registry tags
- latest now follows the newest release, so replaying an older tag cannot
drag it backwards; skipped with a warning if the tag list is unavailable
- smoke test starts the built image and requires 2xx on / before pushing
- timeout-minutes: 20 on the job, so a hung build cannot hold the
capacity-1 runner indefinitely
- the decision doc records the socket's blast radius: root-equivalent,
runner-wide, only on a label PR jobs cannot use
Rejected with evidence: the .dockerignore leak (.env*, *.pem, .git are
excluded) and the Docker client/daemon API mismatch (20.10.24 client
against a 29.9.2 daemon builds over the socket).
Build Dockerfile on every v* tag push (created by release-please when the
release PR merges) and push registry.noelsabia.dev/cv_website/nuxt as the
version, sha-<12> and latest. Main pushes do not build: the registry holds
releases, not commits.
The job runs in node:22-bookworm and needs only the Docker client, so the
act_runner must expose its host socket (container.docker_host: automount);
a preflight step fails with that cause when it does not.
AppNav, AppLogo and AppBottomNav used NuxtLink to "/", which resolves to the English root under prefix_except_default; they now use NuxtLinkLocale and drop the hardcoded aria-current. Bottom-nav labels go through $t as well. The switcher's accessible name now contains the visible locale code, aria-haspopup is gone in favour of a plain disclosure with aria-controls, and Escape returns focus to the trigger.
Resolved: nuxt.config modules now carry @nuxt/icon and @nuxtjs/seo alongside @nuxtjs/i18n; package.json keeps both dependency sets; pnpm-lock.yaml regenerated. Also set i18n.baseUrl from site.config.mjs so sitemap alternates and future hreflang links are absolute.
Locale files in i18n/locales for en, de, es, it and pl; English stays at / and the others are prefixed. One flag dropdown after the GitHub link on desktop, logo plus the language button on phones. Nav, quick links and footer strings go through $t, and the footer line drops "self-healing on purpose".
The diff filter drops pnpm-lock.yaml to keep the patch small; the model read
that as an uncommitted lockfile and raised a BLOCKER on PR #16. Say so in the
prompt instead of widening the diff.
- generate favicon.ico and favicon.svg from the header avatar; the sprite
moves to app/utils/avatar.js so component and generators share one source
- register @nuxtjs/seo with site and Person schema.org data from
site.config.mjs; canonical, robots, sitemap and llms.txt follow the routes
- title "Noel Sabia — <role>", summary_large_image, and no duplicate
"| Noel Sabia" suffix from SEO Utils
- add a committed 1200x630 OG card generated by pnpm og-image; the dynamic
OG renderer and skew protection stay off for the static deployment
- pin the Node version @nuxtjs/seo 6 requires and document the setup in the
OKF bundle
- decisions/icons-via-nuxt-icon.md: local collection, mode svg,
serverBundle collections empty, scanned client bundle; 3 icons, 1.23 kB
- linked from the bundle index and the decisions index, logged
- AppBottomNav: fixed bar below md with Overview, Life Map and Dev View
- default.vue mounts it and carries pb-16 md:pb-0 so the footer stays clear
- AppFooter is hidden below md, where the bar takes over
- icons come from @nuxt/icon (mode svg, scanned client bundle) with the
Material Symbols collection installed locally, replacing the webfont
- deletes the 3.9 MiB Material Symbols woff2 and its @font-face
- review model: opencode-go/claude-haiku-5-5#medium instead of
deepseek-v4.1-flash#max; flash has no medium variant
- merge lint and typecheck into one job with a single pnpm install
- cache the pnpm store and opencode binary via actions/cache@v4.1.0,
keyed on a sha256 of the lockfile (hashFiles is empty on this runner)
- update the decision records and log
The release PR (chore: release main) failed two checks, both verified
locally before pushing:
- droast: the empty production Dockerfile failed DF071 (no
instructions). The new Dockerfile is a runnable Node server (SSR):
multi-stage, manifests-first layers, digest-pinned node:26-slim (same
digest as the dev container), non-root uid 1000, node-fetch
HEALTHCHECK. Measured: docker build succeeds in-image, container
serves HTTP 200 and reports healthy; droast reports 0 errors.
- audit: two high advisories with NO patched release anywhere
(node-forge <=1.4.0 and braces <=3.0.3 are the newest npm versions;
both build-time-only paths under nitropack). Recorded as
auditConfig.ignoreGhsas in pnpm-workspace.yaml with the reason and
removal condition - the audit output still names what it skipped.
pnpm 11 ignores the pnpm field in package.json (caught locally via
the WARN before pushing); settings live in pnpm-workspace.yaml.
OKF_Nuxt: recorded the production-image and audit-policy decisions,
updated log, indexes and open questions.
The 401 in run 89 was the final isomorphic-git push inside
code-suggester's createPullRequest, not an API call: tree, commit and
local ref update all ran through the token-authenticated octokit API,
then 'git push' used the git-username/git-password inputs - unset in
our workflow, so the push was anonymous. The remote branch
release-please--branches--main still sat at an old commit, proving the
push never landed. Pass the account name and the same token.
Validated from review comment 82 on this PR: the 'bash -c' wrapper
consumed the first staged filename as $0 and the command never
referenced $@, so eslint received zero file arguments and linted the
whole repo - --fix silently rewrote unstaged files and WIP lint errors
blocked unrelated commits. The entry now receives filenames directly
from pre-commit (empirically verified with an arg probe); documented
the re-stage loop for --fix and dropped the redundant 'types: [file]'
filter.
The dedicated RELEASE_PLEASE_TOKEN_CV_SITE_NUXT secret authenticated for
reads but threw when creating the release PR (exit 1, releases_created
false, no PR created): it lacks write:repository / write:issue. Use the
proven PR_GITEA_TOKEN instead, per the one-well-scoped-token policy in
OKF_Nuxt/decisions/snyk-paused-and-secrets-policy.md.